On Thu, Jul 26, 2018 at 03:03:04 -0400, Bobo Du wrote:
> it is a bug when the vm is undefined after started.
> blockcommit interface also has the bug with above.
Could you please specify steps and the outcome when this breaks?
vm->newDef should not be present if the VM is not persistent so the co
On Fri, Jul 27, 2018 at 07:26:58 -0400, Steven Albertson wrote:
> Signed-off-by Steven Albertson
> ---
> src/qemu/qemu_block.c | 15 +++
> src/qemu/qemu_block.h | 6 ++
> 2 files changed, 9 insertions(+), 12 deletions(-)
Well, in such case I thing that the qemuDomainObjEnterMoni
One of the attributes that original virCgroupFree() had was it
set passed pointer to NULL. For instance in the following code
the latter call would be practically a no-op:
virCgroupFree(&var);
virCgroupFree(&var);
However, this behaviour of the function was changed in
0f80c71822d824 but corre
On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote:
> One of the attributes that original virCgroupFree() had was it
> set passed pointer to NULL. For instance in the following code
> the latter call would be practically a no-op:
>
> virCgroupFree(&var);
> virCgroupFree(&var);
>
On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote:
> > One of the attributes that original virCgroupFree() had was it
> > set passed pointer to NULL. For instance in the following code
> > the latter call would be
git master requires spice-gtk >= 0.35
Signed-off-by: Daniel P. Berrangé
---
guests/host_vars/libvirt-centos-7/main.yml| 1 -
guests/host_vars/libvirt-debian-8/main.yml| 1 -
guests/host_vars/libvirt-debian-9/main.yml| 1 -
guests/host_vars/libvirt-debian-sid/main.yml
This reverts commit 4da4a9fe0c0956feefe3d592b4ba2b92b2a9a2f9.
Turns out, our code relies on virCgroupFree(&var) setting
var = NULL.
Signed-off-by: Michal Privoznik
---
src/util/vircgroup.c | 1 +
src/util/vircgroup.h | 9 ++---
src/util/vircgrouppriv.h | 2 +-
3 files changed, 4 ins
This reverts commit dd47145aaad780cde0f1d67cf6a85737c0292418.
Turns out, our code relies on virCgroupFree(&var) setting
var = NULL.
Signed-off-by: Michal Privoznik
---
src/util/vircgroup.c | 200 ---
1 file changed, 127 insertions(+), 73 deletions
Turns out, our code relies on virCgroupFree(&var) setting
var = NULL. Otherwise a double free can occur:
https://www.redhat.com/archives/libvir-list/2018-July/msg02004.html
Rather than inserting var = NULL after each virCgroupFree() call lets
revert the patches. The ideal solution would be to use
This reverts commit 0f80c71822d82465d558d697d3be9af2d21e3675.
Turns out, our code relies on virCgroupFree(&var) setting
var = NULL.
Conflicts:
src/util/vircgroup.c: context because 94f1855f099445d is not
reverted.
Signed-off-by: Michal Privoznik
---
src/libvirt-lxc.c| 4 ++--
src/l
On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote:
> git master requires spice-gtk >= 0.35
>
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/host_vars/libvirt-centos-7/main.yml| 1 -
> guests/host_vars/libvirt-debian-8/main.yml| 1 -
> guests/host_vars/libvirt-debian
On Mon, Jul 30, 2018 at 12:17:56PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote:
> > git master requires spice-gtk >= 0.35
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > guests/host_vars/libvirt-centos-7/main.yml| 1 -
> > guests/hos
On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote:
> > > One of the attributes that original virCgroupFree() had was it
> > > set passed point
On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote:
> On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote:
> > > > One of the attr
On Mon, Jul 30, 2018 at 11:19:32AM +0200, Michal Privoznik wrote:
> Turns out, our code relies on virCgroupFree(&var) setting
> var = NULL. Otherwise a double free can occur:
>
> https://www.redhat.com/archives/libvir-list/2018-July/msg02004.html
>
> Rather than inserting var = NULL after each vi
On Mon, Jul 30, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote:
> > On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote:
> > > > On Mon, Jul 3
Signed-off-by: Daniel P. Berrangé
---
projects/virt-viewer.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml
index 12335f3..25474f2 100644
--- a/projects/virt-viewer.yaml
+++ b/projects/virt-viewer.yaml
@@ -13,7 +13,9
On Mon, Jul 30, 2018 at 12:47:37PM +0200, Erik Skultety wrote:
> On Mon, Jul 30, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote:
> > > On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote:
> > > > On Mon, Jul 30, 20
On Fri, 2018-07-27 at 13:22 +0800, Yi Min Zhao wrote:
> 在 2018/7/24 下午10:58, Andrea Bolognani 写道:
> > > @@ -1385,7 +1403,12 @@ qemuDomainCollectPCIAddress(virDomainDefPtr def
> > > ATTRIBUTE_UNUSED,
> > >* parent, and will have its address collected during the scan
> > >* o
On Mon, 2018-07-30 at 11:47 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
A quick note in the commit message explaining why this change is
necessary would certainly be nice.
[...]
>- autotools-rpm-job:
>parent_jobs: 'virt-viewer-master-check'
> -
On Wed, Jul 25, 2018 at 05:57:32PM +0200, Peter Krempa wrote:
The wrapper executes the command and does error detection so there's no
need to open-code all of those things.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 37 +
1 file changed, 5
On Wed, Jul 25, 2018 at 05:57:33PM +0200, Peter Krempa wrote:
The 'device' argument matches only the legacy drive alias. For blockdev
we need to set the throttling for a QOM id and thus we'll need to use
the 'id' field.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 2 +-
src/qe
On Wed, Jul 25, 2018 at 05:57:34PM +0200, Peter Krempa wrote:
The 'device' field reported by 'query-block' is empty when -blockdev is
used. Add an argument which will allow matching disk by using the qdev
id so we can use this code with -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_d
On Wed, Jul 25, 2018 at 05:57:35PM +0200, Peter Krempa wrote:
The disk is not necessary to test the mdevs.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml| 6 --
.../hostdev-mdev-display-spice-egl-headless.x86_64-latest.args | 2 --
te
On Wed, Jul 25, 2018 at 05:57:36PM +0200, Peter Krempa wrote:
The blockdev support will change existing approach to add disks to VMs
so all tests using the DO_TEST_CAPS_LATEST approach which have any disks
need to be forked so that the changes can be applied.
Signed-off-by: Peter Krempa
---
tes
On Wed, Jul 25, 2018 at 05:57:37PM +0200, Peter Krempa wrote:
Add test data for nested backing chains with/without indexes (used in
status XMLs) which will excercise blockdev and the related work.
Signed-off-by: Peter Krempa
---
.../disk-backing-chains-index.x86_64-2.12.0.args | 1 +
.../dis
On Wed, Jul 25, 2018 at 05:57:38PM +0200, Peter Krempa wrote:
It should be impossible to lack an alias in the domain definition. Other
disk types don't generate it so remove it here as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 5 -
1 file changed, 5 deletions(-)
Revi
On Wed, Jul 25, 2018 at 05:57:39PM +0200, Peter Krempa wrote:
Print the values so it's simpler to debug.
Signed-off-by: Peter Krempa
---
src/util/virqemu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
-
On Wed, Jul 25, 2018 at 05:57:40PM +0200, Peter Krempa wrote:
The capability currently is not enabled so that we can add individual
bits first.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 1 +
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 2 insertions(+)
I guess even
On Wed, Jul 25, 2018 at 05:57:41PM +0200, Peter Krempa wrote:
SD cards are currently passed by using -drive only which would not be
compatible with using -blockdev fully.
Floppies at least in the case of the i440 machine type don't have a
reasonable qdev ID if -drive is not used and thus would n
On Sun, Jul 29, 2018 at 09:19:41PM +, Wang, Zhi A wrote:
> BACKGROUND
>
> As the live migration of mdev is going to be supported in VFIO, a scheme of
> deciding if a mdev could be migratable between the source machine and the
> destination machine is needed. Mostly, this email is going to dis
On Wed, Jul 25, 2018 at 05:57:42PM +0200, Peter Krempa wrote:
We need to load the backing chain from the XML when using -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.a
On Wed, Jul 25, 2018 at 05:57:43PM +0200, Peter Krempa wrote:
We'll specify them ourselves so it's pointless to attempt to redetect
them.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.a
On Wed, Jul 25, 2018 at 05:57:44PM +0200, Peter Krempa wrote:
If a user configures the backing chain in the XML we should not ignore
it. We already do parse it but don't format it out. As a
safety-precaution don't attempt to format detected chain into the
inactive XML.
Signed-off-by: Peter Kremp
On Fri, 2018-07-20 at 16:35 +0200, Andrea Bolognani wrote:
> The last build of the Fedora Rawhide Docker image failed
> with
>
> Transaction check error:
> file /usr/lib64/libgdbm_compat.so.4.0.0 from install
> of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
> from package gdbm
On 07/24/2018 11:24 AM, Cornelia Huck wrote:
This option has been deprecated for two releases; remove it.
Signed-off-by: Cornelia Huck
Acked-by: Halil Pasic
---
hw/s390x/3270-ccw.c| 2 +-
hw/s390x/css-bridge.c | 1 -
hw/s390x/css.c
On Tue, 24 Jul 2018 11:24:13 +0200
Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c | 6 ++-
to be the vir prefix and interface name followed by ObjMatch
ex. for virNetworkObjListExport, the match function is named
virNetworkObjMatch
Signed-off-by: Anya Harter
---
src/conf/virnetworkobj.c| 6 +++---
src/conf/virnodedeviceobj.c | 4 ++--
src/conf/virsecretobj.c |
on vir*ObjListExport call stack
Anya Harter (3):
conf: rename structs used by Export function
conf: rename Export Callback functions
conf: rename Match functions
src/conf/virinterfaceobj.c | 10 +-
src/conf/virnetworkobj.c| 16
src/conf/virnodedeviceobj.c | 4
to be the name of the Export function followed by Data
ex. for virInterfaceObjListExport, the struct is named
virInterfaceObjListExportData
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 6 +++---
src/conf/virnetworkobj.c | 6 +++---
src/conf/virsecretobj.c|
to be the name of the export function followed by Callback
ex. for virInterfaceObjListExport, the callback function is named
virInterfaceObjListExportCallback
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 4 ++--
src/conf/virnetworkobj.c | 4 ++--
src/conf/virsto
Jansson does not put a newline at the end of formatted JSON strings.
This breaks the qemucapsprobe utility as we need to keep the spacing so
that tests work. Add an explicit newline.
Signed-off-by: Peter Krempa
---
tests/qemucapsprobemock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t
On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
> As suggested yesterday, I have just tagged the release candidate 1 in git,
> and pushed signed tarbal and rpms to the usual place:
>
>ftp://libvirt.org/libvirt/
>
> seems to work fine with my limited testing, and
> https://ci.ce
On Sun, 29 Jul 2018 21:19:41 +
"Wang, Zhi A" wrote:
> BACKGROUND
>
> As the live migration of mdev is going to be supported in VFIO, a scheme of
> deciding if a mdev could be migratable between the source machine and the
> destination machine is needed. Mostly, this email is going to discu
Add a @flags argument when parsing the network definition
via the virNetworkDefParse{XML|Node|String|File} API's as
this will allow us to in the future make parsing decisions
based on the @flags.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 2 +-
src/conf/network_conf.c
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
As unusual as the case may be, having a name of all white space
has been allowed. This leads to the obvious problem of how a future
usage would be able to "utilize" that resource since it's not "simple"
to determine what combination of spaces and
Split/rename secretXMLParseNode to virSecretDefParseNode and
virSecretDefParseXML in order to follow other drivers usage
and naming of the same functionality.
Signed-off-by: John Ferlan
---
src/conf/secret_conf.c | 56 ++
1 file changed, 35 insertions(+),
Add a @flags argument when parsing the secret definition
via the virSecretDefParse{XML|Node|String|File} API's as
this will allow us to in the future make parsing decisions
based on the @flags.
Signed-off-by: John Ferlan
---
src/conf/secret_conf.c | 25 -
src/conf/sec
Add a @flags argument when parsing the storage pool definition
via the virStoragePoolDefParse{XML|Node|String|File} API's as
this will allow us to in the future make parsing decisions based
on the @flags.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 2 +-
src/conf/storage
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
Add a new define/create flag VIR_DOMAIN_DEF_PARSE_VALIDATE_NAME
to disallow new domains to be defined/created using a name
comprised entirely of spaces.
Alter the qemuxml2argvtest to add a test in order to prove the
failure occurs.
Signed-off-b
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
Add a new define/create flag VIR_NETWORK_DEF_PARSE_VALIDATE_NAME
to disallow new networks to be defined/created using a name
comprised entirely of spaces.
Alter the networkxml2xmltest to add a test in order to prove
the failure occurs.
Signed-o
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
Add a new define/create flag VIR_STORAGE_POOL_DEF_PARSE_VALIDATE_NAME
to disallow new storage pools to be defined/created using a name
comprised entirely of spaces.
Alter the storagepoolxml2xmltest to add a parse failure scenario and
a test in o
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
Add a new define/create flag VIR_SECRET_DEF_PARSE_VALIDATE_USAGE_ID
to disallow new secrets to be defined/created using a usage id
comprised entirely of spaces.
Alter the secretxml2xmltest to add a parse failure scenario and
a test in order to p
Add a @flags argument when parsing the nwfilter definition
via the virNWFilterDefParse{XML|Node|String|File} API's as
this will allow us to in the future make parsing decisions
based on the @flags.
Signed-off-by: John Ferlan
---
src/conf/nwfilter_conf.c | 25 -
sr
https://bugzilla.redhat.com/show_bug.cgi?id=1107420
Add a new define/create flag VIR_NWFILTER_DEF_PARSE_VALIDATE_NAME
to disallow new nwfilters to be defined/created using a name
comprised entirely of spaces.
Alter the nwfilterxml2xmltest to add a test in order to prove the
failure occurs.
Signe
Hi Erik:
Thanks for the reply and also the detailed guide. :) I can understand
your idea is a comprehensive and generic approach for matching and
checking all kinds of "hostdev"s in libvirt, not only mdev-specific one
since mdev is a sub-hierarchy of "hostdev". If you idea become true,
mdev w
On 07/29/2018 11:12 PM, bing@intel.com wrote:
> From: Bing Niu
>
> Extract vcpus parsing part from virDomainCachetuneDefParse into one
> function called virDomainResctrlParseVcpus. So that vcpus parsing logic
> can be reused by other resource control technologies. Adjust error
> message an
On 07/29/2018 11:12 PM, bing@intel.com wrote:
> From: Bing Niu
>
> Introduce a new section memorytune to support memory bandwidth allocation.
> This is consistent with existing cachetune. As the example:
> below:
>
> ..
>
>
>
>
>
> vpus --- vpus subject
On 07/29/2018 11:12 PM, bing@intel.com wrote:
> From: Bing Niu
>
> Add return value check to virResctrlAllocForeachCache in
> virDomainCachetuneDefFormat. The virResctrlAllocForeachCache dose have
s/dose/does/
> return value, so need check return value to make sure function executed
> wi
On 2018年07月31日 06:09, John Ferlan wrote:
On 07/29/2018 11:12 PM, bing@intel.com wrote:
From: Bing Niu
Introduce virResctrlAllocMemoryBandwidthFormat and
virResctrlAllocParseMemoryBandwidthLine which will format
and parse an entry in the schemata file for MBA.
Signed-off-by: Bing Niu
On Mon, Jul 30, 2018 at 05:20:01PM +0200, Andrea Bolognani wrote:
> On Sat, 2018-07-28 at 21:56 +0800, Daniel Veillard wrote:
> > As suggested yesterday, I have just tagged the release candidate 1 in git,
> > and pushed signed tarbal and rpms to the usual place:
> >
> >ftp://libvirt.org/libv
On 2018年07月31日 06:14, John Ferlan wrote:
On 07/29/2018 11:12 PM, bing@intel.com wrote:
From: Bing Niu
This series is to introduce RDT memory bandwidth allocation support by extending
current virresctrl implementation.
[]
Bing Niu (17):
util: Rename some functions of virresctr
It is out, tagged in git and with signed tarball and rpms at the
usual place:
ftp://libvirt.org/libvirt/
in my limited testing it works but we have that pending issue
raised by Andrea. worse case someone reverse the patches and
allows to build against the old lib.
Please give it some tes
Commit d48813e8 made sure we wouldn't get one for i440fx, but not for Q35
machine type. If the primary video didn't get the assumed 0:0:1.0 PCI
address, the evaluation then failed with: "Cannot automatically add a
new PCI bus for a device with connect flags 00"
https://bugzilla.redhat.com/show_bug
64 matches
Mail list logo
