Re: [libvirt] [Qemu-devel] [PULL 00/12] Ui 20180823 v3 patches

2018-08-24 Thread Peter Maydell
On 23 August 2018 at 10:56, Gerd Hoffmann wrote: > The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into > staging (2018-08-20 17:41:18 +0100) > > are available in the git repository at: > > git:

[libvirt] question about job handling across migration protocol phases

2018-08-24 Thread Jim Fehlig
While investigating a bug [1] found by Xen's osstest I realized I don't quite understand how to handle modify jobs (e.g. BeginJob/EndJob) on virDomainObj across the various phases of V3 migration protocol. E.g. on the src host the Begin, Perform, and Confirm phases are performed. Should a modify

Re: [libvirt] [PATCH v2 8/8] xml: report the filename (if any) when parsing files

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:31 +0100, Daniel P. Berrangé wrote: > A generic "failed to parse xml document" message without telling us > which XML file failed is quite unhelpful. > > Signed-off-by: Daniel P. Berrangé > --- > src/util/virxml.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deleti

Re: [libvirt] [PATCH v2 7/8] cpu: split x86 map data into separate files

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:30 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- ... > diff --git a/src/cpu_map/x86_qemu64.xml b/src/cpu_map/x86_qemu64.xml > new file mode 100644 > index 00..ed3b8d54e2 > --- /dev/null > +++ b/src/cpu_map/x86_qemu64.xml > @@ -0,0

Re: [libvirt] [PATCH v2 6/8] cpu: split PPC64 map data into separate files

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:29 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/cpu_map/Makefile.inc.am | 7 + > src/cpu_map/index.xml | 41 + > src/cpu_map/ppc64_POWER6.xml| 6 + > src/cpu_map/p

Re: [libvirt] [PATCH v2 0/8] cpu: modularize the CPU map data file

2018-08-24 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180816121031.10902-1-berra...@redhat.com Subject: [libvirt] [PATCH v2 0/8] cpu: modularize the CPU map data file === TEST SCRIPT BEGIN === #!/bin/bash # Te

Re: [libvirt] [PATCH v2 5/8] cpu: move the CPU map data files into a src/cpu_map directory

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:28 +0100, Daniel P. Berrangé wrote: > In preparation for splitting up the CPU map data file, move it into a > dedicated directory of its own. > > Signed-off-by: Daniel P. Berrangé Once syntax-check passes Reviewed-by: Jiri Denemark -- libvir-list mailing list lib

Re: [libvirt] [PATCH v2 4/8] cpu: simplify failure cleanup paths

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:27 +0100, Daniel P. Berrangé wrote: > Get rid of the separate 'error:' label, so all code paths jump straight > to the 'cleanup:' label. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www

Re: [libvirt] [PATCH v2 3/8] cpu: push more parsing logic into common code

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:26 +0100, Daniel P. Berrangé wrote: > The x86 and ppc impls both duplicate some logic when parsing CPU > features. Change the callback signature so that this duplication can be > pushed up a level to common code. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Ji

Re: [libvirt] [PATCH v2 0/8] cpu: modularize the CPU map data file

2018-08-24 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180816121031.10902-1-berra...@redhat.com Subject: [libvirt] [PATCH v2 0/8] cpu: modularize the CPU map data file === TEST SCRIPT BEGIN === #!/bin/bash # Te

Re: [libvirt] [PATCH v2 2/8] cpu: fix cleanup when signature parsing fails

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:25 +0100, Daniel P. Berrangé wrote: > Two pieces of code accidentally jumped to the wrong label when they > failed causing incorrect cleanup, returning a partially initialized > CPU model struct. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Jiri Denemark --

Re: [libvirt] [PATCH v2 1/8] cpu: allow include files for CPU definition

2018-08-24 Thread Jiri Denemark
On Thu, Aug 16, 2018 at 13:10:24 +0100, Daniel P. Berrangé wrote: > Allow for syntax > > > > to reference other files in the CPU database directory > > Signed-off-by: Daniel P. Berrangé > --- > src/cpu/cpu_map.c | 87 +-- > 1 file changed, 84 in

Re: [libvirt] [PATCH] apparmor: fix ptrace rules with kernel 4.18

2018-08-24 Thread Jamie Strandboge
On Fri, 2018-08-24 at 08:12 +0200, Christian Ehrhardt wrote: > Due to kernel upstream change 338d0be4 ("apparmor: fix ptrace read > check") > libvirt now hits apparmor denies like: > apparmor="DENIED" operation="ptrace" profile="/usr/sbin/libvirtd" > pid=4409 comm="libvirtd" requested_mask="rea

Re: [libvirt] [Qemu-devel] [PULL 0/3] Ui2 20180824 patches

2018-08-24 Thread Peter Maydell
t; > >> > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into >> > staging (2018-08-23 17:35:48 +0100) >> > >> > are available in the git repository at: >> > >> > git://git.kraxel.org/qemu tags/ui2-201

Re: [libvirt] [Qemu-devel] [PULL 0/3] Ui2 20180824 patches

2018-08-24 Thread Daniel P . Berrangé
t' into > > staging (2018-08-23 17:35:48 +0100) > > > > are available in the git repository at: > > > > git://git.kraxel.org/qemu tags/ui2-20180824-pull-request > > > > for you to fetch changes up to eb01505ea6c8330273d189acc053cc60d00bfa1a: >

Re: [libvirt] [Qemu-devel] [PULL 0/3] Ui2 20180824 patches

2018-08-24 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/ui2-20180824-pull-request > > for you to fetch changes up to eb01505ea6c8330273d189acc053cc60d00bfa1a: > > ui: remove support for SDL1.2 in favour of SDL2 (2018-08-24 09:31:39 +0200) > > -

Re: [libvirt] [PATCH] vl.c: make sure maxcpus matches topology to prevent migration failure

2018-08-24 Thread Igor Mammedov
On Fri, 24 Aug 2018 10:53:32 -0300 Eduardo Habkost wrote: > On Fri, Aug 24, 2018 at 01:26:54PM +0200, Igor Mammedov wrote: > > On Fri, 24 Aug 2018 08:11:48 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, Aug 24, 2018 at 11:13:50AM +0200, Igor Mammedov wrote: > > > > On Thu, 23 Aug 2018 1

Re: [libvirt] [PATCH 3/7] vircgroup: Extract placement validation into function

2018-08-24 Thread Ján Tomko
On Fri, Aug 24, 2018 at 03:45:53PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 52 +++- 1 file changed, 32 insertions(+), 20 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -

Re: [libvirt] [PATCH 0/3] Allow inputvol when creating vol from inputvol to be encrypted

2018-08-24 Thread John Ferlan
ping? Tks - John On 08/21/2018 12:23 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1613737 > > Details in the patches (and even more in the bz). > > John Ferlan (3): > storage: Remove secretPath from _virStorageBackendQemuImgInfo > storage: Allow for inputvol to ha

Re: [libvirt] [PATCH 2/7] vircgroup: Extract controller detection into function

2018-08-24 Thread Ján Tomko
On Fri, Aug 24, 2018 at 03:45:52PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 48 +--- 1 file changed, 32 insertions(+), 16 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -

Re: [libvirt] [PATCH 1/7] vircgroup: Duplicate string before modifying

2018-08-24 Thread Ján Tomko
On Fri, Aug 24, 2018 at 03:45:51PM +0200, Pavel Hrdina wrote: The 'mntDir' is part of 'struct mntent' as a result of getmntent_r therefor we should not mangle with it. therefore Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 14 +- 1 file changed, 9 insertions(+), 5 delet

[libvirt] [PATCH v3] qemu: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1607202 It's essentially stated in the nwfilterBindingDelete that we will allow the admin to shoot themselves in the foot by deleting the nwfilter binding which then allows them to undefine the nwfilter that is in use for the running guest... However, b

Re: [libvirt] [PATCH] vl.c: make sure maxcpus matches topology to prevent migration failure

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 10:53:32AM -0300, Eduardo Habkost wrote: > On Fri, Aug 24, 2018 at 01:26:54PM +0200, Igor Mammedov wrote: > > On Fri, 24 Aug 2018 08:11:48 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, Aug 24, 2018 at 11:13:50AM +0200, Igor Mammedov wrote: > > > > On Thu, 23 Aug 2018

Re: [libvirt] [PATCH] vl.c: make sure maxcpus matches topology to prevent migration failure

2018-08-24 Thread Eduardo Habkost
On Fri, Aug 24, 2018 at 01:26:54PM +0200, Igor Mammedov wrote: > On Fri, 24 Aug 2018 08:11:48 -0300 > Eduardo Habkost wrote: > > > On Fri, Aug 24, 2018 at 11:13:50AM +0200, Igor Mammedov wrote: > > > On Thu, 23 Aug 2018 18:32:41 +0200 > > > Paolo Bonzini wrote: > > > > > > > On 23/08/2018 16:

[libvirt] [PATCH 1/7] vircgroup: Duplicate string before modifying

2018-08-24 Thread Pavel Hrdina
The 'mntDir' is part of 'struct mntent' as a result of getmntent_r therefor we should not mangle with it. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index df38

[libvirt] [PATCH 7/7] vircgroup: Remove obsolete sa_assert

2018-08-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 4 1 file changed, 4 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 02de33f74f..64507bf8aa 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -1054,10 +1054,6 @@ virCgroupMakeGroup(virCgroupPtr

[libvirt] [PATCH 5/7] vircgroup: Call virCgroupRemove inside virCgroupMakeGroup

2018-08-24 Thread Pavel Hrdina
This fixes virCgroupEnableMissingControllers where virCgroupRemove was not called in case virCgroupMakeGroup failed. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgro

[libvirt] [PATCH 4/7] vircgroup: Split virCgroupPathOfController into two functions

2018-08-24 Thread Pavel Hrdina
The case where we need path of any controller is only for internal use so move it out to a different function. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 54 ++-- src/util/vircgroup.h | 2 +- 2 files changed, 33 insertions(+), 23 deletions(-)

[libvirt] [PATCH 3/7] vircgroup: Extract placement validation into function

2018-08-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 52 +++- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 6f27c50cbd..2bc4febf23 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgro

[libvirt] [PATCH 6/7] vircgroup: Simplify if conditions in virCgroupMakeGroup

2018-08-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index dde9ed21a2..02de33f74f 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -1079,24 +1079,20

[libvirt] [PATCH 2/7] vircgroup: Extract controller detection into function

2018-08-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 48 +--- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 45b854e864..6f27c50cbd 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgro

[libvirt] [PATCH 0/7] cgroup cleanup

2018-08-24 Thread Pavel Hrdina
Another small set of cgroup cleanup patches as preparation for cgroup v2. Pavel Hrdina (7): vircgroup: Duplicate string before modifying vircgroup: Extract controller detection into function vircgroup: Extract placement validation into function vircgroup: Split virCgroupPathOfController in

Re: [libvirt] [PATCH v2 7/7] qemu_security: Lock metadata while relabelling

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 03:29:24PM +0200, Michal Privoznik wrote: > On 08/24/2018 02:53 PM, Daniel P. Berrangé wrote: > > > > > That sounds reasonable, so we don't need the _WAIT behaviour in > > virtlockd itself, as everything will wait in the secdriver instead. > > At least for now, until we mo

Re: [libvirt] [PATCH v2 7/7] qemu_security: Lock metadata while relabelling

2018-08-24 Thread Michal Privoznik
On 08/24/2018 02:53 PM, Daniel P. Berrangé wrote: > > That sounds reasonable, so we don't need the _WAIT behaviour in > virtlockd itself, as everything will wait in the secdriver instead. > At least for now, until we modularize the startup process with the > shim. Guess that's just one more todo

Re: [libvirt] [PATCH v2 04/10] qemu: capabilities: Detect active block commit via QMP schema probing if possible

2018-08-24 Thread Peter Krempa
On Thu, Aug 23, 2018 at 14:45:35 -0400, John Ferlan wrote: > > > On 08/15/2018 05:18 AM, Peter Krempa wrote: > > For versions where we can probe that the arguments are optional we can > > perform the probing by a schema query rather than sending a separate > > command to do so. > > > > Signed-of

Re: [libvirt] [PATCH 0/2] Allow usage of unpriv_sgio for SCSI generic hostdev

2018-08-24 Thread John Ferlan
On 08/24/2018 09:02 AM, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 01:32:41PM +0200, Ján Tomko wrote: >> On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: >>> In what is perhaps a couple lifetimes ago at this point, patches >>> were posted and "mostly" all eventually accepted

Re: [libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 08:30:50AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1607202 > > It's essentially stated in the nwfilterBindingDelete that we > will allow the admin to shoot themselves in the foot by deleting > the nwfilter binding which then allows them to un

Re: [libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 09:05:06AM -0400, John Ferlan wrote: > > > On 08/24/2018 09:04 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 24, 2018 at 08:30:50AM -0400, John Ferlan wrote: > >> +static void > >> +qemuProcessFiltersInstantiate(virDomainDefPtr def) > >> { > >> size_t i; > >> > >>

Re: [libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread John Ferlan
On 08/24/2018 09:04 AM, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 08:30:50AM -0400, John Ferlan wrote: >> +static void >> +qemuProcessFiltersInstantiate(virDomainDefPtr def) >> { >> size_t i; >> >> for (i = 0; i < def->nnets; i++) { >> virDomainNetDefPtr net = def-

Re: [libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 08:30:50AM -0400, John Ferlan wrote: > +static void > +qemuProcessFiltersInstantiate(virDomainDefPtr def) > { > size_t i; > > for (i = 0; i < def->nnets; i++) { > virDomainNetDefPtr net = def->nets[i]; > if ((net->filter) && (net->ifname)) { >

Re: [libvirt] [PATCH 0/2] Allow usage of unpriv_sgio for SCSI generic hostdev

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 01:32:41PM +0200, Ján Tomko wrote: > On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: > > In what is perhaps a couple lifetimes ago at this point, patches > > were posted and "mostly" all eventually accepted upstream to support > > unpriv_sgio on SCSI generic hos

Re: [libvirt] [PATCH v2 7/7] qemu_security: Lock metadata while relabelling

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 02:01:52PM +0200, Michal Privoznik wrote: > On 08/23/2018 06:14 PM, Michal Privoznik wrote: > > On 08/23/2018 05:51 PM, Daniel P. Berrangé wrote: > >> On Thu, Aug 23, 2018 at 05:45:42PM +0200, Michal Privoznik wrote: > >>> On 08/23/2018 05:01 PM, Daniel P. Berrangé wrote: >

[libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect

2018-08-24 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1607202 It's essentially stated in the nwfilterBindingDelete that we will allow the admin to shoot themselves in the foot by deleting the nwfilter binding which then allows them to undefine the nwfilter that is in use for the running guest... However, b

Re: [libvirt] [PATCH v3] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-24 Thread Ján Tomko
On Fri, Aug 24, 2018 at 12:54:40PM +0200, Katerina Koukiou wrote: This patch ensures that changes in attributes of interfaces will be emit s/will be/will/ errors accept if they are missing from the XML. Previously we were falsely reporting successful updates, because some changed attributes g

Re: [libvirt] [jenkins-ci PATCH v3 00/12] lcitool: Add 'build' action

2018-08-24 Thread Andrea Bolognani
On Fri, 2018-08-24 at 09:47 +0200, Erik Skultety wrote: > On Wed, Aug 22, 2018 at 11:44:15AM +0200, Andrea Bolognani wrote: > > Changes from [v2]: > > > > * rebase on top of master (dbc2de85f775) and integrate recent > > changes to build rules on the Jenkins side; > > > > * drop a commit

[libvirt] [PATCH] qemu: Don't use legacy USB for RISC-V guests

2018-08-24 Thread Andrea Bolognani
The architecture is new enough that we don't need to concern ourselves with backwards compatibility in any capacity. Signed-off-by: Andrea Bolognani --- Requires https://www.redhat.com/archives/libvir-list/2018-June/msg01223.html to be applied (and test data to be refreshed in the process).

Re: [libvirt] [PATCH v3 8/9] tests: Add RISC-V architectures

2018-08-24 Thread Andrea Bolognani
On Thu, 2018-08-23 at 19:18 +0200, Andrea Bolognani wrote: > On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote: [...] > > create mode 100644 tests/qemuxml2startupxmloutdata/riscv64-virt.xml Oh, and this file is unnecessary (qemuxml2startup is only intended to cover some very specific use ca

Re: [libvirt] [PATCH v2 7/7] qemu_security: Lock metadata while relabelling

2018-08-24 Thread Michal Privoznik
On 08/23/2018 06:14 PM, Michal Privoznik wrote: > On 08/23/2018 05:51 PM, Daniel P. Berrangé wrote: >> On Thu, Aug 23, 2018 at 05:45:42PM +0200, Michal Privoznik wrote: >>> On 08/23/2018 05:01 PM, Daniel P. Berrangé wrote: On Thu, Aug 23, 2018 at 04:54:01PM +0200, Michal Privoznik wrote: >

Re: [libvirt] [PATCH 6/8] qemu: monitor: Use qemuMonitorJSONBlockJobError in qemuMonitorJSONDrivePivot

2018-08-24 Thread Peter Krempa
On Thu, Aug 23, 2018 at 17:38:39 -0400, John Ferlan wrote: > > > On 08/15/2018 07:52 AM, Peter Krempa wrote: > > The API deals with a block job so use the common error reporting > > function for it. > > > > Signed-off-by: Peter Krempa > > --- > > src/qemu/qemu_monitor_json.c | 2 +- > > 1 file

Re: [libvirt] [PATCH 8/8] qemu: monitor: Separate probing for active block commit

2018-08-24 Thread Peter Krempa
On Thu, Aug 23, 2018 at 18:11:09 -0400, John Ferlan wrote: > > > On 08/15/2018 07:52 AM, Peter Krempa wrote: > > Extract the code used to probe for the functionality so that it does not > > litter the code used for actual work. > > > > Signed-off-by: Peter Krempa > > --- > > src/qemu/qemu_moni

Re: [libvirt] [PATCH 0/2] Allow usage of unpriv_sgio for SCSI generic hostdev

2018-08-24 Thread Ján Tomko
On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: In what is perhaps a couple lifetimes ago at this point, patches were posted and "mostly" all eventually accepted upstream to support unpriv_sgio on SCSI generic hostdev devices. Since the needed parts of the functionality from the kern

[libvirt] [PATCH v3] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-24 Thread Katerina Koukiou
This patch ensures that changes in attributes of interfaces will be emit errors accept if they are missing from the XML. Previously we were falsely reporting successful updates, because some changed attributes got overwritten before the validity checks. https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [libvirt] [PATCH 1/2] virsh: Implement virNodeGetSEVInfo in virsh

2018-08-24 Thread Erik Skultety
On Tue, Aug 21, 2018 at 11:20:27AM +0800, Han Han wrote: > Add sub-command nodesevinfo to get node infomation of AMD SEV feature. > > Signed-off-by: Han Han > --- > tools/virsh-host.c | 66 ++ > tools/virsh.pod| 5 > 2 files changed, 71 insert

Re: [libvirt] [PATCH] storage: Add --shrink to qemu-img command when shrinking vol

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 04:01:32PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1613746 > > When shrinking the capacity of a qcow2 or luks volume using > the qemu-img program, the --shrink qualifier must be added. > > Signed-off-by: John Ferlan > --- > src/storage/sto

Re: [libvirt] [PATCH] nwfilter: Handle opening for session

2018-08-24 Thread Daniel P . Berrangé
On Thu, Aug 23, 2018 at 08:54:53AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1608275 > > Commit id 2870419eb (in part) added virGetConnectNWFilter to > allow opening drivers (interface, network, nwfilter, nodedev, > secret, and storage) based on context and commit id

Re: [libvirt] [jenkins-ci PATCH v3 09/12] lcitool: Add 'build' action

2018-08-24 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:24AM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] nwfilter: Add extra verbiage for binding create/delete

2018-08-24 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 06:46:03PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1609454 > > Add some cautionary words related to the create and delete > NWFilter Binding use cases and possible issues that may result > to the virsh nwfilter-binding-{create|delete} descrip

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 12:10:47PM +0200, Michal Privoznik wrote: > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > >> On 08/23/2018 05:53 PM, Simon Kobyda wrote: > >>> Created new API for priting tables, mainly to solve alig

Re: [libvirt] [PATCH] access: Fix nwfilter-binding ACL access API name generation

2018-08-24 Thread Daniel P . Berrangé
On Tue, Aug 21, 2018 at 04:23:25PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1611320 > > Generation of the ACL API policy is a "automated process" > based on this perl script which "worked" with the changes to > add nwfilter binding API's because they had the "nwfilte

Re: [libvirt] [PATCH] nwfilter: Handle libvirtd restart if nwfilter binding deleted

2018-08-24 Thread Daniel P . Berrangé
On Thu, Aug 23, 2018 at 07:59:41AM -0400, John Ferlan wrote: > > > On 08/23/2018 07:27 AM, Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 05:43:21PM -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1607202 > >> > >> It's stated that if the admin wants to shoot the

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Michal Privoznik
On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: >> On 08/23/2018 05:53 PM, Simon Kobyda wrote: >>> Created new API for priting tables, mainly to solve alignment problems. >>> Implemented these test to virsh list. In the future, A

Re: [libvirt] [PATCH v2] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-24 Thread Katerina Koukiou
On Thu, Aug 09, 2018 at 05:50:11PM +0200, Ján Tomko wrote: > On Thu, Aug 09, 2018 at 11:21:52AM +0200, Katerina Koukiou wrote: > > This patch ensures that changes in attributes of interfaces will be emit > > errors accept if they are missing from the XML. > > Previously we were falsely reporting su

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > On 08/23/2018 05:53 PM, Simon Kobyda wrote: > > Created new API for priting tables, mainly to solve alignment problems. > > Implemented these test to virsh list. In the future, API may be > > everywhere in virsh and virt-admin. > >

Re: [libvirt] [PATCH v5 1/3] vsh: Add API for printing tables.

2018-08-24 Thread Michal Privoznik
On 08/23/2018 05:53 PM, Simon Kobyda wrote: > It solves problems with alignment of columns. Width of each column > is calculated by its biggest cell. Should solve unicode bug. > In future, it may be implemented in virsh, virt-admin... > > This API has 5 public functions: > - vshTableNew - adds new

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Michal Privoznik
On 08/23/2018 05:53 PM, Simon Kobyda wrote: > Created new API for priting tables, mainly to solve alignment problems. > Implemented these test to virsh list. In the future, API may be > everywhere in virsh and virt-admin. > Also wrote basic tests for the new API, and corrected tests in virshtest >

Re: [libvirt] [PATCH v3 3/9] util: add RISC-V architectures

2018-08-24 Thread Andrea Bolognani
On Thu, 2018-08-23 at 17:30 +0200, Andrea Bolognani wrote: > On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote: > > +VIR_ARCH_RISCV32, /* RISC-V 64 LE > > http://en.wikipedia.org/wiki/RISC-V */ > > This should be 32 LE ... > > > +VIR_ARCH_RIS

Re: [libvirt] [jenkins-ci PATCH v3 00/12] lcitool: Add 'build' action

2018-08-24 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:15AM +0200, Andrea Bolognani wrote: > Changes from [v2]: > > * rebase on top of master (dbc2de85f775) and integrate recent > changes to build rules on the Jenkins side; > > * drop a commit that had already been merged in the meantime. > > Changes from [v1]: > >

Re: [libvirt] [jenkins-ci PATCH v3 07/12] guests: Add build playbook

2018-08-24 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:22AM +0200, Andrea Bolognani wrote: > This playbook represent the entry point for automated > builds, and follows the same calling conventions as the > existing update playbook. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mail

Re: [libvirt] [jenkins-ci PATCH v3 06/12] guests: Add build projects

2018-08-24 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:21AM +0200, Andrea Bolognani wrote: > These tasks mirror the Jenkins projects contained in the > top-level projects/ directory. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat

Re: [libvirt] [jenkins-ci PATCH v3 05/12] guests: Add build jobs

2018-08-24 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:20AM +0200, Andrea Bolognani wrote: > These tasks mirror the Jenkins jobs contained in the > top-level jobs/ directory. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

[libvirt] [PULL 2/3] ui: increase min required GTK3 version to 3.14.0

2018-08-24 Thread Gerd Hoffmann
From: Daniel P. Berrangé Per supported platforms doc[1], the various min GTK3 on relevant distros is: RHEL-7.0: 3.8.8 RHEL-7.2: 3.14.13 RHEL-7.4: 3.22.10 RHEL-7.5: 3.22.26 Debian (Stretch): 3.22.11 Debian (Jessie): 3.14.5 OpenBSD (Ports): 3.22.30 FreeBSD (Ports): 3.22.29 OpenSU

[libvirt] [PULL 1/3] ui: remove support for GTK2 in favour of GTK3

2018-08-24 Thread Gerd Hoffmann
From: Daniel P. Berrangé GTK2 was deprecated in the 2.12.0 release with: commit b7715af2b31f47060cc5b4be930d16c13be93fa9 Author: Daniel P. Berrange Date: Tue Dec 12 11:34:40 2017 + ui: deprecate use of GTK 2.x in favour of 3.x series The GTK 3.0 release was made in Feb, 20

[libvirt] [PULL 3/3] ui: remove support for SDL1.2 in favour of SDL2

2018-08-24 Thread Gerd Hoffmann
From: Daniel P. Berrangé SDL1.2 was deprecated in the 2.12.0 release with: commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa Author: Daniel P. Berrange Date: Mon Jan 15 14:25:33 2018 + ui: deprecate use of SDL 1.2 in favour of 2.0 series The SDL 2.0 release was made in Aug,

[libvirt] [PULL 0/3] Ui2 20180824 patches

2018-08-24 Thread Gerd Hoffmann
The following changes since commit 5ccac548faf041ff5229a8e8342e3be14a34c8af: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2018-08-23 17:35:48 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui2-20180824-pull-re

Re: [libvirt] [PATCH] apparmor: fix ptrace rules with kernel 4.18

2018-08-24 Thread Erik Skultety
On Fri, Aug 24, 2018 at 08:12:11AM +0200, Christian Ehrhardt wrote: > Due to kernel upstream change 338d0be4 ("apparmor: fix ptrace read check") > libvirt now hits apparmor denies like: > apparmor="DENIED" operation="ptrace" profile="/usr/sbin/libvirtd" > pid=4409 comm="libvirtd" requested_mask

Re: [libvirt] [PATCH] qemu: Make sure preferredMachines is not missing any entry

2018-08-24 Thread Erik Skultety
On Thu, Aug 23, 2018 at 06:57:24PM +0200, Andrea Bolognani wrote: > With the current implementation, adding a new architecture > and not updating preferredMachines accordingly will not > cause a build failure, making it very likely that subtle > bugs will be introduced in the process. Rework the co

Re: [libvirt] [PATCH v3 08/12] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-08-24 Thread Yi Min Zhao
在 2018/8/23 下午7:01, Andrea Bolognani 写道: On Thu, 2018-08-23 at 18:01 +0800, Yi Min Zhao wrote: 在 2018/8/22 下午5:56, Andrea Bolognani 写道: The patches I said I'd write are now on the list: https://www.redhat.com/archives/libvir-list/2018-August/msg01105.html No reviews yet, we'll see wheth