Re: [libvirt] [PATCHv2 0/3] network: new network forward mode 'vlan'

2018-09-01 Thread Shi Lei
On 2018-09-01 at 20:13, John Ferlan wrote: > > >On 08/14/2018 03:00 AM, Shi Lei wrote: >> Hi, everyone! >> >> This patch supports VLan by '8021q' kernel module >> other than by OVS. The way of '8021q' is simpler and more robust. >> >> Mode 'vlan' is like mode 'route' except these major

Re: [libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-09-01 Thread Shi Lei
On 2018-08-31 at 20:02, Erik Skultety wrote: >On Thu, Aug 30, 2018 at 02:27:05PM +0800, Shi Lei wrote: >> Thanks for your comments. >> But I have several questions, please see below... >> >> On 2018-08-29 at 19:43, Erik Skultety wrote: >> >On Thu, Aug 23, 2018 at 12:15:08PM +0800, Shi Lei wrote:

Re: [libvirt] [PATCH v3 2/2] qemu: adding domainGetHostname support for QEMU.

2018-09-01 Thread Julio Faracco
Thanks for your review @John. I will wait for 4.8.0 to push all changes in one shot (including news.xml). Julio Cesar Faracco Em qua, 29 de ago de 2018 às 17:15, John Ferlan escreveu: > > > > On 08/21/2018 10:39 PM, Julio Faracco wrote: > > This commit add the support to use the function

Re: [libvirt] [PATCHv2 0/3] network: new network forward mode 'vlan'

2018-09-01 Thread John Ferlan
On 08/14/2018 03:00 AM, Shi Lei wrote: > Hi, everyone! > > This patch supports VLan by '8021q' kernel module > other than by OVS. The way of '8021q' is simpler and more robust. > > Mode 'vlan' is like mode 'route' except these major differences: > - mode 'vlan' inserts a vlan-device between