Re: [libvirt] [PATCH v5 11/13] qemu: Add hotpluging support for PCI devices on S390 guests

2018-09-16 Thread Yi Min Zhao
在 2018/9/11 下午11:21, Andrea Bolognani 写道: On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: [...] +static int +qemuDomainAttachExtensionDevice(qemuMonitorPtr mon, +virDomainDeviceInfoPtr info) +{ +if (!virZPCIDeviceAddressIsEmpty(&info->addr.pci.zpci)) +

Re: [libvirt] [PATCH v5 10/13] qemu: Generate and use zPCI device in QEMU command line

2018-09-16 Thread Yi Min Zhao
在 2018/9/11 下午10:31, Andrea Bolognani 写道: On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: [...] +char * +qemuBuildZPCIDevStr(virDomainDeviceInfoPtr dev) +{ +virBuffer buf = VIR_BUFFER_INITIALIZER; + +virBufferAddLit(&buf, "zpci"); +virBufferAsprintf(&buf, ",uid=%u", dev->addr

Re: [libvirt] [PATCH v5 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-09-16 Thread Yi Min Zhao
在 2018/9/11 下午9:59, Andrea Bolognani 写道: On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: [...] If the user define zPCI extension address but zPCI capability doesn't exist, an error will be reported. You're (no longer) checking for the capability here, so the commit message should be upd

Re: [libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-16 Thread Yi Min Zhao
在 2018/9/13 下午7:47, Andrea Bolognani 写道: Just remove the full stop, like virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("This QEMU binary doesn't support zPCI")); AhGot it. -- Yi Min -- libvir-list mailing list libvir-list@redhat.com https://ww

Re: [libvirt] [PATCH v7] qemu: Introduce state_lock_timeout toqemu.conf

2018-09-16 Thread wang.yi59
> On Thu, Sep 13, 2018 at 18:47:55 +0800, Yi Wang wrote: > > When doing some job holding state lock for a long time, > > we may come across error: > > > > "Timed out during operation: cannot acquire state change lock" > > > > Well, sometimes it's not a problem and users want to continue > > to wait