Re: [libvirt] [RFC PATCH 3/3] news: Update news for vfio-ap support

2018-10-08 Thread Boris Fiuczynski
On 10/9/18 7:10 AM, Bjoern Walk wrote: + The qemu driver now has support to passthrough adjunct processors + into qemu guests on S390. s/qemu/QEMU Ok, changed. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH

Re: [libvirt] [RFC PATCH 3/3] news: Update news for vfio-ap support

2018-10-08 Thread Bjoern Walk
Boris Fiuczynski [2018-10-08, 06:25PM +0200]: > Signed-off-by: Boris Fiuczynski > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index dc08c96352..b47cb979f2 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -35,6

Re: [libvirt] [RFC PATCH 2/3] qemu: vfio-ap device support

2018-10-08 Thread Bjoern Walk
Boris Fiuczynski [2018-10-08, 06:25PM +0200]: > Adjusting domain format documentation, adding device address > support and adding command line generation for vfio-ap. > > Signed-off-by: Boris Fiuczynski > --- > docs/formatdomain.html.in | 3 ++- > docs/schemas/domaincommon.rng | 1 + >

Re: [libvirt] [RFC PATCH 1/3] qemu: add vfio-ap capability

2018-10-08 Thread Bjoern Walk
Boris Fiuczynski [2018-10-08, 06:25PM +0200]: > Introduce vfio-ap capability. > > Signed-off-by: Boris Fiuczynski > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v2 1/1] Add attribute single_usage_restriction for mdev type-id

2018-10-08 Thread Kirti Wankhede
Generally a single instance of mdev device, a share of physical device, is assigned to user space application or a VM. There are cases when multiple instances of mdev devices of same or different types are required by user space application or VM. For example in case of vGPU, multiple mdev devices

[libvirt] [RFC] virfile: fix cast-align error

2018-10-08 Thread Marc Hartmayer
Use the correct type in order to fix the following error on s390x: In function 'virFileIsSharedFSType': ../../src/util/virfile.c:3578:38: error: cast increases required alignment of target type [-Werror=cast-align] virFileIsSharedFixFUSE(path, (long *) _type); Signed-off-by: Marc

Re: [libvirt] [PATCH] qemu: use "id" instead of deprecated "name" for -net

2018-10-08 Thread Laine Stump
On 10/08/2018 10:54 AM, Ján Tomko wrote: > -net name= will be deprecated in QEMU 3.1: > commit 101625a4d4ac7e96227a156bc5f6d21a9cc383cd > net: Deprecate the "name" parameter of -net > git describe: v3.0.0-791-g101625a4d4 > > Use the id option instead, supported since QEMU 1.2: > commit

[libvirt] [RFC PATCH 0/3] qemu: guest dedicated crypto adapters

2018-10-08 Thread Boris Fiuczynski
This RFC patch series introduces initial libvirt support for guest dedicated crypto adapters on S390. It essentially allows to specify a vfio-ap mediated device in a domain. Extensive documentation about AP is available in patch 6 of the QEMU patch series. KVM/kernel: guest dedicated crypto

[libvirt] [RFC PATCH 2/3] qemu: vfio-ap device support

2018-10-08 Thread Boris Fiuczynski
Adjusting domain format documentation, adding device address support and adding command line generation for vfio-ap. Signed-off-by: Boris Fiuczynski --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/qemu/qemu_command.c| 8

[libvirt] [RFC PATCH 3/3] news: Update news for vfio-ap support

2018-10-08 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index dc08c96352..b47cb979f2 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,15 @@ + + + qemu: Add vfio AP

[libvirt] [RFC PATCH 1/3] qemu: add vfio-ap capability

2018-10-08 Thread Boris Fiuczynski
Introduce vfio-ap capability. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e228f52ec0..2ca5af3297 100644 ---

[libvirt] [PATCH] qemu: use "id" instead of deprecated "name" for -net

2018-10-08 Thread Ján Tomko
-net name= will be deprecated in QEMU 3.1: commit 101625a4d4ac7e96227a156bc5f6d21a9cc383cd net: Deprecate the "name" parameter of -net git describe: v3.0.0-791-g101625a4d4 Use the id option instead, supported since QEMU 1.2: commit 6687b79d636cd60ed9adb1177d0d946b58fa7717 convert

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Daniel P . Berrangé
On Mon, Oct 08, 2018 at 02:35:30PM +0200, Andrea Bolognani wrote: > On Mon, 2018-10-08 at 13:09 +0100, Daniel P. Berrangé wrote: > > This patch is doing two things. It is moving the code block earlier, > > to let you drop the duplicated virQEMUCapsCacheLookup(). Second it is > > removing the array

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Andrea Bolognani
On Mon, 2018-10-08 at 13:09 +0100, Daniel P. Berrangé wrote: > This patch is doing two things. It is moving the code block earlier, > to let you drop the duplicated virQEMUCapsCacheLookup(). Second it is > removing the array iteration & just checking one single path instead. > > I'd suggest we

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Daniel P . Berrangé
On Thu, Sep 20, 2018 at 05:25:26PM +0200, Andrea Bolognani wrote: > Now that we have reduced the number of sensible options down > to either the native QEMU binary or RHEL's qemu-kvm, we can > make virQEMUCapsInitGuest() a bit simpler. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Andrea Bolognani
On Mon, 2018-10-08 at 13:10 +0200, Peter Krempa wrote: > On Mon, Oct 08, 2018 at 13:04:17 +0200, Andrea Bolognani wrote: > > On Mon, 2018-10-08 at 12:59 +0200, Peter Krempa wrote: > > > Well, if we are going to bend the rules and make a hack for the mess > > > some downstream distro made, then we

[libvirt] [PATCH] libvirt: add daemon itself as shutdown reason

2018-10-08 Thread Nikolay Shirokovskiy
Let's introduce shutdown reason "daemon" which means we have to kill running domain ourselves as the best action we can take at that moment. Failure to pick up domain on daemon restart is one example of such case. Using reason "crashed" is a bit misleading as it is used when qemu is actually

Re: [libvirt] [PATCH v2 04/12] qemu: domain: Assume 'raw' default storage format also for network storage

2018-10-08 Thread Peter Krempa
On Mon, Oct 08, 2018 at 07:10:28 -0400, John Ferlan wrote: > > > On 10/5/18 8:14 AM, Peter Krempa wrote: > > Post parse callback adds the 'raw' type only for local files. Remote > > files can also have backing store (even local) so we should do this also > > for network backed storage. > > NIT:

Re: [libvirt] [PATCH v2 04/12] qemu: domain: Assume 'raw' default storage format also for network storage

2018-10-08 Thread John Ferlan
On 10/5/18 8:14 AM, Peter Krempa wrote: > Post parse callback adds the 'raw' type only for local files. Remote > files can also have backing store (even local) so we should do this also > for network backed storage. NIT: The .xml/.args in this patch are not all remote storage - they are volume

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Peter Krempa
On Mon, Oct 08, 2018 at 13:04:17 +0200, Andrea Bolognani wrote: > On Mon, 2018-10-08 at 12:59 +0200, Peter Krempa wrote: > > On Fri, Oct 05, 2018 at 17:18:44 +0200, Andrea Bolognani wrote: > > > On Fri, 2018-10-05 at 16:43 +0200, Ján Tomko wrote: > > > > On Thu, Sep 20, 2018 at 05:25:26PM +0200,

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Andrea Bolognani
On Mon, 2018-10-08 at 12:59 +0200, Peter Krempa wrote: > On Fri, Oct 05, 2018 at 17:18:44 +0200, Andrea Bolognani wrote: > > On Fri, 2018-10-05 at 16:43 +0200, Ján Tomko wrote: > > > On Thu, Sep 20, 2018 at 05:25:26PM +0200, Andrea Bolognani wrote: > > > > @@ -756,6 +755,13 @@

Re: [libvirt] [PATCH 08/11] qemu: Simplify QEMU binary search

2018-10-08 Thread Peter Krempa
On Fri, Oct 05, 2018 at 17:18:44 +0200, Andrea Bolognani wrote: > On Fri, 2018-10-05 at 16:43 +0200, Ján Tomko wrote: > > On Thu, Sep 20, 2018 at 05:25:26PM +0200, Andrea Bolognani wrote: > > > @@ -756,6 +755,13 @@ virQEMUCapsInitGuest(virCapsPtr caps, > > > */ > > > binary =

Re: [libvirt] [PATCH v2 00/12] qemu: Fix media changing problems

2018-10-08 Thread Michal Privoznik
On 10/05/2018 02:13 PM, Peter Krempa wrote: > Fixes regression in media changing/disk hotplug as the ordering of the > alias allocation and disk preparation was bad. > > v2: > - be more explicit about old and new definitions used in certain steps > - clean up legacy hotplug to not access old disk

Re: [libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs

2018-10-08 Thread Fabiano Fidêncio
On Mon, 2018-10-08 at 10:53 +0200, Fabiano Fidêncio wrote: > This is a simple draft of a work that has been discussed back in July > as > part of this thread[0]. > > There are a few things which are not clear to me whether we want (or > whether we do *not* want). > > For now I'm not using any

[libvirt] [osinfo-db-tools PATCH v2 2/2] import: Remove unused variable

2018-10-08 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- tools/osinfo-db-import.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/osinfo-db-import.c b/tools/osinfo-db-import.c index 289a85d..c0b4931 100644 --- a/tools/osinfo-db-import.c +++ b/tools/osinfo-db-import.c @@ -193,7 +193,6 @@ static int

[libvirt] [osinfo-db-tools PATCH v2 1/2] import: Learn how to deal with URLs

2018-10-08 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- tools/osinfo-db-import.c | 88 ++-- 1 file changed, 84 insertions(+), 4 deletions(-) diff --git a/tools/osinfo-db-import.c b/tools/osinfo-db-import.c index 0d0bdd9..289a85d 100644 --- a/tools/osinfo-db-import.c +++

[libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs

2018-10-08 Thread Fabiano Fidêncio
This is a simple draft of a work that has been discussed back in July as part of this thread[0]. There are a few things which are not clear to me whether we want (or whether we do *not* want). For now I'm not using any progress callback to print the download status and I don't even know whether

Re: [libvirt] [PATCH 00/15] Move unix socket creation out of qemuBuildCommandLine

2018-10-08 Thread Michal Privoznik
On 10/04/2018 09:22 PM, Ján Tomko wrote: > Add test coverage for all the possible devices and move all the > socket creation to qemuProcessPrepareHost. > TBD: remove the racy qemuSecuritySetSocketLabel call > as well as the rest of host state modification out of > qemuBuildCommandLine > > Ján

[libvirt] [PATCH RFC v2] qemu: fix deadlock when waiting in non async jobs

2018-10-08 Thread Nikolay Shirokovskiy
Block job abort operation can not handle properly qemu crashes when waiting for abort/pivot completion. Deadlock scenario is next: - qemuDomainBlockJobAbort waits for pivot/abort completion - qemu crashes, then qemuProcessBeginStopJob broadcasts for VM condition and then waits for job condition

Re: [libvirt] [PATCH] virresctrl: remove bogus virResetLastError

2018-10-08 Thread Michal Privoznik
On 10/05/2018 04:42 PM, Ján Tomko wrote: > virFileReadValueUint does not log errors for non-existient files, > it merely returns -2. > > Commit 12093f1 introduced this. > > Signed-off-by: Ján Tomko > --- > src/util/virresctrl.c | 2 -- > 1 file changed, 2 deletions(-) > ACK Michal --

Re: [libvirt] [PATCH] virt-host-validate: Fix build on non-Linux

2018-10-08 Thread Pavel Hrdina
On Mon, Oct 08, 2018 at 09:34:48AM +0200, Michal Privoznik wrote: > For non-Linux platforms we have > virHostValidateCGroupControllers() stub which only reports an > error. But we are not marking the ignored arguments the way we > should. > > Signed-off-by: Michal Privoznik > --- >

[libvirt] [PATCH] virt-host-validate: Fix build on non-Linux

2018-10-08 Thread Michal Privoznik
For non-Linux platforms we have virHostValidateCGroupControllers() stub which only reports an error. But we are not marking the ignored arguments the way we should. Signed-off-by: Michal Privoznik --- tools/virt-host-validate-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH v2] qemu: agent: Avoid agentError when closing the QEMU agent

2018-10-08 Thread wang.yechao255
> On 9/28/18 5:36 AM, Wang Yechao wrote: > > After calling qemuAgentClose(), it is still possible for > > the QEMU Agent I/O event callback to get invoked. This > > will trigger an agent error because mon->fd has been set > > to -1 at this point. Then vm->privateData->agentError is > > always

Re: [libvirt] [PATCH v2] qemu: agent: Avoid agentError when closing the QEMU agent

2018-10-08 Thread wang.yechao255
> On 09/28/2018 11:36 AM, Wang Yechao wrote: > > After calling qemuAgentClose(), it is still possible for > > the QEMU Agent I/O event callback to get invoked. This > > will trigger an agent error because mon->fd has been set > > to -1 at this point. Then vm->privateData->agentError is > > always