Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-14 Thread Yi Min Zhao
在 2018/10/12 下午11:04, Daniel P. Berrangé 写道: On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function

Re: [libvirt] [PATCH v6 11/13] qemu: Add hotpluging support for PCI devices on S390 guests

2018-10-14 Thread Yi Min Zhao
在 2018/10/12 下午10:57, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] @@ -1381,7 +1469,8 @@ qemuDomainAttachNetDevice(virQEMUDriverPtr driver, goto cleanup; } -if (qemuDomainIsS390CCW(vm->def) && +if (net->info.type !=

Re: [libvirt] [PATCH v6 10/13] qemu: Generate and use zPCI device in QEMU command line

2018-10-14 Thread Yi Min Zhao
在 2018/10/12 下午10:44, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] @@ -3089,6 +3146,10 @@ qemuBuildControllerDevCommandLine(virCommandPtr cmd, goto cleanup; if (devstr) { +if (qemuCommandAddExtDevice(cmd,

Re: [libvirt] [PATCH v6 12/13] docs: Add 'uid' and 'fid' information

2018-10-14 Thread Yi Min Zhao
在 2018/10/12 下午11:03, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] @@ -3925,7 +3925,14 @@ (since 0.9.7, requires QEMU 0.13). multifunction defaults to 'off', but should be set to 'on' for function 0 of a slot that will -

Re: [libvirt] [PATCH v6 08/13] qemu: Add zPCI address definition check

2018-10-14 Thread Yi Min Zhao
在 2018/10/11 下午9:08, Andrea Bolognani 写道: On Thu, 2018-10-11 at 14:44 +0200, Andrea Bolognani wrote: [...] With the above addressed, Reviewed-by: Andrea Bolognani Forgot to mention: it would be really nice if you added a negative test case showing that using zPCI addresses on eg. x86

Re: [libvirt] [PATCH v6 06/13] conf: Introduce address caching for PCI extensions

2018-10-14 Thread Yi Min Zhao
在 2018/10/11 下午6:31, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] +static void +virDomainPCIAddressSetExtensionFree(virDomainPCIAddressSetPtr addrs) +{ +if (!addrs || !addrs->zpciIds) +return; + +virHashFree(addrs->zpciIds->uids); +

Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-14 Thread Yi Min Zhao
在 2018/10/14 下午8:47, Andrea Bolognani 写道: On Fri, 2018-10-12 at 16:04 +0100, Daniel P. Berrangé wrote: On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: [...] I'm not sure if this was discussed in earlier versions, but to me

Re: [libvirt] [PATCH v6 13/13] news: Update news for PCI address extension attributes

2018-10-14 Thread Yi Min Zhao
在 2018/10/12 下午11:05, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] + + + qemu: Added support for PCI device passthrough on S390 Talking about "device passthrough" is not accurate, because the new feature can be used for emulated

Re: [libvirt] [PATCH v6 08/13] qemu: Add zPCI address definition check

2018-10-14 Thread Yi Min Zhao
在 2018/10/11 下午8:44, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] +static int +qemuDomainDeviceDefValidateAddress(const virDomainDeviceDef *dev, + virQEMUCapsPtr qemuCaps) +{ +virDomainDeviceInfoPtr info = +

[libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-14 Thread Han Han
https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-14 Thread Andrea Bolognani
On Fri, 2018-10-12 at 16:04 +0100, Daniel P. Berrangé wrote: > On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: [...] > > > > > > > > > > > > > function='0x0'> > > > > > > > > I'm not sure if this was discussed in earlier versions, but to

Re: [libvirt] [RFC 0/7] Warn at runtime when deprecated features are used

2018-10-14 Thread Andrea Bolognani
On Fri, 2018-10-12 at 16:21 +0100, Daniel P. Berrangé wrote: > On Wed, Oct 10, 2018 at 01:09:50PM +0200, Andrea Bolognani wrote: > > So once we have these changes in place, command line users can be > > pretty much completely isolated from libvirt defaults, just like > > virt-manager and oVirt and