On 10/26/18 3:00 AM, Chris Venteicher wrote:
Quoting Boris Fiuczynski (2018-10-18 09:54:07)
Adjusting domain format documentation, adding device address
support and adding command line generation for vfio-ap.
Since only one mediated hostdev with model vfio-ap is supported a check
disallows to de
Daniel P. Berrangé [2018-10-25, 06:32PM +0100]:
> On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote:
> > Daniel P. Berrangé [2018-10-24, 10:43PM +0100]:
> > > We could optimize this by jcalling virFileAccessibleAs
> > > once and storing the result in a global. Then just do a
> > > plain
Refactor virFileIsCDROM to virFileCheckCDROM for checking cdrom status.
Add add enum type virFileCDRomStatus.
Now virFileCheckCDROM could be used to check the cdrom drive status such
as ok, no disc, tray open, drive not ready, or unknown.
Signed-off-by: Han Han
---
src/libvirt_private.syms | 2
v3: https://www.redhat.com/archives/libvir-list/2018-July/msg00675.html
v2: https://www.redhat.com/archives/libvir-list/2018-July/msg00655.html
v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00103.html
Refactor virFileIsCDROM to virFileCheckCDROM and add new argument filled
with cdro
https://bugzilla.redhat.com/show_bug.cgi?id=1596096
Implement virFileCheckCDROM in virStorageBackendVolOpen to check if
cdrom backend is ok. Report more detailed error if not ok.
Signed-off-by: Han Han
---
src/storage/storage_util.c | 32
1 file changed, 32 inse
Quoting Boris Fiuczynski (2018-10-18 09:54:07)
> Adjusting domain format documentation, adding device address
> support and adding command line generation for vfio-ap.
> Since only one mediated hostdev with model vfio-ap is supported a check
> disallows to define domains with more than one such hos
Quoting Boris Fiuczynski (2018-10-25 07:35:44)
> On 10/25/18 1:54 PM, Boris Fiuczynski wrote:
> > On 10/25/18 5:17 AM, Chris Venteicher wrote:
> >> Quoting Thomas Huth (2018-10-19 06:58:34)
> >>> On 2018-10-18 16:54, Boris Fiuczynski wrote:
> Introduce vfio-ap capability.
>
> Signed-
On Sat, Oct 20, 2018 at 05:19:56PM +0300, Roman Bolshakov wrote:
> With this change virsh domcapabilites shows:
>
>
> Signed-off-by: Roman Bolshakov
> ---
> src/qemu/qemu_capabilities.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Ber
On Sat, Oct 20, 2018 at 05:19:48PM +0300, Roman Bolshakov wrote:
> There's no QMP command for querying if hvf is supported, therefore we
> use sysctl interface that tells if Hypervisor.framwork works/available
> on the host.
>
> Signed-off-by: Roman Bolshakov
> ---
> src/qemu/qemu_capabilities.c
On Sat, Oct 20, 2018 at 05:19:49PM +0300, Roman Bolshakov wrote:
> Signed-off-by: Roman Bolshakov
> ---
> src/qemu/qemu_capabilities.c | 11 +++
> 1 file changed, 11 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flick
On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote:
> While being at it deprecate cirrus too.
>
> Reason (short version): use stdvga instead.
> Verbose version:
> https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
Every single one of my guests is using cirrus.
On Sat, Oct 20, 2018 at 05:19:47PM +0300, Roman Bolshakov wrote:
> Signed-off-by: Roman Bolshakov
> ---
> src/qemu/qemu_capabilities.c | 1 +
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> in
On Thu, Oct 25, 2018 at 04:26:16PM +0530, P J P wrote:
> +-- On Thu, 25 Oct 2018, Gerd Hoffmann wrote --+
> | We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
> |
> | Reproducer:
> | outw(0xff60, 0x220);
> | outw(0x1020, 0x220);
> | outw(0xffb0, 0x220);
> | Result
On Sat, Oct 20, 2018 at 05:19:46PM +0300, Roman Bolshakov wrote:
> QEMU supports Hypervisor.framework as hvf accel since 2.12.
>
> Signed-off-by: Roman Bolshakov
> ---
> src/conf/domain_conf.c | 4 +++-
> src/conf/domain_conf.h | 1 +
> src/qemu/qemu_command.c | 4
> 3 files changed, 8 in
On Sat, Oct 20, 2018 at 05:19:57PM +0300, Roman Bolshakov wrote:
> Signed-off-by: Roman Bolshakov
> ---
> docs/schemas/domaincommon.rng | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 099a949cf8..2e1203f58e 100644
> -
On 2018-10-25 09:52, Gerd Hoffmann wrote:
> While being at it deprecate cirrus too.
>
> Reason (short version): use stdvga instead.
> Verbose version:
> https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/display/cirrus_vga.c
On 2018-10-25 09:52, Gerd Hoffmann wrote:
> We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
>
> Reproducer:
> outw(0xff60, 0x220);
> outw(0x1020, 0x220);
> outw(0xffb0, 0x220);
> Result:
> Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
>
> The sp
Add some monitor commands to be used during backup/checkpoint
operations: another facet to query-block for learning bitmap
size; x-block-dirty-bitmap-enable,
x-block-dirty-bitmap-merge, and block-dirty-bitmap-remove
used when deleting a checkpoint; block-dirty-bitmap-add for
performing incremental
Still needs to actually kick off the right QMP commands, but at
least allows validation of backup XML, including the fact that
a backup job can survive a libvirtd restart. Atomically creating
a checkpoint alongside the backup still needs implementing.
Signed-off-by: Eric Blake
---
src/qemu/qemu_
Time to actually issue the QMP transactions that create and
delete persistent checkpoints. For create, we only need one
transaction: inside, we visit all disks affected by the
checkpoint, and create a new enabled bitmap, as well as
disabling the bitmap of the parent checkpoint (if any). For
delet
Accept XML describing a generic block job, and output it again
as needed. At the moment, it has some qemu-specific hacks, such
as storing internal XML for a node name, that might be cleaner
once full-tree node-name support goes in.
Still not done: decent tests
Signed-off-by: Eric Blake
---
src/
---
tools/virsh-checkpoint.c | 249 +++
1 file changed, 249 insertions(+)
diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c
index cd08569813..367a424c7b 100644
--- a/tools/virsh-checkpoint.c
+++ b/tools/virsh-checkpoint.c
@@ -1270,6 +1270,237 @@
Work in progress - the checkpoint code is not quite passing
tests (part of that is figuring out the minimal XML that is
still valid as a element, or just use --no-domain flag).
Signed-off-by: Eric Blake
---
src/conf/checkpoint_conf.h | 152
src/conf/domain_conf.h |
Creating a checkpoint does not modify guest-visible state,
but does modify host resources. Rather than reuse existing
domain:write, domain:block_write, or domain:snapshot access
controls, it seems better to introduce a new access control
specific to tasks related to checkpoints and incremental
bac
Introduce a few more new public APIs related to incremental backups.
This builds on the previous notion of a checkpoint (without an
existing checkpoint, the new API is a full backup, differing only
from virDomainCopy in the point of time chosen); and also allows
creation of a new checkpoint at the
Upcoming patches will add support for incremental backups via
a new API; but first, we need a landing page that gives an
overview of capturing various pieces of guest state, and which
APIs are best suited to which tasks.
Signed-off-by: Eric Blake
---
v2: wording improvements based on review
---
Prepare for introducing a bunch of new public APIs related to
backup checkpoints by first introducing a new internal type
and errors associated with that type. Checkpoints are modeled
heavily after virDomainSnapshotPtr (both represent a point in
time of the guest), although a snapshot exists with
Upcoming patches plan to introduce virDomainCheckpointPtr as a new
object for use in incremental backups, along with documentation on
how incremental backups differ from snapshots. But first, we need
to rename any existing mention of a 'system checkpoint' to instead
be a 'full system snapshot', so
The following is the latest version of my API proposal for
incremental backups, and matches the demo I will be presenting
as part of my KVM Forum 2018 talk tomorrow afternoon:
https://kvmforum2018.sched.com/event/FzuB/facilitating-incremental-backup-eric-blake-red-hat
The patches are also availabl
On 10/12/18 11:28 AM, Jiri Denemark wrote:
Since I will be demonstrating the use of this API at the KVM Forum,
I would really like a decision on whether we can commit the API
into libvirt now, even if we have to wait for the qemu implementation
No we can't. We did it once in the past and altho
Complete wiring up incremental backup, by adding in support for
creating a checkpoint at the same time as a backup (make the
transaction have a few more steps) as well as exposing the dirty
bitmap for a prior backup over NBD (requires creating a temporary
bitmap, merging all appropriate bitmaps in,
A lot of this work heavily copies from the existing snapshot
APIs. The interaction with qemu during create/delete still
needs to be implemented, but this takes care of all the libvirt
metadata (saving and restoring XML, and tracking the relations
between multiple checkpoints).
Signed-off-by: Eric
Time to actually issue the QMP transactions that start and
stop backup commands (for now, just pull mode, not push).
Starting a job has to kick off several pre-req steps, then
a transaction, and additionally spawn an NBD server for pull
mode; ending a job as well as failing partway through
beginnin
Introduce a bunch of new virsh commands for managing checkpoints
in isolation. More commands are needed for performing incremental
backups, but these commands were easy to implement by modeling
heavily after virsh-snapshot.c (no need for checkpoint-revert,
and checkpoint-list was a lot easier since
Prepare for new checkpoint and backup APIs by describing the XML
that will represent a checkpoint and backup. The checkpoint XML
is modeled heavily after virDomainSnapshotPtr, since both represent
a point in time of the guest (however, a snapshot exists with the
intent to roll back to that point,
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, at which point the remote driver
code for backups can be generated.
Signed-off-by: Eric Blake
---
src/remote/remote_daemon_dispatch.c | 15 ++
src/remote/remote_driver.c | 33 +++-
src/remote/remote_
Introduce a bunch of new public APIs related to backup checkpoints.
Checkpoints are modeled heavily after virDomainSnapshotPtr (both
represent a point in time of the guest), although a snapshot exists
with the intent of rolling back to that state, while a checkpoint
exists to make it possible to cr
Right now, we only use NBD exports during storage migration,
where we control the NBD client and therefore don't care about
the export name (qemu's default of naming the export after the
device is fine). But upcoming patches for exposing backups over
NBD wants to use a different export name (matchi
An upcoming patch wants to reuse XML parsing of both unix and tcp
network host descriptions in the context of setting up a backup
NBD server. Make that easier by refactoring the existing parser.
Signed-off-by: Eric Blake
---
src/conf/domain_conf.h | 2 ++
src/conf/domain_conf.c | 43 +++
On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote:
> Daniel P. Berrangé [2018-10-24, 10:43PM +0100]:
> > We could optimize this by jcalling virFileAccessibleAs
> > once and storing the result in a global. Then just do a
> > plain stat() call in process to check the st_ctime field
> > for
On Thu, Oct 25, 2018 at 10:32:23AM -0300, Eduardo Habkost wrote:
> From: Philippe Mathieu-Daudé
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Artyom Tarasenko
> Reviewed-by: Cédric Le Goater
> Message-Id: <20181002212522.23303-3-f4...@amsat.org>
> Signed-off-by: Eduardo Habkost
> -
It's out. After 6 years we have a new libvirt-snmp release. Yay. You can
obtain it from the usual sources:
https://libvirt.org/sources/snmp/
I've pushed it into git and tagged. Thanks everybody who participated in
any form.
Changelog:
- Replace placeholder org OID with libvirt OID
- Fix object
From: David Hildenbrand
There are no remaining users of get_region_size() except
memory_device_get_region_size() itself. We can make
memory_device_get_region_size() work directly on get_memory_region()
instead and drop get_region_size().
In addition, we can now use memory_device_get_region_size(
From: David Hildenbrand
We will factor out get_memory_region() from pc-dimm to memory device code
soon. Once that is done, get_region_size() can be implemented
generically and essentially be replaced by
memory_device_get_region_size (and work only on get_memory_region()).
We have some users of g
From: David Hildenbrand
Let's properly forward the errors, so errors from get_region_size() /
get_plugged_size() can be handled.
Users right now call both functions after the device has been realized,
which is will never fail, so it is fine to continue using error_abort.
While at it, remove a l
From: Philippe Mathieu-Daudé
Move from the legacy SysBusDevice::init method to using DeviceState::realize.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-5-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20181002212522.23303-11-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/alpha/typhoon.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/hw/alpha/typhoon.c b/hw/alp
From: Philippe Mathieu-Daudé
Missed while reviewing 5dd85b4b486.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-2-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/timer/trace-events | 2 +-
1 file change
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-3-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/timer/sun4v-rtc.c | 13 +++--
hw/timer/trace-events | 4
2
From: Igor Mammedov
commit
(5cdc9b76e3 vl.c: Remove dead assignment)
removed sockets calculation when 'sockets' weren't provided on CLI
since there wasn't any users for it back then. Exiting checks
are neither reachable
} else if (sockets * cores * threads < cpus) {
or nor triggerable
if
From: Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
topology.
De
From: David Hildenbrand
The memory region is necessary for plugging/unplugging a memory device.
The region size (via get_region_size()) is no longer sufficient, as
besides the alignment, also the region itself is required in order to
add it to the device memory region of the machine via
- memory_
From: David Hildenbrand
Document the functions. Don't document get_region_size(), as we will be
dropping/replacing that one soon.
Use same documentation style as in include/exec/memory.h, but don't
document the parameters, as they are self-explanatory.
Reviewed-by: David Gibson
Reviewed-by: Ig
From: David Hildenbrand
To be able to factor out address assignment of memory devices, we will
have to read (get_addr()) and write (set_addr()) the address.
We can't use properties for this purpose, as properties are device
specific. E.g. while the address property for a DIMM is called "addr", i
From: David Hildenbrand
With all required memory device class functions in place, we can factor
out pre_plug handling of memory devices. Take proper care of errors. We
still have to carry along legacy_align required for pc compatibility
handling.
We will factor out tracing of the address separat
From: David Hildenbrand
While we rephrased most error messages, we missed these.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Igor Mammedov
Reviewed-by: David Gibson
Signed-off-by: David Hildenbrand
Message-Id: <20181005092024.14344-6-da...@redhat.com>
Signed-off-by: Eduardo Habkost
---
From: Li Qiang
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
Message-Id: <20181010161025.34796-1-liq...@163.com>
Reviewed-by: Stefano Garzarella
Signed-off-by: Eduardo Habkost
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/h
From: David Hildenbrand
Handle id==NULL better and indicate that we are dealing with memory
devices.
Signed-off-by: David Hildenbrand
Message-Id: <20181005092024.14344-4-da...@redhat.com>
Reviewed-by: David Gibson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Eduardo Habkost
---
hw/mem
From: David Hildenbrand
Some architectures might support memory devices, while they don't
support DIMM/NVDIMM. So let's
- Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE
- Introduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM
CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE.
Reviewe
From: David Hildenbrand
We're missing "x" after the leading 0.
Reviewed-by: David Gibson
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
Message-Id: <20181005092024.14344-2-da...@redhat.com>
Signed-off-by: Eduardo Habkost
---
hw/mem/memory-device.c | 2 +-
1 file changed, 1 inse
From: David Hildenbrand
We're plugging/unplugging a PCDIMMDevice, so directly pass this type
instead of a more generic DeviceState.
Reviewed-by: David Gibson
Acked-by: David Gibson
Reviewed-by: Igor Mammedov
Reviewed-by: Eric Auger
Signed-off-by: David Hildenbrand
Message-Id: <2018100509202
From: David Hildenbrand
The "at" should actually be a "before".
if (new_addr < address_space_start)
-> "can't add memory ... before... $address_space_start"
So it looks similar to the other check
} else if ((new_addr + size) > address_space_end)
-> "can't add memory ... beyond.
From: Philippe Mathieu-Daudé
Move from the legacy SysBusDevice::init method to using DeviceState::realize.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181002212522.23303-6-f4...@amsat.org>
Reviewed-by: Peter Maydell
Signed-off-by: Eduardo Habkost
---
hw/sh4/sh_pci.c | 20 +--
From: Philippe Mathieu-Daudé
The gt64120 is currently listed as uncategorized device.
Mark it as bridge device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-9-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
-
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20181002212522.23303-12-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/hppa/dino.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 5
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20181002212522.23303-13-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/mips/mips_malta.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw
From: Philippe Mathieu-Daudé
Move from the legacy SysBusDevice::init method to using DeviceState::realize.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20181002212522.23303-7-f4...@amsat.org>
Reviewed-by: Peter Maydell
Signed-off-by: Eduardo Habkost
---
hw/pci-host/bonito.c | 9 +++
From: Philippe Mathieu-Daudé
Convert the gt64120_reset() function into a proper Device reset method.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-8-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/mips
From: Philippe Mathieu-Daudé
Since the I/O Bridge device is not implemented, Use the
TYPE_UNIMPLEMENTED_DEVICE which suits better: if the user
asks for 'unimp' warnings via the -d option then all accesses
will generate logging.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenk
From: Zhang Yi
object_get_canonical_path_component() returns a string which
must be freed using g_free().
Reported-by: Peter Maydell
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Zhang Yi
Message-Id:
<7328fb16c394eaf5d65437d11c2a9343647b6d3d.1535471899.git.yi.z.zh...@linux.intel.com>
Revi
Changes v1 -> v2:
* Fix 'make check' warnings (Igor)
The following changes since commit 13399aad4fa87b2878c49d02a5d3bafa6c966ba3:
Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-10-22' into
staging (2018-10-23 17:20:23 +0100)
are available in the Git repository at:
git:/
From: Philippe Mathieu-Daudé
Move from the legacy SysBusDevice::init method to using DeviceState::realize.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Message-Id: <20181002212522.23303-4-f4...@amsat.org>
Signed-off-by: Eduardo Habkost
---
hw/
On Wed, Oct 24, 2018 at 02:52:12PM +0100, Michal Privoznik wrote:
So far we are taking whatever is `net-snmp-config
--default-mibdirs` returns and using that as MIB_DIR to install
our MIB. This has a drawback that it ignores whatever prefix user
specifies to configure script (which is used by `ma
On 10/25/18 1:54 PM, Boris Fiuczynski wrote:
On 10/25/18 5:17 AM, Chris Venteicher wrote:
Quoting Thomas Huth (2018-10-19 06:58:34)
On 2018-10-18 16:54, Boris Fiuczynski wrote:
Introduce vfio-ap capability.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_capabil
Daniel P. Berrangé [2018-10-24, 10:43PM +0100]:
> We could optimize this by jcalling virFileAccessibleAs
> once and storing the result in a global. Then just do a
> plain stat() call in process to check the st_ctime field
> for changes. We only need re-run the heavy virFileAccessibleAs
> check if
On 10/25/18 5:17 AM, Chris Venteicher wrote:
Quoting Thomas Huth (2018-10-19 06:58:34)
On 2018-10-18 16:54, Boris Fiuczynski wrote:
Introduce vfio-ap capability.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h
On 25/10/18 10:52, Gerd Hoffmann wrote:
While being at it deprecate cirrus too.
Reason (short version): use stdvga instead.
Verbose version:
https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
Signed-off-by: Gerd Hoffmann
---
hw/display/cirrus_vga.c | 2 ++
hw/
On 25/10/18 10:52, Gerd Hoffmann wrote:
We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
Reproducer:
outw(0xff60, 0x220);
outw(0x1020, 0x220);
outw(0xffb0, 0x220);
Result:
Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
The specs google finds
Hi Gerd,
On 25/10/18 10:52, Gerd Hoffmann wrote:
Simliar to deprecated machine types.
"Similar"
Print a warning when creating a deprecated device.
Add deprecation notice to -device help.
TODO: add to intospection.
"introspection"
Do we want the TODO in the git history?
Signed-off-by:
+-- On Thu, 25 Oct 2018, Gerd Hoffmann wrote --+
| While being at it deprecate cirrus too.
|
| Reason (short version): use stdvga instead.
| Verbose version:
| https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
|
| Signed-off-by: Gerd Hoffmann
| ---
| hw/display/cirrus
+-- On Thu, 25 Oct 2018, Gerd Hoffmann wrote --+
| Simliar to deprecated machine types.
| Print a warning when creating a deprecated device.
| Add deprecation notice to -device help.
|
| TODO: add to intospection.
s/intospection/introspection ..?
| diff --git a/hw/core/qdev.c b/hw/core/qdev.c
|
+-- On Thu, 25 Oct 2018, Gerd Hoffmann wrote --+
| We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
|
| Reproducer:
| outw(0xff60, 0x220);
| outw(0x1020, 0x220);
| outw(0xffb0, 0x220);
| Result:
| Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
+ R
Works simliar to machine types, by adding a deprecation_reason field
(using the same name for easy grepping). Also deprecate two devices:
adlib and cirrus.
This is tagged as RfC because the deprecation notice is not added to
introspecction yet.
Gerd Hoffmann (3):
qdev: add deprecation_reason t
We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
Reproducer:
outw(0xff60, 0x220);
outw(0x1020, 0x220);
outw(0xffb0, 0x220);
Result:
Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
The specs google finds (http://www.symphoniae.com/Yamaha/YSC/YM3812.
Simliar to deprecated machine types.
Print a warning when creating a deprecated device.
Add deprecation notice to -device help.
TODO: add to intospection.
Signed-off-by: Gerd Hoffmann
---
hw/core/qdev.c | 9 -
include/hw/qdev-core.h | 1 +
qdev-monitor.c | 7 +++
3 f
While being at it deprecate cirrus too.
Reason (short version): use stdvga instead.
Verbose version:
https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful
Signed-off-by: Gerd Hoffmann
---
hw/display/cirrus_vga.c | 2 ++
hw/display/cirrus_vga_isa.c | 2 ++
qemu-depreca
86 matches
Mail list logo
