Re: [libvirt] [PATCH v2] qemu: Introduce caching whether /dev/kvm is accessible

2018-10-31 Thread Ján Tomko
On Tue, Oct 30, 2018 at 03:53:59PM +, Daniel P. Berrangé wrote: On Tue, Oct 30, 2018 at 04:47:32PM +0100, Michal Privoznik wrote: Well, caching owner + seclabels + ACLs won't help either. What if user loads some profile into AppArmor or something that denies previously allowed access to /dev

Re: [libvirt] [PATCH] nwfilter: intantiate filters on loading driver

2018-10-31 Thread John Ferlan
On 10/31/18 10:41 AM, Nikolay Shirokovskiy wrote: > On 31.10.2018 16:14, John Ferlan wrote: >> >> >> On 10/30/18 3:24 AM, Nikolay Shirokovskiy wrote: >>> >>> >>> On 29.10.2018 22:37, John Ferlan wrote: On 10/15/18 4:26 AM, Nikolay Shirokovskiy wrote: > Before using filters bin

Re: [libvirt] [PATCH] libxl: add support for soft reset

2018-10-31 Thread Jim Fehlig
On 10/30/18 3:18 AM, Michal Privoznik wrote: On 10/30/2018 03:17 AM, Jim Fehlig wrote: On 10/29/18 7:26 PM, Jim Fehlig wrote: The pvops Linux kernel implements machine_ops.crash_shutdown as static void xen_hvm_crash_shutdown(struct pt_regs *regs) { native_machine_crash_shutdown(regs)

[libvirt] [PATCH V2 0/3] libxl: add support for soft reset

2018-10-31 Thread Jim Fehlig
Patches 1 and 2 are new to V2 and make slight improvements to libxlDomainShutdownThread. Patch 3 is adjusted to work with Xen 4.6. Jim Fehlig (3): libxl: remove redundant calls to virObjectEventStateQueue libxl: Remove some goto labels in libxlDomainShutdownThread libxl: add support for soft

[libvirt] [PATCH V2 2/3] libxl: Remove some goto labels in libxlDomainShutdownThread

2018-10-31 Thread Jim Fehlig
There are too many goto labels in libxlDomainShutdownThread. Convert the 'destroy' and 'restart' labels to helper functions, leaving only the commonly used pattern of 'endjob' and 'cleanup' labels. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 66 --

[libvirt] [PATCH V2 1/3] libxl: remove redundant calls to virObjectEventStateQueue

2018-10-31 Thread Jim Fehlig
In libxlDomainShutdownThread, virObjectEventStateQueue is needlessly called in the destroy and restart labels. The cleanup label aready queues whatever event was created based on libxl_shutdown_reason. There is no need to handle destroy and restart differently. Signed-off-by: Jim Fehlig --- src/

[libvirt] [PATCH V2 3/3] libxl: add support for soft reset

2018-10-31 Thread Jim Fehlig
The pvops Linux kernel implements machine_ops.crash_shutdown as static void xen_hvm_crash_shutdown(struct pt_regs *regs) { native_machine_crash_shutdown(regs); xen_reboot(SHUTDOWN_soft_reset); } but currently the libxl driver does not handle the soft reset shutdown event. As a res

Re: [libvirt] [PATCH v2] vhost-user: define conventions for vhost-user backends

2018-10-31 Thread Daniel P . Berrangé
On Wed, Oct 31, 2018 at 07:44:36PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Oct 16, 2018 at 4:14 PM Daniel P. Berrangé > wrote: > > > > It just reinvents the chardev unix socket syntax, but in a > > > > different adhoc manner, which is repeating the mistake we have > > > > made time & ag

Re: [libvirt] [PATCH v2] vhost-user: define conventions for vhost-user backends

2018-10-31 Thread Marc-André Lureau
Hi On Tue, Oct 16, 2018 at 4:14 PM Daniel P. Berrangé wrote: > > > It just reinvents the chardev unix socket syntax, but in a > > > different adhoc manner, which is repeating the mistake we have > > > made time & again in QEMU. Using QAPI we can directly accept > > > the ChardevSocket syntax we a

[libvirt] [PATCH] qemu: Report warning if QoS is set for vhostuser interface

2018-10-31 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1524230 Because of historical reasons, we are not denying starting a domain which has QoS set for unsupported type of device. We do report just a warning instead. And even though we perhaps used to do so for vhostuser it got lost somewhere. Bring it back

Re: [libvirt] [PATCH] nwfilter: intantiate filters on loading driver

2018-10-31 Thread Nikolay Shirokovskiy
On 31.10.2018 16:14, John Ferlan wrote: > > > On 10/30/18 3:24 AM, Nikolay Shirokovskiy wrote: >> >> >> On 29.10.2018 22:37, John Ferlan wrote: >>> >>> >>> On 10/15/18 4:26 AM, Nikolay Shirokovskiy wrote: Before using filters binding filters instantiation was done by hypervisors drivers

Re: [libvirt] [PATCH] nwfilter: intantiate filters on loading driver

2018-10-31 Thread John Ferlan
On 10/30/18 3:24 AM, Nikolay Shirokovskiy wrote: > > > On 29.10.2018 22:37, John Ferlan wrote: >> >> >> On 10/15/18 4:26 AM, Nikolay Shirokovskiy wrote: >>> Before using filters binding filters instantiation was done by hypervisors >>> drivers initialization code (qemu was the only such hyperv

Re: [libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml

2018-10-31 Thread Erik Skultety
On Mon, Oct 22, 2018 at 07:02:24PM +0200, Pino Toscano wrote: > Now that the libvirt-ocaml repository is fixed, let's build it in CI. > > Changes from v1 to v2: > - split according to Andrea's hints > - removed --with-libvirt as argument for configure, no more needed > after upstream changes Rev

Re: [libvirt] [PATCH v2 0/3] qemu: guest dedicated crypto adapters

2018-10-31 Thread Boris Fiuczynski
On 10/29/18 5:48 PM, John Ferlan wrote: On 10/18/18 10:54 AM, Boris Fiuczynski wrote: v2: + added singleton check for vfio-ap mediated device This patch series introduces initial libvirt support for guest dedicated crypto adapters on S390. It allows to specify a vfio-ap mediated device in a do