Hypervisor baseline cpu can be computed locally using libvirt utility
functions or remotely using QEMU QMP commands.
Likewise, cpu feature expansion can be computed locally using libvirt
utility functions or remotely using QEMU QMP commands.
This patch identifies using libvirt as a distinct case
Create public function to convert virCPUDef data structure into
qemuMonitorCPUModelInfoPtr data structure.
There was no existing code to reuse to create this function
so this new virQEMUCapsCPUModelInfoFromCPUDef function was based on
reversing the action of the existing
Locking the monitor object immediately after call to qemuMonitorOpen
doesn't make sense now that we have expanded the QEMU process code to
cover more than the original capabilities usecase.
Removing the monitor lock makes the qemuConnectMonitorQmp code
consistent with the qemuConnectMonitor code
Introduce monitor functions to use QEMU to compute baseline cpu
from an input of two cpu models.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 6
src/qemu/qemu_monitor_json.c | 60
Move code for setting paths and prepping file system from qemuProcessNew
to qemuProcessInitQmp.
This keeps qemuProcessNew limited to structure initialization and most
closely mirrors pattern established in qemuProcessInit within
qemuProcessInitQmp.
The patch is a non-functional, cut / paste
Multiple QEMU processes for QMP commands can operate concurrently.
Use a unique directory under libDir for each QEMU processes
to avoid pidfile and unix socket collision between processes.
The pid file name is changed from "capabilities.pidfile" to "qmp.pid"
because we no longer need to avoid a
qemuProcessStopQmp is one of the 4 public functions used to crate and
manage a Qemu process for QMP command exchanges.
Add comment header and debug message.
Other minor code formatting cleanup.
No change in functionality is intended.
Signed-off-by: Chris Venteicher
---
Failure to connect to QEMU to probe capabilities is not considered a error case
and does not result in a negative return value.
Check for a NULL monitor connection pointer before trying to send capabilities
commands to QEMU rather than depending on a special positive return value.
This
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 1d96a43206..758c8bed05 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8173,6 +8173,9 @@
Qemu process code in qemu_capabilities.c is moved to qemu_process.c in
order to make the code usable outside the original capabilities
usecases.
This process code activates and manages Qemu processes without
establishing a guest domain.
This patch is a straight cut/paste move between files.
Conversion functions are used convert CPUModelInfo structs into
QMP JSON and the reverse.
QMP JSON is of form:
{"model": {"name": "IvyBridge", "props": {}}}
qemuMonitorCPUModelInfoBoolPropAdd is used to add boolean properties to
CPUModelInfo struct.
qemuMonitorJSONGetCPUModelExpansion makes
Create utility function encapsulating code to calculate
hypervisor baseline cpu using the local libvirt utility functions.
Similar function encapsulating code to calculating hypervisor baseline
using QEMU QMP messages will be introduced in later commit.
Patch is a cut and paste of existing code
Hypervisor baseline has an expansion mode where the cpu property /
feature list is fully expanded to list all supported (true) features.
The output (expanded) cpu model should not list properties that are
false (unsupported.)
QEMU expansion output enumerates both true (supported) and false
qemuProcessStartQmp starts a QEMU process and monitor connection that
can be used by multiple functions possibly for multiple QMP commands.
The QMP exchange to exit capabilities negotiation mode and enter command mode
can only be performed once after the monitor connection is established.
Move
Support using QEMU to do feature expansion when also using QEMU to
compute hypervisor baseline.
A QEMU process is already created to send the QMP messages to baseline
using QEMU.
The same QEMU process is used for the CPU feature expansion.
QEMU only returns migratable features when expanding CPU
QEMU only returns migratable props when expanding model unless
explicitly told to also include non-migratable props.
Props will be marked migratable when we are certain QEMU returned only
migratable props resulting in consistent information and expansion output
for s390 that is consistent with
Move existing code to convert between cpu model info structures
(qemuMonitorCPUModelInfoPtr into virCPUDef)
into a reusable function.
The new function is used in this and future patches.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 84 ++--
Simple cut/paste operations within function
qemuConnectBaselineHypervisorCPU to group together code specific to
computing baseline using only libvirt utility functions.
This is done in anticipation of creating new utility functions for
1) baseline using libvirt utilities (this code)
2) baseline
Gracefully handle case when proc activation failed prior to calling.
Consistent with the existing code for qemuConnectMonitor (for domains)
in qemu_process.c...
- Handle qemMonitorOpen failure with INFO message and NULL ptr
- Identify parameters passed to qemuMonitorOpen
Monitor callbacks
Store libDir path in the qemuProcess struct in anticipation of moving
path construction code into qemuProcessInitQmp function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 8 +---
src/qemu/qemu_process.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
Qemu process code for capababilities doesn't use monitor callbacks and
defines empty callback functions.
Allow NULL to be passed to qemuMonitorOpen for callbacks and remove the
empty functions from the QMP process code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 4 ++--
Add capability to calculate hypervisor baseline using QMP message
exchanges with QEMU in addition to existing capability to calculate
baseline using libvirt utility functions.
A new utility function encapsulates the core logic for interacting with QEMU
using QMP baseline messages. The QMP
Catch execution paths where qemuProcessFree is called before
qemuProcessStopQmp then report error and force stop before proceeding.
Also added public function header and debug message.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 19 ---
1 file changed, 16
Move a step closer to the function structure used elsewhere in
qemu_process where qemuProcessStart and qemuProcessStop are the exposed
functions.
qemuProcessStartQmp mirrors qemuProcessStart in calling sub functions to
intialize, launch the process and connect the monitor to the QEMU
process.
qemuProcessNew is one of the 4 public functions used to create and
manage a qemu process for QMP command exchanges outside of domain
operations.
Add descriptive comment block, Debug statement and make source
consistent with the cleanup / VIR_STEAL_PTR format used elsewhere.
No functional changes
A qemuProcess struct tracks the entire lifespan of a single QEMU Process
including storing error output when the process terminates or activation
fails.
Error output remains available until qemuProcessFree is called.
The qmperr buffer no longer needs to be maintained outside of the
qemuProcess
In new process code, move from model where qemuProcess struct can be
used to activate a series of Qemu processes to model where one
qemuProcess struct is used for one and only one Qemu process.
The forceTCG parameter (use / don't use KVM) will be passed when the
qemuProcess struct is initialized
The monitor config data is removed from the qemuProcess struct.
The monitor config data can be initialized immediately before call to
qemuMonitorOpen and does not need to be maintained after the call
because qemuMonitorOpen copies any strings it needs.
Signed-off-by: Chris Venteicher
---
Follow the convention established in qemu_process of
1) alloc process structure
2) start process
3) use process
4) stop process
5) free process data structure
The process data structure persists after the process activation fails
or the process dies or is killed so stderr strings can be retrieved
s/qemuProcessAbort/qemuProcessStopQmp/ applied to change function name
used to stop QEMU processes in process code moved from
qemu_capabilities.
No functionality change.
The new name, qemuProcessStopQmp, is consistent with the existing
function qemuProcessStop used to stop Domain processes.
Qmp
qemuMonitor code lives in qemuConnectMonitorQmp rather than in
qemuProcessNew and qemuProcessLaunchQmp.
This is consistent with existing structure in qemu_process.c where
qemuConnectMonitor function contains monitor code for domain process
activation.
Simple code moves in this patch.
s/cmd/proc/ in process code imported from qemu_capabilities.
No functionality is changed.
Process code imported from qemu_capabilities was oriented around
starting a process to issue a single QMP command.
Future usecases were targeting use a single process for multiple
different QMP commands.
Create an augmented CPUModelInfo identifying which props are/aren't
migratable based on a diff between migratable and non-migratable
inputs.
This patch pulls existing logic out of virQEMUCapsProbeQMPHostCPU
and wraps the existing logic in a standalone function hopefully
simplifying both functions
A Full CPUModelInfo structure with props is sent to QEMU for expansion.
virQEMUCapsProbeQMPHostCPU migratability logic partitioned into new function
for clarity.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 8 +---
src/qemu/qemu_monitor.c | 31
Prevent compile errors due to trying to use a const string as a
non-const input to qemuProcessNew.
No functionality change.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 +-
src/qemu/qemu_process.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
s/virQEMUCapsInitQMPCommand/qemuProcess/
No functionality change.
Use appropriate prefix in moved code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 +++---
src/qemu/qemu_process.c | 28 ++--
src/qemu/qemu_process.h | 22
A helper function allocates an initializes model name
in CPU Model Info structs.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_monitor.c | 32 +++-
src/qemu/qemu_monitor.h | 2 ++
3 files changed, 30 insertions(+),
Some architectures (S390) depend on QEMU to compute baseline CPU model and
expand a models feature set.
Interacting with QEMU requires starting the QEMU process and completing one or
more query-cpu-model-baseline QMP exchanges with QEMU in addition to a
query-cpu-model-expansion QMP exchange to
A dry run can be used as a best-effort check that a migration command
will succeed. The destination host will be checked to see if it can
accommodate the resources required by the domain. DRY_RUN will fail if
the destination host is not capable of running the domain. Although a
subsequent
On 11/2/18 11:52 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> lib/Sys/Virt/TCK.pm | 33
> lib/Sys/Virt/TCK/NetworkBuilder.pm| 33 +++-
> scripts/networks/300-guest-network-isolated.t | 82 ++
>
On 11/2/18 11:52 AM, Daniel P. Berrangé wrote:
> The code does not in fact delete everything on the host, only things
> whose name starts with a "tck" prefix.
Yep! Multiple people have asked me about that, and I had to allay their
fears (I was actually worried about it for a long time, then one
On Fri, Nov 02, 2018 at 02:00:32PM +0100, Igor Mammedov wrote:
> On Fri, 2 Nov 2018 12:43:10 +0100
> David Hildenbrand wrote:
>
> > On 01.11.18 15:10, Igor Mammedov wrote:
> > > On Wed, 24 Oct 2018 12:19:25 +0200
> > > David Hildenbrand wrote:
> > >
> > >> For now, the hotplug handler is not
The main goal of this patch series is addition of tests which create
a virtual network with every possible forwarding mode, and attempt to
boot a guest with them. A couple of other pieces were added at the end.
Daniel P. Berrangé (3):
Add tests for virtual network <-> guest connections
Fix
The -t argument accepts the path to a test file or a test directory. It
would be useful if shell wildcards could be used to specify test files,
but this doesn't work when using optional arguments.
By changing the test path(s) to be positional arguments we can easily
allow for shell wildcards.
The code does not in fact delete everything on the host, only things
whose name starts with a "tck" prefix.
Signed-off-by: Daniel P. Berrangé
---
bin/libvirt-tck | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/bin/libvirt-tck
Signed-off-by: Daniel P. Berrangé
---
lib/Sys/Virt/TCK.pm | 33
lib/Sys/Virt/TCK/NetworkBuilder.pm| 33 +++-
scripts/networks/300-guest-network-isolated.t | 82 ++
scripts/networks/310-guest-network-nat.t | 83
On 11/2/18 10:01 AM, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> docs/news.xml | 49 +
> 1 file changed, 49 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index e5476a3332..b75df36ddb 100644
> ---
On 02/11/2018 15:58, John Ferlan wrote:
>
>
> On 11/2/18 8:49 AM, Povilas Kanapickas wrote:
>> On 21/10/2018 21:31, Povilas Kanapickas wrote:
>>> Hey,
>>>
>>> It seems that there's an issue of how external disk snapshots currently
>>> work. The snapshot definition xml[1] that is supplied to the
On 11/02/2018 03:44 PM, Erik Skultety wrote:
> On Fri, Nov 02, 2018 at 01:56:17PM +0100, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1524230
>>
>> The qemuBuildVhostuserCommandLine builds command line for
>> vhostuser type interfaces. It is duplicating some code of the
On Fri, Nov 02, 2018 at 01:56:17PM +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1524230
>
> The qemuBuildVhostuserCommandLine builds command line for
> vhostuser type interfaces. It is duplicating some code of the
> function it is called from
The actual type of an enum in C is implementation defined when there are
no negative values, and thus it can be int, or uint. This is the case
of the virError* enums in libvirt, as they do not have negative values.
Hence, to avoid hitting tautological comparison errors when checking
their rage,
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-fedora-27/docker.yml | 2 -
.../host_vars/libvirt-fedora-27/install.yml | 2 -
guests/host_vars/libvirt-fedora-27/main.yml | 22 -
guests/inventory | 1 -
guests/vars/mappings.yml
Signed-off-by: Andrea Bolognani
---
guests/playbooks/build/jobs/defaults.yml| 2 ++
guests/playbooks/build/projects/libvirt-dbus.yml| 3 +++
guests/playbooks/build/projects/libvirt-ocaml.yml | 1 +
guests/playbooks/build/projects/libvirt-sandbox.yml | 2 ++
Signed-off-by: Andrea Bolognani
---
guests/playbooks/build/jobs/defaults.yml| 2 --
guests/playbooks/build/projects/libvirt-dbus.yml| 3 ---
guests/playbooks/build/projects/libvirt-ocaml.yml | 1 -
guests/playbooks/build/projects/libvirt-sandbox.yml | 2 --
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-fedora-29/docker.yml | 2 +
.../host_vars/libvirt-fedora-29/install.yml | 2 +
guests/host_vars/libvirt-fedora-29/main.yml | 22 +
guests/inventory | 1 +
guests/vars/vault.yml
It's that time of the year again :)
Andrea Bolognani (4):
guests: Add Fedora 29
Build on Fedora 29
Stop building on Fedora 27
guests: Drop Fedora 27
guests/host_vars/libvirt-fedora-27/docker.yml | 2 -
guests/host_vars/libvirt-fedora-29/docker.yml | 2 +
.../install.yml
On 11/01/2018 04:50 PM, Erik Skultety wrote:
> There's a lot of stuff going on in src/conf/nodedev_conf which not
> always has to do anything with config, so even though we're trying,
> we're not really consistent in putting only parser/formatter related
> stuff here like we do for domains. So,
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 49 +
1 file changed, 49 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index e5476a3332..b75df36ddb 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,16 @@
+
On 11/2/18 8:49 AM, Povilas Kanapickas wrote:
> On 21/10/2018 21:31, Povilas Kanapickas wrote:
>> Hey,
>>
>> It seems that there's an issue of how external disk snapshots currently
>> work. The snapshot definition xml[1] that is supplied to the API has a
>> list of disks each of which specify
On 02.11.2018 16:31, John Ferlan wrote:
> [...]
>
Looks like reinstatiation was lost in
commit 57f5621f464b8df5671cbe5df6bab3cf006981dd
Author: Daniel P. Berrangé
Date: Thu Apr 26 18:34:33 2018 +0100
nwfilter: keep track of active filter bindings
On 02.11.18 14:00, Igor Mammedov wrote:
> On Fri, 2 Nov 2018 12:43:10 +0100
> David Hildenbrand wrote:
>
>> On 01.11.18 15:10, Igor Mammedov wrote:
>>> On Wed, 24 Oct 2018 12:19:25 +0200
>>> David Hildenbrand wrote:
>>>
For now, the hotplug handler is not called for devices that are
On 11/2/18 4:21 AM, Nikolay Shirokovskiy wrote:
> Hi, John!
>
> Looks like this series is stucked somehow even though there is almost 100%
> agreement.
>
>
Right, but there's been a few events in between that pushed this down
the stack of things I was involved with (beyond my own work) -
[...]
>>> Looks like reinstatiation was lost in
>>>
>>> commit 57f5621f464b8df5671cbe5df6bab3cf006981dd
>>> Author: Daniel P. Berrangé
>>> Date: Thu Apr 26 18:34:33 2018 +0100
>>>
>>> nwfilter: keep track of active filter bindings
>>>
>>>
>>> nwfilterInstantiateFilter is called from
https://bugzilla.redhat.com/show_bug.cgi?id=1524230
The qemuBuildVhostuserCommandLine builds command line for
vhostuser type interfaces. It is duplicating some code of the
function it is called from (qemuBuildInterfaceCommandLine)
because of the way it's called. If we merge it into the caller
not
On 21/10/2018 21:31, Povilas Kanapickas wrote:
> Hey,
>
> It seems that there's an issue of how external disk snapshots currently
> work. The snapshot definition xml[1] that is supplied to the API has a
> list of disks each of which specify where the new overlay disks should
> be placed.
>
>
On Fri, 2 Nov 2018 12:43:10 +0100
David Hildenbrand wrote:
> On 01.11.18 15:10, Igor Mammedov wrote:
> > On Wed, 24 Oct 2018 12:19:25 +0200
> > David Hildenbrand wrote:
> >
> >> For now, the hotplug handler is not called for devices that are
> >> being cold plugged. The hotplug handler is
Hi. Sorry for the late reply.
On 10/11/18 9:03 PM, John Ferlan wrote:
On 10/4/18 9:14 AM, Daniel Henrique Barboza wrote:
This patch makes two quality of life changes for non-x86 guests. The
first one is a maxCpus validation at qemuDomainDefValidate. The check
is made by the same function used
On 21/10/2018 19:38, Povilas Kanapickas wrote:
> Hey all,
>
> Currently libvirt only supports creation of external disk snapshots, but not
> reversion and deletion which are essential for any serious use of this
> feature.
> I've looked into implementing removal and reversion of external disk
On Fri, Nov 02, 2018 at 01:33:32PM +0100, Andrea Bolognani wrote:
> On Fri, 2018-11-02 at 07:46 -0400, John Ferlan wrote:
> > > > + * NB: Usage of event based socket algorithm causes some issues with
> > > > + * older platforms such as CentOS 6 in which the data socket is opened
> > >
> > >
On Fri, 2018-11-02 at 07:46 -0400, John Ferlan wrote:
> > > + * NB: Usage of event based socket algorithm causes some issues with
> > > + * older platforms such as CentOS 6 in which the data socket is opened
> >
> > ^Sounds a bit too generic, as an event based algorithm is not forced to
> > open
Am 02.11.2018 um 12:37 hat Nikolay Shirokovskiy geschrieben:
> On 02.11.2018 13:23, Kevin Wolf wrote:
> > Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben:
> >> Just set l2-cache-size to INT64_MAX for all format nodes of
> >> qcow2 type in block node graph.
> >>
> >> AFAIK this is sane
On Fri, Nov 02, 2018 at 07:46:35AM -0400, John Ferlan wrote:
>
>
> On 11/2/18 3:48 AM, Erik Skultety wrote:
> > On Thu, Nov 01, 2018 at 01:48:39PM -0400, John Ferlan wrote:
> >> Commit cdbe1332 neglected to document the API. So let's add some
> >> details about the algorithm and why it was used to
On Fri, 2018-11-02 at 12:21 +0100, Pino Toscano wrote:
> > Either way, I'll have to apply changes to the live CI
> > environment as you don't have any permissions there...
>
> Feel free to start the update magic, please ;)
Done.
https://ci.centos.org/view/libvirt/job/libvirt-ocaml-build/
On 02.11.2018 13:23, Kevin Wolf wrote:
> Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben:
>> Just set l2-cache-size to INT64_MAX for all format nodes of
>> qcow2 type in block node graph.
>>
>> AFAIK this is sane because *actual* cache size depends on size
>> of data being
On 01.11.18 15:10, Igor Mammedov wrote:
> On Wed, 24 Oct 2018 12:19:25 +0200
> David Hildenbrand wrote:
>
>> For now, the hotplug handler is not called for devices that are
>> being cold plugged. The hotplug handler is setup when the machine
>> initialization is fully done. Only bridges that
On 11/2/18 3:48 AM, Erik Skultety wrote:
> On Thu, Nov 01, 2018 at 01:48:39PM -0400, John Ferlan wrote:
>> Commit cdbe1332 neglected to document the API. So let's add some
>> details about the algorithm and why it was used to help future
>> readers understand the issues encountered. Based
On 02.11.2018 13:11, Kevin Wolf wrote:
> Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben:
>> Hi, all.
>>
>> This is a patch series after offlist agreement on introducing
>> metadata-cache-size option for disks. The options itself is described in 2nd
>> patch of the series.
>>
>>
On Friday, 2 November 2018 12:08:22 CET Andrea Bolognani wrote:
> On Mon, 2018-10-22 at 19:02 +0200, Pino Toscano wrote:
> > Now that the libvirt-ocaml repository is fixed, let's build it in CI.
> >
> > Changes from v1 to v2:
> > - split according to Andrea's hints
> > - removed --with-libvirt as
On Mon, 2018-10-22 at 19:02 +0200, Pino Toscano wrote:
> Now that the libvirt-ocaml repository is fixed, let's build it in CI.
>
> Changes from v1 to v2:
> - split according to Andrea's hints
> - removed --with-libvirt as argument for configure, no more needed
> after upstream changes
>
> Pino
Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben:
> Just set l2-cache-size to INT64_MAX for all format nodes of
> qcow2 type in block node graph.
>
> AFAIK this is sane because *actual* cache size depends on size
> of data being referenced in image and thus the total size of
> all
Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben:
> Hi, all.
>
> This is a patch series after offlist agreement on introducing
> metadata-cache-size option for disks. The options itself is described in 2nd
> patch of the series.
>
> There is a plenty of attempts to add option to set
Hi, John!
Looks like this series is stucked somehow even though there is almost 100%
agreement.
On 17.10.2018 11:41, Nikolay Shirokovskiy wrote:
>
>
> On 16.10.2018 21:40, John Ferlan wrote:
>>
>> $SUBJ:
>>
>> s/pass/Pass
>>
>> On 10/10/18 4:04 AM, Nikolay Shirokovskiy wrote:
>>> We send
On 02.11.2018 00:50, John Ferlan wrote:
>
>
> On 11/1/18 3:26 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 01.11.2018 03:48, John Ferlan wrote:
>>>
>>>
>>> On 10/31/18 10:41 AM, Nikolay Shirokovskiy wrote:
On 31.10.2018 16:14, John Ferlan wrote:
>
>
> On 10/30/18 3:24 AM,
Hello,
I found snapshot APIs(like virDomainSnapshotNum) invoked with
VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will return 0 even there are internal
no-metadata snapshots in the domain.
Then I find the reason is in virDomainSnapshotObjListGetNames():
937 /* If this common code is being used, we
On Thu, Nov 01, 2018 at 01:48:39PM -0400, John Ferlan wrote:
> Commit cdbe1332 neglected to document the API. So let's add some
> details about the algorithm and why it was used to help future
> readers understand the issues encountered. Based largely off a
> description provided by Erik Skultety
On 01.11.2018 17:24, John Ferlan wrote:
>
>
> On 10/22/18 3:36 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 18.10.2018 18:28, John Ferlan wrote:
>>> When qemuProcessReconnectHelper was introduced (commit d38897a5d)
>>> reconnection failure used VIR_DOMAIN_SHUTOFF_FAILED; however, that
>>> was
86 matches
Mail list logo
