Re: [libvirt] [PATCH] qemu: Don't use -mem-prealloc among with .prealloc=yes

2018-11-06 Thread John Ferlan
On 11/5/18 9:49 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1624223 > > There are two ways to request memory preallocation on cmd line: > -mem-prealloc and .prealloc attribute to memory-backend-file. s/to/for a/ ? > However, as it turns out it's not safe to use

[libvirt] [PATCH] libxl: Properly dispose libxl_domain_config object

2018-11-06 Thread Jim Fehlig
V2 of the libxl soft reset patch, which was pushed as commit da4b0fd9, dropped the hunk that disposed of the libxl_domain_config object. Add the missing hunk to properly dispose the object. Signed-off-by: Jim Fehlig --- Pushing as trivial... src/libxl/libxl_domain.c | 1 + 1 file changed, 1

Re: [libvirt] [PATCH] virNetworkDefUpdateDNSHost: Only require IP to match

2018-11-06 Thread W. Trevor King
I've filed [1] to track this in Bugzilla. Cheers, Trevor [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1647211 -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -- libvir-list mailing list

Re: [libvirt] [PATCH v2] lxc: Include support to lxc version 3.0 or higher.

2018-11-06 Thread John Ferlan
On 11/5/18 1:57 PM, Julio Faracco wrote: > This patch introduce the new settings for LXC 3.0 or higher. The older > versions keep the compatibility to deprecated settings for LXC, but > after release 3.0, the compatibility was removed. This commit adds the > support to the refactored settings.

[libvirt] [PATCH] virNetworkDefUpdateDNSHost: Only require IP to match

2018-11-06 Thread W. Trevor King
On Tue, Nov 06, 2018 at 09:10:39AM -0800, W. Trevor King wrote: > This commit update the matching logic to only consider the IP > address. Oops, I should have updated the subject to: virNetworkDefUpdateDNSHost: Only require IP to match Cheers, Trevor -- This email may be signed or encrypted

Re: [libvirt] [PATCH v4 2/2] storage: Improve error handling on cdrom backend

2018-11-06 Thread John Ferlan
On 10/25/18 11:39 PM, Han Han wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1596096 > > Implement virFileCheckCDROM in virStorageBackendVolOpen to check if > cdrom backend is ok. Report more detailed error if not ok. > > Signed-off-by: Han Han > --- > src/storage/storage_util.c | 32

Re: [libvirt] [PATCH v4 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

2018-11-06 Thread John Ferlan
On 10/25/18 11:39 PM, Han Han wrote: > Refactor virFileIsCDROM to virFileCheckCDROM for checking cdrom status. > Add add enum type virFileCDRomStatus. > > Now virFileCheckCDROM could be used to check the cdrom drive status such > as ok, no disc, tray open, drive not ready, or unknown. > >

Re: [libvirt] [PATCH go] version: Add ParseVersion and a Version struct

2018-11-06 Thread W. Trevor King
Anything I can do to help this along? I've adjusted the subject to have "PATCH go" instead of just "PATCH"; sorry about that. Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[libvirt] [PATCH] virNetworkDefUpdateDNSHost: Require both IP and a hostname to match

2018-11-06 Thread W. Trevor King
Since fc19a0059 (network: backend functions for updating network dns host/srv/txt, 2012-11-12), the matching logic for various network components has been: 1) for HOST records, it's considered a match if the IP address or any of the hostnames of an existing record matches. 2) for SRV records,

Re: [libvirt] [PATCHv7 10/18] conf: Remove virDomainResctrlAppend and introduce virDomainResctrlNew

2018-11-06 Thread John Ferlan
On 11/6/18 4:51 AM, Huaqiang,Wang wrote: > > > On 2018年11月06日 01:26, John Ferlan wrote: >> >> On 10/22/18 4:01 AM, Wang Huaqiang wrote: >>> Introduced virDomainResctrlNew to do the most part of >>> virDomainResctrlAppend >>> and move the operation of appending resctrl to @def->resctrls out of

Re: [libvirt] [PATCHv7 05/18] util: Refactor code for adding PID to the resource group

2018-11-06 Thread John Ferlan
On 11/6/18 3:41 AM, Huaqiang,Wang wrote: > > > On 2018年11月05日 23:03, John Ferlan wrote: >> >> On 10/22/18 4:01 AM, Wang Huaqiang wrote: >>> The code of adding PID to the allocation could be reused, refactor it >>> for later reuse. >>> >>> Signed-off-by: Wang Huaqiang >>> --- >>>  

Re: [libvirt] [PATCHv7 01/18] docs, util: Refactor schemas and virresctrl to support optional cache

2018-11-06 Thread John Ferlan
On 11/6/18 3:30 AM, Huaqiang,Wang wrote: > > > On 2018年11月06日 16:18, Huaqiang,Wang wrote: >> >> >> On 2018年11月05日 23:01, John Ferlan wrote: >>> >>> On 10/22/18 4:01 AM, Wang Huaqiang wrote: Refactor schemas and virresctrl to support optional element in . Later, the monitor

Re: [libvirt] [PATCH v2 1/3] qemu: Move allow reboot check setting

2018-11-06 Thread John Ferlan
On 11/6/18 7:48 AM, Michal Privoznik wrote: > On 11/06/2018 01:28 PM, John Ferlan wrote: >> >> >> On 11/6/18 4:38 AM, Michal Privoznik wrote: >>> On 11/01/2018 05:04 PM, John Ferlan wrote: Checking and setting the priv->allowReboot can be done before we start processing the job. A

Re: [libvirt] [PATCH v2 1/3] qemu: Move allow reboot check setting

2018-11-06 Thread Michal Privoznik
On 11/06/2018 01:28 PM, John Ferlan wrote: > > > On 11/6/18 4:38 AM, Michal Privoznik wrote: >> On 11/01/2018 05:04 PM, John Ferlan wrote: >>> Checking and setting the priv->allowReboot can be done before we start >>> processing the job. A subsequent patch will make use of the value to >>> make

Re: [libvirt] [PATCH v2 1/3] qemu: Move allow reboot check setting

2018-11-06 Thread John Ferlan
On 11/6/18 4:38 AM, Michal Privoznik wrote: > On 11/01/2018 05:04 PM, John Ferlan wrote: >> Checking and setting the priv->allowReboot can be done before we start >> processing the job. A subsequent patch will make use of the value to >> make decisions in the error label, so we need to have it

Re: [libvirt] [PATCH V2 0/3] libxl: add support for soft reset

2018-11-06 Thread Michal Privoznik
On 10/31/2018 08:51 PM, Jim Fehlig wrote: > Patches 1 and 2 are new to V2 and make slight improvements to > libxlDomainShutdownThread. Patch 3 is adjusted to work with Xen 4.6. > > Jim Fehlig (3): > libxl: remove redundant calls to virObjectEventStateQueue > libxl: Remove some goto labels in

Re: [libvirt] [PATCH V2 3/3] libxl: add support for soft reset

2018-11-06 Thread Michal Privoznik
On 10/31/2018 08:51 PM, Jim Fehlig wrote: > The pvops Linux kernel implements machine_ops.crash_shutdown as > > static void xen_hvm_crash_shutdown(struct pt_regs *regs) > { > native_machine_crash_shutdown(regs); > xen_reboot(SHUTDOWN_soft_reset); > } > > but currently the libxl

Re: [libvirt] [PATCHv7 11/18] conf: move virResctrlAllocIsEmpty to a place a litter lower

2018-11-06 Thread Huaqiang,Wang
On 2018年11月06日 01:26, John Ferlan wrote: $SUBJ: s/litter/little Perhaps better said: conf: Alter order of Cachetune virDomainResctrlNew call On 10/22/18 4:01 AM, Wang Huaqiang wrote: This refactor allows to add some code between virDomainResctrlNew and virResctrlAllocIsEmpty to extend the

Re: [libvirt] RFC: VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA is not functional?

2018-11-06 Thread Han Han
On Mon, Nov 5, 2018 at 9:38 PM Peter Krempa wrote: > On Fri, Nov 02, 2018 at 15:52:54 +0800, Han Han wrote: > > Hello, > > I found snapshot APIs(like virDomainSnapshotNum) invoked with > > VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will return 0 even there are > internal > > no-metadata snapshots in

Re: [libvirt] [PATCHv7 10/18] conf: Remove virDomainResctrlAppend and introduce virDomainResctrlNew

2018-11-06 Thread Huaqiang,Wang
On 2018年11月06日 01:26, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Introduced virDomainResctrlNew to do the most part of virDomainResctrlAppend and move the operation of appending resctrl to @def->resctrls out of function. Rather than rely on virDomainResctrlAppend to

Re: [libvirt] [PATCHv7 12/18] conf: Introduce cache monitor element in cachetune

2018-11-06 Thread Huaqiang,Wang
On 2018年11月06日 01:26, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Introducing element under to represent a cache monitor. Signed-off-by: Wang Huaqiang --- docs/formatdomain.html.in | 26 +++ docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH v2 1/3] qemu: Move allow reboot check setting

2018-11-06 Thread Michal Privoznik
On 11/01/2018 05:04 PM, John Ferlan wrote: > Checking and setting the priv->allowReboot can be done before we start > processing the job. A subsequent patch will make use of the value to > make decisions in the error label, so we need to have it set properly. > > Signed-off-by: John Ferlan > ---

Re: [libvirt] [PATCH v2 3/3] qemu: Narrow the shutdown reconnection failure reason window

2018-11-06 Thread Michal Privoznik
On 11/01/2018 05:04 PM, John Ferlan wrote: > The current qemuProcessReconnect logic paints a broad brush > determining that the shutdown reason must be crashed if it was > determined that the domain was started with -no-shutdown; however, > there's many other ways to get to the error label, so

Re: [libvirt] [PATCH v2 2/3] qemu: Restore lost shutdown reason

2018-11-06 Thread Michal Privoznik
On 11/01/2018 05:04 PM, John Ferlan wrote: > When qemuProcessReconnectHelper was introduced (commit d38897a5d) > reconnection failure used VIR_DOMAIN_SHUTOFF_FAILED; however, that > was changed in commit bda2f17d to either VIR_DOMAIN_SHUTOFF_CRASHED > or VIR_DOMAIN_SHUTOFF_UNKNOWN. > > When

Re: [libvirt] [PATCH v2] snapshot: Don't hose list on deletion failure

2018-11-06 Thread Michal Privoznik
On 10/18/2018 03:45 AM, Eric Blake wrote: > If qemuDomainSnapshotDiscard() fails for any reason (rare, > but possible with an ill-timed ENOMEM or if > qemuDomainSnapshotForEachQcow2() has problems talking to the > qemu guest monitor), then an attempt to retry the snapshot > deletion API will crash

Re: [libvirt] [PATCHv7 04/18] util: Add interface to determine monitor path

2018-11-06 Thread Huaqiang,Wang
On 2018年11月06日 01:19, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Add interface for resctrl monitor to determine the path. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 1 + src/util/virresctrl.c| 55

Re: [libvirt] [PATCHv7 09/18] util: Add more interfaces for resctrl monitor

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:10, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Add interfaces monitor group to support operations such as add PID, set ID, remove group ... etc. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 5 + src/util/virresctrl.c| 47

Re: [libvirt] [PATCHv7 03/18] util: Refactor code for determining allocation path

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:02, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: The code for determining resctrl allocation path could be reused for monitor. Refactor it for reuse. Signed-off-by: Wang Huaqiang --- src/util/virresctrl.c | 38 ++ 1

Re: [libvirt] [PATCH v7 13/14] docs: Add 'uid' and 'fid' information

2018-11-06 Thread Yi Min Zhao
在 2018/11/5 下午9:22, Andrea Bolognani 写道: On Fri, 2018-10-19 at 11:40 +0800, Yi Min Zhao wrote: [...] @@ -3925,7 +3925,15 @@ (since 0.9.7, requires QEMU 0.13). multifunction defaults to 'off', but should be set to 'on' for function 0 of a slot that will -

Re: [libvirt] [PATCHv7 04/18] util: Add interface to determine monitor path

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:02, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Add interface for resctrl monitor to determine the path. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 1 + src/util/virresctrl.c| 55

Re: [libvirt] [PATCHv7 02/18] util: Introduce resctrl monitor for CMT

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:02, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Cache Monitoring Technology (aka CMT) provides the capability to report cache utilization information of system task. This patch introduces the concept of resctrl monitor through data structure

Re: [libvirt] [PATCHv7 05/18] util: Refactor code for adding PID to the resource group

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:03, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: The code of adding PID to the allocation could be reused, refactor it for later reuse. Signed-off-by: Wang Huaqiang --- src/util/virresctrl.c | 30 +++--- 1 file changed, 19

Re: [libvirt] [PATCHv7 07/18] util: Refactor code for creating resctrl group

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:03, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: The code for creating resctrl allocation group could be reused for monitoring group, refactor it for reuse in the later patch. Signed-off-by: Wang Huaqiang --- src/util/virresctrl.c | 37

Re: [libvirt] [PATCHv7 06/18] util: Add interface for adding PID to the monitor

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:03, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Add interface for adding task PID to the monitor. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 1 + src/util/virresctrl.c| 8 src/util/virresctrl.h| 4 3 files

Re: [libvirt] [PATCHv7 08/18] util: Add interface for creating monitor group

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:04, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Add interface for creating the resource monitoring group according to '@virResctrlMonitor->path'. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 1 + src/util/virresctrl.c| 24

Re: [libvirt] [PATCHv7 01/18] docs, util: Refactor schemas and virresctrl to support optional cache

2018-11-06 Thread Huaqiang,Wang
On 2018年11月06日 16:18, Huaqiang,Wang wrote: On 2018年11月05日 23:01, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Refactor schemas and virresctrl to support optional element in . Later, the monitor entry will be introduced and to be placed under . Either cache entry or

Re: [libvirt] [PATCH RESEND] qemu: Process RDMA GID state change event

2018-11-06 Thread Michal Privoznik
On 11/05/2018 08:27 PM, Yuval Shaia wrote: > On Mon, Nov 05, 2018 at 05:42:10PM +0100, Michal Privoznik wrote: >> [There is no need to resend your patch just to put yourself onto CC >> list. The review policy is always "reply to all"] > > Hi Michal, > > Actually i posted the "RESEND" as my

Re: [libvirt] [PATCHv7 01/18] docs, util: Refactor schemas and virresctrl to support optional cache

2018-11-06 Thread Huaqiang,Wang
On 2018年11月05日 23:01, John Ferlan wrote: On 10/22/18 4:01 AM, Wang Huaqiang wrote: Refactor schemas and virresctrl to support optional element in . Later, the monitor entry will be introduced and to be placed under . Either cache entry or monitor entry is an optional element of . An