[libvirt] [PATCH 1/2] util: Fix VIR_ERR_ACCESS_DENIED formatting

2018-11-09 Thread John Ferlan
In commit ccc72d5cb I thought I had the brilliant idea that I could alter an error message in virErrorMsg to take two arguments "drivername" and NULL. Then passing the failed drivername for VIR_ERR_ACCESS_DENIED users would magically allow any "real" error message to be included. Of course it

[libvirt] [PATCH 0/2] Fix some errors around VIR_ACCESS_DENIED

2018-11-09 Thread John Ferlan
Patch 1 fixes my own error made in this release fortunately, but only seen because I was invesigating Patch 2 Patch 2 is perhaps a longer term issue, but perhaps coming more to light now that the nwfilter bindings have been separated and use a virConnectOpen for nwfilter:///system during

[libvirt] [PATCH 2/2] qemu: Set identity for the reconnect all thread

2018-11-09 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1631622 If polkit authentication is enabled, an attempt to open the connection failed during virAccessDriverPolkitGetCaller when the call to virIdentityGetCurrent returned NULL resulting in the errors: virAccessDriverPolkitGetCaller:87 : access

Re: [libvirt] [PATCH 1/5] snapshot: Implement reverting for external disk snapshots

2018-11-09 Thread Povilas Kanapickas
Hi Peter, Many thanks for the reviews. I replied inline below. On 07/11/2018 17:40, Peter Krempa wrote: > On Sun, Oct 21, 2018 at 19:38:48 +0300, Povilas Kanapickas wrote: > [...] >> + int* out_mapping) >> +{ >> +size_t i, j; >> +int found_idx;

[libvirt] [PATCH v3] lxc: Include support to lxc version 3.0 or higher.

2018-11-09 Thread Julio Faracco
This patch introduce the new settings for LXC 3.0 or higher. The older versions keep the compatibility to deprecated settings for LXC, but after release 3.0, the compatibility was removed. This commit adds the support to the refactored settings. v1-v2: Michal's suggestions to handle differences

Re: [libvirt] [PATCH v4 00/37] BaselineHypervisorCPU using QEMU QMP exchanges

2018-11-09 Thread Collin Walling
Hi Chris, On 11/9/18 11:27 AM, Chris Venteicher wrote: > Quoting Chris Venteicher (2018-11-02 22:13:01) >> Some architectures (S390) depend on QEMU to compute baseline CPU model and >> expand a models feature set. >> >> Interacting with QEMU requires starting the QEMU process and completing one

Re: [libvirt] [PATCH v4 00/37] BaselineHypervisorCPU using QEMU QMP exchanges

2018-11-09 Thread Chris Venteicher
Quoting Chris Venteicher (2018-11-02 22:13:01) > Some architectures (S390) depend on QEMU to compute baseline CPU model and > expand a models feature set. > > Interacting with QEMU requires starting the QEMU process and completing one or > more query-cpu-model-baseline QMP exchanges with QEMU in

Re: [libvirt] [PATCH 0/2] qemu: Drop priv->gotShutdown

2018-11-09 Thread John Ferlan
On 11/7/18 9:37 AM, Jiri Denemark wrote: > Jiri Denemark (2): > qemu: Drop unreachable code from qemuProcessHandleStop > qemu: Drop priv->gotShutdown > > src/qemu/qemu_domain.h | 1 - > src/qemu/qemu_driver.c | 3 ++- > src/qemu/qemu_process.c | 13 + > 3 files changed, 3

Re: [libvirt] [PATCH v3 04/13] security_manager: Rework metadata locking

2018-11-09 Thread John Ferlan
On 11/9/18 7:42 AM, Michal Privoznik wrote: > On 11/09/2018 03:59 AM, John Ferlan wrote: >> >> >> On 10/17/18 5:06 AM, Michal Privoznik wrote: >>> Trying to use virlockd to lock metadata turns out to be too big >>> gun. Since we will always spawn a separate process for relabeling >>> we are

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-09 Thread John Ferlan
On 11/9/18 7:42 AM, Michal Privoznik wrote: > On 11/08/2018 11:45 PM, John Ferlan wrote: >> >> >> On 10/17/18 5:06 AM, Michal Privoznik wrote: >>> In the next commit the virSecurityManagerMetadataLock() is going >>> to be turned thread unsafe. Therefore, we have to spawn a >>> separate process

Re: [libvirt] [PATCH v3 03/13] security: Always spawn process for transactions

2018-11-09 Thread Michal Privoznik
On 11/08/2018 11:45 PM, John Ferlan wrote: > > > On 10/17/18 5:06 AM, Michal Privoznik wrote: >> In the next commit the virSecurityManagerMetadataLock() is going >> to be turned thread unsafe. Therefore, we have to spawn a >> separate process for it. Always. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v3 04/13] security_manager: Rework metadata locking

2018-11-09 Thread Michal Privoznik
On 11/09/2018 03:59 AM, John Ferlan wrote: > > > On 10/17/18 5:06 AM, Michal Privoznik wrote: >> Trying to use virlockd to lock metadata turns out to be too big >> gun. Since we will always spawn a separate process for relabeling >> we are safe to use thread unsafe POSIX locks and take out >>

Re: [libvirt] [PATCH] qemu:address:Fix segfault in qemuDomainPrimeVirtioDeviceAddresses

2018-11-09 Thread Andrea Bolognani
On Fri, 2018-11-09 at 14:41 +0800, Wang Yechao wrote: > On aarch64, lauch vm with the follow configuration: > > > > > function="0x2"/> > > > > libvirtd will crash when access the net->model. > > Signed-off-by: Wang Yechao > --- > src/qemu/qemu_domain_address.c | 3 ++- > 1

[libvirt] [PATCH v2] qemu: disable external snapshot of readonly disk

2018-11-09 Thread Nikolay Shirokovskiy
Disable external snapshot of readonly disk for inactive domains as this operation is not very useful. As to active domains such snapshot was not possible before already but error message was not helpful so now it will be better. Signed-off-by: Nikolay Shirokovskiy --- Diff from v1 [1]