On 11/12/18 4:26 AM, Daniel P. Berrangé wrote:
On Fri, Nov 02, 2018 at 04:34:02PM -0600, Jim Fehlig wrote:
A dry run can be used as a best-effort check that a migration command
will succeed. The destination host will be checked to see if it can
accommodate the resources required by the domain. D
On 11/11/18 12:46 PM, Julio Faracco wrote:
> Em sáb, 10 de nov de 2018 às 11:17, John Ferlan escreveu:
>>
>>
>>
>> On 11/9/18 12:30 PM, Julio Faracco wrote:
>>> This patch introduce the new settings for LXC 3.0 or higher. The older
>>> versions keep the compatibility to deprecated settings for L
On 11/12/18 1:14 PM, Erik Skultety wrote:
Even though commit 11708641 claims that a domain is allowed have a
single VFIO AP hostdev only, this is a limitation posed by the platform
vendor on purely virtual devices. Generally, post parse should only be
I am little confused by the term "purely vir
ble in the git repository at:
>
> git://git.kraxel.org/qemu tags/fixes-31-20181112-pull-request
>
> for you to fetch changes up to f1aba960cc40ab65fa88c8678883bd2201708c55:
>
> ui/gtk: fix cursor in egl mode (2018-11-12 14:15:54 +0100)
>
> -
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> A qemuProcess struct tracks the entire lifespan of a single QEMU Process
> including storing error output when the process terminates or activation
> fails.
>
> Error output remains available until qemuProcessFree is called.
>
> The qmperr buffer
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> In new process code, move from model where qemuProcess struct can be
> used to activate a series of Qemu processes to model where one
> qemuProcess struct is used for one and only one Qemu process.
>
> The forceTCG parameter (use / don't use KVM) w
On Wed, Nov 07, 2018 at 07:13:11PM +0400, Marc-André Lureau wrote:
> As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> review, let's define a common set of backend conventions to help with
> management layer implementation, and interoperability.
>
> v2:
> - use a vhost-user.json
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> s/cmd/proc/ in process code imported from qemu_capabilities.
>
> No functionality is changed. Just variable renaming.
>
> Process code imported from qemu_capabilities was oriented around
> starting a process to issue a single QMP command.
>
> Fu
On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> s/virQEMUCapsInitQMPCommand/qemuProcess/
>
> No functionality change.
>
> Use appropriate prefix in moved code.
>
> Signed-off-by: Chris Venteicher
> ---
> src/qemu/qemu_capabilities.c | 14 +++---
> src/qemu/qemu_process.c | 28 ++
On Mon, Nov 12, 2018 at 03:25:02PM +0100, Michal Privoznik wrote:
> On 11/12/2018 12:56 PM, Erik Skultety wrote:
> > There's a lot of stuff going on in src/conf/nodedev_conf which is
> > sometimes not directly related to config and we're not really consistent
> > with putting only parser/formatter
On 11/12/18 1:14 PM, Erik Skultety wrote:
Since we'll need to validate other models apart from VFIO PCI too,
having a helper for each model should keep the code base cleaner.
Signed-off-by: Erik Skultety
---
src/qemu/qemu_domain.c | 35 +--
1 file changed, 29
In egl mode the scale_x and scale_y variables are not set, so the
scaling logic in the mouse motion event handler does not work.
Fix that. Also scale the cursor position in gd_egl_cursor_position().
Reported-by: Chen Zhang
Signed-off-by: Gerd Hoffmann
Tested-by: Chen Zhang
Message-id: 2018110
The following changes since commit 460f0236c12a86a38692c12d9bf8e2391dc10a77:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
staging (2018-11-12 10:12:07 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/fixes-31-20181112-pu
From: Thomas Huth
It has been unmaintained since years, and there were only trivial or
tree-wide changes to the related files since many years, so the
code is likely very bitrotten and broken. For example the following
segfaults as soon as as you press a key:
qemu-system-x86_64 -usb -device usb
The rate of pulseaudio absorbing the audio stream is used to control the
the rate of the guests audio stream. When the emulated hardware uses
small chunks (like intel-hda does) we need small chunks on the audio
backend side too, otherwise that feedback loop doesn't work very well.
Cc: Max Ehrlich
From: Marc-André Lureau
Simplify the code that doesn't need strncpy() since length of string
is already computed.
/home/elmarco/src/qemu/hw/display/edid-generate.c: In function 'edid_desc_text':
/home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy'
specified bound depends on
On Mon, Nov 12, 2018 at 03:03:34PM +0100, Marc Hartmayer wrote:
> On Mon, Nov 12, 2018 at 01:14 PM +0100, Erik Skultety
> wrote:
> > Since we'll need to validate other models apart from VFIO PCI too,
> > having a helper for each model should keep the code base cleaner.
> >
> > Signed-off-by: Erik
ping?
Tks,
John
On 11/5/18 7:58 AM, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2018-October/msg01065.html
>
> NB: Minor mods for this are change using 4.10.0 instead of 4.9.0, merge of
> qemu_capabilities conflict, and updated news.xml
>
> .. v2 Cover Letter
On Mon, Nov 12, 2018 at 03:13 PM +0100, "Daniel P. Berrangé"
wrote:
> On Mon, Nov 12, 2018 at 02:48:09PM +0100, Marc Hartmayer wrote:
>> On Mon, Nov 12, 2018 at 01:30 PM +0100, Pavel Hrdina
>> wrote:
>> > On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Hartmayer wrote:
>> >> On Thu, Nov 01, 2018
On 11/12/18 6:13 AM, Daniel P. Berrangé wrote:
> On Fri, Nov 09, 2018 at 03:30:59PM -0200, Julio Faracco wrote:
>> This patch introduce the new settings for LXC 3.0 or higher. The older
>> versions keep the compatibility to deprecated settings for LXC, but
>> after release 3.0, the compatibility wa
On 11/12/2018 12:56 PM, Erik Skultety wrote:
> There's a lot of stuff going on in src/conf/nodedev_conf which is
> sometimes not directly related to config and we're not really consistent
> with putting only parser/formatter related stuff here, e.g. like we do
> for domains. So, let's start simply
On 11/09/2018 03:02 PM, John Ferlan wrote:
>
>
> On 11/9/18 7:42 AM, Michal Privoznik wrote:
>> On 11/08/2018 11:45 PM, John Ferlan wrote:
>>>
>>>
>>> On 10/17/18 5:06 AM, Michal Privoznik wrote:
In the next commit the virSecurityManagerMetadataLock() is going
to be turned thread unsafe
On 11/09/2018 03:47 PM, John Ferlan wrote:
> So, then I assume the disks are shared because they've been allowed in
> two domains that are allowed to be running at the same time. If they're
> shared and domainA has/uses a different label than domainB, then who
> "wins" that war in the long run? Se
On Mon, Nov 12, 2018 at 01:14 PM +0100, Erik Skultety
wrote:
> Since we'll need to validate other models apart from VFIO PCI too,
> having a helper for each model should keep the code base cleaner.
>
> Signed-off-by: Erik Skultety
> ---
> src/qemu/qemu_domain.c | 35
On Mon, Nov 12, 2018 at 02:48:09PM +0100, Marc Hartmayer wrote:
> On Mon, Nov 12, 2018 at 01:30 PM +0100, Pavel Hrdina
> wrote:
> > On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Hartmayer wrote:
> >> On Thu, Nov 01, 2018 at 09:31 AM +0100, Martin Kletzander
> >> wrote:
> >
> > [...]
> >
> >> H
https://bugzilla.redhat.com/show_bug.cgi?id=1631622
If polkit authentication is enabled, an attempt to open
the connection failed during virAccessDriverPolkitGetCaller
when the call to virIdentityGetCurrent returned NULL resulting
in the errors:
virAccessDriverPolkitGetCaller:87 : access denied
https://bugzilla.redhat.com/show_bug.cgi?id=1631606
Changes made to manage and utilize a secondary connection
driver to APIs outside the scope of the primary connection
driver have resulted in some confusion processing polkit rules
since the simple "access denied" error message doesn't provide
eno
This reverts commit ccc72d5cbdd85f66cb737134b3be40aac1df03ef.
Based on upstream comment to a follow-up patch, this didn't take the
right approach and the right thing to do is revert and rework.
Signed-off-by: John Ferlan
---
src/access/viraccessmanager.c | 25 -
src/rpc/
v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00339.html
Changes since v1:
* Do the right thing, revert the bad patch and rework it. Thus patch1 is
the revert and patch2 is the rework. If it's decided that patch2 is
unnecessary or undesired, that's perfectly fine, but w
On Mon, Nov 12, 2018 at 01:30 PM +0100, Pavel Hrdina wrote:
> On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Hartmayer wrote:
>> On Thu, Nov 01, 2018 at 09:31 AM +0100, Martin Kletzander
>> wrote:
>
> [...]
>
>> How can you run a machine/QEMU VM under a different user:group other
>> than changin
Refactoring qemuDomainGetStatsCpu, make it possible to add
more CPU statistics.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 09e04b8..89d46e
Add functions for creating, destroying, reconnecting resctrl
monitor in qemu according to the configuration in domain XML.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 49 -
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git
Introduced virDomainResctrlNew to do the most part of virDomainResctrlAppend
and move the operation of appending resctrl to @def->resctrls out of
function.
Rather than rely on virDomainResctrlAppend to perform the allocation, move
the onus to the caller and make use of virBitmapNewCopy for @vcpus
Adding the interface in qemu to report CMT statistic information
through command 'virsh domstats --cpu-total'.
Below is a typical output:
# virsh domstats 1 --cpu-total
Domain: 'ubuntu16.04-base'
...
cpu.cache.monitor.count=2
cpu.cache.monitor.0.
Add interface for resctrl monitor to determine the path.
Signed-off-by: Wang Huaqiang
Reviewed-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 55
src/util/virresctrl.h| 5 -
3 files changed, 60 insertion
The code for creating resctrl allocation group could be reused
for monitoring group, refactor it for reuse in the later patch.
Signed-off-by: Wang Huaqiang
Reviewed-by: John Ferlan
---
src/util/virresctrl.c | 37 +++--
1 file changed, 23 insertions(+), 14 deleti
Refactor schemas and virresctrl to support optional element
in .
Later, the monitor entry will be introduced and to be placed
under . Either cache entry or monitor entry is
an optional element of .
An cachetune has no element is taking the default resource
allocating policy defined in '/sys/fs/
Add virResctrlMonitorSetID by leveraging previous refactored patch.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 4e4831c..ed682c9 100644
--- a/src/util/virresctrl.c
+++ b/sr
The code of adding PID to the allocation could be reused, refactor it
for later reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index a
Add interface for creating the resource monitoring group according
to '@virResctrlMonitor->path'.
Signed-off-by: Wang Huaqiang
Reviewed-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 24
src/util/virresctrl.h| 4
3 files chang
Introducing element under to represent
a cache monitor.
Signed-off-by: Wang Huaqiang
Reviewed-by: John Ferlan
---
docs/formatdomain.html.in | 26 +++
docs/schemas/domaincommon.rng | 10 +
src/conf/domain_conf.c | 234
Signed-off-by: Wang Huaqiang
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 88774c5..3c84126 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -50,6 +50,17 @@
pvops-based HVM domains.
+
+
The code for determining resctrl allocation path could be reused
for monitor. Refactor it for reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 38 ++
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util
Add interface for adding task PID to the monitor.
Signed-off-by: Wang Huaqiang
Reviewed-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 8
src/util/virresctrl.h| 4
3 files changed, 13 insertions(+)
diff --git a/src/libvirt_private.syms b/src/l
Refactor virResctrlAllocSetID.
In new code the error of id overwriting is reported promptly.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 3
This series of patches and the series already been merged introduce
the x86 Cache Monitoring Technology (CMT) to libvirt by interacting
with kernel resource control (resctrl) interface. CMT is one of the
Intel(R) x86 CPU feature which belongs to the Resource Director
Technology (RDT). CMT reports t
Add interfaces monitor group to support operations such
as add PID, get ID, remove group ... etc.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 5 ++
src/util/virresctrl.c| 167 +++
src/util/virresctrl.h| 26
3 files c
Cache Monitoring Technology (aka CMT) provides the capability
to report cache utilization information of system task.
This patch introduces the concept of resctrl monitor through
data structure virResctrlMonitor.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresc
On Mon, Nov 12, 2018 at 02:14:02PM +0100, Gerd Hoffmann wrote:
> On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote:
> > It has been unmaintained since years, and there were only trivial or
> > tree-wide changes to the related files since many years, so the
> > code is likely very bitrotte
On Mon, Nov 12, 2018 at 11:00:30AM +0100, Thomas Huth wrote:
> It has been unmaintained since years, and there were only trivial or
> tree-wide changes to the related files since many years, so the
> code is likely very bitrotten and broken. For example the following
> segfaults as soon as as you p
Every time we call all domain stats for inactive domain with
unavailable source we get error message in logs. It's a bit noisy.
While it's arguable whether we need such message or not for mandatory
disks we would like not to see messages for optional disks. Let's
filter at least for cases of local
Because missing optional source is not error. The patch
address only local files. Fixing other cases is a bit ugly.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_process.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_proces
Nikolay Shirokovskiy (2):
qemu: don't log error for missing optional sources on stats
qemu: don't log error for missing optional sources on start
src/qemu/qemu_driver.c | 5 +
src/qemu/qemu_process.c | 12 +++-
src/qemu/qemu_process.h | 2 ++
3 files changed, 18 insertions(+),
On Mon, Nov 12, 2018 at 12:43:11PM +0100, Marc Hartmayer wrote:
> On Thu, Nov 01, 2018 at 10:18 AM +0100, "Daniel P. Berrangé"
> wrote:
> > On Thu, Nov 01, 2018 at 09:31:50AM +0100, Martin Kletzander wrote:
> >> On Tue, Oct 30, 2018 at 03:07:59PM +, Daniel P. Berrangé wrote:
> >> > On Tue, Oc
On Mon, Nov 12, 2018 at 12:50:41PM +0100, Marc Hartmayer wrote:
> On Thu, Nov 01, 2018 at 09:31 AM +0100, Martin Kletzander
> wrote:
[...]
> How can you run a machine/QEMU VM under a different user:group other
> than changing the user:group in qemu.conf and restart/reload libvirtd?
>
> As soon
Move the respective bits to QEMU validation code instead.
Erik Skultety (2):
qemu: Extract MDEV VFIO PCI validation code into a separate helper
conf: Move VFIO AP validation from post parse to QEMU validation code
src/conf/domain_conf.c | 28 ---
src/qemu/qemu_domain.c | 61 +
Even though commit 11708641 claims that a domain is allowed have a
single VFIO AP hostdev only, this is a limitation posed by the platform
vendor on purely virtual devices. Generally, post parse should only be
used to populate some default values if missing or at least fail
gracefully with VIR_DOMA
Since we'll need to validate other models apart from VFIO PCI too,
having a helper for each model should keep the code base cleaner.
Signed-off-by: Erik Skultety
---
src/qemu/qemu_domain.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/sr
On 11/6/2018 2:44 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
Add functions for creating, destroying, reconnecting resctrl
monitor in qemu according to the configuration in domain XML.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 66 +++
On 11/6/2018 3:27 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
Refactoring qemuDomainGetStatsCpu, make it possible to add
more CPU statistics.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 45 ++---
1 file changed, 22
On 11/6/2018 4:19 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
This series of patches and the series already been merged introduce
the x86 Cache Monitoring Technology (CMT) to libvirt by interacting
with kernel resource control (resctrl) interface. CMT is one of the
Intel(
-Original Message-
From: John Ferlan [mailto:jfer...@redhat.com]
Sent: Tuesday, November 6, 2018 4:09 AM
To: Wang, Huaqiang ; libvir-list@redhat.com
Cc: Feng, Shaohe ; Niu, Bing ;
Ding, Jian-feng ; Zang, Rui
Subject: Re: [PATCHv7 18/18] qemu: Setting up vcpu and adding pids to resctrl
This patch is added previously because I though the vcpupid would be
changed during
libvirt re-connection, and if vcpupid is changed and libvirt is not
aware of this change
it will make monitor working on an stale *tasks file and monitor will
get wrong
cache information.
But the vcpuid wi
On 11/6/2018 2:01 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
Add functions for creating, destroying, reconnecting resctrl
monitor in qemu according to the configuration in domain XML.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 66 +++
On 11/6/2018 4:04 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
Adding the interface in qemu to report CMT statistic information
through command 'virsh domstats --cpu-total'.
Below is a typical output:
# virsh domstats 1 --cpu-total
Domain: 'ubuntu16.04
On 11/6/2018 3:15 AM, John Ferlan wrote:
On 10/22/18 4:01 AM, Wang Huaqiang wrote:
Adding element 'id' to virDomainResctrlDef tracking resource group
id, it reflects the attribute 'id' of of element in XML.
virResctrlAlloc.id is a copy from virDomanResctrlDef.id.
Signed-off-by: Wang Huaqian
On Fri, Nov 02, 2018 at 03:30:56PM +0100, Michal Privoznik wrote:
> On 11/01/2018 04:50 PM, Erik Skultety wrote:
> > There's a lot of stuff going on in src/conf/nodedev_conf which not
> > always has to do anything with config, so even though we're trying,
> > we're not really consistent in putting
There's a lot of stuff going on in src/conf/nodedev_conf which is
sometimes not directly related to config and we're not really consistent
with putting only parser/formatter related stuff here, e.g. like we do
for domains. So, let's start simply by adding a new module
node_device_util containing so
On Thu, Nov 01, 2018 at 09:31 AM +0100, Martin Kletzander
wrote:
> On Tue, Oct 30, 2018 at 03:07:59PM +, Daniel P. Berrangé wrote:
>>On Tue, Oct 30, 2018 at 03:45:36PM +0100, Michal Privoznik wrote:
>>> On 10/30/2018 02:46 PM, Michal Privoznik wrote:
>>> > On 10/30/2018 01:55 PM, Daniel P. Be
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, November 7, 2018 12:15 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; bing@intel.com; Ding, Jian-
> feng ; Zang, Rui
> Subject: Re: [PATCHv7 10/18] conf: Remove virDomainRes
On Thu, Nov 01, 2018 at 10:18 AM +0100, "Daniel P. Berrangé"
wrote:
> On Thu, Nov 01, 2018 at 09:31:50AM +0100, Martin Kletzander wrote:
>> On Tue, Oct 30, 2018 at 03:07:59PM +, Daniel P. Berrangé wrote:
>> > On Tue, Oct 30, 2018 at 03:45:36PM +0100, Michal Privoznik wrote:
>> > > On 10/30/20
On Fri, Nov 02, 2018 at 04:34:02PM -0600, Jim Fehlig wrote:
> A dry run can be used as a best-effort check that a migration command
> will succeed. The destination host will be checked to see if it can
> accommodate the resources required by the domain. DRY_RUN will fail if
> the destination host i
On Fri, Nov 02, 2018 at 04:23:02PM -0400, Laine Stump wrote:
> On 11/2/18 11:52 AM, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > lib/Sys/Virt/TCK.pm | 33
> > lib/Sys/Virt/TCK/NetworkBuilder.pm| 33 +++-
> > scripts
On Fri, Nov 09, 2018 at 03:30:59PM -0200, Julio Faracco wrote:
> This patch introduce the new settings for LXC 3.0 or higher. The older
> versions keep the compatibility to deprecated settings for LXC, but
> after release 3.0, the compatibility was removed. This commit adds the
> support to the ref
On Mon, Nov 12, 2018 at 11:00:30 +0100, Thomas Huth wrote:
> It has been unmaintained since years, and there were only trivial or
> tree-wide changes to the related files since many years, so the
> code is likely very bitrotten and broken. For example the following
> segfaults as soon as as you pre
It has been unmaintained since years, and there were only trivial or
tree-wide changes to the related files since many years, so the
code is likely very bitrotten and broken. For example the following
segfaults as soon as as you press a key:
qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Tuesday, November 6, 2018 10:41 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; bing@intel.com; Ding, Jian-
> feng ; Zang, Rui
> Subject: Re: [PATCHv7 05/18] util: Refactor code for add
77 matches
Mail list logo
