Re: [libvirt] [PATCH v2 06/13] squash into rendernode capability patch

2018-11-28 Thread Peter Krempa
On Wed, Nov 28, 2018 at 16:38:57 +0100, Erik Skultety wrote: > On Wed, Nov 28, 2018 at 03:13:29PM +0100, Peter Krempa wrote: > > On Wed, Nov 28, 2018 at 14:38:16 +0100, Erik Skultety wrote: > > > Signed-off-by: Erik Skultety > > > > This needs to be commited as a separate patch adding the caps and

Re: [libvirt] [RFC v2 3/3] nvdimm: update docs for introducing more NVDIMM configurations

2018-11-28 Thread Luyao Zhong
On 2018/11/28 下午10:33, Peter Krempa wrote: On Wed, Nov 28, 2018 at 22:09:19 +0800, Luyao Zhong wrote: Update news.xml and add description about new supported configurations about NVDIMM in html, including 'alignsize', 'pmem', 'unarmed' and 'persistence'. Signed-off-by: Luyao Zhong --- docs

Re: [libvirt] [RFC v2 2/3] nvdimm: update qemu command-line generating for NVDIMM memory

2018-11-28 Thread Luyao Zhong
On 2018/11/28 下午10:32, Peter Krempa wrote: On Wed, Nov 28, 2018 at 22:09:01 +0800, Luyao Zhong wrote: According to the result parsing from xml, add corresponding properties into QEMU command line, including 'align', 'pmem', 'unarmed' and 'nvdimm-persistence'. Signed-off-by: Luyao Zhong ---

[libvirt] [PATCH v3] qemu: Add check for whether KVM nesting is enabled

2018-11-28 Thread John Ferlan
Support for nested KVM is handled via a kernel module configuration parameters values for kvm_intel, kvm_amd, kvm_hv (PPC), or kvm (s390). While it's possible to fetch the kmod config values via virKModConfig, unfortunately that is the static value and we need to get the current/dynamic value from

Re: [libvirt] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [libvirt] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices Message-id: 20181127024959.7060-1-ehabk...@redhat.com === TEST SCRIPT BEGIN ===

[libvirt] [PATCH 1/3] Add armv6l Support as guest

2018-11-28 Thread infos
From: Stefan Schallenberg Support for armv6l qemu guests has been added. Tested with arm1176 CPU on x86. Signed-off-by: Stefan Schallenberg --- docs/schemas/basictypes.rng | 1 + src/qemu/qemu_capabilities.c | 5 +- src/qemu/qemu_command.c

[libvirt] [PATCH 2/3] qemu: Add Default PCI Device for armv6l versatilepb guests

2018-11-28 Thread infos
From: Stefan Schallenberg Signed-off-by: Stefan Schallenberg --- src/qemu/qemu_domain.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index efe6202101..f348eccb2f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -326

[libvirt] [PATCH 3/3] News: Add armv6l Support as guest

2018-11-28 Thread infos
From: Stefan Schallenberg Signed-off-by: Stefan Schallenberg --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3983613f8a..4dfa215184 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -102,6 +102,11 @@ + +

[libvirt] [PATCH v2 0/3] qemu: arm guest on x86

2018-11-28 Thread infos
From: Stefan Schallenberg rewrite of patch after discussion. Stefan Schallenberg (3): Add armv6l Support as guest qemu: Add Default PCI Device for armv6l versatilepb guests News: Add armv6l Support as guest docs/news.xml| 5 ++ docs/schemas/basictypes.rng

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Wed, Nov 28, 2018 at 12:28:21PM +, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 01:26:17PM +0100, Erik Skultety wrote: > > On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > > > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > > > On Tue, Nov 27, 2

Re: [libvirt] [PATCH v2 06/13] squash into rendernode capability patch

2018-11-28 Thread Erik Skultety
On Wed, Nov 28, 2018 at 03:13:29PM +0100, Peter Krempa wrote: > On Wed, Nov 28, 2018 at 14:38:16 +0100, Erik Skultety wrote: > > Signed-off-by: Erik Skultety > > This needs to be commited as a separate patch adding the caps and not > squashed into any random capability addition. > > You seem to be

Re: [libvirt] [PATCH] virsh: Strip XML declaration when extracting CPU XMLs

2018-11-28 Thread Ján Tomko
On Fri, Nov 23, 2018 at 12:48:44PM +0100, Jiri Denemark wrote: On Thu, Nov 22, 2018 at 17:39:16 +0100, Ján Tomko wrote: On Thu, Nov 22, 2018 at 04:46:33PM +0100, Jiri Denemark wrote: >Since commit v4.3.0-336-gc84726fbdd all >{hypervisor-,}cpu-{baseline,compare} commands use a generic >vshExtract

Re: [libvirt] [PATCH v2 1/2] lxc: Initializing IPv6 and IPv4 gateway to overwrite old settings.

2018-11-28 Thread Michal Privoznik
On 11/28/18 4:38 AM, Julio Faracco wrote: > This commit fixes a bug when you have multiple network settings defined. > Basically, if you set an IPv6 or IPv4 gateway, it carries on next > network settings. It is happening because the data is not being > initialized when a new network type is defined

Re: [libvirt] [PATCH v2 2/2] tests: Adding test case to include multiple network definitions.

2018-11-28 Thread Michal Privoznik
On 11/28/18 4:38 AM, Julio Faracco wrote: > This commit includes a test case for multiple network definitions. It is > useful right now, but it will be more useful when the index used by LXC > version 3.X is implemented to support this new settings. > > Signed-off-by: Julio Faracco > --- > .../l

Re: [libvirt] [RFC v2 3/3] nvdimm: update docs for introducing more NVDIMM configurations

2018-11-28 Thread Peter Krempa
On Wed, Nov 28, 2018 at 22:09:19 +0800, Luyao Zhong wrote: > Update news.xml and add description about new supported configurations > about NVDIMM in html, including 'alignsize', 'pmem', 'unarmed' and > 'persistence'. > > Signed-off-by: Luyao Zhong > --- > docs/formatdomain.html.in | 94

Re: [libvirt] [RFC v2 2/3] nvdimm: update qemu command-line generating for NVDIMM memory

2018-11-28 Thread Peter Krempa
On Wed, Nov 28, 2018 at 22:09:01 +0800, Luyao Zhong wrote: > According to the result parsing from xml, add corresponding properties > into QEMU command line, including 'align', 'pmem', 'unarmed' and > 'nvdimm-persistence'. > > Signed-off-by: Luyao Zhong > --- > src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH v2 06/13] squash into rendernode capability patch

2018-11-28 Thread Peter Krempa
On Wed, Nov 28, 2018 at 14:38:16 +0100, Erik Skultety wrote: > Signed-off-by: Erik Skultety This needs to be commited as a separate patch adding the caps and not squashed into any random capability addition. You seem to be missing the VMX capability, did you create this on a VM? I have a versio

[libvirt] [RFC v2 3/3] nvdimm: update docs for introducing more NVDIMM configurations

2018-11-28 Thread Luyao Zhong
Update news.xml and add description about new supported configurations about NVDIMM in html, including 'alignsize', 'pmem', 'unarmed' and 'persistence'. Signed-off-by: Luyao Zhong --- docs/formatdomain.html.in | 94 --- docs/news.xml | 9 2 f

[libvirt] [RFC v2 1/3] nvdimm: introduce more config elements into xml for NVDIMM memory

2018-11-28 Thread Luyao Zhong
1.alignsize The 'alignsize' option allows users to specify the proper alignment. 2.pmem The 'pmem' option allows users to specify whether the backend storage of memory-backend-file is a real persistent memory. 3.persistence The 'persistence' option allows users to set guest platform supported fea

[libvirt] [RFC v2 2/3] nvdimm: update qemu command-line generating for NVDIMM memory

2018-11-28 Thread Luyao Zhong
According to the result parsing from xml, add corresponding properties into QEMU command line, including 'align', 'pmem', 'unarmed' and 'nvdimm-persistence'. Signed-off-by: Luyao Zhong --- src/qemu/qemu_capabilities.c | 17 +++ src/qemu/qemu_capabilities.h |

[libvirt] [RFC v2 0/3] update NVDIMM support

2018-11-28 Thread Luyao Zhong
Hi libvirt experts, This is the RFC v2 for updating NVDIMM support in libvirt. There are some gaps between qemu and libvirt, libvirt has not supported several config options about NVDIMM memory while qemu is ready now, including 'align', 'pmem', 'unarmed' and 'persistence'. I have already reword

[libvirt] [PATCH v2 05/13] qemu: caps: Introduce QEMU_EGL_HEADLESS_RENDERNODE capability

2018-11-28 Thread Erik Skultety
Now that we have QAPI introspection of display types in QEMU upstream, we can check whether the 'rendernode' option is supported with egl-headless display type. Signed-off-by: Erik Skultety --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions

[libvirt] [PATCH v2 12/13] security: dac: gfx: egl-headless: Relabel the DRI device

2018-11-28 Thread Erik Skultety
Just like for SPICE, we need to change the permissions on the DRI device used as the @rendernode for egl-headless graphics type. Signed-off-by: Erik Skultety --- src/security/security_dac.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/security/security_

[libvirt] [PATCH v2 13/13] qemu: command: gfx: egl-headless: Add 'rendernode' option to the cmdline

2018-11-28 Thread Erik Skultety
Depending on whether QEMU actually supports the option, we can put the 'rendernode' on the '-display egl-headless' cmdline. As for the test, we don't need a new input source, hence the symlink, we just need a new .args output, since the functionality is determined by a QEMU capability. Signed-off-

[libvirt] [PATCH v2 04/13] qemu: command: Introduce qemuBuildGraphicsEGLHeadlessCommandLine helper

2018-11-28 Thread Erik Skultety
We're going to need a bit more logic for egl-headless down the road so prepare a helper just like for the other display types. Signed-off-by: Erik Skultety --- src/qemu/qemu_command.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH v2 07/13] conf: gfx: Add egl-headless as a member to virDomainGraphicsDef struct

2018-11-28 Thread Erik Skultety
Since we need to specify the rendernode option onto QEMU cmdline, we need this union member to retain consistency in how we build the cmdline. Signed-off-by: Erik Skultety --- src/conf/domain_conf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_c

[libvirt] [PATCH v2 03/13] qemu: process: spice: Pick the first available DRM render node

2018-11-28 Thread Erik Skultety
Up until now, we formatted 'rendernode=' onto QEMU cmdline only if the user specified it in the XML, otherwise we let QEMU do it for us. This causes permission issues because by default the /dev/dri/renderDX permissions are as follows: crw-rw. 1 root video There's literally no reason why it s

[libvirt] [PATCH v2 02/13] conf: Introduce virDomainGraphics-related helpers

2018-11-28 Thread Erik Skultety
A few simple helpers that allow us to determine whether a graphics can and will need to make use of a DRM render node. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c | 41 src/conf/domain_conf.h | 9 + src/libvirt_private.syms | 3 +

[libvirt] [PATCH v2 11/13] qemu: cgroup: gfx: egl-headless: Add the DRI device into the cgroup list

2018-11-28 Thread Erik Skultety
Just like for SPICE, we need to put the render node DRI device into the device cgroup list so that users don't need to add it manually via qemu.conf file. Signed-off-by: Erik Skultety --- src/qemu/qemu_cgroup.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/qe

[libvirt] [PATCH v2 09/13] qemu: process: gfx: egl-headless: Pick the first available DRM node

2018-11-28 Thread Erik Skultety
Just like for SPICE, pick the first available DRM render node for egl-headless. Signed-off-by: Erik Skultety --- src/qemu/qemu_process.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f3d194b0ce..bb2b8e8358 1006

[libvirt] [PATCH v2 10/13] qemu: domain: egl-headless: Add the DRI device into the namespace

2018-11-28 Thread Erik Skultety
Just like for SPICE, we need to put the DRI device into the namespace, otherwise it will be left out from the DAC relabeling process. Signed-off-by: Erik Skultety --- src/qemu/qemu_domain.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/

[libvirt] [PATCH v2 08/13] conf: gfx: egl-headless: Introduce a new subelement

2018-11-28 Thread Erik Skultety
Unlike with SPICE and SDL which use the subelement to enable OpenGL acceleration, specifying egl-headless graphics in the XML has essentially the same meaning, thus in case of egl-headless we don't have a need for the 'enable' element attribute and we'll only be interested in the 'rendernode' one

[libvirt] [PATCH v2 01/13] util: Introduce virHostGetDRMRenderNode helper

2018-11-28 Thread Erik Skultety
This is the first step towards libvirt picking the first available render node instead of QEMU. It also makes sense for us to be able to do that, since we allow specifying the node directly for SPICE, so if there's no render node specified by the user, we should pick the first available one. The al

[libvirt] [PATCH v2 00/13] Autoselect a DRM node for egl-headless and add it to cmdline

2018-11-28 Thread Erik Skultety
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628892. The problem is that we didn't put the DRI device into the namespace for QEMU to access, but that was only a part of the issue. The other part of the issue is that QEMU doesn't support specifying 'rendernode' for egl-headless yet (patches ar

Re: [libvirt] [PATCH] openvswitch: Add new port VLAN mode "dot1q-tunnel"

2018-11-28 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 1542985233-323537-1-git-send-email-luzhip...@uniudc.com Subject: [libvirt] [PATCH] openvswitch: Add new port VLAN mode "dot1q-tunnel" === TEST SCRIPT BEGIN =

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread Caio Carrara
On Tue, Nov 27, 2018 at 11:06:17AM -0200, Eduardo Habkost wrote: > On Tue, Nov 27, 2018 at 10:56:21AM -0200, Caio Carrara wrote: > > Hello, Eduardo. > > > > Just some minor comments regarding the Python code. > > > [...] > > > +def devtype_implements(vm, devtype, implements): > > > +return de

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread Caio Carrara
Hello, Eduardo. Just some minor comments regarding the Python code. On Tue, Nov 27, 2018 at 12:49:59AM -0200, Eduardo Habkost wrote: > Many of the current virtio-*-pci device types actually represent > 3 different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transition

[libvirt] [PATCH] openvswitch: Add new port VLAN mode "dot1q-tunnel"

2018-11-28 Thread luzhipeng
From: ZhiPeng Lu Signed-off-by: ZhiPeng Lu --- docs/formatnetwork.html.in | 13 +++-- docs/schemas/networkcommon.rng | 1 + src/conf/netdev_vlan_conf.c | 2 +- src/util/virnetdevopenvswitch.c | 5 + src/util/virnetdevvlan.h| 1 + 5 files changed, 15 insertions(

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > > > a failure, then when col

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 01:26:17PM +0100, Erik Skultety wrote: > On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > > > During qemuConnectGetAll

Re: [libvirt] [PATCH 0/2] vsh-table: Remove trailing spaces

2018-11-28 Thread Michal Privoznik
On 11/27/18 10:07 AM, Simon Kobyda wrote: > Right now, each line in last column of our table leaves trailing spaces. > Let's get rid of it. > > Simon Kobyda (2): > vsh-table: Get rid of trailing spaces > tests: Remove trailing spaces in test cases > > tests/virshtest.c| 10 > te

Re: [libvirt] [PATCH 1/2] Add armv6l Support as guest

2018-11-28 Thread Andrea Bolognani
On Tue, 2018-11-27 at 20:37 +0100, in...@nafets.de wrote: > > What OS did you run inside the guest? I would like to give this a try > > myself. > > I use: > - Arch Linux ARM http://os.archlinuxarm.org/os/ArchLinuxARM-rpi-latest.tar.gz > - Kernel > https://github.com/dhruvvyas90/qemu-rpi-kernel/

Re: [libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 07:13:05AM -0500, John Ferlan wrote: > > > On 11/28/18 5:02 AM, Daniel P. Berrangé wrote: > > On Tue, Nov 27, 2018 at 02:15:39PM -0500, John Ferlan wrote: > >> > >> > >> On 11/27/18 12:05 PM, Andrea Bolognani wrote: > >>> On Mon, 2018-11-26 at 18:38 -0500, John Ferlan wrot

Re: [libvirt] [PATCH] qemu: Fix post-copy migration on the source

2018-11-28 Thread Ján Tomko
On Fri, Nov 16, 2018 at 02:16:33PM +0100, Jiri Denemark wrote: Post-copy migration has been broken on the source since commit v3.8.0-245-g32c29f10db which implemented support for pause-before-switchover QEMU migration capability. Even though the migration itself went well, the source did not rea

Re: [libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-28 Thread John Ferlan
On 11/28/18 5:02 AM, Daniel P. Berrangé wrote: > On Tue, Nov 27, 2018 at 02:15:39PM -0500, John Ferlan wrote: >> >> >> On 11/27/18 12:05 PM, Andrea Bolognani wrote: >>> On Mon, 2018-11-26 at 18:38 -0500, John Ferlan wrote: >>> [...] +static bool +virQEMUCapsKVMIsNested(void) +{ >>>

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > > a failure, then when collecting more than one domain's worth of > > statistics the loop in virDomain

Re: [libvirt] [PATCH 03/18] security: Include security_util

2018-11-28 Thread Michal Privoznik
On 11/28/18 11:00 AM, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 09:35:49AM +0100, Michal Privoznik wrote: >> On 11/27/18 4:20 PM, Daniel P. Berrangé wrote: >>> On Fri, Nov 23, 2018 at 09:43:21AM +0100, Michal Privoznik wrote: >>> +/* There are four namespaces available (xattr(7)): >>

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > a failure, then when collecting more than one domain's worth of > statistics the loop in virDomainStatsRecordListFree would call > virDomainFree which would call virRese

Re: [libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-28 Thread Daniel P . Berrangé
On Tue, Nov 27, 2018 at 02:15:39PM -0500, John Ferlan wrote: > > > On 11/27/18 12:05 PM, Andrea Bolognani wrote: > > On Mon, 2018-11-26 at 18:38 -0500, John Ferlan wrote: > > [...] > >> +static bool > >> +virQEMUCapsKVMIsNested(void) > >> +{ > >> +VIR_AUTOFREE(char *) kConfig = NULL; > >> + >

Re: [libvirt] [PATCH 03/18] security: Include security_util

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 09:35:49AM +0100, Michal Privoznik wrote: > On 11/27/18 4:20 PM, Daniel P. Berrangé wrote: > > On Fri, Nov 23, 2018 at 09:43:21AM +0100, Michal Privoznik wrote: > > > >> +/* There are four namespaces available (xattr(7)): > > > > s/available/available on Linux/ > > > > Fr

Re: [libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-28 Thread Andrea Bolognani
On Tue, 2018-11-27 at 14:15 -0500, John Ferlan wrote: > On 11/27/18 12:05 PM, Andrea Bolognani wrote: > > Oh, wait, I get it now: 'modprobe -c' doesn't dump the *current* host > > configuration, but the *static* one! So if you enable nested KVM > > support by doing > > > > # modprobe -r kvm_inte

Re: [libvirt] [PATCH 03/18] security: Include security_util

2018-11-28 Thread Michal Privoznik
On 11/27/18 4:20 PM, Daniel P. Berrangé wrote: > On Fri, Nov 23, 2018 at 09:43:21AM +0100, Michal Privoznik wrote: > >> +/* There are four namespaces available (xattr(7)): > > s/available/available on Linux/ > > FreeBSD only supports 'user' and 'system' namespaces D'oh! > >> + * >> + * user