Re: [libvirt] [PATCH 2/2] qemu: don't log error for missing optional sources on start

2018-12-10 Thread Nikolay Shirokovskiy
On 11.12.2018 01:05, John Ferlan wrote: > $SUBJ > > "storage sources" > > On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: >> Because missing optional source is not error. The patch >> address only local files. Fixing other cases is a bit ugly. >> >> Signed-off-by: Nikolay Shirokovskiy >>

Re: [libvirt] [PATCH 1/2] qemu: don't log error for missing optional sources on stats

2018-12-10 Thread Nikolay Shirokovskiy
On 11.12.2018 01:05, John Ferlan wrote: > > $SUBJ: > > 'storage sources' > > On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: >> Every time we call all domain stats for inactive domain with >> unavailable source we get error message in logs. It's a bit noisy. > > Are there ones in

Re: [libvirt] [PATCH] secret: Add check/validation for correct usage when LookupByUUID

2018-12-10 Thread John Ferlan
ping? Thanks, John On 12/4/18 3:32 PM, John Ferlan wrote: > If virSecretGetSecretString is using by secretLookupByUUID, > then it's possible the found sec->usageType doesn't match the > desired @secretUsageType. If this occurs for the encrypted > volume creation processing and a subsequent

Re: [libvirt] [PATCH 0/8] Add tests for Storage Pool startup command line generation

2018-12-10 Thread John Ferlan
ping? Thanks, John On 12/4/18 11:47 AM, John Ferlan wrote: > Similar to qemuxml2argv and storagevolxml2argv, add storagepoolxml2argvtest > in order to check the command line creation for the pool 'Start' commands. > > Only applicable for pool types with a "@startPool" function - that is disk,

Re: [libvirt] [PATCH 2/2] qemu: don't log error for missing optional sources on start

2018-12-10 Thread John Ferlan
$SUBJ "storage sources" On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: > Because missing optional source is not error. The patch > address only local files. Fixing other cases is a bit ugly. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_process.c | 3 ++- > 1 file changed, 2

Re: [libvirt] [PATCH 1/2] qemu: don't log error for missing optional sources on stats

2018-12-10 Thread John Ferlan
$SUBJ: 'storage sources' On 11/12/18 7:58 AM, Nikolay Shirokovskiy wrote: > Every time we call all domain stats for inactive domain with > unavailable source we get error message in logs. It's a bit noisy. Are there ones in particular? > While it's arguable whether we need such message or

Re: [libvirt] [PATCH 2/2] libxl: handle external domain destroy

2018-12-10 Thread Jim Fehlig
On 12/7/18 7:46 PM, Marek Marczykowski-Górecki wrote: If domain is killed with `xl destroy`, libvirt will not notice it and still report the domain as running. Also trying to destroy the domain through libvirt will fail. The only way to recover from such a situation is to restart libvirt daemon.

Re: [libvirt] [PATCH 1/2] libxl: add missing cleanup on error path in libxlDomainPMWakeup

2018-12-10 Thread Jim Fehlig
On 12/7/18 7:45 PM, Marek Marczykowski-Górecki wrote: Since domain was suspended before and on failed wakeup is destroyed, send an event. Also, add missing libxlDomainCleanup. Signed-off-by: Marek Marczykowski-Górecki --- src/libxl/libxl_driver.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [libvirt] [PATCH] On Xen, domains may be destroyed without libvirt being involved

2018-12-10 Thread Jim Fehlig
On 12/9/18 11:01 AM, Demi M. Obenour wrote: This can happen via `xl destroy`, for example.  When this happens, libvirt is stuck in an inconsistent state: libvirt believes the domain is still running, but attempts to use libvirt’s APIs to shutdown the domain fail.  The only way out of this

Re: [libvirt] [PATCH v2] qemu: disable external snapshot of readonly disk

2018-12-10 Thread John Ferlan
On 11/9/18 3:00 AM, Nikolay Shirokovskiy wrote: > Disable external snapshot of readonly disk for inactive domains > as this operation is not very useful. As to active domains > such snapshot was not possible before already but error message was > not helpful so now it will be better. > >

Re: [libvirt] [PATCH v2 3/4] qemu: support metadata-cache-size for blockdev

2018-12-10 Thread John Ferlan
On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: > Just set l2-cache-size to INT64_MAX for all format nodes of > qcow2 type in block node graph. > > -drive configuration is not supported because we can not > set l2 cache size down the backing chain in this case. > > Note that imlementation

Re: [libvirt] [PATCH v2 2/4] qemu: caps: add QEMU_CAPS_QCOW2_L2_CACHE_SIZE

2018-12-10 Thread John Ferlan
On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: > For qemu capable of setting l2-cache-size for qcow2 images > to INT64_MAX and semantics of upper limit on l2 cache > size. We can only check this by qemu version (3.1.0) now. > > Signed-off-by: Nikolay Shirokovskiy > --- >

Re: [libvirt] [PATCH v2 1/4] xml: add disk driver metadata_cache_size option

2018-12-10 Thread John Ferlan
On 11/8/18 8:02 AM, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > docs/formatdomain.html.in | 8 > docs/schemas/domaincommon.rng | 11 + > src/conf/domain_conf.c | 17 >

[libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-10 Thread Daniel P . Berrangé
The virt-pki-validate tool is extracting components in the x509 certificate Subject field. Unfortunately the regex it is is using is far too strict, and so truncating valid data. It needs to consider ',' as a field separator, and if that's not there take all data until the EOL. With the broken

Re: [libvirt] [PATCH] On Xen, domains may be destroyed without libvirt being involved

2018-12-10 Thread Daniel P . Berrangé
On Sun, Dec 09, 2018 at 01:01:27PM -0500, Demi M. Obenour wrote: > This can happen via `xl destroy`, for example.  When this happens, > libvirt is stuck in an inconsistent state: libvirt believes the domain > is still running, but attempts to use libvirt’s APIs to shutdown the > domain fail.  The

Re: [libvirt] [PATCH] On Xen, domains may be destroyed without libvirt being involved

2018-12-10 Thread Peter Krempa
On Sun, Dec 09, 2018 at 13:01:27 -0500, Demi M. Obenour wrote: > This can happen via `xl destroy`, for example.  When this happens, > libvirt is stuck in an inconsistent state: libvirt believes the domain > is still running, but attempts to use libvirt’s APIs to shutdown the > domain fail.  The

Re: [libvirt] libvirt-csharp for .NET Standard/Core

2018-12-10 Thread Daniel P . Berrangé
On Sun, Dec 09, 2018 at 11:27:35AM +0100, Brian Wengel wrote: > Anyone out there manage to port *libvirt-csharp* to *.NET Standard* (or > Core)? > Or perhaps it could be in the future? > > I think .Core is getting more mature on Linux and I would love to have more > direct access to libvirt in my

Re: [libvirt] Adding MTU DHCP option when specified

2018-12-10 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 04:29:18PM +0100, Casey Callendrello wrote: > Hi there, > I was working on some MTU testing for OpenShift, and I realized that, while > libvirt does allow specifying the MTU of the bridge interface, it doesn't > plumb it through the DHCP server. > > This is really easy -

[libvirt] [PATCH] On Xen, domains may be destroyed without libvirt being involved

2018-12-10 Thread Demi M. Obenour
This can happen via `xl destroy`, for example.  When this happens, libvirt is stuck in an inconsistent state: libvirt believes the domain is still running, but attempts to use libvirt’s APIs to shutdown the domain fail.  The only way out of this situation is to restart libvirt. To prevent this

[libvirt] Adding MTU DHCP option when specified

2018-12-10 Thread Casey Callendrello
Hi there, I was working on some MTU testing for OpenShift, and I realized that, while libvirt does allow specifying the MTU of the bridge interface, it doesn't plumb it through the DHCP server. This is really easy - it's just an extra line in the dnsmasq.conf file, e.g.:

[libvirt] libvirt-csharp for .NET Standard/Core

2018-12-10 Thread Brian Wengel
Anyone out there manage to port *libvirt-csharp* to *.NET Standard* (or Core)? Or perhaps it could be in the future? I think .Core is getting more mature on Linux and I would love to have more direct access to libvirt in my .Core code :-) Best regards Brian Wengel Denmark -- libvir-list mailing

Re: [libvirt] [bug report] Requested operation is not valid: migration with shmem device is not supported

2018-12-10 Thread Peter Krempa
On Mon, Dec 10, 2018 at 08:39:37 +, 吴 雨霖 wrote: > 1.Description of problem: > > It report use migration with shmem device is not supported , when I use > the command "virsh migrate --live" to migrate a VM to another host. Migration with shmem was specifically forbidden by commit:

[libvirt] [bug report] Requested operation is not valid: migration with shmem device is not supported

2018-12-10 Thread 吴 雨霖
1.Description of problem: It report use migration with shmem device is not supported , when I use the command "virsh migrate --live" to migrate a VM to another host. 2.Version-Release number of selected component (if applicable): libvirt 3.9.0 qemu-kvm 2.8.1 3.Steps to

[libvirt] 转发: [bug confirm] Requested operation is not valid: migration with shmem device is not supported

2018-12-10 Thread 吴 雨霖
1.Description of problem: It report use migration with shmem device is not supported , when I use the command "virsh migrate --live" to migrate a VM to another host. 2.Version-Release number of selected component (if applicable): libvirt 3.9.0 qemu-kvm 2.8.1 3.Steps to