On 20.12.2018 23:31, John Ferlan wrote:
>
>
> On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
>> In case of active persistent domain snapshot metadata is
>> not complete. We save only active configuration and on
>> restore use it both for active and inactive configuration.
>> Let's fix it and
The initial trigger for working on this was the fact that Fedora
Rawhide no longer contains the python2-dnf package, breaking our
update procedure; while looking into it, however, I ended up
cleaning up some other stuff and dropping some code which is no
longer needed with modern Ansible versions.
When parsing something like
os_version: 9
YAML will, somewhat reasonably, decide that os_version is
a number rather than a string.
This would be okay if not for the fact that in-development
versions of operating systems are usually assigned a
codename rather than a version number (Debian sid,
We're always storing os_version as string now, so casting
it before use has become unnecessary.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 2 +-
guests/playbooks/update/tasks/packages.yml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
So far we've only needed to use ansible_python_interpreter
for FreeBSD, where Ansible is unable to locate the Python
binary itself; nowever, now that we want to use Python 3
instead of the default Python 2 almost everywhere, we need
to make sure we always point Ansible to the appropriate
Python bin
Modern Ansible versions do this automatically.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/update/tasks/base.yml | 8
1 file changed, 8 deletions(-)
diff --git a/guests/playbooks/update/tasks/base.yml
b/guests/playbooks/update/tasks/base.yml
index 2899382..5cffbeb 100644
---
Now that we need to point Ansible to the Python binary
explicitly and we prefer Python 3 to Python 2 while doing
so, we might as well just re-use the path stored in the
inventory instead of looking for it dynamically.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/update/tasks/paths.yml
Almost all our target operating systems have a version
of Python 3 which is recent enough (>= 3.5) to be used
by Ansible available.
In fact, almost all of them have it pre-installed, which
makes installing Python 2 in addition to it just to use
Ansible, when Ansible itself would be absolutely happ
Modern Ansible versions can take care of this step
automatically the first time the package module is used,
which is nice because it means we don't have to worry
about whether we're using Python 3 or Python 2 on the
managed host.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/update/tasks/
On 20.12.2018 23:32, John Ferlan wrote:
>
>
> On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
>> Signed-off-by: Nikolay Shirokovskiy
>> ---
>> docs/formatsnapshot.html.in | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>
> This probably should be merged with patch5 - nice to separate fo
On 21.12.2018 00:01, John Ferlan wrote:
>
>
> On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
>> Renaming domain which has snapshots is prohibited. Also reverting
>> to ABI compatible active domain with a different name can have
>> issues later I guess. So let's prohibit changing domain name
On 21.12.2018 00:15, John Ferlan wrote:
>
>
> On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
>> This patch just adds basic checks for persistent domain config
>> on snapshot metadata redefine. It also lets use previous version
>> of config if it exists in previous version of metadata and
>>
At some point during the life of CentOS 7, the Go compiler
and related packages appear to has been moved from out of
the base repositories and into EPEL.
Since as a rule we only rely on first-party repositories
to fulfill build requirements, this means we can no longer
build Go projects on CentOS
Found while creating a new CentOS 7 guest from scratch using
lcitool. See the commit messages for more details.
Andrea Bolognani (2):
Stop building Go projects on CentOS 7
guests: Don't prepare CentOS 7 for Go projects
guests/host_vars/libvirt-centos-7/main.yml | 2 --
guests/playbo
The corresponding packages are no longer available without
enabling EPEL, which resulted in the update procedure
failing.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/main.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/guests/host_vars/libvirt-centos-7/main.yml
On 2018/12/21 上午1:10, John Ferlan wrote:
$SUBJ:
docs: Add news for new nvdimm options
On 12/20/18 4:14 AM, Luyao Zhong wrote:
add more configure options for NVDIMM
Signed-off-by: Luyao Zhong
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/
On 13.12.2018 14:02, Nikolay Shirokovskiy wrote:
> John, I still did not add anything to formatdomain.html.in because when
> I gave this a thought it looks odd to add something like "we don't get
> stats for missing storage source" - it is obvious because such
> getting stats is simply not possi
On 21.12.2018 12:22, Nikolay Shirokovskiy wrote:
>
>
> On 13.12.2018 14:02, Nikolay Shirokovskiy wrote:
>> John, I still did not add anything to formatdomain.html.in because when
>> I gave this a thought it looks odd to add something like "we don't get
>> stats for missing storage source" - it
On Fri, Dec 21, 2018 at 09:36:20AM +0100, Andrea Bolognani wrote:
> The initial trigger for working on this was the fact that Fedora
> Rawhide no longer contains the python2-dnf package, breaking our
> update procedure; while looking into it, however, I ended up
> cleaning up some other stuff and d
On Fri, Dec 21, 2018 at 10:15:31AM +0100, Andrea Bolognani wrote:
> Found while creating a new CentOS 7 guest from scratch using
> lcitool. See the commit messages for more details.
>
> Andrea Bolognani (2):
> Stop building Go projects on CentOS 7
> guests: Don't prepare CentOS 7 for Go projec
On Thu, Dec 20, 2018 at 04:41:32PM -0500, John Ferlan wrote:
Both found by Coverity...
Please, be kind if this send is messed up - I have a new laptop and
I'm slowly finding out all the things that I don't have on it that I
used to have on the old one.
John Ferlan (2):
security: Resolve possib
On Tue, Dec 18, 2018 at 03:03:14PM -0500, John Ferlan wrote:
Modify the generation of the command line to allow usage of a
new XML pool source directory "mount_opts" in order to allow (for
instance) starting an NFS pool with specific mount options.
We should not try to pretend to support passi
On Thu, Dec 20, 2018 at 09:20 PM +0100, Michal Prívozník
wrote:
> On 12/18/18 12:18 PM, Michal Privoznik wrote:
>
>> Otherwise looking good. I agree with Martin that this might not be the
>> best solution but it's the best we have (also, the problem is not on our
>> side).
>>
>> ACK (will wait a
[...]
>>>
>>> By the way the patch works only for -blockdev configuration which is
>>> available since QEMU 2.10 AFAIK. So we could purse to support 2.10, 2.11,
>>> 2.12 and 3.0 version in principle.
>>
>> Ah true, the --blockdev option is required.
>>
>> I've put the "artificial" point in time of
On 12/21/18 3:23 AM, Nikolay Shirokovskiy wrote:
>
>
> On 20.12.2018 23:31, John Ferlan wrote:
>>
>>
>> On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
>>> In case of active persistent domain snapshot metadata is
>>> not complete. We save only active configuration and on
>>> restore use it bo
On Thu, Dec 20, 2018 at 09:15 PM +0100, Michal Prívozník
wrote:
> On 12/20/18 12:48 PM, Marc Hartmayer wrote:
>> On Wed, Dec 19, 2018 at 03:37 PM +0100, Michal Privoznik
>> wrote:
>>> On 12/19/18 2:54 PM, Ján Tomko wrote:
Reviewed-by: Ján Tomko
>>>
>>> Thanks to you and Dan. I've pus
On 12/21/18 10:32 AM, Marc Hartmayer wrote:
> On Thu, Dec 20, 2018 at 09:15 PM +0100, Michal Prívozník
> wrote:
>> On 12/20/18 12:48 PM, Marc Hartmayer wrote:
>>> On Wed, Dec 19, 2018 at 03:37 PM +0100, Michal Privoznik
>>> wrote:
On 12/19/18 2:54 PM, Ján Tomko wrote:
>
> Reviewe
On Fri, Dec 21, 2018 at 4:15 AM Andrea Bolognani wrote:
>
> At some point during the life of CentOS 7, the Go compiler
> and related packages appear to has been moved from out of
> the base repositories and into EPEL.
>
> Since as a rule we only rely on first-party repositories
> to fulfill build
28 matches
Mail list logo