Pulling in gnulib just for the header is rather
expensive, especially since that header does not require us
to link against gnulib. It's better to make the event-test
example be standalone by just open-coding a more limited form
of a verify() macro that depends on modern gcc (we have enough
CI
Since v1:
- push patch 1, 2 that had successful reviews
- new patch 1
- rewrite old patch 3 to remove all use of gnulib from examples/,
rather than being partitioned based on what uses config.h (in part
by reverting Jan's recent patch that added config.h everywhere)
Eric Blake (2):
examples:
Commit 0c6ad476 updated gnulib, which rearranged some of the
conditions in gnulib wrapper headers such that compilation
started failing on BSD systems when the normal system
tried to include another system header but instead got a
gnulib wrapper header in an incomplete state; this is because
In a VPATH build, is in the builddir, but it includes
from the top source directory; hence, we need to
keep the -I(top_srcdir) directive that was accidentally removed
from commit 7a879323 (the problem is not visible in an in-tree
build).
Signed-off-by: Eric Blake
---
Pushing as a
On 1/7/19 5:19 AM, Ján Tomko wrote:
> On Fri, Jan 04, 2019 at 02:12:19PM -0600, Eric Blake wrote:
>> Our use of INCLUDES in Makefile.am hearkens back to when we had to
>> cater to automake 1.9.6 (thanks, RHEL 5) which lacked AM_CPPFLAGS.
>> Modern Automake flags a warning that INCLUDES is
On 1/7/19 9:39 AM, Ján Tomko wrote:
> On Mon, Jan 07, 2019 at 09:11:03AM -0600, Eric Blake wrote:
>
> [...]
>
| $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[ ]"%s"//' \
| $(GREP) '[ ]"' && \
{ echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
>>>
>>> With the
On Wed, Dec 12, 2018 at 06:08:39PM +0100, Peter Krempa wrote:
Modify qemuBlockJobSyncBeginDisk to operate on qemuBlockt sJobDataPtr and
Also, s/Blockt s/Block/g
Jano
rename it accordingly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 11 +++
src/qemu/qemu_blockjob.h
On 1/3/19 3:19 PM, Erik Skultety wrote:
> Essentially, bring back the old behaviour as of commit eba36a38 which
> was later changed by commit ae06048bf5d. Even though all the stderr
> messages will eventually end up in the journal, we're not making use of
> the fields journald provides.
>
>
On Wed, Jan 02, 2019 at 03:08:32PM +0100, Pavel Hrdina wrote:
In cgroups v2 there is no devices controller, BPF should be used
instead.
Patches 3 - 12 will be squashed into single commit and they need to be
compiled together, I've separated them to make review easier.
Pavel Hrdina (19):
util:
On Wed, Dec 12, 2018 at 06:08:56PM +0100, Peter Krempa wrote:
Allow using the delayed dismiss of the job so that we can reap the state
even if libvirtd was not running when qemu emitted the job completion
event.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c| 2 +-
On Wed, Dec 12, 2018 at 06:08:55PM +0100, Peter Krempa wrote:
Allow using the node name to specify the base and top of the 'commit'
operation, allow specifying explicit job name and add support for
delayed dismiss of the job so that we can reap the state even if
libvirtd was not running when
On Wed, Dec 12, 2018 at 06:08:54PM +0100, Peter Krempa wrote:
Allow using the node name to specify the base of the 'stream' operation,
allow specifying explicit job name and add support for delayed dismiss
of the job so that we can reap the state even if libvirtd was not
running when qemu
On Wed, Dec 12, 2018 at 06:08:53PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
.../blockjob-blockdev-in.xml | 364 ++
.../blockjob-blockdev-out.xml | 1 +
tests/qemuxml2xmltest.c | 2 +
3 files changed, 367
On Wed, Dec 12, 2018 at 06:08:51PM +0100, Peter Krempa wrote:
Later on we'll format these values into the status XML so the from/to
string functions will come handy. The implementation also notes that
these will be used in the status XML to avoid somebody changing the
values.
Signed-off-by:
On Wed, Dec 12, 2018 at 06:08:52PM +0100, Peter Krempa wrote:
We need to store the block job state in the status XML so that we can
properly recover any data when reconnecting after startup and also in
the end to be able to do any transition of the backing chain that
happened while libvirt was
On Wed, Dec 12, 2018 at 06:08:50PM +0100, Peter Krempa wrote:
Add the job structure to the table when instantiating a new job and
remove it when it terminates/fails.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 31 ---
src/qemu/qemu_blockjob.h | 6
On Wed, Dec 12, 2018 at 06:08:49PM +0100, Peter Krempa wrote:
Block jobs currently belong to disks only so we can look up the block
job data for them in the corresponding disks. This won't be the case
when using blockdev as certain jobs don't even correspond to a disk and
most of them can run on
On Wed, Dec 12, 2018 at 06:08:48PM +0100, Peter Krempa wrote:
Currently the job name corresponds to the disk the job belongs to. For
jobs which will not correspond to disks we'll need to track the name
separately.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20
On Mon, Jan 07, 2019 at 09:11:03AM -0600, Eric Blake wrote:
[...]
| $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[ ]"%s"//' \
| $(GREP) '[ ]"' && \
{ echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
With the /dev/null changes removed or justified:
I hope that was the
On Wed, Dec 12, 2018 at 06:08:47PM +0100, Peter Krempa wrote:
And rename it in accordance with the change.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20 ++--
src/qemu/qemu_blockjob.h | 6 +++---
src/qemu/qemu_driver.c| 4 ++--
src/qemu/qemu_migration.c |
On Wed, Dec 12, 2018 at 06:08:46PM +0100, Peter Krempa wrote:
Now that the data is per-job, we don't really need to bother with
finishing the synchronous job handling if the job is already terminated.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 1 -
1 file changed, 1 deletion(-)
On Wed, Dec 12, 2018 at 06:08:45PM +0100, Peter Krempa wrote:
Rather than storing the presence of the blockjob in a flag we can bind
together the lifecycle of the job with the lifecycle of the object which
is tracking the data for it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c |
On 1/7/19 5:35 AM, Ján Tomko wrote:
> On Fri, Jan 04, 2019 at 02:12:20PM -0600, Eric Blake wrote:
>> Travis shows that clang (but not gcc) fails to build after our
>> recent gnulib updates, due to:
>>
>
> This is a BSD vs Linux thing, we use Travis to get Mac OS X coverage.
> I regulary build
On 1/7/19 5:00 AM, Ján Tomko wrote:
> On Thu, Jan 03, 2019 at 01:41:59PM -0600, Eric Blake wrote:
>> Similar to the gnulib changes we just incorporated into maint.mk,
>> it's time to use '$(VC_LIST) | xargs program' instead of
>> 'program $$($(VC_LIST))', in order to bypass the problem of hitting
On Wed, Dec 12, 2018 at 06:08:44PM +0100, Peter Krempa wrote:
Instead of passing in the disk information, pass in the job and name the
function accordingly.
Few callers needed to be modified to have the job pointer handy.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 20
On 1/4/19 9:22 AM, Ján Tomko wrote:
> Since gnulib commit 6954995d unistd.h is included via stdlib.h
> on BSD systems, which requires config.h to be included first.
>
> Add config.h to the files that use it.
>
> Part of this commit reverts commit 6ee918de7462a20947241ec817c4571d6b84a716
>
>
On Wed, Dec 12, 2018 at 06:08:43PM +0100, Peter Krempa wrote:
The processing function modifies the job state so it should make sure
that the variable holding the new state is cleared properly and not the
caller. The caller should only deal with the job state and not the
transition that happened.
On Wed, Dec 12, 2018 at 06:08:42PM +0100, Peter Krempa wrote:
The job error can be safely accessed in the job structure, so we don't
need to propagate it through qemuBlockJobUpdateDisk.
Drop the propagation and refactor any caller that pased non-NULL error.
Signed-off-by: Peter Krempa
---
On Wed, Dec 12, 2018 at 06:08:41PM +0100, Peter Krempa wrote:
The same message is reported in 3 distinct places. Move it out into a
single function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 43 ---
1 file changed, 18 insertions(+), 25
On Wed, Dec 12, 2018 at 06:08:40PM +0100, Peter Krempa wrote:
Add a field tracking the current state of job so that it can be queried
later. Until now the job state e.g. that the job is _READY for
finalizing was tracked only for mirror jobs. Add tracking of state for
all jobs.
Similarly to
On Wed, Dec 12, 2018 at 06:08:39PM +0100, Peter Krempa wrote:
Modify qemuBlockJobSyncBeginDisk to operate on qemuBlockt sJobDataPtr and
rename it accordingly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 11 +++
src/qemu/qemu_blockjob.h | 2 +-
src/qemu/qemu_driver.c
On 12/28/18 8:01 PM, Julio Faracco wrote:
> LXC was using a single data structure to define all LXC NICs. In terms
> of optimization it is very interesting, but it is not useful when you
> use a index to define networks. After major release 3.0, LXC adopted
> indexes for network definitions. So,
On Wed, Dec 12, 2018 at 06:08:38PM +0100, Peter Krempa wrote:
Don't split out individual fields, just pass in the job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
Reviewed-by: Ján Tomko
Jano
On Wed, Dec 12, 2018 at 06:08:37PM +0100, Peter Krempa wrote:
We can properly track the job type when starting the job so that we
don't have to infer it later.
This patch also adds an enum of block job types specific to qemu
(qemuBlockjobType) which mirrors the public block job types
On Mon, Jan 07, 2019 at 14:35:08 +0100, Ján Tomko wrote:
> On Wed, Dec 12, 2018 at 06:08:34PM +0100, Peter Krempa wrote:
> > Rather than direclty modifying fields in the qemuBlockJobDataPtr
>
> directly
>
> > structure add a bunch of fields which allow to do the transitions.
> >
> > This will
On Wed, Dec 12, 2018 at 06:08:36PM +0100, Peter Krempa wrote:
Block jobs can also happen on objects which are not a disk at a given
point (e.g. the frontend was not hotplugged yet) and thus will be
eventually kept separately. Add a reference back to the disk for
blockjobs which do correspond to
On Wed, Dec 12, 2018 at 06:08:35PM +0100, Peter Krempa wrote:
If the job wasn't started, we don't need to end the synchronous job. Add
a note and drop the unnecessary calls.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 4 +++-
src/qemu/qemu_migration.c | 8 ++--
2 files
On Wed, Dec 12, 2018 at 06:08:34PM +0100, Peter Krempa wrote:
Rather than direclty modifying fields in the qemuBlockJobDataPtr
directly
structure add a bunch of fields which allow to do the transitions.
This will help later when adding more complexity to the job handing.
handling
APIs
On Wed, Dec 12, 2018 at 06:08:33PM +0100, Peter Krempa wrote:
Extract the disk mirroring startup code from the loop into a separate
function to allow cleaner cleanup paths.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 85 +--
1 file changed, 55
On Wed, Dec 12, 2018 at 06:08:32PM +0100, Peter Krempa wrote:
The field is used to note the state the job has transitioned to while
handling the blockjob state change event. Rename the field so that it's
obvious that this is the new state and not the general state of the
blockjob.
On Wed, Dec 12, 2018 at 06:08:31PM +0100, Peter Krempa wrote:
Reference counting will simplify semantics of the lifecycle of the
object.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 33 -
src/qemu/qemu_blockjob.h | 5 +++--
src/qemu/qemu_domain.c
On Wed, Dec 12, 2018 at 06:08:30PM +0100, Peter Krempa wrote:
When cancelling job after a reconnect we can now use the disk block job
state rather than having to re-detect it in the migration code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 63
On 1/7/19 9:08 AM, Han Han wrote:
>
> Han Han (2):
> news: Add support for "stibp" x86_64 feature
> news: Add support for postcopy-requests migration statistics
>
> docs/news.xml | 19 +++
> 1 file changed, 19 insertions(+)
>
ACKed and pushed (after polished a bit).
Also, s/comlpleted/completed/ in the subject.
On Wed, Dec 12, 2018 at 06:08:26PM +0100, Peter Krempa wrote:
qemuBlockJobEventProcessLegacy was getting too big. Remove handling of
completed jobs in a separate function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 118
On Sat, 2018-12-22 at 01:36 -0500, Neal Gompa wrote:
> On Fri, Dec 21, 2018 at 4:15 AM Andrea Bolognani wrote:
> > At some point during the life of CentOS 7, the Go compiler
> > and related packages appear to has been moved from out of
> > the base repositories and into EPEL.
> >
> > Since as a
On Fri, Jan 04, 2019 at 02:12:20PM -0600, Eric Blake wrote:
Travis shows that clang (but not gcc) fails to build after our
recent gnulib updates, due to:
This is a BSD vs Linux thing, we use Travis to get Mac OS X coverage.
I regulary build with clang and did not hit such error.
CC
On Fri, Jan 04, 2019 at 02:12:18PM -0600, Eric Blake wrote:
Commit c0a8ea45 removed the use of gettextize, and the setting of
GETTEXT_CPPFLAGS, but did not scrub the now-unused variable from
Makefile.am snippets.
Signed-off-by: Eric Blake
---
gnulib/lib/Makefile.am | 2 --
On Fri, Jan 04, 2019 at 02:12:19PM -0600, Eric Blake wrote:
Our use of INCLUDES in Makefile.am hearkens back to when we had to
cater to automake 1.9.6 (thanks, RHEL 5) which lacked AM_CPPFLAGS.
Modern Automake flags a warning that INCLUDES is deprecated, and
now that we mandate RHEL 7 or better
On Thu, Jan 03, 2019 at 01:41:59PM -0600, Eric Blake wrote:
Similar to the gnulib changes we just incorporated into maint.mk,
it's time to use '$(VC_LIST) | xargs program' instead of
'program $$($(VC_LIST))', in order to bypass the problem of hitting
argv limits due to our large set of files.
On Thu, Jan 03, 2019 at 01:41:58PM -0600, Eric Blake wrote:
We already used $(GREP) in some places, but might as well use it
everywhere during syntax check, in line with similar recent gnulib
changes.
---
cfg.mk | 54 +++---
1 file changed, 27
On Thu, Jan 03, 2019 at 01:41:57PM -0600, Eric Blake wrote:
In particular, this incorporates Roman's patches to allow
'make syntax-check' to work on BSD with its exec argv
limitations that previously failed when trying to grep the
large number of files present in libvirt.
cfg.mk needs similar
On 12/24/18 4:11 PM, Daniel P. Berrangé wrote:
> The use of 'lxc://' was mistakenly broken in:
>
> commit 4c8574c85c554e68de0d8bf9b85727954a5bea91
> Author: Daniel P. Berrangé
> Date: Wed Mar 28 12:49:29 2018 +0100
>
> driver: ensure NULL URI isn't passed to drivers with whitelisted
On 12/2/18 10:54 AM, Michal Prívozník wrote:
> Dear list,
>
Just a friendly reminder to update the page. In a week I'll start
filling out the organization application.
Thanks,
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This feature is introduced by 3f4914e0.
Signed-off-by: Han Han
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 78ae81e7ca..a4fc335a32 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -112,6 +112,15 @@
sibling
This feature is from eb1b551d.
Signed-off-by: Han Han
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 6a2a73b534..78ae81e7ca 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -102,6 +102,16 @@
the 'readonly'
Han Han (2):
news: Add support for "stibp" x86_64 feature
news: Add support for postcopy-requests migration statistics
docs/news.xml | 19 +++
1 file changed, 19 insertions(+)
--
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
56 matches
Mail list logo
