On 01/21/2019 08:13 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> [...]
>> VIR_ENUM_IMPL(virDomainRNGModel,
>>VIR_DOMAIN_RNG_MODEL_LAST,
>> - "virtio");
>> + "virtio",
>> + "virtio-transitional",
>> +
On 01/18/2019 10:54 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> [...]
>> @@ -1118,6 +1120,8 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[]
>> = {
>> {"virtio-blk-pci-non-transitional",
>> QEMU_CAPS_DEVICE_VIRTIO_BLK_NON_TRANSITIONAL},
>>
On 01/18/2019 09:20 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>> Add new model handling for virtio transitional devices. Ex:
>>
>>
>>
>>
>>
>> * "virtio-transitional" maps to qemu "virtio-net-pci-transitional"
>> * "virtio-non-transitional" maps to
On 1/21/19 7:59 AM, Ján Tomko wrote:
> Add a capability check to qemuDomainDefValidate and refuse to start
> a domain with VNC graphics if the TLS secret was set in qemu.conf
> and it's not supported.
>
> Note that qemuDomainSecretGraphicsPrepare does not generate any
> secret data if the capabi
On 1/21/19 7:59 AM, Ján Tomko wrote:
> Instead of hardcoding the TLS creds alias in
> qemuBuildGraphicsVNCCommandLine, store it
> in the domain private data.
>
> Given that we only support one VNC graphics
> and thus have only one alias per-domain,
> this is overengineered, but it will allow us
On 01/18/2019 08:35 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> [...]
>> @@ -11329,6 +11329,22 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr
>> xmlopt,
>> goto error;
>> }
>>
>> +/* NIC model (see -net nic,model=?). We only ch
On 01/18/2019 07:33 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>> +if (has_tmodel) {
>> +if (virQEMUCapsGet(qemuCaps, tmodel_cap))
>> +virBufferAddLit(buf, "-transitional");
>> +
>> +/* No error for if -transitional is not s
On 01/18/2019 07:33 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> [...]
>> @@ -1108,6 +1110,8 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[]
>> = {
>> { "vfio-ap", QEMU_CAPS_DEVICE_VFIO_AP },
>> { "zpci", QEMU_CAPS_DEVICE_ZPCI },
>>
On 01/18/2019 04:43 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>> The next release of QEMU is going to be 4.0.0. A bit early, but
>> this adds capabilities data for x86_64 from current qemu git
>> 15bede554162dda822cd762c689edb6fa32b6e3b
>>
>> Signed-off-b
On 01/18/2019 06:24 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>
> [...]
>
>
> So you got rid of the macro from RFC's 2/6 completely? Despite the
> code duplication issue I've pointed out at the time, I'd still
> rather see that macro being used, after
On Wed, Jan 16, 2019 at 11:45:09AM +, Mark McLoughlin wrote:
> PolicyKit authentication rules have switched to a JavaScript based
> format quite some time ago. See:
>
> http://davidz25.blogspot.com/2012/06/authorization-rules-in-polkit.html
>
> While backwards compat for the old .pkla format
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> This generates new XML like:
>
>
>
> virtio-transitional
> virtio-non-transitional
>
>
virtio should appear in the output as well...
[...]
> @@ -5286,6 +5286,13 @@ virQEMUCapsFillDomainDeviceDiskCap
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> +typedef enum {
> +VIR_DOMAIN_CONTROLLER_MODEL_VIRTIO_SERIAL_DEFAULT = -1,
> +VIR_DOMAIN_CONTROLLER_MODEL_VIRTIO_SERIAL_VIRTIO,
> +VIR_DOMAIN_CONTROLLER_MODEL_VIRTIO_SERIAL_VIRTIO_TRANSITIONAL,
> +VIR_DOMAIN_CONTROLLER_
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> Add devices. Ex:
>
>
>
> * "virtio-transitional" maps to qemu "virtio-scsi-pci-transitional"
> * "virtio-non-transitional" maps to qemu "virtio-scsi-non-transitional"
>
> The naming here doesn't match the pre-existing model=virtio-scs
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> @@ -1142,6 +1144,8 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[]
> = {
> {"virtio-balloon-pci-non-transitional",
> QEMU_CAPS_DEVICE_VIRTIO_BALLOON_NON_TRANSITIONAL},
> {"vhost-vsock-pci-transitional",
> QEMU_CA
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> +VIR_ENUM_IMPL(virDomainInputModel, VIR_DOMAIN_INPUT_MODEL_LAST,
> + "default",
> + "virtio",
> + "virtio-transitional",
> + "virtio-non-transitional")
Same comment as always for VIR
On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote:
> If a -drive has no image, using image properties makes qemu whine that
> they should not be used.
>
> This patch stops formating cache/readonly/... for empty drives
> for the pre-blockdev syntax. Unfortunately those parameters can't b
On Wed, Jan 16, 2019 at 10:42:09AM +0100, Peter Krempa wrote:
> Upcomming change will influence CDROM with cache mode so add a test
> case.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2argvdata/disk-cdrom.args | 4 +++-
> tests/qemuxml2argvdata/disk-cdrom.x86_64-2.12.0.arg
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> @@ -893,7 +893,9 @@ VIR_ENUM_IMPL(virDomainIOMMUModel,
> VIR_DOMAIN_IOMMU_MODEL_LAST,
>
> VIR_ENUM_IMPL(virDomainVsockModel, VIR_DOMAIN_VSOCK_MODEL_LAST,
>"default",
> - "virtio")
> + "virt
On Mon, Jan 21, 2019 at 03:23:59PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 21, 2019 at 03:13:20PM +, Richard W.M. Jones wrote:
> > GCC 9 complains:
> >
> > nwfilter/nwfilter_dhcpsnoop.c: In function 'virNWFilterDHCPSnoopThread':
> > nwfilter/nwfilter_dhcpsnoop.c:1456:31: error: converti
On Mon, Jan 21, 2019 at 15:13:21 +, Richard W.M. Jones wrote:
> GCC 9 gives pages of errors like:
>
> qemumonitorjsontest.c: In function 'mymain':
> qemumonitorjsontest.c:2904:9: error: jump skips variable initialization
> [-Werror=jump-misses-init]
> 2904 | goto cleanup;
> |
On Wed, Jan 16, 2019 at 10:42:08AM +0100, Peter Krempa wrote:
See patch 2/2 for explanation.
Peter Krempa (2):
tests: qemuxml2argv: Add test case for empty CDROM with cache mode
qemu: command: Don't format image properties for empty -drive
src/qemu/qemu_command.c | 47 ++
On Mon, Jan 21, 2019 at 03:13:21PM +, Richard W.M. Jones wrote:
> GCC 9 gives pages of errors like:
>
> qemumonitorjsontest.c: In function 'mymain':
> qemumonitorjsontest.c:2904:9: error: jump skips variable initialization
> [-Werror=jump-misses-init]
> 2904 | goto cleanup;
> |
On Wed, Jan 16, 2019 at 12:15:51 +, Daniel Berrange wrote:
> On Wed, Jan 16, 2019 at 01:12:01PM +0100, Peter Krempa wrote:
> > On Wed, Jan 16, 2019 at 09:52:42 +, Daniel Berrange wrote:
> > > On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote:
> > > > If a -drive has no image, usi
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Message-id: 20190121151321.6259-1-rjo...@redhat.com
Subject: [libvirt] [PATCH 0/2] A couple of GCC 9 fixes.
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will b
Add documentation that the 'VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB' flag
is auto-assumed if the block copy job is started while the VM is
transient and remove the restriction to define the domain when copy
is running.
Signed-off-by: Peter Krempa
---
src/libvirt-domain.c | 13 ++---
src/qe
The transition to the ready state is best observed by events as it's
ansynchronous and does not hint users to do polling. As currently only
the qemu driver supports block copy and block commit and the ready state
event was introduced by qemu 1.3 we can fully switch to the new
approach.
Signed-off-
Modernize documentation for our APIs and clean up some old cruft.
Some of those may be slightly controversial.
Peter Krempa (3):
qemu: Don't reject making domain persistent if block copy is running
lib: Clarify that any block job may block VM save or device detach
lib: domain: Emphasise tha
The documentation was only referring to a copy job, but in fact any
running blockjob will have the same results.
Signed-off-by: Peter Krempa
---
src/libvirt-domain.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index c155
On Mon, Jan 21, 2019 at 03:13:20PM +, Richard W.M. Jones wrote:
> GCC 9 complains:
>
> nwfilter/nwfilter_dhcpsnoop.c: In function 'virNWFilterDHCPSnoopThread':
> nwfilter/nwfilter_dhcpsnoop.c:1456:31: error: converting a packed
> 'virNWFilterSnoopEthHdrPtr' {aka 'struct _virNWFilterSnoopEthHd
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> +++ b/docs/formatdomain.html.in
> @@ -7902,6 +7902,8 @@ qemu-kvm -net nic,model=? /dev/null
>
>
>'virtio' - default with QEMU/KVM
> + 'virtio-transitional'
> + 'virtio-non-transitional'
GCC 9 complains:
nwfilter/nwfilter_dhcpsnoop.c: In function 'virNWFilterDHCPSnoopThread':
nwfilter/nwfilter_dhcpsnoop.c:1456:31: error: converting a packed
'virNWFilterSnoopEthHdrPtr' {aka 'struct _virNWFilterSnoopEthHdr *'} pointer
(alignment 1) to 'const u_char *' {aka 'const unsigned char *'}
I'm not 100% confident about either of these patches, so
please take care with them. I also think the second patch
is probaby best fixed by disabling the warning, or else a
much more fundamental rewrite of the test.
Rich.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
GCC 9 gives pages of errors like:
qemumonitorjsontest.c: In function 'mymain':
qemumonitorjsontest.c:2904:9: error: jump skips variable initialization
[-Werror=jump-misses-init]
2904 | goto cleanup;
| ^~~~
qemumonitorjsontest.c:3111:2: note: label 'cleanup' defined here
31
On Mon, 2019-01-21 at 12:56 +, Daniel P. Berrangé wrote:
> The %{extra_release} field was previously populated by data from the old
> autobuild.sh file but is no longer used.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> libvirt.spec.in | 2 +-
> mingw-libvirt.spec.in | 2 +-
> 2 files
Similar to what commit 86dba8f3 did for virPortAllocatorRelease,
ignore port 0 in virPortAllocatorSetUsed.
For all the reasonable use cases the callers already check that
the port is non-zero, however if the port from the XML overflows
unsigned short and turns into 0, it can be set as used by
virP
On Mon, Jan 21, 2019 at 03:12:28PM +0100, Ján Tomko wrote:
> On Mon, Jan 21, 2019 at 03:05:30PM +0100, Erik Skultety wrote:
> > On Mon, Jan 21, 2019 at 02:56:14PM +0100, Ján Tomko wrote:
> > > Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
> > > to get rid of the cleanup section.
>
On Mon, Jan 21, 2019 at 02:06:37PM +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
>
> Pushed under the "fix the previous build breaker fix" rule :-( Sorry.
That would explain the ubuntu build failure, thanks.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
ht
On Mon, Jan 21, 2019 at 03:05:30PM +0100, Erik Skultety wrote:
On Mon, Jan 21, 2019 at 02:56:14PM +0100, Ján Tomko wrote:
Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.
Requested-by: John Ferlan
Signed-off-by: Ján Tomko
---
src/qemu/qemu_con
Signed-off-by: Daniel P. Berrangé
---
Pushed under the "fix the previous build breaker fix" rule :-( Sorry.
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 567721f424..823f0753ae 100644
--- a/libvirt.spec.in
+++ b/libvi
On Mon, Jan 21, 2019 at 02:56:13PM +0100, Ján Tomko wrote:
> Ján Tomko (4):
> virQEMUDriverConfigLoadProcessEntry: use VIR_AUTOFREE
> virQEMUDriverConfigLoadNVRAMEntry: use VIR_AUTOFREE
> virQEMUDriverConfigLoadSecurityEntry: use VIR_AUTOFREE
> virQEMUDriverConfigLoadSWTPMEntry: use VIR_AUT
On Mon, Jan 21, 2019 at 02:56:14PM +0100, Ján Tomko wrote:
> Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
> to get rid of the cleanup section.
>
> Requested-by: John Ferlan
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_conf.c | 45 +++-
Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.
Requested-by: John Ferlan
Signed-off-by: Ján Tomko
---
src/qemu/qemu_conf.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qem
Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.
Requested-by: John Ferlan
Signed-off-by: Ján Tomko
---
src/qemu/qemu_conf.c | 45 +++--
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/src/q
Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.
Requested-by: John Ferlan
Signed-off-by: Ján Tomko
---
src/qemu/qemu_conf.c | 52 +++-
1 file changed, 23 insertions(+), 29 deletions(-)
diff --git
Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.
Requested-by: John Ferlan
Signed-off-by: Ján Tomko
---
src/qemu/qemu_conf.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/q
Ján Tomko (4):
virQEMUDriverConfigLoadProcessEntry: use VIR_AUTOFREE
virQEMUDriverConfigLoadNVRAMEntry: use VIR_AUTOFREE
virQEMUDriverConfigLoadSecurityEntry: use VIR_AUTOFREE
virQEMUDriverConfigLoadSWTPMEntry: use VIR_AUTOFREE
src/qemu/qemu_conf.c | 131 +-
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> If we validate that memballoon is NONE or VIRTIO earlier,
> we can simplify some checks in some driver APIs
Moving checks from the command line generation step to the domain
validation step - that's what I'm talking about! \o/
[...]
> +
On Mon, Jan 21, 2019 at 01:07:14PM +, Radostin Stoyanov wrote:
Signed-off-by: Radostin Stoyanov
---
config-post.h | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.red
On Fri, 2019-01-18 at 11:44 +, Daniel P. Berrangé wrote:
> For QEMU the element currently implies the 9p filesystem
> passthrough impl.
>
> We already have a need to reuse it for USB-MTP filesystem sharing,
> and quite soon we'll have to support virtio-fs too. The virtio-fs
> module is essent
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> +VIR_ENUM_IMPL(virDomainFSModel, VIR_DOMAIN_FS_MODEL_LAST,
> + "default",
> + "virtio",
> + "virtio-transitional",
> + "virtio-non-transitional")
Here as well, you can have
VIR_EN
On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> VIR_ENUM_IMPL(virDomainRNGModel,
>VIR_DOMAIN_RNG_MODEL_LAST,
> - "virtio");
> + "virtio",
> + "virtio-transitional",
> + "virtio-non-transitional");
Since you're tou
Signed-off-by: Radostin Stoyanov
---
config-post.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/config-post.h b/config-post.h
index dd4ef8fc0b..54731feff7 100644
--- a/config-post.h
+++ b/config-post.h
@@ -69,7 +69,6 @@
# undef WITH_VIRTUALPORT
# undef WITH_SECDRIVER_SELINUX
# undef WITH
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/conf/domain_conf.c | 9 -
src/conf/domain_conf.h | 3 +++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 761f9bffef..54d6364f4f 100644
--- a/src/conf/domain_con
Be generic instead of trying to enumerate all the involved
device types.
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 855bd9cb14..4f45773d
Add a capability check to qemuDomainDefValidate and refuse to start
a domain with VNC graphics if the TLS secret was set in qemu.conf
and it's not supported.
Note that qemuDomainSecretGraphicsPrepare does not generate any
secret data if the capability is not present and qemuBuildTLSx509BackendProp
A helper function for allocating the virDomainGraphicsDef structure.
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/conf/domain_conf.c | 23 +++
src/conf/domain_conf.h | 2 ++
2 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c
Add an option that lets the user specify the secret
that unlocks the server TLS key.
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/qemu/libvirtd_qemu.aug | 1 +
src/qemu/qemu.conf | 6 ++
src/qemu/qemu_conf.c | 4
src/qemu/qemu_conf.h
Use the password stored in the secret driver under
the uuid specified by the vnc_tls_x509_secret_uuid
option in qemu.conf.
https://bugzilla.redhat.com/show_bug.cgi?id=1602418
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/qemu/qemu_command.c | 11 +-
src/qe
Also introduce the necessary callbacks.
Signed-off-by: Ján Tomko
Reviewed-by: John Ferlan
---
src/qemu/qemu_domain.c | 39 +++
src/qemu/qemu_domain.h | 12
2 files changed, 51 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_dom
Instead of hardcoding the TLS creds alias in
qemuBuildGraphicsVNCCommandLine, store it
in the domain private data.
Given that we only support one VNC graphics
and thus have only one alias per-domain,
this is overengineered, but it will allow us
to prepare the secret upfront when we start
supportin
For:
https://bugzilla.redhat.com/show_bug.cgi?id=1602418
v1:
https://www.redhat.com/archives/libvir-list/2019-January/msg00490.html
v2:
* fixed memory leaks pointed out by John in v1
Patches without R-b:
[4/8] cowardly refused to unref the private data in Secret.*Destroy
[8/8] fixed the logic to i
The %{extra_release} field was previously populated by data from the old
autobuild.sh file but is no longer used.
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 2 +-
mingw-libvirt.spec.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/lib
On Thu, Jan 17, 2019 at 11:08:03AM -0500, John Ferlan wrote:
On 1/16/19 2:41 AM, Ján Tomko wrote:
Instead of hardcoding the TLS creds alias in
qemuBuildGraphicsVNCCommandLine, store it
in the domain private data.
Given that we only support one VNC graphics
and thus have only one alias per-dom
Ceph in upstream and Fedora has dropped support for building on host
architectures which are 32-bit.
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix for RPM builds
libvirt.spec.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index b04c
Device attribute does not have dotted "portAddr" format. Instead it
has single number format described but "usbAddr" which corresponds
to device parsing code in virDomainHostdevSubsysUSBDefParseXML.
Looks like [1] mistakenly changed device format for hostdev devices.
And [2] copy-n-paste this for
66 matches
Mail list logo
