Re: [libvirt] [PATCH 2/2] security: aa-helper: generate more rules for gl devices

On Tue, 12 Feb 2019, Christian Ehrhardt wrote: > Change fb01e1a44 "virt-aa-helper: generate rules for gl enabled > graphics devices" implemented the detection for gl enabled > devices in virt-aa-helper. But further testing showed > that it will need much more access for the full gl stack > to

Re: [libvirt] [PATCH 1/2] security: aa-helper: allow virt-aa-helper to read /dev/dri

On Tue, 12 Feb 2019, Christian Ehrhardt wrote: > Change fb01e1a44 "virt-aa-helper: generate rules for gl enabled > graphics devices" implemented the detection for gl enabled > devices in virt-aa-helper. But it will in certain cases e.g. if > no rendernode was explicitly specified need to read

Re: [libvirt] [PATCH] conf: make virPCIDeviceAddressFormat void

On 2/15/19 12:46 PM, Daniel P. Berrangé wrote: Only one of the three callers of virPCIDeviceAddressFormat correctly handles an error return status. Fortunately it can't fail so can be made void. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump -- libvir-list mailing list

[libvirt] [PATCH] nwfilter: allow for different format of IPv6 netmask/prefix in ebtables output

The iptables-ebtables package is meant as a drop-in replacement for the native ebtables package, but it formats some items in the -L output differently, leading to failure of scripts that depend on the output of ebtables -L. In particular: with old ebtables IPv6 prefixes are output as a netmask

[libvirt] [PATCH] conf: make virPCIDeviceAddressFormat void

Only one of the three callers of virPCIDeviceAddressFormat correctly handles an error return status. Fortunately it can't fail so can be made void. Signed-off-by: Daniel P. Berrangé --- src/conf/device_conf.c | 3 +-- src/conf/device_conf.h | 6 +++--- src/conf/domain_conf.c

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

On 2/15/19 10:51 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 02:56:31PM +, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: On Mon,

Re: [libvirt] [PATCH v4 00/17] Add authorization support to all network services

mis-fire. Ignore this one, I used the wrong base branch to git-publish and didn't interrupt it quickly enough Re-posted v4 with correct base. On Fri, Feb 15, 2019 at 05:13:28PM +, Daniel P. Berrangé wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html > v2:

[libvirt] [PATCH v4 5/6] vnc: allow specifying a custom authorization object name

From: "Daniel P. Berrange" The VNC server has historically had support for ACLs to check both the SASL username and the TLS x509 distinguished name. The VNC server was responsible for creating the initial ACL, and the client app was then responsible for populating it with rules using the HMP

[libvirt] [PATCH v4 6/6] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

The various ACL related commands are obsolete now that the QAuthZ framework for authorization is fully integrated throughout QEMU network services. Mark it as deprecated with no replacement to be provided. Authorization is now provided by using 'object_add' together with the 'tls-authz' or

[libvirt] [PATCH v4 1/6] qemu-nbd: add support for authorization of TLS clients

From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use the NBD server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a

[libvirt] [PATCH v4 2/6] nbd: allow authorization with nbd-server-start QMP command

From: "Daniel P. Berrange" As with the previous patch to qemu-nbd, the nbd-server-start QMP command also needs to be able to specify authorization when enabling TLS encryption. First the client must create a QAuthZ object instance using the 'object-add' command: { 'execute':

[libvirt] [PATCH v4 3/6] migration: add support for a "tls-authz" migration parameter

From: "Daniel P. Berrange" The QEMU instance that runs as the server for the migration data transport (ie the target QEMU) needs to be able to configure access control so it can prevent unauthorized clients initiating an incoming migration. This adds a new 'tls-authz' migration parameter that is

[libvirt] [PATCH v4 4/6] chardev: add support for authorization for TLS clients

From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use a chardev server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a

[libvirt] [PATCH v4 00/17] Add authorization support to all network services

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html This series builds on the core authorization framework: v8:

[libvirt] [PATCH v4 0/6] Add authorization support to all network services

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html This series builds on the core authorization framework: v8:

[libvirt] [PATCH v4 01/17] util: add helper APIs for dealing with inotify in portable manner

The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Wrapping it also allows introduction of a platform portability layer, so that we can add impls for non-Linux based equivalents in

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

On Mon, Feb 11, 2019 at 02:56:31PM +, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: > > On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: > > > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > > > > On Mon, Feb 11, 2019, 5:50 AM Daniel P.

Re: [libvirt] [PATCH 1/2] rpc: client: fix race on stream error and stream creation

Below is patch that simulates race behaviour. Let's add delay on replying to virDomainOpenConsole and report error for console stream immediately. For this let's use IO helper thread for console fd stream. With this patch you'll get next error in interactive virsh session: (note that a generated

[libvirt] [PATCH 2/2] tools: console: pass stream/fd errors to user

If console disconnected due to connection problem or problem on server side for example it is convinient to provide the cause to the user. If error comes from API then error is saved in virsh global variable but as we return success from virshRunConsole if we reach waiting stage then error is

[libvirt] [PATCH 0/2] tools: console: a fix and improvment

Nikolay Shirokovskiy (2): tools: console: cleanup console on errors in main thread tools: console: pass stream/fd errors to user tools/virsh-console.c | 220 ++ 1 file changed, 169 insertions(+), 51 deletions(-) -- 1.8.3.1 -- libvir-list

[libvirt] [PATCH 1/2] tools: console: cleanup console on errors in main thread

We only check now for virObjectWait failures in virshRunConsole but we'd better check and for other failures too. Anyway if failure happened we need to shutdown console to stop delivering events from event loop thread or we are in trouble as console is freed on virshRunConsole exit. And we need

[libvirt] [PATCH 1/2] rpc: client: fix race on stream error and stream creation

Message of API call that creates stream and stream itself have same rpc serial. This can lead to issues. If stream got error immediately after creation then notification can be delivered before API call reply arrived. This is possible because the reply and the error message are sent from different

[libvirt] [PATCH 2/2] rpc: client: stream: notify streams of closing connection

It not done yet. As a result if we doing 'virsh console' and libvirtd is killed we get [1] message as virsh tracks connection status but virsh itself won't exit because it won't get notification that stream is broken. Only after we press a key and virsh tries to write that key code to stream we

[libvirt] [PATCH 0/2] rpc: client: stream bugfix and improvement

Nikolay Shirokovskiy (2): rpc: client: fix race on stream error and stream creation rpc: client: stream: notify streams of closing connection src/rpc/virnetclient.c | 13 ++--- src/rpc/virnetclientstream.c | 30 -- src/rpc/virnetclientstream.h | 2

Re: [libvirt] [PATCH 3/7] conf: Introduce virDomainDiskDefPostParse()

On Fri, 2019-02-15 at 14:25 +0100, Ján Tomko wrote: > On Fri, Feb 15, 2019 at 12:55:48PM +0100, Andrea Bolognani wrote: > > @@ -4855,6 +4855,51 @@ virDomainRNGDefPostParse(virDomainRNGDefPtr rng) > > return 0; > > } > > > > + > > ^ Whitespace Watch would worry. That's because I added one

Re: [libvirt] [PATCH 7/7] conf: Rework virDomainDeviceDefPostParseCommon()

On Fri, Feb 15, 2019 at 12:55:52PM +0100, Andrea Bolognani wrote: Now that we've moved all the actual code into helper functions, we can turn it into a switch statement. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 77 +++--- 1 file changed,

Re: [libvirt] [PATCH 5/7] conf: Introduce virDomainControllerDefPostParse()

On Fri, Feb 15, 2019 at 12:55:50PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 6/7] conf: Introduce virDomainNetDefPostParse()

On Fri, Feb 15, 2019 at 12:55:51PM +0100, Andrea Bolognani wrote: Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 4/7] conf: Introduce virDomainVideoDefPostParse()

On Fri, Feb 15, 2019 at 12:55:49PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 3/7] conf: Introduce virDomainDiskDefPostParse()

On Fri, Feb 15, 2019 at 12:55:48PM +0100, Andrea Bolognani wrote: Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 83 -- 1 file changed, 47 insertions(+), 36 deletions(-) diff --git

Re: [libvirt] [PATCH 2/7] conf: Introduce virDomainRNGDefPostParse()

On Fri, Feb 15, 2019 at 12:55:47PM +0100, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 74bb18d726..99319578f7

Re: [libvirt] [PATCH 1/7] conf: Introduce virDomainChrDefPostParse()

On Fri, Feb 15, 2019 at 12:55:46PM +0100, Andrea Bolognani wrote: Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 59 -- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git

[libvirt] [PATCH 4/5] util: Remove the AUTOPTR func for virStorageSource

Since virStorageSource is now a subclass of virObject, we can use VIR_AUTOUNREF instead. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c| 2 +- src/qemu/qemu_domain.c| 2 +- src/qemu/qemu_driver.c| 6 +++--- src/qemu/qemu_migration.c

[libvirt] [PATCH 2/5] util: storage: Turn virStorageSource into a virObject

To allow tracking a single virStorageSource in multiple structures without extra hassle allow refcounting by turining it into an object. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 40 +-- src/util/virstoragefile.h | 2 ++ 2 files changed, 32

[libvirt] [PATCH 1/5] util: Introduce function for allocating virStorageSource

Add virStorageSourceNew and refactor places allocating that structure to use the helper. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c| 10 +- src/conf/snapshot_conf.c | 4 ++-- src/conf/storage_conf.c | 2 +-

[libvirt] [PATCH 5/5] util: Replace virStorageSourceFree with virObjectUnref

Now that virStorageSource is a subclass of virObject we can use virObjectUnref and remove virStorageSourceFree which was a thin wrapper. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 src/conf/snapshot_conf.c | 2 +- src/libvirt_private.syms | 1 -

[libvirt] [PATCH 3/5] util: alloc: Introduce VIR_AUTOUNREF macro

Add helper for utilizing __attribute__(cleanup())) for unref-ing instances of sublasses of virObject. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/viralloc.h | 10 ++ src/util/virobject.c | 13 + src/util/virobject.h | 3 +++ 4

[libvirt] [PATCH 0/5] util: Turn virStorageSource into a virObject (blockdev-add saga)

In todays side story we witness the transmutation of virStorageSource into a virObject. Peter Krempa (5): util: Introduce function for allocating virStorageSource util: storage: Turn virStorageSource into a virObject util: alloc: Introduce VIR_AUTOUNREF macro util: Remove the AUTOPTR func

[libvirt] [PATCH 3/7] conf: Introduce virDomainDiskDefPostParse()

Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 83 -- 1 file changed, 47 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 5/7] conf: Introduce virDomainControllerDefPostParse()

Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4cfdfb230e..872cb3352b 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH 7/7] conf: Rework virDomainDeviceDefPostParseCommon()

Now that we've moved all the actual code into helper functions, we can turn it into a switch statement. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 77 +++--- 1 file changed, 58 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH 4/7] conf: Introduce virDomainVideoDefPostParse()

Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b794200e47..4cfdfb230e 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH 6/7] conf: Introduce virDomainNetDefPostParse()

Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 872cb3352b..7f66fa27ff 100644 ---

[libvirt] [PATCH 2/7] conf: Introduce virDomainRNGDefPostParse()

Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 74bb18d726..99319578f7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [PATCH 0/7] conf: Rework virDomainDeviceDefPostParseCommon()

Split actual functionality into a series of small helpers and turn it into a dispatcher. Andrea Bolognani (7): conf: Introduce virDomainChrDefPostParse() conf: Introduce virDomainRNGDefPostParse() conf: Introduce virDomainDiskDefPostParse() conf: Introduce virDomainVideoDefPostParse()

[libvirt] [PATCH 1/7] conf: Introduce virDomainChrDefPostParse()

Minor tweaks to ensure compliance with our coding style. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 59 -- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt] [PATCH] network: explicitly allow icmp/icmpv6 in libvirt zonefile

On Thu, Feb 14, 2019 at 02:46:22PM -0500, Laine Stump wrote: > The libvirt zonefile for firewalld (added in commit 3b71f2e4) does the > following: > > 1) lists specific services it wants to allow, then > > 2) uses a lower priority rule to block all other services to >the host, and then