On Fri, Feb 15, 2019 at 01:42:10PM +0100, Peter Krempa wrote:
> To allow tracking a single virStorageSource in multiple structures
> without extra hassle allow refcounting by turining it into an object.
>
> Signed-off-by: Peter Krempa
> ---
> src/util/virstoragefile.c | 40
On Fri, Feb 15, 2019 at 01:42:09PM +0100, Peter Krempa wrote:
> Add virStorageSourceNew and refactor places allocating that structure to
> use the helper.
>
> Signed-off-by: Peter Krempa
> ---
Looks like you caught all the occurrences but 1 in bhyve: bhyveParsePCIDisk
With that addressed too:
Add a bhyveDomainDefNeedsISAController() helper function
which by domain configuration determines whether LPC controller is
required or not.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 5 +
src/bhyve/bhyve_domain.c | 10 ++
src/bhyve/bhyve_domain.h | 2 ++
3
When domain configuration requires the 'isa' controller to be present,
automatically add it on domain post-parse stage.
Now, as this controller is always available when needed, it's not
necessary to implicitly add it to the bhyve command line, so remove
bhyveBuildLPCArgStr().
Also, make
Signed-off-by: Roman Bogorodskiy
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 8d6d58ae6a..e0c9c3590f 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -59,6 +59,16 @@
of the network's bridge element.
Support modeling of the 'isa' controller for bhyve. When controller is
not present in the domain XML, but domain requires it to be there (e.g.
because bootrom is used), implicitly add addition of this controller to
the command line arguments, and bind it to PCI slot 1.
PCI slot 1 is always
Introduce 'isa' controller type. The only supported model
now is 'isa-bridge'. In domain XML it looks this way:
...
...
Currently, this is needed for the bhyve driver to allow choosing a
specific PCI address for that. In bhyve, this controller is used to
attach serial
Changes from v1:
* Changed LPC controller type from PCI to ISA
* Split bhyve changes into smaller chunks
Also, I decided to keep PCI slot 1 reserved for LPC only,
even if users choose other slot for LPC. If things work fine,
it could be easily made available for other devices in future.
Roman
Document ability to specify LCP PCI-ISA bridge PCI address.
Signed-off-by: Roman Bogorodskiy
---
docs/drvbhyve.html.in | 22 ++
1 file changed, 22 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 2e9cf5551b..d31ce781cf 100644
---
