Simply move the big status enum comment block to above the status
function, and document it as being deprecated. The whole confusing
block can get deleted in three releases time.
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 36 +++-
1 file changed, 19
"Frozen" was a good description a long time ago, but it isn't adequate now.
Rename the frozen predicate to has_successor to make the semantics of the
predicate more clear to outside callers.
In the process, remove some calls to frozen() that no longer semantically
make sense. For
Currently, the enabled predicate means something like:
"the QAPI status of the bitmap is ACTIVE."
After this patch, it should mean exclusively:
"This bitmap is recording guest writes, and is allowed to do so."
In many places, this is how this predicate was already used.
Internal usages of the
The current API allows us to report a single status, which we've defined as:
Frozen: has a successor, treated as qmp_locked, may or may not be enabled.
Locked: no successor, qmp_locked. may or may not be enabled.
Disabled: Not frozen or locked, disabled.
Active: Not frozen, locked, or disabled.
Check that the bitmap is not in use prior to it checking if it is
not enabled/recording guest writes. The bitmap being busy was likely
at the behest of the user, so this error has a greater chance of being
understood by the user.
Signed-off-by: John Snow
---
nbd/server.c | 10 +-
1 file
This adds a simple test that ensures the busy bit works for push backups,
as well as doubling as bonus test for incremental backups that get interrupted
by EIO errors.
Recording bit tests are already handled sufficiently by 236.
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 110
These mean the same thing now. Unify them and rename the merged call
bdrv_dirty_bitmap_busy to indicate semantically what we are describing,
as well as help disambiguate from the various _locked and _unlocked
versions of bitmap helpers that refer to mutex locks.
Signed-off-by: John Snow
---
This field isn't present anymore.
Signed-off-by: John Snow
---
blockdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 1aaadb6128..cbce44877d 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1255,7 +1255,6 @@ out_aio_context:
* @node: The name of the BDS node
Instead of implying a user_locked/busy status, make it explicit.
Now, bitmaps in use by migration, NBD or backup operations
are all treated the same way with the same code paths.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
block/dirty-bitmap.c | 11 ++-
1 file changed, 6
The current internal meanings of "locked", "user_locked",
"qmp_locked", "frozen", "enabled", and "disabled" are all
a little muddled.
Deprecate the @status field in favor of two new booleans
that carry very specific meanings. Then, rename and rework
some of the internal semantics to help make the
bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an
internal API by the mirror and migration areas of our code. These
calls modify the bitmap, but do so at the behest of QEMU and not the
guest.
Presently, these bitmaps are always "enabled" anyway, but there's no
reason they have
On Fri, Feb 22, 2019 at 10:54:10AM -0600, Eric Blake wrote:
> On 2/22/19 10:43 AM, Daniel P. Berrangé wrote:
> > On Fri, Feb 22, 2019 at 04:32:27PM +0100, Erik Skultety wrote:
> >> Unfortunately, in order to support the new flags, the last patch
> >> introduces an
> >> API breakage as the
On 2/22/19 10:43 AM, Daniel P. Berrangé wrote:
> On Fri, Feb 22, 2019 at 04:32:27PM +0100, Erik Skultety wrote:
>> Unfortunately, in order to support the new flags, the last patch introduces
>> an
>> API breakage as the convention we use for the bindings is to also enforce
>> types
>> for flags.
On Fri, Feb 22, 2019 at 10:39:06AM -0600, Eric Blake wrote:
> On 2/22/19 9:32 AM, Erik Skultety wrote:
> > Unfortunately, in order to support the new flags, the last patch introduces
> > an
> > API breakage as the convention we use for the bindings is to also enforce
> > types
> > for flags.
>
On Fri, Feb 22, 2019 at 04:32:27PM +0100, Erik Skultety wrote:
> Unfortunately, in order to support the new flags, the last patch introduces an
> API breakage as the convention we use for the bindings is to also enforce
> types
> for flags.
Yes, unfortunately this need to break ABI is fallout
On 2/22/19 9:32 AM, Erik Skultety wrote:
> This breaks API compatibility! Recently libvirt introduced 2 new
> separate flag enums in order to stop recycling the old virDomainXMLFlags
> since 2/3 flags were discouraged to use. While it's fine for libvirt
> to introduce such a change since it uses
On Thu, Feb 21, 2019 at 03:39:15PM +0100, Erik Skultety wrote:
> number of test cases (and also many unnecessary legacy test cases). An
> alternative set of functional test cases is available as part of the
> libvirt-tck framework [2]. The obvious question now is how can we build upon
> any of
On 2/22/19 9:32 AM, Erik Skultety wrote:
> Unfortunately, in order to support the new flags, the last patch introduces an
> API breakage as the convention we use for the bindings is to also enforce
> types
> for flags.
Oh bummer - I didn't realize that some of the other language bindings
are
We'd free only the first element of the vector leaking the rest.
Signed-off-by: Peter Krempa
---
src/util/viralloc.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index 983a6e83d1..6de311259d 100644
--- a/src/util/viralloc.h
+++
VIR_DEFINE_AUTOPTR_FUNC defines a function which is supposed to free the
resources for the given VIR_AUTOPTR variable. Given that the cleanup
function is executed when the stack frame is being destroyed it does not
make much sense to set the pointer to NULL.
Making the inline function contain
VIR_AUTOLISTPTR allows you to define a pointer to a NULL-terminated list
of elements which will be auto-freed when destroying the scope.
This is done so that we can avoid using VIR_AUTOPTR in those cases as it
worked only for virStringList-related stuff.
Signed-off-by: Peter Krempa
---
VIR_AUTOPTR should not be used for vectors except for the rare case of
NULL-terminated lists. Convert all cases of usage of VIR_AUTOPTR for
'virString' to VIR_AUTOLISTPTR.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 2 +-
src/qemu/qemu_conf.c | 8
Document that VIR_AUTOPTR should not be used with vectors ...
Peter Krempa (4):
util: alloc: Remove pointless clearing of variable in AUTOPTR_FUNCs
util: alloc: Introduce macro for self-freeing NULL-terminated lists
util: string: Use VIR_AUTOLISTPTR for 'virString'
util: alloc: Note that
Signed-off-by: Erik Skultety
---
domain.go | 8 +++-
domain_compat.h | 4
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/domain.go b/domain.go
index 91b8399..9211b6e 100644
--- a/domain.go
+++ b/domain.go
@@ -817,6 +817,12 @@ const (
On Thu, Feb 21, 2019 at 09:45:31PM +0100, Jiri Denemark wrote:
Jiri Denemark (2):
cputest: Adapt scripts to split cpu_map
cputest: Use python3 in CPU parser scripts
tests/cputestdata/cpu-cpuid.py| 24 +++-
tests/cputestdata/cpu-reformat.py | 2 +-
2 files changed, 12
Signed-off-by: Erik Skultety
---
domain_compat.h | 4
domain_snapshot.go| 6 ++
domain_snapshot_wrapper.h | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/domain_compat.h b/domain_compat.h
index 9a30e8f..d5a3f78 100644
--- a/domain_compat.h
+++
This breaks API compatibility! Recently libvirt introduced 2 new
separate flag enums in order to stop recycling the old virDomainXMLFlags
since 2/3 flags were discouraged to use. While it's fine for libvirt
to introduce such a change since it uses plain 'int' for flags, not so
much for the Go
Unfortunately, in order to support the new flags, the last patch introduces an
API breakage as the convention we use for the bindings is to also enforce types
for flags.
Erik Skultety (3):
Introduce DomainSnapshotXMLFlags constant
Introduce DomainSaveImageXMLFlags constant
Enforce new flags
On 2/15/19 9:10 AM, Nikolay Shirokovskiy wrote:
> Message of API call that creates stream and stream itself have
> same rpc serial. This can lead to issues. If stream got error
> immediately after creation then notification can be delivered
> before API call reply arrived. This is possible
On 2/15/19 9:39 AM, Nikolay Shirokovskiy wrote:
> If console disconnected due to connection problem or problem on server
If the console was disconnected due to a connection problem or a problem
on the server
> side for example it is convinient to provide the cause to the user.
side it is
On 2/21/19 1:02 PM, Daniel P. Berrangé wrote:
On Fri, Feb 15, 2019 at 01:21:50PM -0500, Laine Stump wrote:
The iptables-ebtables package is meant as a drop-in replacement for
the native ebtables package, but it formats some items in the -L
output differently, leading to failure of scripts that
On 2/15/19 9:39 AM, Nikolay Shirokovskiy wrote:
> We only check now for virObjectWait failures in virshRunConsole but
> we'd better check and for other failures too. Anyway if failure
> happened we need to shutdown console to stop delivering events
> from event loop thread or we are in trouble
Signed-off-by: David Kiarie
---
src/xenconfig/xen_xl.c | 1 +
src/xenconfig/xen_xl.h | 1 +
tests/xlconfigtest.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
index accfc3a..64a5ddf 100644
--- a/src/xenconfig/xen_xl.c
+++
these patche follows up a very co-operative review on a preview patch or
lack of thereof.
i have updated this to reflect the exact name i use in person.
David Kiarie (1):
src/xenconfig: update copyright notice
src/xenconfig/xen_xl.c | 1 +
src/xenconfig/xen_xl.h | 1 +
tests/xlconfigtest.c
On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
> On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
> > it looks sensible that the copyright notice on the affected files in
> > updated as in this patch so as to also cover another party who hugely
> > participated in writing
On Fri, Feb 22, 2019 at 11:49:57AM +0300, David Kiarie wrote:
> On Fri, Feb 22, 2019 at 11:42 AM David Kiarie
> wrote:
>
> >
> >
> > On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark
> > wrote:
> >
> >> On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
> >> > On Thu, Feb 21, 2019 at
On Fri, Feb 22, 2019 at 12:08 PM Michal Privoznik
wrote:
> On 2/21/19 7:44 PM, David Kiarie wrote:
> > Signed-off-by: David Kiarie
> > ---
> > src/xenconfig/xen_xl.c | 1 +
> > src/xenconfig/xen_xl.h | 1 +
> > tests/xlconfigtest.c | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff
>
> Frankly, I find theese lines useless. Git blame tells you who wrote
>> which lines of code. I'm no laywer, but the way I understand copyrights
>> in GPL projects is that it comes important only if project wants to
>> change the licence (e.g. to BSD). Then it has to have confirmation from
>>
On Fri, Feb 22, 2019 at 11:42:04 +0300, David Kiarie wrote:
> On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark wrote:
>
> > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
> > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
> > > > it looks sensible that the copyright
We can purge any packages which expand to None straight away, and
simply convert to a set to get rid of duplicates.
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index
Debian's filesystem layout has a nice advantage over Fedora which is
that it can install non-native RPMs in the main root filesystem. It is
thus possible to prepare an x86_64 filesystem containing -dev packages
for a foreign architecture, along with a GCC cross compiler.
QEMU has used this
Signed-off-by: Daniel P. Berrangé
---
guests/lcitool | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index 35a6b68..5c2b785 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -550,18 +550,14 @@ class Application:
temp =
Replace all uses where virBuffer would need clearing on the cleanup
path.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Signed-off-by: Jiri Denemark
---
tests/cputestdata/cpu-cpuid.py| 16
tests/cputestdata/cpu-reformat.py | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/cputestdata/cpu-cpuid.py b/tests/cputestdata/cpu-cpuid.py
index 9ee83e0cd2..f532475702 100755
To prevent domains started with older libvirtd from disappearing, we
need to be able to parse the string representation of QEMU capabilities,
even if we no longer use them in the code.
Put those in a separate array where we won't bother with enum constants.
Signed-off-by: Ján Tomko
---
On Thu, Feb 21, 2019 at 11:48:56 -0600, Eric Blake wrote:
> On 2/21/19 9:50 AM, Peter Krempa wrote:
> > The new utility macros are useful for variables we put on the stack but
> > require some cleanup. The most prominent of those is virBuffer which is
> > used almost exclusively in that way.
> >
On 2/21/19 9:50 AM, Peter Krempa wrote:
> First 4 patches clean up existing mess.
>
> Note that this series both fixes and then deletes virBufferEscapeN.
> The split is deliberate, so that if somebody needs virBufferEscapeN
> in the future they can revert the removal and get a working version.
>
Jiri Denemark (2):
cputest: Adapt scripts to split cpu_map
cputest: Use python3 in CPU parser scripts
tests/cputestdata/cpu-cpuid.py| 24 +++-
tests/cputestdata/cpu-reformat.py | 2 +-
2 files changed, 12 insertions(+), 14 deletions(-)
--
2.20.1
--
libvir-list
On 2/21/19 12:55 PM, Eric Blake wrote:
> I wanted to do a demonstration with virsh batch mode, which
> takes multiple commands all packed into a single argument:
>
> Let's be more like the shell, and treat unquoted newline as a
> command separator just as we do for semicolon. In fact, with
>
On Fri, Feb 15, 2019 at 01:21:50PM -0500, Laine Stump wrote:
> The iptables-ebtables package is meant as a drop-in replacement for
> the native ebtables package, but it formats some items in the -L
> output differently, leading to failure of scripts that depend on the
> output of ebtables -L. In
virBuffer is almost always stack-allocated, but requires freeing of the
internals on error. Introduce a VIR_AUTOCLEAN function to deal with
this.
Along with the addition add a test which would leak the buffer contents
if it weren't autocleaned.
Signed-off-by: Peter Krempa
---
After running:
tests/group-qemu-caps.pl
the capabilities with numbers in the skip function will be dropped
from qemu_capabilities.[ch] and printed into
qemu_capabilities.[ch].dropped.
---
tests/group-qemu-caps.pl | 21 +
1 file changed, 21 insertions(+)
diff --git
The conversion to VIR_AUTOFREE of 'escapeList' introduced memory leak of
the copied item to be escaped:
==17517== 2 bytes in 1 blocks are definitely lost in loss record 1 of 32
==17517==at 0x483880B: malloc (vg_replace_malloc.c:309)
==17517==by 0x54D666D: strdup (in
Prepare for removal of deprecated flags from the capability
string array and quietly drop flags present in the deprecated
string array if they were not found in the main array.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 12 +---
1 file changed, 9 insertions(+), 3
Commit a1dce962 added the allocated scsiVPDDeviceId without freeing it.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f511193fca..74f34af292 100644
---
On Wed, 2019-02-20 at 14:20 +0100, Michal Privoznik wrote:
> The current naming makes it hard for me to see which holds the
> expected value and which holds the actual value. Rename them to
> make it obvious.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/testutils.c | 10 +-
> 1
On Fri, Feb 22, 2019 at 03:22:35PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > * deprecated QEMU_AUDIO_ env vars
> >
> > Libvirt does currently use these, so we'll need to update libvirt
> > code to use the new cli args
>
> Note: The old vars will continue to work, and possibly it makes
Hi,
> > * deprecated QEMU_AUDIO_ env vars
>
> Libvirt does currently use these, so we'll need to update libvirt
> code to use the new cli args
Note: The old vars will continue to work, and possibly it makes sense to
keep at least QEMU_AUDIO_DRV (which I think is the only one used by
On Fri, Feb 22, 2019 at 01:40:42PM +, Daniel P. Berrangé wrote:
> On Wed, Feb 20, 2019 at 10:37:32PM +0100, Kővágó, Zoltán wrote:
> > This patch adds documentation of an -audiodev command line option, that
> > deprecates the old QEMU_* environment variables for audio backend
> > configuration.
On 2/20/19 3:46 PM, Cole Robinson wrote:
> On 2/13/19 3:31 AM, Andrea Bolognani wrote:
>> On Fri, 2019-02-08 at 17:11 -0500, Cole Robinson wrote:
>>> v2 libvirt patches:
>>> https://www.redhat.com/archives/libvir-list/2019-January/msg00877.html
>>> v1 libvirt patches:
>>>
On 2/18/19 6:21 PM, Laine Stump wrote:
> This fixes a bug that has been present since the original version of
> the function was pushed in commit 1ab80f3 on Nov. 26 2010 (by me). The
> virSocketAddr::len was not being set.
>
> Apparently until now we were always calling
>
The element in zanata.xml is no longer relevant as this info
is recorded server side.
Signed-off-by: Daniel P. Berrangé
---
po/zanata.xml | 99 ---
1 file changed, 99 deletions(-)
diff --git a/po/zanata.xml b/po/zanata.xml
index 70cc22a..042c695
Signed-off-by: Daniel P. Berrangé
---
po/or.mini.po | 20 +
po/or.po | 153
po/pa.mini.po | 20 +
po/pa.po | 153
po/{pl.po => pl.mini.po}
Signed-off-by: Daniel P. Berrangé
---
po/mn.mini.po | 20 +++
po/mn.po | 153 -
po/mr.mini.po | 20 +++
po/mr.po | 153 -
po/ms.mini.po | 20 +++
po/ms.po | 153
Signed-off-by: Daniel P. Berrangé
---
po/sq.mini.po | 20 ++
po/sq.po| 153 ---
po/sr.mini.po | 21 ++
po/sr.po| 154
po/s...@latin.mini.po | 21 ++
Signed-off-by: Daniel P. Berrangé
---
po/cs.mini.po | 34 +-
po/fr.mini.po | 3 +++
2 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/po/cs.mini.po b/po/cs.mini.po
index 35389e7..4481728 100644
--- a/po/cs.mini.po
+++ b/po/cs.mini.po
@@ -23,7 +23,7
Signed-off-by: Daniel P. Berrangé
---
po/af.mini.po| 20 ++
po/af.po | 153 --
po/am.mini.po| 20 ++
po/am.po | 153 --
po/anp.mini.po | 19 ++
po/anp.po| 152
Signed-off-by: Daniel P. Berrangé
---
po/kw.mini.po | 20 ++
po/kw.po| 153 ---
po/k...@kkcor.mini.po | 20 ++
po/k...@kkcor.po | 153 ---
po/k...@uccor.mini.po | 20 ++
On Wed, Feb 20, 2019 at 09:46:58AM -0500, John Ferlan wrote:
Alter the logic to return @tmpnode to ctxt->node in both the error
and non-error path when calling virDomainNetIPInfoParseXML.
What is the motivation here?
On error, ctxt->node will be restored anyway to 'oldnode'.
Jano
Add a new function to output all of the domain's snapshots in one
buffer.
Signed-off-by: Eric Blake
---
src/conf/snapshot_conf.h | 8 +++-
src/conf/snapshot_conf.c | 39 +++
src/libvirt_private.syms | 1 +
3 files changed, 47 insertions(+), 1
On 2/20/19 10:37 AM, Ján Tomko wrote:
> On Wed, Feb 20, 2019 at 09:46:57AM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities cleaning up any
>> now unnecessary goto paths.
>
> My clang 7 and gcc 8.2 both happily compile code where the cleanup:
> label only contains
On Wed, Feb 20, 2019 at 09:46:57AM -0500, John Ferlan wrote:
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
My clang 7 and gcc 8.2 both happily compile code where the cleanup:
label only contains a return statement, the goto paths can be cleaned
When we create cgroup for qemu threads we need to enable cpuset
controller in order to use it.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroupv2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c
index 25afab1cad..4084929c5a 100644
---
On Wed, Feb 20, 2019 at 09:46:56AM -0500, John Ferlan wrote:
Make usage of VIR_STEAL_PTR in preparation for some autofree mods.
s/ in preparation for some autofree mods//g
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 162 ++---
1 file changed,
Make usage of VIR_STEAL_PTR in preparation for some autofree mods.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 162 ++---
1 file changed, 55 insertions(+), 107 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
On 2/20/19 9:53 AM, Eric Blake wrote:
> Right now, copying the state of a transient domain with snapshots
> from one host to another requires multiple API calls on both
> machines - on the host: get the domain XML, get a list of the
> snapshots, and then for each snapshot get the snapshot's XML;
>
On 2/20/19 5:05 AM, Marc Hartmayer wrote:
> Changelog:
> + RFC -> v1:
> - Remove the event handle in the error path of nodeStateInitializeEnumerate
> - Added patch 2: wake up udev thread in case of an error
>
> Marc Hartmayer (2):
> udev: nodeStateInitializeEnumerate: remove watch
Signed-off-by: Daniel P. Berrangé
---
po/de.mini.po | 20 +
po/de.po | 153
po/el.mini.po | 20 +
po/el.po | 153
po/{en_GB.po =>
On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote:
> On 2/20/19 2:37 AM, Michal Privoznik wrote:
> > On 2/19/19 9:19 PM, John Ferlan wrote:
> > > Assuming extraction (sigh) of the VIR_AUTOFREE,
> >
> > While I'd definitely want this to be split into two patches if it was
> > fixing something
On Wed, 2019-02-20 at 14:20 +0100, Michal Privoznik wrote:
> In order to save a few lines of code, and also since it's hype
https://i.imgflip.com/2u5fpr.jpg
> let's use VIR_AUTOFREE() for the two strings we allocate there.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/testutils.c | 17
Signed-off-by: Daniel P. Berrangé
---
po/cs.mini.po | 34 +-
po/fr.mini.po | 3 +++
2 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/po/cs.mini.po b/po/cs.mini.po
index 35389e7..4481728 100644
--- a/po/cs.mini.po
+++ b/po/cs.mini.po
@@ -23,7 +23,7
On 2/20/19 1:56 PM, Andrea Bolognani wrote:
On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote:
On 2/20/19 2:37 AM, Michal Privoznik wrote:
On 2/19/19 9:19 PM, John Ferlan wrote:
Assuming extraction (sigh) of the VIR_AUTOFREE,
While I'd definitely want this to be split into two patches if
Signed-off-by: Daniel P. Berrangé
---
po/kw.mini.po | 20 ++
po/kw.po| 153 ---
po/k...@kkcor.mini.po | 20 ++
po/k...@kkcor.po | 153 ---
po/k...@uccor.mini.po | 20 ++
Use refcounting for priv->monConfig instead of asymmetric freeing.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_driver.c | 5 +
src/qemu/qemu_process.c | 6 +++---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c
On Tue, Feb 12, 2019 at 09:46 PM +0100, John Ferlan wrote:
> On 2/7/19 11:08 AM, Marc Hartmayer wrote:
>> Commit "nodedev: Move device enumumeration out of nodeStateInitialize"
>> (9f0ae0b18e3e620) has moved the heavy task of device enumeration into
>> a separate thread. The problem with this
On 2/19/19 1:33 PM, John Ferlan wrote:
>> + * capabilities of the host. If @flags contains VIR_DOMAIN_XML_MIGRATABLE,
>> + * the XML is altered to trim redundant information that might interfere
>> + * with migration to an older version of libvirt, as well as expose
>> additional
>> + *
Similar to the libvirt=glib.pot, .po files contain line numbers and file
names identifying where in the source a translatable string comes from.
The source locations in the .po files are thrown away and replaced with
content from the libvirt-glib.pot whenever msgmerge is run, so this is not
On 2/19/19 9:19 PM, John Ferlan wrote:
Assuming extraction (sigh) of the VIR_AUTOFREE,
Reviewed-by: John Ferlan
While I'd definitely want this to be split into two patches if it was
fixing something under src/, but this is under tests/ and therefore I
did not bother. The reason for
On 2/19/19 6:00 PM, Eric Blake wrote:
> On 2/19/19 2:24 PM, Eric Blake wrote:
>
>>
>>> BTW: For the two callers that pass all 3 maybe it'd be good to change
>>> those to pass VIR_DOMAIN_XML_COMMON_FLAGS. Currently:
>>>
>>> * qemuMigrationCookieXMLFormat
>>> * qemuDomainSaveImageDefineXML
We'll want to use this function in the cleanup path soon,
and in order to be able to do that we need to make sure we
can call it multiple times on the same virFileWrapperFd
without side effects.
Signed-off-by: Andrea Bolognani
---
src/util/virfile.c | 8 +++-
1 file changed, 7
Switch most 'supported' handling to use virTristateBool, so eventually
we can handle the ABSENT state.
For now the XML formatter treats ABSENT the same as FALSE, so there's
no functional output change. This will be addressed in later patches
Signed-off-by: Cole Robinson
---
Upcoming changes will make outputting these subelements optional.
While we are here drop the useless interleave: since this is an output
only format the elements are always in the same order
Signed-off-by: Cole Robinson
---
docs/schemas/domaincaps.rng | 20
1 file changed,
On 2/19/19 1:44 PM, John Ferlan wrote:
>
>
> On 2/14/19 4:29 PM, Eric Blake wrote:
>> Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use
>> of @flags as a subset of virDomainXMLFlags, documenting that 2 of the
>> 3 flags defined at the time would never be valid. Later, commit
On Tue, 2019-02-19 at 15:49 +, Daniel P. Berrangé wrote:
> On Tue, Feb 19, 2019 at 04:42:51PM +0100, Andrea Bolognani wrote:
> > On Tue, 2019-02-19 at 13:58 +, Daniel P. Berrangé wrote:
> > > IOW, if we need to report an error from the io helper, then it
> > > needs to be done earlier,
On Tue, Feb 19, 2019 at 10:04:58AM +0100, Jiri Denemark wrote:
From: Chris Venteicher
Move code for setting paths and prepping file system from
qemuProcessQMPNew to qemuProcessQMPInit.
This keeps qemuProcessQMPNew limited to data structures and path
initialization is done in
On Tue, Feb 19, 2019 at 04:42:51PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-02-19 at 13:58 +, Daniel P. Berrangé wrote:
> > On Wed, Feb 13, 2019 at 01:04:07PM +0100, Andrea Bolognani wrote:
> [...]
> > > @@ -351,8 +351,12 @@ virFileWrapperFdFree(virFileWrapperFdPtr wfd)
> > > if
On Tue, Feb 19, 2019 at 10:05:01AM +0100, Jiri Denemark wrote:
Users qemuProcessQMP struct were always forced to call both
qemuProcessQMPStop and qemuProcessQMPFree when they are done with the
process. We can just call qemuProcessQMPStop from qemuProcessQMPFree and
let users call
On 2/19/19 1:33 PM, John Ferlan wrote:
>
>
> On 2/14/19 4:29 PM, Eric Blake wrote:
>> Commit 28f8dfdc (1.0.0) added a flag to virDomainGetXMLDesc, but
>> failed to document its effects.
>>
>> Signed-off-by: Eric Blake
>> ---
>> src/libvirt-domain.c | 8 +++-
>> 1 file changed, 7
On Tue, 2019-02-19 at 13:58 +, Daniel P. Berrangé wrote:
> On Wed, Feb 13, 2019 at 01:04:07PM +0100, Andrea Bolognani wrote:
[...]
> > @@ -351,8 +351,12 @@ virFileWrapperFdFree(virFileWrapperFdPtr wfd)
> > if (!wfd)
> > return;
> >
> > +/* If the command used to process IO
On 2/19/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> 19.02.2019 1:32, John Snow wrote:
>>
>>
>> On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 14.02.2019 2:23, John Snow wrote:
"Frozen" was a good description a long time ago, but it isn't adequate now.
Rename the
1 - 100 of 162 matches
Mail list logo
