Re: [libvirt] [PATCH v3 06/10] block/dirty-bitmap: explicitly lock bitmaps with successors

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > Instead of implying a user_locked/busy status, make it explicit. > Now, bitmaps in use by migration, NBD or backup operations > are all treated the same way with the same code paths. > > Signed-off-by: John Snow > Reviewed-by: Eric Blake hmm, you forget my r-b:

Re: [libvirt] [PATCH v3 05/10] nbd: change error checking order for bitmaps

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > Check that the bitmap is not in use prior to it checking if it is > not enabled/recording guest writes. The bitmap being busy was likely > at the behest of the user, so this error has a greater chance of being > understood by the user. > > Signed-off-by: John Sn

Re: [libvirt] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > Currently, the enabled predicate means something like: > "the QAPI status of the bitmap is ACTIVE." > After this patch, it should mean exclusively: > "This bitmap is recording guest writes, and is allowed to do so." > > In many places, this is how this predicate

Re: [libvirt] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
about subject: shouldn't it be "against disabled bit" instead? 23.02.2019 3:06, John Snow wrote: > bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an > internal API by the mirror and migration areas of our code. These > calls modify the bitmap, but do so at the behest of QEMU an

Re: [libvirt] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > "Frozen" was a good description a long time ago, but it isn't adequate now. > Rename the frozen predicate to has_successor to make the semantics of the > predicate more clear to outside callers. > > In the process, remove some calls to frozen() that no longer se

Re: [libvirt] [PATCH v3 01/10] block/dirty-bitmap: add recording and busy properties

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:06, John Snow wrote: > The current API allows us to report a single status, which we've defined as: > > Frozen: has a successor, treated as qmp_locked, may or may not be enabled. > Locked: no successor, qmp_locked. may or may not be enabled. > Disabled: Not frozen or locked, disabled.

[libvirt] [PATCH v5] openvswitch: Add new port VLAN mode "802.1ad"

2019-02-24 Thread ZhiPeng LU
This patch adds functionality to allow libvirt to configure the '802.1ad' modes(802.1ad double-tagged) on openvswitch networks. For example: Signed-off-by: ZhiPeng Lu --- v1->v2: 1. Fix "make syntax-check" failure v2->v3: 1. rem

Re: [libvirt] [PATCH v2 2/6] bhyve: add bhyveDomainDefNeedsISAController helper

2019-02-24 Thread Roman Bogorodskiy
Ján Tomko wrote: > On Sun, Feb 17, 2019 at 05:04:01PM +0400, Roman Bogorodskiy wrote: > >Add a bhyveDomainDefNeedsISAController() helper function > >which by domain configuration determines whether LPC controller is > >required or not. > > > >Signed-off-by: Roman Bogorodskiy > >--- > > src/bhyv

Re: [libvirt] [PATCH v2 3/3] news: document bhyve msrs feature

2019-02-24 Thread Roman Bogorodskiy
Cole Robinson wrote: > On 2/10/19 6:09 AM, Roman Bogorodskiy wrote: > > Describe bhyve's ignoring unknown MSRs writes feature > > introduced by commit 525918ac5c. > > > > Signed-off-by: Roman Bogorodskiy > > --- > > docs/news.xml | 10 ++ > > 1 file changed, 10 insertions(+) > > > >