In a case where we want to hotplug the following disk:
(...)
In a QEMU guest that has a single OS disk, as follows:
(...)
What happens is that the existing guest disk will receive the ID
'scsi0-0-0-0' due to how Libvirt calculate the alias based on
the address in
v3:
- changed to a simpler and more generic approach
- v2 can be found here:
https://www.redhat.com/archives/libvir-list/2019-January/msg00673.html
Daniel Henrique Barboza (1):
domain_conf: check device address before attach
src/conf/domain_conf.c | 8
1 file changed, 8 insertions(+)
On 2/19/19 3:57 AM, Nikolay Shirokovskiy wrote:
> Remove unused variable. Fix for [1]
>
> [1] 821dd6d8: storage: Use VIR_AUTOFREE for storage backends
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
>
> Pushed as trivial build fix.
I'm trying to get a working build of src/vz/ on my system, to
On 3/14/19 4:29 PM, Eric Blake wrote:
On 3/14/19 2:42 PM, Cole Robinson wrote:
+typedef enum {
+ ARG_QEMU_CAPS = 1,
+
+ ARG_END = QEMU_CAPS_LAST,
+} testInfoArgNames;
+
Do you need some sort of compile-time check that QEMU_CAPS_LAST doesn't
overlap with any other ARG_*?
Sure but
On Wed, Feb 06, 2019 at 12:14:36PM -0500, Cole Robinson wrote:
> On 2/6/19 11:54 AM, Andrea Bolognani wrote:
> > On Wed, 2019-02-06 at 11:12 -0500, Cole Robinson wrote:
> > > On 1/29/19 11:05 AM, Andrea Bolognani wrote:
> > > > Eduardo, do you think we might ever get in trouble if we did that?
> >
On 3/12/19 7:48 AM, Pavel Hrdina wrote:
On Fri, Mar 08, 2019 at 11:21:37AM -0500, Laine Stump wrote:
On 3/8/19 8:34 AM, John Ferlan wrote:
On 2/24/19 9:15 AM, ZhiPeng LU wrote:
This patch adds functionality to allow libvirt to configure the '802.1ad'
modes(802.1ad double-tagged) on
On Fri, Mar 15, 2019 at 06:27:43PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> docs/news.xml | 13 +
> 1 file changed, 13 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Fri, Mar 15, 2019 at 06:27:42PM +0100, Andrea Bolognani wrote:
> Now that we no longer support the weird "redhat+systemd"
> configuration, we can make our code slightly simpler.
>
> Signed-off-by: Andrea Bolognani
> ---
> m4/virt-init-script.m4 | 9 +++--
> 1 file changed, 3
On Fri, Mar 15, 2019 at 06:27:41PM +0100, Andrea Bolognani wrote:
> Despite the misleading name, these were supposed to be used
> with a System V style init; however, none of the platforms we
> target is using that kind of init anymore: almost all Linux
> distributions have switched to systemd,
On Fri, Mar 15, 2019 at 06:27:39PM +0100, Andrea Bolognani wrote:
> It's no longer used.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Fri, Mar 15, 2019 at 06:27:38PM +0100, Andrea Bolognani wrote:
> We're gonna drop support for non-systemd init scripts soon,
> and we don't want Travis CI builds to break when we do.
>
> Since we have init system auto-detection, we can just rely on
> that and stop passing --with-init-script to
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index cc07b5dd0a..bb548f1ec1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -95,6 +95,19 @@
+
+
+
+
It's no longer used.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 0e7a1a033c..54de7dd7ad 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -43,7 +43,6 @@ script:
-w /build
-e
Now that we no longer support the weird "redhat+systemd"
configuration, we can make our code slightly simpler.
Signed-off-by: Andrea Bolognani
---
m4/virt-init-script.m4 | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/m4/virt-init-script.m4 b/m4/virt-init-script.m4
Despite the misleading name, these were supposed to be used
with a System V style init; however, none of the platforms we
target is using that kind of init anymore: almost all Linux
distributions have switched to systemd, those that haven't
(such as Gentoo and Alpine) are mostly using OpenRC with
Not a single one of the platforms we target still uses Upstart, and
the Upstart project itself has been abandoned for several years now.
Signed-off-by: Andrea Bolognani
Reviewed-by: Daniel P. Berrangé
---
m4/virt-init-script.m4 | 7 +-
src/Makefile.am | 29
We're gonna drop support for non-systemd init scripts soon,
and we don't want Travis CI builds to break when we do.
Since we have init system auto-detection, we can just rely on
that and stop passing --with-init-script to configure entirely.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 2
Changes from [v1]:
* drop support for "Red Hat" init scripts in addition to Upstart.
[v1] https://www.redhat.com/archives/libvir-list/2019-March/msg00917.html
Andrea Bolognani (6):
travis: Stop using --with-init-script
travis: Drop $DISTCHECK_CONFIGURE_FLAGS
Drop support for Upstart
On 3/15/19 12:02 AM, Eric Blake wrote:
> This is a respin of patch 4/20 in my larger series:
> https://www.redhat.com/archives/libvir-list/2019-March/msg00386.html
>
> As John pointed out, my v4/v5 posting had a LOT of duplicate code,
> including lots of poorly commented code managing a potential
On 3/15/19 8:30 AM, Daniel P. Berrangé wrote:
> On Fri, Mar 15, 2019 at 08:24:35AM -0500, Eric Blake wrote:
>>> 0.69 prohibit_author
>>> prohibit_backslash_alignment
>>> src/datatypes.h:302:!virObjectIsClass(virChkDom(_check),
>>> virDomainClass) || \
>>> src/datatypes.h:313:#
Pavel Hrdina writes:
> On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote:
>> From: Kővágó, Zoltán
>>
>> Audio drivers now get an Audiodev * as config paramters, instead of the
>> global audio_option structs. There is some code in audio/audio_legacy.c
>> that converts the old
On Fri, 2019-03-15 at 15:06 +, Daniel P. Berrangé wrote:
> On Fri, Mar 15, 2019 at 01:24:20PM +0100, Andrea Bolognani wrote:
> > [...]
> > > +# Run in a separate build directory. Set to empty
> > > +# for a in-source tree build, but note SRCDIR must
> > > +# also be set to a corresponding
On Fri, Mar 15, 2019 at 04:12:17PM +0100, Michal Privoznik wrote:
> On 3/15/19 2:53 PM, Pavel Hrdina wrote:
> > On Wed, Mar 06, 2019 at 03:59:12PM +0100, Michal Privoznik wrote:
> > > So far we have two branches: either we zero BLOCK_PER_PACKET
> > > (currently 128) block at one, or if we're close
On 3/15/19 10:30 AM, Ján Tomko wrote:
> On Fri, Mar 15, 2019 at 10:12:45AM -0500, Eric Blake wrote:
>> Checking that the derived class is larger than the requested parent
>> class saves us from some obvious mistakes, but as written, it does not
>> catch all the cases; in particular, it is easy to
On Fri, Mar 15, 2019 at 03:51:57PM +, Singh, Brijesh wrote:
> Hi Daniel,
>
>
> On 3/15/19 7:18 AM, Daniel P. Berrangé wrote:
> > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote:
> >>
> >> On 1/18/19 3:39 AM, Erik Skultety wrote:
> >>> I proceeded with cloning [1] to systemd
Hi Daniel,
On 3/15/19 7:18 AM, Daniel P. Berrangé wrote:
> On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote:
>>
>> On 1/18/19 3:39 AM, Erik Skultety wrote:
>>> I proceeded with cloning [1] to systemd and creating an udev rule that I
>>> planned
>>> on submitting to systemd
On Fri, Mar 15, 2019 at 10:12:45AM -0500, Eric Blake wrote:
> Checking that the derived class is larger than the requested parent
> class saves us from some obvious mistakes, but as written, it does not
> catch all the cases; in particular, it is easy to forget to update a
> VIR_CLASS_NEW when
On Fri, Mar 15, 2019 at 10:12:45AM -0500, Eric Blake wrote:
Checking that the derived class is larger than the requested parent
class saves us from some obvious mistakes, but as written, it does not
catch all the cases; in particular, it is easy to forget to update a
VIR_CLASS_NEW when changing
On Fri, Mar 15, 2019 at 10:06:58AM -0500, Eric Blake wrote:
As explained in the previous patch, collecting pointer typedefs into a
common header makes it easier to avoid circular inclusions. Continue
the efforts by pulling the appropriate typedefs from capabilities.h
into the new header.
This
From: Jason Dillaman
The librbd API will transparently revert to a slow disk usage
calculation method if the fast-diff map is marked as invalid.
Signed-off-by: Jason Dillaman
---
src/storage/storage_backend_rbd.c | 41 ---
1 file changed, 37 insertions(+), 4
From: Jason Dillaman
Use the new 'refresh_volume_allocation' pool override to skip
computing the actual volume usage if disabled.
Signed-off-by: Jason Dillaman
---
src/storage/storage_backend_rbd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Jason Dillaman
When this attribute is set to 'capacity', refreshing volume
allocations within the pool will report the capacity for the
allocation. This is useful for certain backends where computing
the actual allocation of a volume might be an expensive
operation.
Signed-off-by: Jason
From: Jason Dillaman
The RBD fast-diff feature can vastly reduce the amount of time needed
to calculate actual disk usage of volumes, but it might still be a
slow operation for large RBD pools or pools with large RBD images.
Therefore, this feature should be able to be optionally disabled if
On Fri, Mar 15, 2019 at 02:49:19PM +0100, Andrea Bolognani wrote:
> These are basically the same tweaks that have recently been
> applied to lcitool.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Checking that the derived class is larger than the requested parent
class saves us from some obvious mistakes, but as written, it does not
catch all the cases; in particular, it is easy to forget to update a
VIR_CLASS_NEW when changing the 'parent' member from virObject to
virObjectLockabale, but
On 3/15/19 2:53 PM, Pavel Hrdina wrote:
On Wed, Mar 06, 2019 at 03:59:12PM +0100, Michal Privoznik wrote:
So far we have two branches: either we zero BLOCK_PER_PACKET
(currently 128) block at one, or if we're close to the last block
then we zero out one block at the time. This is very
As explained in the previous patch, collecting pointer typedefs into a
common header makes it easier to avoid circular inclusions. Continue
the efforts by pulling the appropriate typedefs from capabilities.h
into the new header.
This patch is just straight code motion (all typedefs are listed in
On Fri, Mar 15, 2019 at 01:24:20PM +0100, Andrea Bolognani wrote:
> On Wed, 2019-03-06 at 09:34 +, Daniel P. Berrangé wrote:
> [...]
> > +++ b/.gitignore
> > @@ -46,6 +46,7 @@
> > /autom4te.cache
> > /build-aux/*
> > /build/
> > +/citree/
>
> Bikeshedding: I would prefer if we used
On Fri, Mar 15, 2019 at 03:44:58PM +0100, Peter Krempa wrote:
The functions do basically exactly the same thing modulo few checks.
In case of virtio disks we check that the device is not multifunction as
that can't be unplugged at once. In case of USB and SCSI disks we
checked that no active
On Fri, Mar 15, 2019 at 03:44:57PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
libvir-list
On Fri, Mar 15, 2019 at 03:44:56PM +0100, Peter Krempa wrote:
Use the correct type in switch and populate the missing cases.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Fri, Mar 15, 2019 at 03:44:55PM +0100, Peter Krempa wrote:
We don't have any cleanup section, we can return the value directly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 92af85c3d3..ffe0031362 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
The functions do basically exactly the same thing modulo few checks.
In case of virtio disks we check that the device is not multifunction as
that can't be unplugged at once. In case of USB and SCSI disks we
checked that no active block job is running.
The check for running blockjobs should have
We don't have any cleanup section, we can return the value directly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 811fdf6c3a..0825b03a0d 100644
---
Refactor checking of disk bus and type for disk unplug and fix checking
whether a virtio disk has a running block job by deleting the
almost-identical implementation specific to virtio disks.
Peter Krempa (4):
qemu: hotplug: Remove 'ret' variable in qemuDomainDetachDeviceDiskLive
qemu:
Use the correct type in switch and populate the missing cases.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0825b03a0d..92af85c3d3 100644
---
On Wed, Mar 06, 2019 at 03:59:18PM +0100, Michal Privoznik wrote:
> Only active pools can be refreshed. But our completer offers just
> all pool, even inactive ones.
>
> Signed-off-by: Michal Privoznik
> ---
> tools/virsh-pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, Mar 06, 2019 at 03:59:17PM +0100, Michal Privoznik wrote:
> If pool refresh failed, then the internal table of volumes is
> probably left in inconsistent or incomplete state anyways. Clear
> it out then. This has an advantage that we can move the
> virStoragePoolObjClearVols() from those
On Wed, Mar 06, 2019 at 03:59:16PM +0100, Michal Privoznik wrote:
> This is a wrapper over refreshPool() call as at all places we are
> doing basically the same. Might as well have a single function to
> call.
>
> Signed-off-by: Michal Privoznik
> ---
> src/storage/storage_driver.c | 61
On Wed, Mar 06, 2019 at 03:59:15PM +0100, Michal Privoznik wrote:
> In d16f803d780 we've tried to solve an issue that after wiping an
> image its format might have changed (e.g. from qcow2 to raw) but
> libvirt wasn't probing the image format. We fixed this by calling
>
On 3/15/19 12:02 AM, Eric Blake wrote:
> snapshot_conf.h was mixing three separate types: the snapshot
> definition, the snapshot object, and the snapshot object list.
> Separate out the snapshot object list code into its own file, and
> update includes for affected clients.
>
> This is just code
On Fri, Mar 15, 2019 at 08:51:39AM -0500, Eric Blake wrote:
> On 3/15/19 8:34 AM, Ján Tomko wrote:
> > On Fri, Mar 15, 2019 at 12:02:32AM -0500, Eric Blake wrote:
> >> Upcoming patches want to add virDomainCheckpoint that behaves very
> >> similarly to virDomainCheckpoint; th eeasiest way to share
On Fri, 2019-03-15 at 13:44 +, Daniel P. Berrangé wrote:
> On Fri, Mar 15, 2019 at 02:27:55PM +0100, Andrea Bolognani wrote:
> > On Wed, 2019-03-06 at 09:34 +, Daniel P. Berrangé wrote:
> > > +++ b/.travis.yml
> > > @@ -11,26 +11,30 @@ matrix:
> > > - docker
> > >env:
> >
On Wed, Mar 06, 2019 at 03:59:14PM +0100, Michal Privoznik wrote:
> In bf5cf610f206d5d54 I've fixed a problem where iscsi-direct
> backend was reporting only the last LUN. The fix consisted of
> moving virStoragePoolObjClearVols() one level up. However, as it
> turns out, storage driver already
On Wed, Mar 06, 2019 at 03:59:13PM +0100, Michal Privoznik wrote:
> If virStorageBackendISCSIDirectVolWipeZero() fails, it has
> already reported an error which is probably specific enough. Do
> not overwrite it with some generic one.
>
> Signed-off-by: Michal Privoznik
> ---
>
On Wed, Mar 06, 2019 at 03:59:12PM +0100, Michal Privoznik wrote:
> So far we have two branches: either we zero BLOCK_PER_PACKET
> (currently 128) block at one, or if we're close to the last block
> then we zero out one block at the time. This is very suboptimal.
> We know how many block are there
On 3/15/19 8:21 AM, Eric Blake wrote:
> On 3/15/19 7:46 AM, Ján Tomko wrote:
>> [ not sure how John Snow got on the CC list. Hi, John! ]
>>
>> s/snapshot/conf/ in the summary
>
> Sure. It's related to my work on snapshots, but independent enough (and
> doesn't even touch snapshot_conf).
>
>>> #
On 3/15/19 8:34 AM, Ján Tomko wrote:
> On Fri, Mar 15, 2019 at 12:02:32AM -0500, Eric Blake wrote:
>> Upcoming patches want to add virDomainCheckpoint that behaves very
>> similarly to virDomainCheckpoint; th eeasiest way to share common code
>> is to give both classes a common base class. Thanks
Turns out we can use the built-in Exception class directly.
Signed-off-by: Andrea Bolognani
---
refresh | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/refresh b/refresh
index 730bb7c..1b94736 100755
--- a/refresh
+++ b/refresh
@@ -21,13 +21,6 @@ import
These are basically the same tweaks that have recently been
applied to lcitool.
Andrea Bolognani (3):
refresh: Remove double space
refresh: Drop Error class
refresh: Move exception handling to Application.run()
refresh | 40 +---
1 file changed, 17
flake8 complains about it.
Signed-off-by: Andrea Bolognani
---
refresh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refresh b/refresh
index 1e6c185..730bb7c 100755
--- a/refresh
+++ b/refresh
@@ -35,7 +35,7 @@ class MoveAlongException(Exception):
class Dockerfile:
This commit is best viewed with 'git show -w'.
Signed-off-by: Andrea Bolognani
---
refresh | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/refresh b/refresh
index 1b94736..1db0fc8 100755
--- a/refresh
+++ b/refresh
@@ -117,19 +117,20 @@ class
On Fri, Mar 15, 2019 at 02:27:55PM +0100, Andrea Bolognani wrote:
> On Wed, 2019-03-06 at 09:34 +, Daniel P. Berrangé wrote:
> > +++ b/.travis.yml
> > @@ -11,26 +11,30 @@ matrix:
> > - docker
> >env:
> > - IMAGE="ubuntu-18"
> > --
On 3/15/19 8:31 AM, Ján Tomko wrote:
> On Fri, Mar 15, 2019 at 12:02:31AM -0500, Eric Blake wrote:
>> Upcoming patches want to add virDomainCheckpoint that behaves very
>> similarly to virDomainCheckpoint; the easiest way to share common code
>> is to give both classes a common base class. If this
On Fri, Mar 15, 2019 at 12:02:33AM -0500, Eric Blake wrote:
Prepare for introducing a bunch of new public APIs related to backup
checkpoints by first introducing a new internal type and errors
associated with that type. Checkpoints are modeled heavily after
virDomainSnapshotPtr (both represent
On Fri, Mar 15, 2019 at 12:02:32AM -0500, Eric Blake wrote:
Upcoming patches want to add virDomainCheckpoint that behaves very
similarly to virDomainCheckpoint; th eeasiest way to share common code
is to give both classes a common base class. Thanks to the accessor
functions in the previous
On Fri, Mar 15, 2019 at 12:02:31AM -0500, Eric Blake wrote:
Upcoming patches want to add virDomainCheckpoint that behaves very
similarly to virDomainCheckpoint; the easiest way to share common code
is to give both classes a common base class. If this were C++, we'd
just use public member
On Wed, Mar 06, 2019 at 03:59:11PM +0100, Michal Privoznik wrote:
> This function reports error for one of the two error paths. This
> is unfortunate as a caller see this function failing but doesn't
> know right away if an error was reported.
>
> Signed-off-by: Michal Privoznik
> ---
>
On Fri, Mar 15, 2019 at 08:24:35AM -0500, Eric Blake wrote:
> > 0.69 prohibit_author
> > prohibit_backslash_alignment
> > src/datatypes.h:302:!virObjectIsClass(virChkDom(_check),
> > virDomainClass) || \
> > src/datatypes.h:313:# define virCheckDomainSnapshotReturn(obj, retval)
On Wed, 2019-03-06 at 09:34 +, Daniel P. Berrangé wrote:
> +++ b/.travis.yml
> @@ -11,26 +11,30 @@ matrix:
> - docker
>env:
> - IMAGE="ubuntu-18"
> -- DISTCHECK_CONFIGURE_FLAGS="--with-init-script=systemd"
> -- DOCKER_CMD="$LINUX_CMD"
> +-
On 3/15/19 12:02 AM, Eric Blake wrote:
> Upcoming patches want to add virDomainCheckpoint that behaves very
> similarly to virDomainCheckpoint; th eeasiest way to share common code
I can't type late at night :)
virDomainSnapshot; the easiest
(and copy-pasted into 8/8)
--
Eric Blake, Principal
On 3/15/19 12:17 AM, no-re...@patchew.org wrote:
> Hi,
>
> This series was run against 'syntax-check' test by patchew.org, which failed,
> please find the details below:
>
Patchew maintainers: Can we get this to output just a useful tail rather
than the entire log?
> 0.69 prohibit_author
>
On 3/15/19 7:46 AM, Ján Tomko wrote:
> [ not sure how John Snow got on the CC list. Hi, John! ]
>
> s/snapshot/conf/ in the summary
Sure. It's related to my work on snapshots, but independent enough (and
doesn't even touch snapshot_conf).
>
> On Fri, Mar 15, 2019 at 12:02:26AM -0500, Eric
On 3/15/19 5:32 AM, Daniel P. Berrangé wrote:
> On Wed, Mar 13, 2019 at 10:13:00PM -0500, Eric Blake wrote:
>> Based on recent list questions about the proposed addition of
>> virDomainCheckpointCreateXML(REDEFINE), it is worth adding some
>> clarification to the existing snapshot redefine
On Fri, Mar 15, 2019 at 12:02:30AM -0500, Eric Blake wrote:
snapshot_conf.h was mixing three separate types: the snapshot
definition, the snapshot object, and the snapshot object list.
Separate out the snapshot object list code into its own file, and
update includes for affected clients.
This
On 3/15/19 2:40 AM, Erik Skultety wrote:
> On Thu, Mar 14, 2019 at 11:24:47PM -0500, Eric Blake wrote:
>> I had to inspect the code to learn whether a final virObjectUnref()
>> calls ALL dispose callbacks in child-to-parent order (akin to C++
>> destructors), or whether I manually had to call a
On Fri, Mar 15, 2019 at 12:02:29AM -0500, Eric Blake wrote:
The next patch will require access to the helper functions
virDomainSnapshotDefFormatInternal and
virDomainSnapshotRedefineValidate from two different files; make the
file split easier by exporting these functions.
Signed-off-by: Eric
On Fri, Mar 15, 2019 at 12:02:28AM -0500, Eric Blake wrote:
snapshot_conf.h was mixing three separate types: the snapshot
definition, the snapshot object, and the snapshot object list.
Separate out the snapshot object code into its own file, which
includes moving a typedef to avoid circular
On Fri, Mar 15, 2019 at 12:02:27AM -0500, Eric Blake wrote:
It's easier to locate a typedef if they are stored in sorted order;
do so mechanically via:
$ sed -i '/typedef struct/ {N; N; s/\n//g}' src/conf/virconftypes.h
$ # sorting the lines
$ sed -i '/typedef struct/ s/;/;\n/g'
[ not sure how John Snow got on the CC list. Hi, John! ]
s/snapshot/conf/ in the summary
On Fri, Mar 15, 2019 at 12:02:26AM -0500, Eric Blake wrote:
Right now, snapshot_conf.h is rather large - it deals with three
separate types: virDomainSnapshotDef (the snapshot definition as it
maps to
On Wed, 2019-03-06 at 09:34 +, Daniel P. Berrangé wrote:
[...]
> +++ b/.gitignore
> @@ -46,6 +46,7 @@
> /autom4te.cache
> /build-aux/*
> /build/
> +/citree/
Bikeshedding: I would prefer if we used /ci-tree/ instead, and same
for the various ci-build, ci-shell, ci-... make targets.
[...]
>
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote:
>
> On 1/18/19 3:39 AM, Erik Skultety wrote:
> > I proceeded with cloning [1] to systemd and creating an udev rule that I
> > planned
> > on submitting to systemd upstream - the initial idea was to mimic /dev/kvm
> > and
> > make
On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote:
> From: Kővágó, Zoltán
>
> Audio drivers now get an Audiodev * as config paramters, instead of the
> global audio_option structs. There is some code in audio/audio_legacy.c
> that converts the old environment variables to audiodev
On Fri, 2019-03-15 at 11:12 +, Daniel P. Berrangé wrote:
> Thinking some more, I expect what happened is that the Debian 32-bit x86
> arch did indeed generate code compatible with i386 and thus this library
> path got set. These days no one cares about true i386 compat, so the
> compiler
On Fri, Mar 15, 2019 at 11:23:51 +0100, Michal Privoznik wrote:
> The aim of this function will be to fix return value of
> qemuMonitorDelDevice() in one specific case. But that is yet to
> come. Right now this is nothing but a plain substitution.
>
> Signed-off-by: Michal Privoznik
> ---
>
On Fri, Mar 15, 2019 at 12:06:13PM +0100, Andrea Bolognani wrote:
> On Fri, 2019-03-15 at 11:27 +0100, Erik Skultety wrote:
> > On Thu, Mar 14, 2019 at 05:52:17PM +, Daniel P. Berrangé wrote:
> > > Although the toolchain binaries for 32-bit x86 are using the ABI
> > > i686-linux-gnu, the
On Fri, Mar 15, 2019 at 11:48:43AM +0100, Andrea Bolognani wrote:
> On Fri, 2019-03-15 at 10:26 +, Daniel P. Berrangé wrote:
> > On Fri, Mar 15, 2019 at 10:23:52AM +, Daniel P. Berrangé wrote:
> > > On Thu, Mar 14, 2019 at 12:31:08PM +0100, Andrea Bolognani wrote:
> > > >env:
> > >
On Tue, Mar 12, 2019 at 02:14:41PM +0300, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy
> ---
> docs/news.xml | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Tue, Mar 12, 2019 at 02:14:40PM +0300, Nikolay Shirokovskiy wrote:
> This info can be useful to filter devices visible
> to mgmt clients so that they won't see devices that
> unsafe/not meaningful to pass thru.
>
> Provide class info the way it is provided by udev or
> kernel that is as single
On Fri, 2019-03-15 at 11:27 +0100, Erik Skultety wrote:
> On Thu, Mar 14, 2019 at 05:52:17PM +, Daniel P. Berrangé wrote:
> > Although the toolchain binaries for 32-bit x86 are using the ABI
> > i686-linux-gnu, the library install directory is strangely named
> > with the different
On Tue, Mar 12, 2019 at 02:14:39PM +0300, Nikolay Shirokovskiy wrote:
> Vim treats *.h files as cpp ones with respect to syntax highlighting.
Surprised it doesn't use .hpp for C++ headers, but no matter.
> Thus "class" in _virNodeDevCapPCIDev highlighted mistakenly.
> This can be fixed by
On Wed, Mar 13, 2019 at 10:39:46AM +0300, Nikolay Shirokovskiy wrote:
> We only check now for virObjectWait failures in virshRunConsole but
> we'd better check and for other failures too. Anyway if failure
> happened we need to shutdown console to stop delivering events
> from event loop thread or
On Wed, Mar 13, 2019 at 03:13:42PM +0800, 傅姜晨 wrote:
> if VDSP is set to null during the method delete(), Object snapshot can't be
> freed in method free() in the same class.
>
>
> Showing 1 changed file with 1 addition and 7 deletions.
> View file
>
> 8
On Fri, 2019-03-15 at 10:26 +, Daniel P. Berrangé wrote:
> On Fri, Mar 15, 2019 at 10:23:52AM +, Daniel P. Berrangé wrote:
> > On Thu, Mar 14, 2019 at 12:31:08PM +0100, Andrea Bolognani wrote:
> > >env:
> > > - IMAGE="centos-7"
> > > --
On Wed, Mar 13, 2019 at 04:08:00PM -0600, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 896700fa97..f437a3f455 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@
On Fri, Mar 15, 2019 at 11:27:48AM +0100, Erik Skultety wrote:
> On Thu, Mar 14, 2019 at 05:52:17PM +, Daniel P. Berrangé wrote:
> > Although the toolchain binaries for 32-bit x86 are using the ABI
> > i686-linux-gnu, the library install directory is strangely named
> > with the different
On Fri, Mar 15, 2019 at 11:23:54 +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1623389
>
> If a device is detached twice from the same domain the following
> race condition may happen:
>
> 1) The first DetachDevice() call will issue "device_del" on qemu
> monitor,
On Thu, Mar 14, 2019 at 07:15:10AM -0400, Stefan Berger wrote:
> On 3/14/19 5:59 AM, Daniel P. Berrangé wrote:
> > On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote:
> > > Hello!
> > >
> > > If you have some feedback regarding a seccomp profile extension for
> > > swtpm
> > > for
On Wed, Mar 13, 2019 at 10:13:00PM -0500, Eric Blake wrote:
> Based on recent list questions about the proposed addition of
> virDomainCheckpointCreateXML(REDEFINE), it is worth adding some
> clarification to the existing snapshot redefine documentation that is
> serving as the basis for
1 - 100 of 120 matches
Mail list logo
