Re: [libvirt] [PATCH] test: Avoid use-after-free on virDomainSnapshotDelete

2019-03-16 Thread Eric Blake
On 3/16/19 11:13 PM, Eric Blake wrote: > The following virsh command was triggering a use-after-free: > > $ virsh -c test:///default ' > snapshot-create-as test s1 > snapshot-create-as test s2 > snapshot-delete --children-only test s1 > snapshot-current --name test' > Domain snapshot s1

[libvirt] [PATCH] test: Avoid use-after-free on virDomainSnapshotDelete

2019-03-16 Thread Eric Blake
The following virsh command was triggering a use-after-free: $ virsh -c test:///default ' snapshot-create-as test s1 snapshot-create-as test s2 snapshot-delete --children-only test s1 snapshot-current --name test' Domain snapshot s1 created Domain snapshot s2 created Domain snapshot s1

Re: [libvirt] [PATCH v3 0/2] Add function for XML yes|no string handling

2019-03-16 Thread Cole Robinson
On 3/13/19 2:30 AM, Shotaro Gotanda wrote: > Changes since v2: > - adjust the code to the coding guideline > > > Shotaro Gotanda (2): > util: add virStringParseYesNo() > conf: Use virStringParseYesNo() > > src/conf/domain_conf.c | 30 +- > src/conf/secret_conf.c

[libvirt] ANNOUNCE: Oz 0.17.0 release

2019-03-16 Thread Chris Lalancette
All,     I'm pleased to announce release 0.17.0 of Oz.  Oz is a program for doing automated installation of guest operating systems with limited input from the user.  Release 0.17.0 switches Oz to be python3 only, since Python 2 support is ending soon.  There are also some minor fixes in

Re: [libvirt] [PATCH v2 5/8] storageVolWipePattern: Don't take shortcut to refreshPool()

2019-03-16 Thread Michal Prívozník
On 3/15/19 3:14 PM, Pavel Hrdina wrote: > On Wed, Mar 06, 2019 at 03:59:15PM +0100, Michal Privoznik wrote: >> In d16f803d780 we've tried to solve an issue that after wiping an >> image its format might have changed (e.g. from qcow2 to raw) but >> libvirt wasn't probing the image format. We fixed

[libvirt] [PATCH v3 2/2] storageVolWipePattern: Don't take shortcut to refreshPool()

2019-03-16 Thread Michal Privoznik
In d16f803d780 we've tried to solve an issue that after wiping an image its format might have changed (e.g. from qcow2 to raw) but libvirt wasn't probing the image format. We fixed this by calling virStorageBackendRefreshVolTargetUpdate() which is what refreshPool() would end up calling. But this

[libvirt] [PATCH v3 1/2] storage_backend_iscsi_direct: Simplify vol zeroing

2019-03-16 Thread Michal Privoznik
So far we have two branches: either we zero BLOCK_PER_PACKET (currently 128) block at once, or if we're close to the last block then we zero out one block at the time. This is very suboptimal. We know how many block are there left. Might as well just write them all at once. Signed-off-by: Michal

[libvirt] [PATCH v3 0/2] Couple of storage driver improvements

2019-03-16 Thread Michal Privoznik
v3 of: https://www.redhat.com/archives/libvir-list/2019-March/msg00326.html diff to v2: - Patches acked in v2 are pushed now, - Patch 1/2 is a resurrection of patch 1/6 from v1. As Pavel found out we can't use writesame(), so let's simplify write() at least. - Patch 2/2 now checks for VSTORAGE

Re: [libvirt] [PATCH v2 2/8] storage_backend_iscsi_direct: Simplify vol zeroing

2019-03-16 Thread Michal Prívozník
On 3/15/19 5:18 PM, Pavel Hrdina wrote: > On Fri, Mar 15, 2019 at 04:12:17PM +0100, Michal Privoznik wrote: >> On 3/15/19 2:53 PM, Pavel Hrdina wrote: >>> On Wed, Mar 06, 2019 at 03:59:12PM +0100, Michal Privoznik wrote: So far we have two branches: either we zero BLOCK_PER_PACKET