On 2/27/19 11:29 AM, Daniel P. Berrangé wrote:
Introduce a virNetworkPortDefPtr struct to represent the data associated
with a virtual network port. Add APIs for parsing/formatting XML docs
with the data.
Signed-off-by: Daniel P. Berrangé
---
src/conf/Makefile.inc.am |
On 2/27/19 11:28 AM, Daniel P. Berrangé wrote:
An update to
v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00681.html
Currently the network driver registers a set of callbacks with the virt
driver in order to handle allocating/releasing network ports associated
with guest
On Fri, Mar 15, 2019 at 01:46:37PM -0400, Laine Stump wrote:
> On 3/12/19 7:48 AM, Pavel Hrdina wrote:
> > On Fri, Mar 08, 2019 at 11:21:37AM -0500, Laine Stump wrote:
> > > On 3/8/19 8:34 AM, John Ferlan wrote:
> > > > On 2/24/19 9:15 AM, ZhiPeng LU wrote:
> > > > > This patch adds functionality
These blocks are only triggered when updating from a libvirt version
less than 0.9.4, which was released in august 2011. I think it's been
long enough that we can say this upgrade path is unsupported without
an intermediate step
Signed-off-by: Cole Robinson
---
libvirt.spec.in | 19
Since Fedora 28 (our minimum supported build), ldconfig is called
automatically for us:
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
These changes appear to be implemented for rhel > 7 as well, so only
run ldconfig on rhel7
Signed-off-by: Cole Robinson
---
This is a different approach to solving the problem describd in:
https://www.redhat.com/archives/libvir-list/2019-March/msg00584.html
That patch would treat each chain creation attempt as non-fatal. This
means ipv4 chains still get created if ipv6 is missing, or if a subset
of ip[6]tables
During startup libvirtd creates top level chains for both ipv4
and ipv6 protocols. If this fails for any reason then startup
of virtual networks is blocked.
The default virtual network, however, only requires use of ipv4
and some servers have ipv6 disabled so it is expected that ipv6
chain
During startup we create some top level chains in which all
virtual network firewall rules will be placed. The upfront
creation is done to avoid slowing down creation of individual
virtual networks by checking for chain existance every time.
There are some factors which can cause this upfront
On Mon, 2019-03-18 at 07:27 +, Nikolay Shirokovskiy wrote:
> On 15.03.2019 23:02, Eric Blake wrote:
> > I'm trying to get a working build of src/vz/ on my system, to make sure
> > I don't cause similar types of build-breakage. What is the process for
> > getting PARALLELS_SDK installed on
On Mon, Mar 18, 2019 at 04:54:54PM +0100, Peter Krempa wrote:
It's not used outside of src/conf/domain_conf.c
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 10 --
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 12
On Mon, Mar 18, 2019 at 04:54:53PM +0100, Peter Krempa wrote:
Use virDomainStorageSourceFormatFull which has the same functionality.
Not quite,
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 43 --
1 file changed, 4 insertions(+), 39
On Mon, Mar 18, 2019 at 04:54:52PM +0100, Peter Krempa wrote:
The new function formats a virStorageSource into an XML element which
already contains type and format for simpler handling.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 39 +++
On Mon, Mar 18, 2019 at 04:54:51PM +0100, Peter Krempa wrote:
Move the formatters from virDomainDiskSourceFormatInternal to
virDomainStorageSourceFormat.
While 'startupPolicy' is attribute of the disk, we can format it when
formating generic virStorageSource into an element to allow simplifying
On Fri, 2019-03-15 at 17:20 +0100, Andrea Bolognani wrote:
> On Fri, 2019-03-15 at 15:06 +, Daniel P. Berrangé wrote:
> > > > + @echo "Available targets:"
> > > > + @echo
> > > > + @echo "cibuild-\$$IMAGE - run a default 'make'"
> > > > + @echo "
On Mon, 4 Mar 2019 14:52:30 +0100
Igor Mammedov wrote:
> On Fri, 1 Mar 2019 18:01:52 +
> "Dr. David Alan Gilbert" wrote:
>
> > * Igor Mammedov (imamm...@redhat.com) wrote:
> > > On Fri, 1 Mar 2019 15:49:47 +
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Fri, Mar 01, 2019 at
fillStringValues is only used if WITH_QEMU || WITH_BHYVE
Signed-off-by: Cole Robinson
---
Pushed under build break rule
tests/domaincapstest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c
index 1aa8c023a2..2cccfbc8e2 100644
---
https://bugzilla.redhat.com/show_bug.cgi?id=1686927
When trying to create a nwfilter binding via
nwfilterBindingCreateXML() we may encounter a crash. The sequence
of functions called is as follows:
1) nwfilterBindingCreateXML() parses the XML and calls
virNWFilterBindingObjListAdd() which calls
On Mon, Mar 18, 2019 at 04:54:50PM +0100, Peter Krempa wrote:
Rename it to 'seclabels' and invert the value.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 14 +++---
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_domain.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
On Mon, Mar 18, 2019 at 16:21:18 +0100, Christian Ehrhardt wrote:
> Currently there is no means to permanently modify the metadata stored
> within a snapshot if it does not pass the ABI compat checker.
Could you elaborate when this happens? The ABI check is quite important
and if you change the
When the block copy operation is started with a reused external file in
incremental mode libvirt will need to open and insert the backing chain
for that file into qemu (in -blockdev mode). This means that we'll need
to track the backing chain and metadata such as node names for the full
chain of .
Storage source private data can be parsed along with other components of
private data rather than a separate function which is called from
multiple places.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 42 --
src/conf/domain_conf.h | 3 ++-
All callers pass in 'true' so we can remove the parameter.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 9 -
src/conf/domain_conf.h | 1 -
src/conf/snapshot_conf.c | 2 +-
tests/virstoragetest.c | 2 +-
4 files changed, 6 insertions(+), 8 deletions(-)
diff --git
The new helper allows to avoid hand-rolled code to parse a storage
source.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 62 --
1 file changed, 12 insertions(+), 50 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
Replace most of the function by using the existing parsing helper.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 53 +-
1 file changed, 11 insertions(+), 42 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Move parsing of into virDomainStorageSourceParseFull so
that it can be reused easily.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 100 +--
src/conf/domain_conf.h | 3 +-
src/conf/snapshot_conf.c | 2 +-
src/qemu/qemu_domain.c | 2 +-
Similarly to the disk source we need to keep the disk index (which is in
the qemu driver used for identification of the source for block jobs)
for the element so that when it's replaced as a disk source
after pivoting all the allocated data is present.
Signed-off-by: Peter Krempa
---
All callers now pass true so we can remove the argument.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d12a8dcaf9..51bacfdd82 100644
---
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ec666d8d8c..5790b19315 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
Use the new parser function for disk source.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d77d3befd3..ec666d8d8c 100644
---
virDomainDiskSourceParse was now just a thin wrapper without any extra
value. Replace all usage of it by the function it calls and remove the
function.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 22 --
src/conf/domain_conf.h | 5 -
2 files changed, 4
Use the new parser instead of virDomainDiskSourceParse.
Signed-off-by: Peter Krempa
---
src/conf/snapshot_conf.c | 38 +++---
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index
Modify the check that the format is in range to be standalone and use
the convertor function directly.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
We parse the seclabels and use them internally so omitting them when
formatting would be misleading. Additionally our schema actually allows
them.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c| 3 +--
tests/qemuxml2argvdata/disk-backing-chains.xml
---
src/conf/domain_conf.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0c650ffc2c..ef164f3375 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9070,7 +9070,6 @@
virDomainDiskSourceFormat would call virDomainDiskSourceFormatInternal
with a limited set of parameters. Remove the 'Internal' variant by
squishing into virDomainDiskSourceFormat and fix the callers.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 38
virDomainDiskSourcePrivateDataParse and virDomainDiskSourcePRParse don't
need the 'cleanup' label any more thanks to VIR_XPATH_NODE_AUTORESTORE.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git
Introduce a helper which parses XML into virStorageSource according to
XPath queries passed in for the various bits. The new parser will allow
to unify the parsing of the various XML formats we use in different
parts without the need to do custom parsers.
Signed-off-by: Peter Krempa
---
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index f40cba36cd..b1d1ed943c 100644
--- a/tests/qemublocktest.c
+++ b/tests/qemublocktest.c
@@ -43,14
Simplify parsing and formatting of virStorageSource into/from XML. This
series contains the refactors which unify the various parsers into one
with a neat cleanup.
The plan is to reuse the parser for parsing job backing chains when the
disk frontend will be unplugged by the guest so that we don't
Move the formatters from virDomainDiskSourceFormatInternal to
virDomainStorageSourceFormat.
While 'startupPolicy' is attribute of the disk, we can format it when
formating generic virStorageSource into an element to allow simplifying
the code.
Since the arguments for virDomainStorageSourceFormat
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ae17992b83..2b6a2b7ee8 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
Get rid of the 'cleanup' label.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index b1d1ed943c..96c70e381a 100644
--- a/tests/qemublocktest.c
+++
The function does not have any code in the 'cleanup' label so we can
simplify the control flow.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/src/conf/domain_conf.c
Now that all external callers were changed we can stop exporting this
func.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 7 ---
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c
It's not used outside of src/conf/domain_conf.c
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 10 --
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c
Move the recursion to format the full backing store into
virDomainDiskSourceFormat controlled by a new argument so that it's
simpler to reuse in other places.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 30 +++---
src/conf/domain_conf.h | 1 +
We can use our VIR_AUTOPTR machinery also for libxml2's xmlDoc and
xmlXPathContext.
Signed-off-by: Peter Krempa
---
src/util/virxml.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virxml.h b/src/util/virxml.h
index b91fedde82..4875e88f2e 100644
--- a/src/util/virxml.h
+++
Add switch which will allow formating full chain.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 11 ++-
src/conf/domain_conf.h | 1 +
src/qemu/qemu_domain.c | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c
Upcoming commits will reorganize control flow leading to calling the
function to virDomainDiskSourceFormat thus it needs to be moved slightly
up.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 102 -
1 file changed, 51 insertions(+), 51
This is part of the effort to minimize use of virDomainDiskSourceParse.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 130 --
1 file changed, 61 insertions(+), 69 deletions(-)
diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index
Rename it to 'seclabels' and invert the value.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 14 +++---
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_domain.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c
Use virDomainStorageSourceFormatFull which has the same functionality.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 43 --
1 file changed, 4 insertions(+), 39 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Now that the cleanup section is handled automatically it can be removed.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 79e15c9886..b78481c280 100644
---
The new function formats a virStorageSource into an XML element which
already contains type and format for simpler handling.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 39 +++
src/conf/domain_conf.h | 8
src/libvirt_private.syms |
This allows users to actively ignore validadtion if needed e.g. when
changing metadata intentionally that does not pass the ABI checker.
It is utilizing EDIT_RELAX of virsh-edit.c to set the
VIR_DOMAIN_SNAPSHOT_CREATE_NOCHECK flag defined in the former patch.
Fixes:
Currently there is no means to permanently modify the metadata stored
within a snapshot if it does not pass the ABI compat checker.
That is pretty much intentional but there are use cases where users
verified that the change will work according to their needs and
don't want to: snapshot-revert ->
On 3/18/19 2:27 AM, Nikolay Shirokovskiy wrote:
>> I'm trying to get a working build of src/vz/ on my system, to make sure
>> I don't cause similar types of build-breakage. What is the process for
>> getting PARALLELS_SDK installed on Fedora 29?
>
> Hi, Erik!
>
> We don't test our package
On Mon, 2019-03-11 at 12:55 +0100, Michal Privoznik wrote:
> On 3/11/19 11:43 AM, Daniel P. Berrangé wrote:
> > What I mean is that this transaction is checking the filter, nat and
> > mangle tables of both ipv4 and ipv6. You have a missing mangle table
> > for ipv6, but this "ignore errors"
On 3/18/19 2:19 AM, Peter Krempa wrote:
> Mention that successful return does not equal to device being detached
> similarly as we do at the API level.
>
> Signed-off-by: Peter Krempa
> ---
> tools/virsh.pod | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git
On 3/13/19 2:29 PM, Andrea Bolognani wrote:
We already document how to generate them, so might as well
go the extra mile and document the remaining steps.
Signed-off-by: Andrea Bolognani
---
tests/qemucapabilitiestest.c | 8
1 file changed, 8 insertions(+)
ACK
Michal
--
On 3/18/19 2:53 PM, Cole Robinson wrote:
On 3/18/19 9:28 AM, Michal Privoznik wrote:
On 3/7/19 12:36 AM, Cole Robinson wrote:
v1 posting:
https://www.redhat.com/archives/libvir-list/2019-February/msg01088.html
v2 changes:
- Rebase to master
- Remove the full.xml test in patch #3
On 3/18/19 9:28 AM, Michal Privoznik wrote:
On 3/7/19 12:36 AM, Cole Robinson wrote:
v1 posting:
https://www.redhat.com/archives/libvir-list/2019-February/msg01088.html
v2 changes:
- Rebase to master
- Remove the full.xml test in patch #3
- Add virCapsEnum 'format' and use it
In 0eca80e60 _class was renamed to klass for variety of struct
members. However, gather_usb_cap() was missed out in this rename
leaving FreeBSD build broken.
Signed-off-by: Michal Privoznik
---
Pushed under trivial and build-breker rules.
src/node_device/node_device_hal.c | 2 +-
1 file
On 3/7/19 12:36 AM, Cole Robinson wrote:
v1 posting:
https://www.redhat.com/archives/libvir-list/2019-February/msg01088.html
v2 changes:
- Rebase to master
- Remove the full.xml test in patch #3
- Add virCapsEnum 'format' and use it
- Extend docs to explain optional XML
v1
On Mon, Mar 18, 2019 at 11:24:03 +, Zhangbo (Oscar) wrote:
> Hi all:
> qemu-pr-helper exits to help qemu do the high-privileged scsi related
> jobs. LIBVIRTD is responsible to launch qemu-pr-helper and qemu, and set
> selinux/DAC labels for them and their socket.
>
> #
> #
> #
> #
> #
On Mon, Mar 18, 2019 at 13:24:35 +0100, Michal Privoznik wrote:
> On 3/18/19 8:19 AM, Peter Krempa wrote:
> > This command is fully async. Note that users can use virsh event to be
> > notified of the guest actually removing the device.
> >
> > Signed-off-by: Peter Krempa
> > ---
> >
On Mon, Mar 18, 2019 at 12:20:18PM +, Daniel P. Berrangé wrote:
The rbd_list method has been deprecated in Ceph >= 14.0.0
in favour of the new rbd_list2 method which populates an
array of structs.
Signed-off-by: Daniel P. Berrangé
---
m4/virt-storage-rbd.m4| 1 +
On Mon, Mar 18, 2019 at 12:20:17PM +, Daniel P. Berrangé wrote:
The rbd_list method has a quite unpleasant signature returning an
array of strings in a single buffer instead of an array. It is
being deprecated in favour of rbd_list2. To maintain clarity of
code when supporting both APIs in
On 3/18/19 8:19 AM, Peter Krempa wrote:
This command is fully async. Note that users can use virsh event to be
notified of the guest actually removing the device.
Signed-off-by: Peter Krempa
---
tools/virsh.pod | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
The rbd_list method has a quite unpleasant signature returning an
array of strings in a single buffer instead of an array. It is
being deprecated in favour of rbd_list2. To maintain clarity of
code when supporting both APIs in parallel, split the rbd_list
code out into a separate method.
Latest ceph has deprecated the rbd_list API and this is present in
Fedora 30/31-rawhide
Technically this is a build breaker fix, but the patches are complex
enough that they would benefit from review before pushing.
Daniel P. Berrangé (2):
storage: split off code for calling rbd_list
The rbd_list method has been deprecated in Ceph >= 14.0.0
in favour of the new rbd_list2 method which populates an
array of structs.
Signed-off-by: Daniel P. Berrangé
---
m4/virt-storage-rbd.m4| 1 +
src/storage/storage_backend_rbd.c | 32 +++
2 files
On Sun, Mar 17, 2019 at 04:02:43PM -0400, Cole Robinson wrote:
This code originates from:
commit d0aa10fdd6c108ad442886e4451b2629a3dc8b86
Author: Daniel P. Berrange
Date: Tue Mar 3 12:03:44 2009 +
QEMU security driver usage for sVirt support (James Morris, Dan Walsh,
Daniel
On Mon, Mar 18, 2019 at 12:11:17PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2019 at 18:27:05 +0800, Han Han wrote:
Fix issue introduced by 047cfb05ee. Since group_name is str, use STRNEQ
instead of CHECK_EQ to do comparition.
comparison
Signed-off-by: Han Han
---
src/qemu/qemu_domain.c
Hi all:
qemu-pr-helper exits to help qemu do the high-privileged scsi related
jobs. LIBVIRTD is responsible to launch qemu-pr-helper and qemu, and set
selinux/DAC labels for them and their socket.
#
#
#
#
# ___
#
On Mon, Mar 18, 2019 at 18:27:05 +0800, Han Han wrote:
> Fix issue introduced by 047cfb05ee. Since group_name is str, use STRNEQ
> instead of CHECK_EQ to do comparition.
>
> Signed-off-by: Han Han
> ---
> src/qemu/qemu_domain.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
On 18/03/19 11:22, Daniel P. Berrangé wrote:
> Or can we just make the emails only include the last 100 lines
> of output. In the few cases where this is probably not sufficient,
> there's still the option of seeing the full log online at patchew.org
Ok, I configured the emails to do that.
On Sun, Mar 17, 2019 at 06:04:27 +, Humaid wrote:
> From: Ubuntu
>
This address is not resolvable your git is probably misconfigured.
Please provide a commit message according to the contributor
guildelines including certification of agreement with the developer
certificate of origin.
On Sun, Mar 17, 2019 at 06:04:27AM +, Humaid wrote:
> From: Ubuntu
>
You need to set your git author name to something sensible using
commands line this:
$ git config --global user.name "John Doe"
$ git config --global user.email john...@example.com
you can use 'git commit --amend
Fix issue introduced by 047cfb05ee. Since group_name is str, use STRNEQ
instead of CHECK_EQ to do comparition.
Signed-off-by: Han Han
---
src/qemu/qemu_domain.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
On Sun, Mar 17, 2019 at 10:26:21AM +0800, Fam Zheng wrote:
> On Fri, 03/15 08:24, Eric Blake wrote:
> > On 3/15/19 12:17 AM, no-re...@patchew.org wrote:
> > > Hi,
> > >
> > > This series was run against 'syntax-check' test by patchew.org, which
> > > failed, please find the details below:
> > >
From: Ubuntu
---
src/qemu/qemu_tpm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index 835a9caf46..b60e443f14 100644
--- a/src/qemu/qemu_tpm.c
+++ b/src/qemu/qemu_tpm.c
@@ -834,16 +834,16 @@
On Fri, 03/15 08:24, Eric Blake wrote:
> On 3/15/19 12:17 AM, no-re...@patchew.org wrote:
> > Hi,
> >
> > This series was run against 'syntax-check' test by patchew.org, which
> > failed, please find the details below:
> >
>
> Patchew maintainers: Can we get this to output just a useful tail
> On Mar 17, 2019, at 10:26, Fam Zheng wrote:
>
> On Fri, 03/15 08:24, Eric Blake wrote:
>> On 3/15/19 12:17 AM, no-re...@patchew.org wrote:
>>> Hi,
>>>
>>> This series was run against 'syntax-check' test by patchew.org, which
>>> failed, please find the details below:
>>>
>>
>> Patchew
We didn't add this until now because i686 cross-compilation
requires special care and lcitool was known to produce broken
Dockerfiles, but that's been fixed as of libvirt-jenkins-ci
commit f72d09153905 so we can finally go ahead and complete
our coverage of non-x86_64 architectures.
On 17/03/19 03:26, Fam Zheng wrote:
> On Fri, 03/15 08:24, Eric Blake wrote:
>> On 3/15/19 12:17 AM, no-re...@patchew.org wrote:
>>> Hi,
>>>
>>> This series was run against 'syntax-check' test by patchew.org, which
>>> failed, please find the details below:
>>>
>>
>> Patchew maintainers: Can we
On Sat, Mar 16, 2019 at 08:47:57AM +0100, Michal Privoznik wrote:
> v3 of:
>
> https://www.redhat.com/archives/libvir-list/2019-March/msg00326.html
>
> diff to v2:
> - Patches acked in v2 are pushed now,
> - Patch 1/2 is a resurrection of patch 1/6 from v1. As Pavel found out
> we can't use
Diff from v2[1]
- split first patch further into 2
[1] https://www.redhat.com/archives/libvir-list/2019-March/msg00812.html
Nikolay Shirokovskiy (5):
tools: console: make console virLockableObject
tools: console: cleanup console on errors in main thread
tools: console: add missing locks in
We need to turn console into virObject object because stream/fd callbacks
can be called from the event loop thread after freeing console
in main thread. It is convinient to turn into virLockableObject as
we have mutex in console object.
Signed-off-by: Nikolay Shirokovskiy
---
We only check now for virObjectWait failures in virshRunConsole but
we'd better check and for other failures too. And we need to shutdown
console on error in the main thread.
Signed-off-by: Nikolay Shirokovskiy
---
tools/virsh-console.c | 52 +--
On error in main thread virConsoleShutdown is called which
deletes fd watches/stream callback and yet callbacks can
be called after. Thus we can incorrectly allocate
terminalToStream.data memory and get memory leak for example.
Let's check if console was shutdown in the very beginning of
If the console was disconnected due to a connection problem or a problem on the
server side it is convinient to provide the cause to the user. If the error
come from the API then the error is saved in a virsh global variable. However,
since success is returned from virshRunConsole after we reach
Stream/fd callbacks accessing console object are called from the
event loop thread and the console object is also accessed from
the main thread so we are better add locking to handlers.
Signed-off-by: Nikolay Shirokovskiy
---
tools/virsh-console.c | 35 +--
1
On Mon, Mar 18, 2019 at 08:19:48AM +0100, Peter Krempa wrote:
> Peter Krempa (2):
> virsh: man: Document quirks of device-detach and friends
> virsh: man: Document asynchronous behaviour of detach-device-alias
>
> tools/virsh.pod | 19 ++-
> 1 file changed, 18 insertions(+), 1
Pushed. Thanx!
On 12.03.2019 14:14, Nikolay Shirokovskiy wrote:
> Diff from v1 [1]
> ===
> - add patch to use/restrict name "klass" in headers instead of class, _class
> - add news patch
>
> [1] https://www.redhat.com/archives/libvir-list/2019-February/msg01036.html
>
> Nikolay
Commit [1] moved snapshot list functions declaration into
its own file but missed a fix for vz driver.
[1] 9b75154c : snapshot: Break out virDomainSnapshotObjList into its own file
Signed-off-by: Nikolay Shirokovskiy
---
Pushed as trivial/build fix.
src/vz/vz_utils.h | 1 +
1 file changed, 1
On 15.03.2019 23:02, Eric Blake wrote:
> On 2/19/19 3:57 AM, Nikolay Shirokovskiy wrote:
>> Remove unused variable. Fix for [1]
>>
>> [1] 821dd6d8: storage: Use VIR_AUTOFREE for storage backends
>>
>> Signed-off-by: Nikolay Shirokovskiy
>> ---
>>
>> Pushed as trivial build fix.
>
> I'm trying
Mention that successful return does not equal to device being detached
similarly as we do at the API level.
Signed-off-by: Peter Krempa
---
tools/virsh.pod | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 66e2bf24ec..39ff8cd7c9 100644
Peter Krempa (2):
virsh: man: Document quirks of device-detach and friends
virsh: man: Document asynchronous behaviour of detach-device-alias
tools/virsh.pod | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
--
2.20.1
--
libvir-list mailing list
This command is fully async. Note that users can use virsh event to be
notified of the guest actually removing the device.
Signed-off-by: Peter Krempa
---
tools/virsh.pod | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index
100 matches
Mail list logo
