Hi Paolo,
(+libvir-list)
I'd like to report a regression introduced by this patch set:
On 03/07/19 21:58, Paolo Bonzini wrote:
> The following changes since commit
> 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6:
>
> Merge remote-tracking branch
> 'remotes/cleber/tags/python-next-pull-request'
On 3/20/19 1:40 AM, Eric Blake wrote:
> Separate the algorithm for which list members to vist (which is
> generic and can be shared with checkpoints, provided that checkpoints
> pick the same bit values for some of its flags) from the decision on
> which members to return (which is specific to
On 3/20/19 1:40 AM, Eric Blake wrote:
> An upcoming patch will rework virDomainSnapshotObjList to be generic
> for both snapshots and checkpoints; reduce the churn by adding a new
> accessor virDomainSnapshotObjGetDef() which returns the
> snapshot-specific definition even when the list is
On 3/20/19 6:47 AM, Ján Tomko wrote:
> On Wed, Mar 20, 2019 at 12:40:50AM -0500, Eric Blake wrote:
>> The following virsh command was triggering a use-after-free:
>>
>> $ virsh -c test:///default '
>> snapshot-create-as test s1
>> snapshot-create-as test s2
>> snapshot-delete --children-only
Rather than one file per snapshot, store all qemu snapshots in a
single file, using the recently added bulk snapshot list
operations. For now, this doesn't change how often libvirt writes a
snapshot file, but it does open the door for the next patch to update
the signature to
Remove a now-unused parameter from qemuDomainSnapshotWriteMetadata().
Then, instead of calling it after every individual change to a given
snapshot, call it only once at the end of the API function that
resulted in any overall changes.
Signed-off-by: Eric Blake
---
src/qemu/qemu_domain.h | 1 -
On 3/20/19 1:40 AM, Eric Blake wrote:
> Rather than allowing a leaky abstraction where multiple drivers have
> to open-code operations that update the relations in a
> virDomainSnapshotObjList, it is better to add accessor functions so
> that updates to relations are maintained closer to the
On 3/20/19 3:39 PM, John Ferlan wrote:
>
>
> On 3/20/19 1:40 AM, Eric Blake wrote:
>> It is easier to track the current snapshot as part of the list of
>> snapshots. In particular, doing so lets us guarantee that the current
>> snapshot is cleared if that snapshot is removed from the list
On 3/20/19 1:40 AM, Eric Blake wrote:
> It is easier to track the current snapshot as part of the list of
> snapshots. In particular, doing so lets us guarantee that the current
> snapshot is cleared if that snapshot is removed from the list (rather
> than depending on the caller to do so, and
On 3/20/19 1:40 AM, Eric Blake wrote:
> The only use for the 'current' member of virDomainSnapshotDef was with
> the PARSE/FORMAT_INTERNAL flag for controlling an internal-use
> element marking whether a particular snapshot definition was
> current, and even then, only by the qemu driver on
On 3/20/19 1:40 AM, Eric Blake wrote:
> An upcoming patch will be reworking virDomainSnapshotDef to have a
> base class; minimize the churn by using a local variable to reduce the
> number of dereferences required when acessing the domain definition
> associated with the snapshot.
>
>
On 3/20/19 1:40 AM, Eric Blake wrote:
> Upcoming patches want to add virDomainCheckpoint that behaves very
> similarly to virDomainSnapshot; the easiest way to share common code
> is to give both classes a common base class. Thanks to the accessor
> functions in the previous patch, we have
On Wed, 20 Mar 2019 15:24:42 +
Daniel P. Berrangé wrote:
> On Wed, Mar 20, 2019 at 04:20:19PM +0100, Igor Mammedov wrote:
> > > This could be solved if QEMU has some machine type based property
> > > that indicates whether "memdev" is required for a given machine,
> > > but crucially *does
On Wed, Mar 20, 2019 at 11:39:01 -0500, Eric Blake wrote:
> On 3/20/19 3:16 AM, Christian Ehrhardt wrote:
>
> >> So looking at the bug, user created a snapshot, then upgraded qemu to a
> >> version which dropped the old machine type.
> >>
> >> Reverting to a inactive internal snapshot in this
On 3/20/19 3:16 AM, Christian Ehrhardt wrote:
>> So looking at the bug, user created a snapshot, then upgraded qemu to a
>> version which dropped the old machine type.
>>
>> Reverting to a inactive internal snapshot in this case will restore the
>> definition including the machine type. That is
On Wed, 20 Mar 2019 13:46:59 +
Daniel P. Berrangé wrote:
> On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote:
> > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote:
> > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
> > [...]
[...]
> >
On Wed, Mar 20, 2019 at 11:37:06AM -0400, Yash Mankad wrote:
> The libvirt CI maintainers/contributors have agreed to update
> the default spam e-mail to include only the libvirt-ci mailing
> list and remove my e-mail from the spam list in the
> defaults.yaml
FWIW you don't really need our
On Wed, 2019-03-20 at 11:37 -0400, Yash Mankad wrote:
> The libvirt CI maintainers/contributors have agreed to update
> the default spam e-mail to include only the libvirt-ci mailing
> list and remove my e-mail from the spam list in the
> defaults.yaml
>
> Signed-off-by: Yash Mankad
> ---
>
The libvirt CI maintainers/contributors have agreed to update
the default spam e-mail to include only the libvirt-ci mailing
list and remove my e-mail from the spam list in the
defaults.yaml
Signed-off-by: Yash Mankad
---
jenkins/jobs/defaults.yaml | 2 +-
1 file changed, 1 insertion(+), 1
On Wed, Mar 20, 2019 at 04:20:19PM +0100, Igor Mammedov wrote:
> > This could be solved if QEMU has some machine type based property
> > that indicates whether "memdev" is required for a given machine,
> > but crucially *does not* actually activate that property until
> > several releases later.
>
On Wed, Mar 20, 2019 at 11:46:20AM -0300, Eduardo Habkost wrote:
> On Wed, Mar 20, 2019 at 01:46:59PM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote:
> > > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote:
> > > > On Wed, Mar
On Wed, 20 Mar 2019 11:51:51 +
Daniel P. Berrangé wrote:
> On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
> > On Tue, 19 Mar 2019 14:51:07 +
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote:
> > > > On Thu, 7 Mar
On Wed, Mar 20, 2019 at 01:46:59PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote:
> > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote:
> > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
> > [...]
> > > >
On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote:
> On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
> [...]
> > > So it's rather questionable if we should care about arbitrarily old
> > >
On 3/20/19 9:11 AM, Michal Privoznik wrote:
> On 3/20/19 12:17 PM, John Ferlan wrote:
>>
>>
>> On 3/20/19 6:31 AM, Michal Privoznik wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1686927
>>>
>>> When trying to create a nwfilter binding via
>>> nwfilterBindingCreateXML() we may encounter
On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote:
> On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
[...]
> > So it's rather questionable if we should care about arbitrarily old
> > libvirt with new QEMU in case of new machines (especially upstream).
>
>
On Wed, Mar 20, 2019 at 11:31:57AM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1686927
When trying to create a nwfilter binding via
nwfilterBindingCreateXML() we may encounter a crash. The sequence
of functions called is as follows:
1) nwfilterBindingCreateXML()
On 3/20/19 12:17 PM, John Ferlan wrote:
On 3/20/19 6:31 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1686927
When trying to create a nwfilter binding via
nwfilterBindingCreateXML() we may encounter a crash. The sequence
of functions called is as follows:
1)
On Wed, Mar 20, 2019 at 01:01:52PM +0100, Erik Skultety wrote:
> On Tue, Mar 19, 2019 at 04:00:59PM +, Daniel P. Berrangé wrote:
> > We previously had to disable RBD on 32-bit platforms since Ceph has
> > dropped all support for 32-bit. Unfortunately anyone with the RPM
> >
On Tue, Mar 19, 2019 at 04:00:59PM +, Daniel P. Berrangé wrote:
> We previously had to disable RBD on 32-bit platforms since Ceph has
> dropped all support for 32-bit. Unfortunately anyone with the RPM
> libvirt-daemon-driver-storage-rbd installed on 32-bit now has a
> broken upgrade path.
>
>
On Wed, Mar 20, 2019 at 12:35:14PM +0100, Pavel Hrdina wrote:
> On Tue, Mar 12, 2019 at 02:14:40PM +0300, Nikolay Shirokovskiy wrote:
> > This info can be useful to filter devices visible
> > to mgmt clients so that they won't see devices that
> > unsafe/not meaningful to pass thru.
> >
> >
On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote:
> On Tue, 19 Mar 2019 14:51:07 +
> Daniel P. Berrangé wrote:
>
> > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote:
> > > On Thu, 7 Mar 2019 10:07:05 +
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Wed,
On Wed, Mar 20, 2019 at 12:40:50AM -0500, Eric Blake wrote:
The following virsh command was triggering a use-after-free:
$ virsh -c test:///default '
snapshot-create-as test s1
snapshot-create-as test s2
snapshot-delete --children-only test s1
snapshot-current --name test'
Domain snapshot
On Tue, Mar 12, 2019 at 02:14:40PM +0300, Nikolay Shirokovskiy wrote:
> This info can be useful to filter devices visible
> to mgmt clients so that they won't see devices that
> unsafe/not meaningful to pass thru.
>
> Provide class info the way it is provided by udev or
> kernel that is as single
On 3/20/19 6:31 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1686927
>
> When trying to create a nwfilter binding via
> nwfilterBindingCreateXML() we may encounter a crash. The sequence
> of functions called is as follows:
>
> 1) nwfilterBindingCreateXML() parses
On Wed, Mar 20, 2019 at 8:45 AM Christian Ehrhardt
wrote:
>
> On Mon, Mar 4, 2019 at 11:42 AM Christian Ehrhardt
> wrote:
> >
> > On Fri, Mar 1, 2019 at 5:56 PM Jamie Strandboge wrote:
> > >
> > > On Mon, 18 Feb 2019, Christian Ehrhardt wrote:
> > >
> > > > So far we were detecting at guest
Daniel P. Berrangé writes:
> On Wed, Mar 20, 2019 at 07:46:33AM +0100, Markus Armbruster wrote:
>> We're going in circles. Igor keeps telling you QEMU needs to shed dead
>> weight, badly. In Igor's words:
>>
>> We really need to figure out how to introduce breaking change on
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1686927
When trying to create a nwfilter binding via
nwfilterBindingCreateXML() we may encounter a crash. The sequence
of functions called is as follows:
1) nwfilterBindingCreateXML() parses the XML and calls
virNWFilterBindingObjListAdd() which calls
On Tue, 19 Mar 2019 14:51:07 +
Daniel P. Berrangé wrote:
> On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote:
> > On Thu, 7 Mar 2019 10:07:05 +
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote:
> > > > On Wed, 6 Mar
On Wed, Mar 20, 2019 at 07:46:33AM +0100, Markus Armbruster wrote:
> We're going in circles. Igor keeps telling you QEMU needs to shed dead
> weight, badly. In Igor's words:
>
> We really need to figure out how to introduce breaking change on
> management (CLI) side* in QEMU and make it
On Wed, Mar 20, 2019 at 8:53 AM Peter Krempa wrote:
>
> On Tue, Mar 19, 2019 at 08:18:15 +0100, Christian Ehrhardt wrote:
> > On Mon, Mar 18, 2019 at 4:58 PM Peter Krempa wrote:
> > >
> > > On Mon, Mar 18, 2019 at 16:21:18 +0100, Christian Ehrhardt wrote:
> > > > Currently there is no means to
On Wed, Mar 20, 2019 at 07:46:33 +0100, Markus Armbruster wrote:
[...]
> I'm with Igor on this one. I'm all for QEMU going the extra mile to
> help libvirt, simply because that helps a very large fraction of our
> users. I'm now asking libvirt to extend the courtesy back to QEMU.
>
> Please
On Tue, Mar 19, 2019 at 08:18:15 +0100, Christian Ehrhardt wrote:
> On Mon, Mar 18, 2019 at 4:58 PM Peter Krempa wrote:
> >
> > On Mon, Mar 18, 2019 at 16:21:18 +0100, Christian Ehrhardt wrote:
> > > Currently there is no means to permanently modify the metadata stored
> > > within a snapshot if
On Mon, Mar 4, 2019 at 11:42 AM Christian Ehrhardt
wrote:
>
> On Fri, Mar 1, 2019 at 5:56 PM Jamie Strandboge wrote:
> >
> > On Mon, 18 Feb 2019, Christian Ehrhardt wrote:
> >
> > > So far we were detecting at guest start if any devices needed vhost net
> > > and only if that was true added a
Daniel P. Berrangé writes:
> On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote:
>> On Thu, 7 Mar 2019 10:07:05 +
>> Daniel P. Berrangé wrote:
>>
>> > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote:
>> > > On Wed, 6 Mar 2019 18:16:08 +
>> > > Daniel P.
45 matches
Mail list logo
