On 3/29/19 9:33 AM, Peter Krempa wrote:
This was meant to stop abusing the members directly, but we don't do
this for other internal structs. Additionally this did not stop the
test from touching the members. Remove the header obscurization.
I agree with you that this obfuscation does nothing
Purge apps that are dead and fix broken links
Daniel P. Berrangé (4):
apps: remove dead archipel project
apps: update link for buildbot
apps: drop link for zenoss software
apps: remove VM Manager android app
docs/apps.html.in | 39 +--
1 file changed,
The VM Manager app is no longer present on the Play store and while
Google shows a couple of hits they look like the typical untrustworthy
3rd party download redistributors rather than an official site.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 11
The libvirt specific page linked for buildbot is a 404. This replacement
link is the closest to what was originally linked.
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index
The page we link to is a 404 and github repo hasn't been touched since
2012 so is clearly dead.
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index 5108994911..33e205bd9e 100644
---
The project website http://archipelproject.org/ is dead, reporting a
cloudflare error message
The git repo at https://github.com/ArchipelProject/Archipel/ hasn't
had a commit since Nov 2016, and the last release was a beta6 release
in 2013.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P.
On Wed, 2019-03-27 at 17:10 +, Daniel P. Berrangé wrote:
> The Travis CI system uses docker containers for its build environment.
> These are pre-built and hosted under quay.io/libvirt so that developers
> can use them for reproducing problems locally.
Throughout the commit message,
On Fri, 2019-03-29 at 15:05 +, Daniel P. Berrangé wrote:
> On Fri, Mar 29, 2019 at 03:35:54PM +0100, Andrea Bolognani wrote:
> > I'm not sure what was on the page previously linked to...
>
> No idea either.
I got curious and went Wayback (get it?), here's the most recent
copy I could find at
On Fri, Mar 29, 2019 at 03:35:54PM +0100, Andrea Bolognani wrote:
> On Fri, 2019-03-29 at 14:12 +, Daniel P. Berrangé wrote:
> > The libvirt specific page linked for buildbot is a 404. There is no
> > stable replacement link, just ever changing version number specific
> > links per-release.
On Fri, 2019-03-29 at 14:12 +, Daniel P. Berrangé wrote:
> The VM Manager app is no longer present on the Play store and while
> google shows a couple of hits they look like the typical untrustworthy
s/google/Google.
With that fixed,
Reviewed-by: Andrea Bolognani
Both this and 1/4 are
On Fri, 2019-03-29 at 14:12 +, Daniel P. Berrangé wrote:
> The page we link to is a 404 and there is not an obvious libvirt
> specific replacement, so use the project homepage instead.
I would say
https://www.zenoss.com/product/zenpacks/libvirt-virtualization
looks like a reasonable
On Fri, 2019-03-29 at 14:12 +, Daniel P. Berrangé wrote:
> The libvirt specific page linked for buildbot is a 404. There is no
> stable replacement link, just ever changing version number specific
> links per-release. Just link to the top of the project site instead.
Would either
On Fri, Mar 29, 2019 at 01:26:34PM +0100, Peter Krempa wrote:
> Failure of qemuMonitorGetVersion is fatal now that we only support QMP
> based qemus. Remove the debug message since we report an error already.
>
> Signed-off-by: Peter Krempa
> ---
Reviewed-by: Erik Skultety
--
libvir-list
On Fri, 2019-03-29 at 14:12 +, Daniel P. Berrangé wrote:
> The project website http://archipelproject.org/ is dead, reporting a
> cloudflare error message
>
> The git repo at https://github.com/ArchipelProject/Archipel/ hasn't
> had a commit since Nov 2016, and the last release was a beta6
On Fri, Mar 29, 2019 at 01:26:33PM +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
Let's include the TCG equivalent of the same function.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Mar 29, 2019 at 01:26:32PM +0100, Peter Krempa wrote:
> If the detected qemu version is below our required version 'package'
> would be leaked.
>
> Signed-off-by: Peter Krempa
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 37 +
1 file changed, 37 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2067830848..fcf8520132 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -148,8 +148,45 @@
tables are not
Purge apps that are dead and fix broken links
Daniel P. Berrangé (4):
apps: remove dead archipel project
apps: update link for buildbot
apps: update link for zenoss software
apps: remove VM Manager android app
docs/apps.html.in | 35 ++-
1 file changed, 2
The libvirt specific page linked for buildbot is a 404. There is no
stable replacement link, just ever changing version number specific
links per-release. Just link to the top of the project site instead.
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 2 +-
1 file changed, 1
The page we link to is a 404 and there is not an obvious libvirt
specific replacement, so use the project homepage instead.
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/apps.html.in b/docs/apps.html.in
index
The project website http://archipelproject.org/ is dead, reporting a
cloudflare error message
The git repo at https://github.com/ArchipelProject/Archipel/ hasn't
had a commit since Nov 2016, and the last release was a beta6 release
in 2013.
Signed-off-by: Daniel P. Berrangé
---
The VM Manager app is no longer present on the Play store and while
google shows a couple of hits they look like the typical untrustworthy
3rd party download redistributors rather than an official site.
Signed-off-by: Daniel P. Berrangé
---
docs/apps.html.in | 11 ---
1 file changed, 11
On Fri, Mar 29, 2019 at 01:26:31PM +0100, Peter Krempa wrote:
> Most probing functions in virQEMUCapsInitQMPMonitor decide internally if
> there's anything to do and return success if there isn't. Move the
> decision logic for virQEMUCapsProbeQMPGICCapabilities,
>
Hey,
On Wed, Mar 27, 2019 at 01:32:44PM +0100, Ján Tomko wrote:
> Please use --cover-letter for series with two or more patches for neater
> alignment of e-mails.
>
> On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote:
> > This also adjusts the argument name which should be
On Fri, Mar 29, 2019 at 01:26:30PM +0100, Peter Krempa wrote:
> Some caps are cleared according to some more advanced logic after
> detection. Split all that logic out into virQEMUCapsInitProcessCaps.
>
> Signed-off-by: Peter Krempa
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
Pavel Hrdina writes:
> On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote:
>> Pavel Hrdina writes:
>>
>> > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
>> >> Eric Blake writes:
>> >>
>> >> > On 3/28/19 3:06 PM, Eric Blake wrote:
>> >> >> On 3/28/19 2:32
Using copy_on_read for removable disks is a hassle. It also does not
work for CDROMs at all as the image is supposed to be read-only and we
might ignore it for floppies when they are started as empty. Forbid it
for floppies completely rather than trying to support what probably
nobody is using.
Until the block job completes we can't change the disk chain. Removal
would fail as the block job still has reference to the chain.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 54afb6dd7b..e903d36fec 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -2668,14 +2668,13 @@
qemuDomainChangeGraphicsPasswords and qemuDomainRemoveHostDevice
don't use 'cfg' any more.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 4e94d80f21..0318547bd8 100644
---
Unref the config pointer automatically in code paths which get a local
copy.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 40 +---
1 file changed, 13 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
First patch is not entirely relevant in this series.
Peter Krempa (5):
qemu: domain: Use VIR_AUTOFREE in
qemuDomainObjPrivateXMLParseBlockjobs
qemu: hotplug: Remove unused copies of virQEMUDriverConfigPtr
qemu: hotplug: Use VIR_AUTOUNREF for virQEMUDriverConfigPtr
qemu: hotplug:
On Fri, Mar 29, 2019 at 01:26:29PM +0100, Peter Krempa wrote:
> virQEMUCapsInitQMPMonitor is massive now since it collects calls to the
> various probing functions and also version based capabilities. Split
> out the version based caps into a separate function.
>
> Signed-off-by: Peter Krempa
>
The last step of the conversion involves copying of the generated JSON
into a separate string. We can use a virBuffer to do this as this will
also allow to subsequently use the buffer when we actually need to do
some other formatting of the string.
Signed-off-by: Peter Krempa
---
The internal qemu machinery already logs the sent message via the PROBE
point in qemuMonitorSend and the monitor receive function. Those are way
better as they are easy grepable. Remove the additional ones from the
monitor code which just duplicate the sent data.
Signed-off-by: Peter Krempa
---
Sent this out to the list a few days ago, but never saw it appear on the
archives. Resending--hopefully this makes it to the list.
---
For pinned vcpus, vcpupin will report inaccurate affinity values on machines
with high core counts (256 cores in my case). The problem is produced as
follows:
$
This was meant to stop abusing the members directly, but we don't do
this for other internal structs. Additionally this did not stop the
test from touching the members. Remove the header obscurization.
Signed-off-by: Peter Krempa
---
src/util/virbuffer.c | 12
src/util/virbuffer.h
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 4 ++--
src/util/virjson.h | 5 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 73ef24d66f..7b9ea23ab9 100644
---
We have tests that validate the XML formatter. Additionally almost every
guide tells users to disable JSON logging. Drop logging of output string
in virJSONValueToString.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
Use virJSONValueToBuffer so that we can append the command terminator
string without copying of the string again. Also avoid a 'strlen' as we
can query the buffer use size.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 13 -
1 file changed, 8 insertions(+), 5
Use size_t for all sizes. The '*' modifier unfortunately does require an
int so a temporary variable is necessary in the tests.
Signed-off-by: Peter Krempa
---
src/util/virbuffer.c | 2 +-
src/util/virbuffer.h | 6 +++---
tests/virbuftest.c | 4 +++-
3 files changed, 7 insertions(+), 5
Remove a few unnecessary copies of the JSON string as well as duplicate
and unneeded debug logs.
Peter Krempa (7):
util: buffer: Remove struct member munging
util: buffer: Use 'size_t' for buffer size variables
util: json: Use virBuffer in JSON->string conversion
util: json: Don't bother
On Fri, 2019-03-29 at 13:40 +0100, Michal Privoznik wrote:
> On 3/22/19 1:21 PM, Andrea Bolognani wrote:
> > tests/virstoragetest.c | 50 +-
> > 1 file changed, 10 insertions(+), 40 deletions(-)
>
> ACK and safe for freeze.
Thanks for the review :)
On 3/22/19 1:21 PM, Andrea Bolognani wrote:
The layout of my home directory is somewhat peculiar: I store
all git repositories in ~/src/upstream, but since I spend
almost all of my time hacking on libvirt, I also have a
convenience symlink ~/src/libvirt -> ~/src/upstream/libvirt
that I use to
If the detected qemu version is below our required version 'package'
would be leaked.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
virQEMUCapsInitQMPMonitor is massive now since it collects calls to the
various probing functions and also version based capabilities. Split
out the version based caps into a separate function.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 124
Failure of qemuMonitorGetVersion is fatal now that we only support QMP
based qemus. Remove the debug message since we report an error already.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
Some cleanups done while attempting to implement a new capability.
Peter Krempa (6):
qemu: caps: Separate capabilities based on qemu version
qemu: caps: Aggregate all caps post-processing into a function
qemu: capabilities: Move logic deciding whether to probe into probing
functions
Some caps are cleared according to some more advanced logic after
detection. Split all that logic out into virQEMUCapsInitProcessCaps.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 85 +---
1 file changed, 50 insertions(+), 35 deletions(-)
diff
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 37 +---
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index e3db7ce71c..2127cfb85c 100644
---
Most probing functions in virQEMUCapsInitQMPMonitor decide internally if
there's anything to do and return success if there isn't. Move the
decision logic for virQEMUCapsProbeQMPGICCapabilities,
virQEMUCapsProbeQMPSEVCapabilities, and virQEMUCapsProbeQMPSchemaCapabilities
into the function itself
>
> On Wed, Mar 20, 2019 at 8:53 AM Peter Krempa
> wrote:
>
> I'm not persuaded that this workaround is necessary.
>
> Thanks Peter for taking a deeper look!
>
> And yes your summary seems correct.
> I personally still like to give admins the ability to force configs,
> but I'm ok if the
ping
On Fri, 2019-03-22 at 13:21 +0100, Andrea Bolognani wrote:
> The layout of my home directory is somewhat peculiar: I store
> all git repositories in ~/src/upstream, but since I spend
> almost all of my time hacking on libvirt, I also have a
> convenience symlink ~/src/libvirt ->
On Thu, Mar 28, 2019 at 01:54:50PM -0400, Laine Stump wrote:
On 3/28/19 10:34 AM, Ján Tomko wrote:
A marco for comparing string fields of the disk.
Polo'ed-by: Laine Stump
(seriously, though - s/marco/macro/ :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1601677
Signed-off-by: Ján
On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote:
> Pavel Hrdina writes:
>
> > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >> > On 3/28/19 3:06 PM, Eric Blake wrote:
> >> >> On 3/28/19 2:32 PM, Markus Armbruster wrote:
> >>
Our PCIe topology depends on the availability of PCIe Root Ports,
so if none of the suitable devices (pcie-root-port, ioh3420) is
compiled into QEMU we should fall back to virtio-mmio rather than
trying to use PCI addresses only to fail immediately afterwards
when we realize we can't use the
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2067830848..5715d0a510 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -148,6 +148,18 @@
tables are not required.
>
> On Wed, Mar 20, 2019 at 8:53 AM Peter Krempa
> wrote:
>
> I'm not persuaded that this workaround is necessary.
>
> Thanks Peter for taking a deeper look!
>
> And yes your summary seems correct.
> I personally still like to give admins the ability to force configs,
> but I'm ok if the
The rules are the same for all virt guests, regardless of the
architecture.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain_address.c | 38 --
1 file changed, 9 insertions(+), 29 deletions(-)
diff --git a/src/qemu/qemu_domain_address.c
Now that the patches necessary to enable pcie-root-port usage on
RISC-V have been merged into QEMU, we can go ahead and start using
PCI by default on such guests when appropriate.
The full series, with patch 3/4 in its unabridged form, can be
obtained from
There are a few differences, but the one we're interested in is
that PCIe Root Ports are finally available: as a result of this,
our riscv64-virt-headless guest will switch from virtio-mmio to
virtio-pci.
Signed-off-by: Andrea Bolognani
---
This version of the patch is heavily snipped to comply
Pavel Hrdina writes:
> On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>> > On 3/28/19 3:06 PM, Eric Blake wrote:
>> >> On 3/28/19 2:32 PM, Markus Armbruster wrote:
>> >>> Markus Armbruster writes:
>> Pavel Hrdina writes:
>> >>
>> > I'm
The libvirt project no longer considers it a target platform.
The corresponding libvirt-jenkins-ci commit is c6c648534dd1.
Signed-off-by: Andrea Bolognani
---
buildenv-ubuntu-16.Dockerfile | 85 ---
1 file changed, 85 deletions(-)
delete mode 100644
The corresponding platforms are not longer supported by the
libvirt-jenkins-ci project.
Series pushed under the Dockerfile refresh rule.
Andrea Bolognani (2):
Drop Debian 8 Dockerfile
Drop Ubuntu 16.04 Dockerfile
buildenv-debian-8.Dockerfile | 82 -
The libvirt project no longer considers it a target platform.
The corresponding libvirt-jenkins-ci commit is 170d87bc9810.
Signed-off-by: Andrea Bolognani
---
buildenv-debian-8.Dockerfile | 82
1 file changed, 82 deletions(-)
delete mode 100644
On Thu, Mar 28, 2019 at 05:57:57PM +0100, Andrea Bolognani wrote:
> I'm a bit conflicted about this one: on one hand, unlike Debian 8 we
> haven't really run into any issue with Ubuntu 16.04, we can still
> build almost all projects on it, and it doesn't require any crazy
> hacks to maintain; on
On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 3/28/19 3:06 PM, Eric Blake wrote:
> >> On 3/28/19 2:32 PM, Markus Armbruster wrote:
> >>> Markus Armbruster writes:
> Pavel Hrdina writes:
> >>
> > I'm glad that this is merged now and I
On Thu, 2019-03-28 at 18:42 +0100, Fabiano Fidêncio wrote:
> [snip]
>
> Please, just do a s/18.04/16.04 in the commit message before pushing.
Good catch! I've fixed it locally, thanks :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, 2019-03-28 at 17:37 +, Daniel P. Berrangé wrote:
> On Thu, Mar 28, 2019 at 05:57:57PM +0100, Andrea Bolognani wrote:
> > I'm a bit conflicted about this one: on one hand, unlike Debian 8 we
>
> I don't see a conflict. As your first patch says, our support policy
> has eliminated this
On Thu, Mar 28, 2019 at 05:26:17PM +0100, Andrea Bolognani wrote:
> See patch 1/2 and
>
> https://www.redhat.com/archives/libvir-list/2019-March/msg01864.html
>
> for the rationale.
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On 3/19/19 2:49 PM, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (3):
DO NOT APPLY: Simple reproducer for virDomainObjListRemove
virDomainObjListAddLocked: Produce better error message than
'Duplicate key'
virNWFilterBindingObjListAddLocked: Produce better error
On Fri, Mar 29, 2019 at 02:21:00 +, Zhangbo (Oscar) wrote:
[...]
> >>This does not play well with the fact that processes as the PR helper
> >>are always required.
> >>
> >>Merging them into libvirtd would make the VM stop until libvirtd is
> >>running again. Additionally if any of the
Eric Blake writes:
> On 3/28/19 3:06 PM, Eric Blake wrote:
>> On 3/28/19 2:32 PM, Markus Armbruster wrote:
>>> Markus Armbruster writes:
Pavel Hrdina writes:
>>
> I'm glad that this is merged now and I wanted to start working on
> libvirt patches, but there is one big issue with
Eric Blake [2019-03-28, 09:05AM -0500]:
> Even though Coverity can prove that 'last' is always set if the prior
> loop executed, gcc 8.0.1 cannot:
>
> CC conf/libvirt_conf_la-virdomainmomentobjlist.lo
> ../../src/conf/virdomainmomentobjlist.c: In function
>
74 matches
Mail list logo
