On 4/10/19 12:53 PM, Andrea Bolognani wrote:
> On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> [...]
>> @@ -170,6 +150,11 @@ mymain(void)
>> char *fakerootdir;
>> struct testQemuInfo info;
>> virQEMUDriverConfigPtr cfg = NULL;
>> +virHashTablePtr capslatest = NULL;
>>
On 4/8/19 4:42 AM, Nikolay Shirokovskiy wrote:
> Nikolay Shirokovskiy (3):
> vz: fix for tracking current snapshot
> vz: fixes: snapshot: Switch type of virDomainSnapshotObj.def
> vz: fixes: snapshot: Factor out virDomainMomentDef class
>
> src/vz/vz_driver.c | 36
Checking if a device is a CDROM or floppy disk is a common
verification that is made a few times in the code, and next
patch is going to add one more.
Let's put it into a helper to enhance readability and spare some
lines of code.
Signed-off-by: Daniel Henrique Barboza
---
Commit f1d6585300 ("domain_conf: check device address before attach")
added an address verification for all devices, avoiding calling
the driver attach() for a case in which we know that the device
would have duplicated address.
That commit failed to contemplate the case of CDROM/Floppy devices
Hi,
Jim Fehlig reported a failure in a libvirt-tck test after the
patch:
commit f1d658531c7b23b8796a0faa4411c3531996
Author: Daniel Henrique Barboza
Date: Fri Mar 15 18:06:45 2019 -0300
domain_conf: check device address before
This patch is blocking the use of 'virsh attach-device'
On 4/4/19 5:25 AM, Michal Privoznik wrote:
> This completer is used to offer shutdown/reboot modes.
>
> Signed-off-by: Michal Privoznik
> ---
> tools/virsh-completer.c | 56 +
> tools/virsh-completer.h | 4 +++
> tools/virsh-domain.c| 2 ++
> 3
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> Here is the problem: If all disks had XATTRs (i.e. domains using
> them were started with owner remembering turned on) then
> refcounting implemented in XATTRs would work nicely and we could
> set the whole backing chain and restore it later. But
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> A simple helper function that would be used from DAC and SELinux
> drivers.
>
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_util.c | 75
> src/security/security_util.h | 5 +++
> 2 files
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> Just like previous commit allowed to enable or disable owner
> remembering for each individual path, do the same for SELinux
> driver. This is going to be needed in the next commit.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Cole Robinson
-
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> One caller in particular (virSecurityDACSetImageLabelInternal)
> will want to have the feature turned on only in some cases.
> Introduce @remember member to _virSecurityDACChownItem to track
> whether caller wants to do owner remembering or not.
> The
On Wed, 20 Mar 2019, Christian Ehrhardt wrote:
> On Wed, Mar 20, 2019 at 8:45 AM Christian Ehrhardt
> wrote:
> >
> > On Mon, Mar 4, 2019 at 11:42 AM Christian Ehrhardt
> > wrote:
> > >
> > > On Fri, Mar 1, 2019 at 5:56 PM Jamie Strandboge
> > > wrote:
> > > >
> > > > On Mon, 18 Feb 2019,
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> Both DAC and SELinux drivers support transactions. Each item on
> the transaction list consists of various variables and @restore
> is one of them. Document it so that as the list of variables grow
> it's easier to spot which variable does what.
>
>
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> The way that virSecurityDACRecallLabel is currently written is
> that if XATTRs are not supported for given path to the caller
> this is not different than if the path is still in use. The value
> of 1 is returned which makes secdrivers skip label
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> It's better to have the function report errors, because none of
> the callers does.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virfile.c | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
Reviewed-by: Cole
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> It's better to have the function report errors, because none of
> the callers does.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virfile.c | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
Reviewed-by: Cole
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> The way that security drivers use XATTR is kind of verbose. If
> error reporting was left for caller then the caller would end up
> even more verbose.
>
> There are two places where we do not want to report error if
> virFileGetXAttr fails. Therefore
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> Just like it's DAC counterpart is doing,
> virSecuritySELinuxRestoreAllLabel() could print @migrated in the
> debug message.
>
> Signed-off-by: Michal Privoznik
> ---
> src/security/security_selinux.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On 3/28/19 11:04 AM, Michal Privoznik wrote:
> Firstly, there's no reason to enumerate all XATTRs since they
> differ only in the prefix and we can construct them in a loop.
>
> Secondly, and more importantly, the script was still looking for
> just one prefix "trusted.libvirt.security" even on
On 4/10/19 4:33 PM, Jim Fehlig wrote:
On 4/10/19 1:17 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:33 PM, Jim Fehlig wrote:
On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:08 PM, Jim Fehlig wrote:
I noticed libvirt-tck test domain/207-disk-media-change.t started
On 4/10/19 1:17 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:33 PM, Jim Fehlig wrote:
On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:08 PM, Jim Fehlig wrote:
I noticed libvirt-tck test domain/207-disk-media-change.t started failing
after updating to libvirt 5.2.0. A
On 4/10/19 3:33 PM, Jim Fehlig wrote:
On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:08 PM, Jim Fehlig wrote:
I noticed libvirt-tck test domain/207-disk-media-change.t started
failing after updating to libvirt 5.2.0. A bisection fingered commit
f1d65853
commit
On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:08 PM, Jim Fehlig wrote:
I noticed libvirt-tck test domain/207-disk-media-change.t started failing
after updating to libvirt 5.2.0. A bisection fingered commit f1d65853
commit f1d658531c7b23b8796a0faa4411c3531996
Author:
Drop redundant NULL checks, and add an error string prefix
Signed-off-by: Cole Robinson
---
src/qemu/qemu_monitor_text.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
index 414da0ca28..76095674ab
qemu 4.0.0 will prefix most errors with 'Error: ', so consider any
string instance of that an error.
This fixes savevm failure detection when migration is blocked due to
usage of nested VMX
https://bugzilla.redhat.com/show_bug.cgi?id=1697997
Signed-off-by: Cole Robinson
---
qemu in Fedora 30 rejects migration if the VM has nested VMX
configured. This means managedsave and snapshots are rejected too.
Unfortunately the scraping we need to resort to with the text monitor
snapshot commands is not detecting that 'savevm' actually failed, so
the snapshot appears to
Drop redundant NULL checks, add error string prefixes, consolidate
a few indentical reports.
Signed-off-by: Cole Robinson
---
src/qemu/qemu_monitor_text.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_monitor_text.c
On 4/10/19 3:08 PM, Jim Fehlig wrote:
I noticed libvirt-tck test domain/207-disk-media-change.t started
failing after updating to libvirt 5.2.0. A bisection fingered commit
f1d65853
commit f1d658531c7b23b8796a0faa4411c3531996
Author: Daniel Henrique Barboza
Date: Fri Mar 15 18:06:45
I noticed libvirt-tck test domain/207-disk-media-change.t started failing after
updating to libvirt 5.2.0. A bisection fingered commit f1d65853
commit f1d658531c7b23b8796a0faa4411c3531996
Author: Daniel Henrique Barboza
Date: Fri Mar 15 18:06:45 2019 -0300
domain_conf: check device
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> # define DO_TEST(name, ...) \
> -DO_TEST_FULL(name, WHEN_BOTH, GIC_NONE, __VA_ARGS__)
> +DO_TEST_FULL(name, WHEN_BOTH, ARG_QEMU_CAPS, __VA_ARGS__, QEMU_CAPS_LAST)
Please move ARG_QEMU_CAPS and its arguments to a separate
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> @@ -170,6 +150,11 @@ mymain(void)
> char *fakerootdir;
> struct testQemuInfo info;
> virQEMUDriverConfigPtr cfg = NULL;
> +virHashTablePtr capslatest = NULL;
> +
> +capslatest = testQemuGetCapsLatest();
> +
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> The qemuxml2xml testInfo is now just a subset of testQemuInfo, so it's
> a drop in replacement
>
> Signed-off-by: Cole Robinson
> ---
> tests/qemuxml2xmltest.c | 41 -
> 1 file changed, 12
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> +virHashTablePtr
> +testQemuGetCapsLatest(void)
A better name for this would be testQemuGetLatestCaps(), since it's
literally calling testQemuGetLatestCapsForArch() over a number of
architectures.
Incidentally, both these functions
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> +#define TEST_CAPS_PATH abs_srcdir "/qemucapabilitiesdata"
Note to self: rename this to TEST_QEMU_CAPS_PATH, move it to
testutilsqemu.h, and start using it throughout the test suite
instead of repeating the raw string over and over
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> In preparation for moving these bits to a shared place, rename them
> to match one of the testqemuutils.c function prefixes. Rename
s/testqemuutils/testutilsqemu/
[...]
> static int
> -testCheckExclusiveFlags(int flags)
>
v2 of:
https://www.redhat.com/archives/libvir-list/2019-April/msg00658.html
diff to v1:
- Fixed the reported problem. Basically, even though emulator CGroup was
created qemu was not running in it. Now qemu is moved into the CGroup
even before exec()
Michal Prívozník (2):
There is one string that can be VIR_AUTOFREE used on.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_cgroup.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index c23f0af2aa..689e0839cd 100644
---
It's funny how this went unnoticed for such a long time. Long
story short, if a domain is configured with
VIR_DOMAIN_NUMATUNE_MEM_STRICT libvirt doesn't really honour
that. This is because of 7e72ac787848 after which libvirt allowed
qemu to allocate memory just anywhere and only after that it used
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> @@ -758,6 +747,17 @@ testInfoClear(struct testInfo *info)
> virObjectUnref(info->qemuCaps);
> }
>
> +static int
> +testInfoSetPaths(struct testInfo *info, const char *suffix)
One argument per line.
> +{
> +if
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> Track infile and outfile in testInfo. This is step towards moving path
> creation out of the test case, which will eventually help sharing more
> code with qemuxml2xmltest.c
>
> Signed-off-by: Cole Robinson
> ---
>
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> @@ -40,8 +39,7 @@ testXML2XMLActive(const void *opaque)
> const struct testInfo *info = opaque;
>
> return testCompareDomXML2XMLFiles(driver.caps, driver.xmlopt,
> - info->infile,
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> Just renamed from existing inName and outActiveName
>
> Signed-off-by: Cole Robinson
> ---
> tests/qemuxml2xmltest.c | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
Reviewed-by: Andrea
Signed-off-by: Michal Privoznik
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 21807f26d3..eb97d25c80 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -49,6 +49,18 @@
release.
+
+
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
> These will need to be separate to share testInfo with qemuxml2argv
>
> Signed-off-by: Cole Robinson
> ---
> tests/qemuxml2xmltest.c | 25 +
> 1 file changed, 9 insertions(+), 16 deletions(-)
Reviewed-by: Andrea
It's no longer needed as of libvirt commit 105756660f94.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/update/tasks/kludges.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/guests/playbooks/update/tasks/kludges.yml
b/guests/playbooks/update/tasks/kludges.yml
index
On Wed, Apr 10, 2019 at 16:24:14 +0200, Ján Tomko wrote:
> Also free the backends array, not just its members.
>
> Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_hotplug.c | 1 +
> 1 file changed, 1 insertion(+)
Oops, ACK.
signature.asc
On Fri, Apr 05, 2019 at 06:04:23PM +0200, Peter Krempa wrote:
The function open-codes addition into an array. Use the helper instead.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko
Jano
Also free the backends array, not just its members.
Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101
Signed-off-by: Ján Tomko
---
src/qemu/qemu_hotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 34249bd030..540befba68 100644
---
On Fri, Apr 05, 2019 at 06:04:22PM +0200, Peter Krempa wrote:
Demonstrate how VIR_RETURN_PTR by refactoring qemu_block.c
verb
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 48 +++
1 file changed, 12 insertions(+), 36 deletions(-)
On 4/10/19 3:31 PM, Andrea Bolognani wrote:
Commit 5b9819eedc71 started using the virFileWrapper APIs in
the test program, and correctly called them only in the section
of code guarded by WITH_QEMU; however, a single call to the
virFileWrapperClearPrefixes() function ended up in the
Commit 5b9819eedc71 started using the virFileWrapper APIs in
the test program, and correctly called them only in the section
of code guarded by WITH_QEMU; however, a single call to the
virFileWrapperClearPrefixes() function ended up in the
hypervisor-agnostic section, causing a build failure on
On 4/10/19 12:35 AM, Daniel Henrique Barboza wrote:
Hi,
On 4/9/19 11:10 AM, Michal Privoznik wrote:
If there's a domain configured as:
4096
but there is not enough memory on NUMA node 1 the domain will start
successfully because we allow it to allocate memory from other
The virFileWrapperClearPrefixes() function is defined only when
building for non-WIN32.
Signed-off-by: Michal Privoznik
---
Technically a build breaker fix, but I can't decide if ifdef is better
or removing the call is better.
tests/domaincapstest.c | 2 ++
1 file changed, 2 insertions(+)
On 4/10/19 10:35 AM, Laszlo Ersek wrote:
Hi,
On 04/09/19 16:52, Michal Privoznik wrote:
v2 of:
https://www.redhat.com/archives/libvir-list/2019-April/msg00460.html
diff to v1:
- Expose 'secure' too
- Switch to uint64_t for qemuFirmwareGetSupported()
Michal Prívozník (4):
qemu_firmware:
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
> GitLab CI provides some shared build runners that use Docker containers.
> This resource can usefully run cross-compiled builds since all other CI
> build testing is currently x86 only, and Travis CI is already very busy
> testing
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> + @echo "Available cross-compiler container images:"
> + @echo
> + @echo "debian-[9,sid]-cross-aarch64"
All these should look either like
debian-{9,sid}-cross-...
(shell style, my personal preference) or
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
> Now that we don't have separate scripts defined for native and mingw
> builds, there is no point having one for macOS. It can just be inlined
> at the one place it is needed.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .travis.yml
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> ./autogen.sh --prefix=\$(pwd)/install-root &&
> make -j3 &&
> make -j3 install &&
> -make -j3 dist ||
> -(
> - echo '=== LOG FILE(S) START ===';
> - find -name
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> +addons:
> + homebrew:
> +update: true
> +packages:
> + - ccache
Looking at
https://docs.travis-ci.com/user/caching/#ccache-cache
I'm pretty sure we're not taking advantage of ccache support at
all... We might
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> + script:
> +- make -f Makefile.ci ci-build@$IMAGE MAKE_ARGS="$MAKE_ARGS"
Because of the changes made to Makefile.ci since v3, you need to use
CI_MAKE_ARGS="$MAKE_ARGS" here and...
> + script:
> +-
On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> It is also possible to do cross compiled builds via the Debian containers
>
>make ci-build@debian-9-cross-s390x
You're not advertising cross-compilation images until commit 6/7,
so either drop this from the commit message
This reverts commit a5e16020907e91bca1b0ab6c4ee5dbbdcccf6a54.
Getting rid of unistd.h from our headers will require more work than
just fixing the broken mingw build. Revert it until I have a more
complete proposal.
Signed-off-by: Peter Krempa
---
Pushed under the build-breaker rule.
Hi,
On 04/09/19 16:52, Michal Privoznik wrote:
> v2 of:
>
> https://www.redhat.com/archives/libvir-list/2019-April/msg00460.html
>
> diff to v1:
> - Expose 'secure' too
> - Switch to uint64_t for qemuFirmwareGetSupported()
>
> Michal Prívozník (4):
> qemu_firmware: Separate firmware loading
Commit e423182b4528 updated the host list for the job, but got
things slightly wrong in that it included libvirt-debian-sid,
libvirt-freebsd-current and libvirt-ubuntu-18 in the Jenkins
configuration rather than the Ansible one.
Signed-off-by: Andrea Bolognani
---
Pushed as a trivial fix.
On Wed, 2019-04-03 at 10:51 +0200, Ján Tomko wrote:
> Ján Tomko (2):
> Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU
> fixup: regroup QEMU capabilities
>
> src/qemu/qemu_capabilities.c | 248 +--
> src/qemu/qemu_capabilities.h | 248
On Mon, 2019-04-08 at 14:01 +0200, Fabiano Fidêncio wrote:
> This patch set updates both libosinfo and osinfo-db-tools deps. The
> changes done are, basically:
> libosinfo:
> - drop gnome-common
> - drop intltool
>
> osinfo-db-tools:
> - drop gnome-common
> - drop intltool
> - add python3
> - add
On Mon, 2019-04-08 at 14:01 +0200, Fabiano Fidêncio wrote:
> libosinfo's commit 3a2dd3050 dropped intltool dependency.
>
> signed-off-by: Fabiano Fidêncio
Note the lower-case "s" at the start: our commit hook prevented
me from pushing until I fixed it manually.
--
Andrea Bolognani / Red Hat /
On Wed, Apr 10, 2019 at 3:30 AM Cole Robinson wrote:
> You missed v2 in the subject. format-patch -v2 or send-email -v2 will
> add it.
>
> Patch subjects should be short, 50 chars is the goal though sometimes
> that's not practical. This is a good set of guidelines:
>
67 matches
Mail list logo
