On Thu, May 09, 2019 at 11:24:49PM +0800, Cornelia Huck wrote:
> On Wed, 8 May 2019 07:57:05 -0400
> Yan Zhao wrote:
>
> > On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote:
> > > On Sun, 5 May 2019 21:49:04 -0400
> > > Yan Zhao wrote:
> > >
> > > > version attribute is used to
On 5/9/19 9:18 AM, Andrea Bolognani wrote:
On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote:
Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did
not consider SLE 12 which still has 2.0.1 that does not ship
"SLE" is no longer a thing, so either
s/SLE/SUSE Linux
This is a VM with 'osxsave' capability declared, when there is no
'osxsave' guest support, using this series on top of current master:
$ sudo ./run tools/virsh start ub1810-osxsave
error: Failed to start domain ub1810-osxsave
error: internal error: process exited while connecting to monitor:
On Thu, May 9, 2019 at 4:36 PM Michal Privoznik wrote:
>
> On 5/7/19 10:23 PM, Ilias Stamatis wrote:
> > Return the number of disks present in the configuration of the fake
> > driver when called with @errors as NULL and @maxerrors as 0.
> >
> > Otherwise return 0 as the number of errors
On 5/9/19 6:31 AM, Christian Ehrhardt wrote:
On Tue, May 7, 2019 at 11:03 PM Daniel Henrique Barboza
wrote:
On 4/25/19 9:50 AM, Christian Ehrhardt wrote:
Hi,
this series tries to address a drop of commandline options by qemu in regard to
osxsave [1] and ospke [2].
This was already
* Cornelia Huck (coh...@redhat.com) wrote:
> On Thu, 9 May 2019 16:48:57 +0100
> "Dr. David Alan Gilbert" wrote:
>
> > * Cornelia Huck (coh...@redhat.com) wrote:
> > > On Tue, 7 May 2019 15:18:26 -0600
> > > Alex Williamson wrote:
> > >
> > > > On Sun, 5 May 2019 21:49:04 -0400
> > > > Yan
On Thu, 9 May 2019 16:48:57 +0100
"Dr. David Alan Gilbert" wrote:
> * Cornelia Huck (coh...@redhat.com) wrote:
> > On Tue, 7 May 2019 15:18:26 -0600
> > Alex Williamson wrote:
> >
> > > On Sun, 5 May 2019 21:49:04 -0400
> > > Yan Zhao wrote:
> >
> > > > + Errno:
> > > > + If vendor
* Cornelia Huck (coh...@redhat.com) wrote:
> On Tue, 7 May 2019 15:18:26 -0600
> Alex Williamson wrote:
>
> > On Sun, 5 May 2019 21:49:04 -0400
> > Yan Zhao wrote:
>
> > > + Errno:
> > > + If vendor driver wants to claim a mdev device incompatible to all
> > > other mdev
> > > + devices,
On Thu, May 09, 2019 at 04:25:03PM +0200, Andrea Bolognani wrote:
> On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> > Subject: mappings: add pulseaudio libs for native packages
>
> Again, this can be
>
> mappings: Add PulseAudio
>
> [...]
> > + pulseaudio:
> > +rpm:
On Tue, 7 May 2019 15:18:26 -0600
Alex Williamson wrote:
> On Sun, 5 May 2019 21:49:04 -0400
> Yan Zhao wrote:
> > + Errno:
> > + If vendor driver wants to claim a mdev device incompatible to all other
> > mdev
> > + devices, it should not register version attribute for this mdev device.
Hi all,
I'm getting started with hacking around with libvirt and am trying to
familiarize myself with launching and running an instance of libvirtd
I built from source on Centos 7.6.
Following the instructions from https://libvirt.org/compiling.html to
launch my built versions of libvirtd and
On Thu, May 09, 2019 at 05:16:16PM +0200, Pavel Hrdina wrote:
> The HAL driver is not used by any supported Linux, the only possible
> user could be FreeBSD, but the official libvirt port disables HAL
> driver unconditionally which means probably nobody is using it there.
Last time we asked,
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Don't assume that all projects have a dedicated tests/ subdirectory
> for unit tests.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/playbooks/build/jobs/autotools-check-job.yml | 2 +-
> jenkins/jobs/autotools.yaml
On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote:
> Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did
> not consider SLE 12 which still has 2.0.1 that does not ship
"SLE" is no longer a thing, so either
s/SLE/SUSE Linux Enterprise Server/
(preferred) or
s/SLE/SLES/
On Wed, 8 May 2019 07:57:05 -0400
Yan Zhao wrote:
> On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote:
> > On Sun, 5 May 2019 21:49:04 -0400
> > Yan Zhao wrote:
> >
> > > version attribute is used to check two mdev devices' compatibility.
> > >
> > > The key point of this
The function was deprecated in udev 219 and all the supported OSes
don't have older version of udev or systemd.
Signed-off-by: Pavel Hrdina
---
m4/virt-udev.m4| 5
src/node_device/node_device_udev.c | 41 --
2 files changed, 46 deletions(-)
Pavel Hrdina (2):
node_device_udev: remove deprecated logging function
src: remove HAL node device driver
configure.ac | 3 +-
docs/drvnodedev.html.in | 3 +-
docs/hvsupport.pl| 2 +-
libvirt.spec.in | 1 -
The HAL driver is not used by any supported Linux, the only possible
user could be FreeBSD, but the official libvirt port disables HAL
driver unconditionally which means probably nobody is using it there.
Signed-off-by: Pavel Hrdina
---
HAL was deprecated on FreeBSD as well and the current
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Subject: mappings: remove gtk-vnc2 native and mingw packages
This can be simply
mappings: Remove gtk-vnc2
Either way
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> guests/playbooks/build/jobs/defaults.yml | 1 +
> guests/vars/projects/virt-viewer+mingw32.yml | 1 -
> guests/vars/projects/virt-viewer+mingw64.yml | 1 -
>
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> +++ b/jenkins/projects/gtk-vnc.yaml
> @@ -0,0 +1,15 @@
> +---
> +- project:
> +name: gtk-vnc
> +machines: '{all_machines}'
> +title: GTK-VNC
> +archive_format: gz
> +git_url: '{git_urls[gtk-vnc][default]}'
> +
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
[...]
> +++ b/guests/playbooks/build/projects/gtk-vnc.yml
> @@ -0,0 +1,12 @@
> +---
> +- set_fact:
> +name: gtk-vnc
> +machines: '{{ all_machines }}'
> +archive_format: gz
> +git_url: '{{ git_urls["gtk-vnc"][git_remote]
On Thu, May 09, 2019 at 04:10:36PM +0200, Olaf Hering wrote:
> Am Thu, 9 May 2019 13:31:45 +0200
> schrieb Ján Tomko :
>
> > +dnl TODO: delete this in July 2020
>
> Does this come with a cost? I mean, SLE_12 is not going away any time soon.
> Just dropping things because we can seems to be
On 5/7/19 10:23 PM, Ilias Stamatis wrote:
Return the number of disks present in the configuration of the fake
driver when called with @errors as NULL and @maxerrors as 0.
Otherwise return 0 as the number of errors encountered.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 27
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Subject: mappings: add pulseaudio libs for native packages
Again, this can be
mappings: Add PulseAudio
[...]
> + pulseaudio:
> +rpm: pulseaudio-libs-devel
> +deb: libpulse-dev
Lines are not in alphabetical order.
More
On Thu, May 09, 2019 at 03:56:20PM +0200, Martin Kletzander wrote:
> On Thu, May 09, 2019 at 01:54:42PM +0100, Daniel P. Berrangé wrote:
> > On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote:
> > > The way it works now the Makefile needs to be both make valid and automake
> > >
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Subject: mappings: add libgcrypt native & mingw packages
This can be simply
mappings: Add libgcrypt
[...]
> + libgcrypt:
> +rpm: libgcrypt-devel
> +deb: libgcrypt20-dev
> +cross-policy-deb: foreign
This should be
Am Thu, 9 May 2019 13:31:45 +0200
schrieb Ján Tomko :
> +dnl TODO: delete this in July 2020
Does this come with a cost? I mean, SLE_12 is not going away any time soon.
Just dropping things because we can seems to be the wrong approach.
There might be other new things that must be used in
Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did
not consider SLE 12 which still has 2.0.1 that does not ship
a pkg-config file.
Similar to how we check for readline, prefer pkg-config if available
and fall back to the old detection code if not found.
NB: this is not a clean
On Thu, 2019-05-09 at 13:31 +0200, Ján Tomko wrote:
> + PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0])
> +
> + if test $use_pkgconfig = 1; then
> +dnl 2.0.3 was the version where the pkg-config file was first added
> +LIBVIRT_CHECK_PKG([YAJL], [yajl], [2.0.3])
> +
On Thu, May 09, 2019 at 01:54:42PM +0100, Daniel P. Berrangé wrote:
On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote:
The way it works now the Makefile needs to be both make valid and automake
valid. That is fine for now, but if we want to use anything more advanced, like
On Thu, 2019-05-09 at 13:08 +0100, Daniel P. Berrangé wrote:
> On Tue, May 07, 2019 at 03:17:40PM +0200, Andrea Bolognani wrote:
> > - name: Bootstrap Ansible
> > - raw: 'yum install -y {{ python }}'
> > - when:
> > -- package_format == 'rpm'
> > -
> > -- name: Bootstrap Ansible
> > - raw:
On Thu, Apr 18, 2019 at 04:43:07PM +0200, Peter Krempa wrote:
Use qemuDomainStorageSourceAccessModify with correct flags to do the
job.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 30 ++
1 file changed, 6 insertions(+), 24 deletions(-)
Reviewed-by:
On Thu, Apr 18, 2019 at 04:43:06PM +0200, Peter Krempa wrote:
Some operations e.g. namespace setup are not necessary when modifying
access to a file which the VM can already access. Add a flag which
allows to skip them.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 11 ---
1
On Thu, Apr 18, 2019 at 04:43:05PM +0200, Peter Krempa wrote:
In some cases when we need to modify access permissions for a storage
source which is already used by the VM we should not revoke all
permissions on a failure. Allow this in qemuDomainStorageSourceAccessModify
by adding a new flag.
On Thu, Apr 18, 2019 at 04:43:04PM +0200, Peter Krempa wrote:
Rather than jumping to the correct label use a set of booleans to
determine which operation needs to be rolled back. This will allow more
flexibility when e.g. rollback after a failed operation will not be
necessary/desired.
On Thu, Apr 18, 2019 at 04:43:03PM +0200, Peter Krempa wrote:
Add a new flag which will set the image as read-only even if the image
data allows writing.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Ján Tomko
Jano
On Tue, May 07, 2019 at 05:45:31PM +0200, Martin Kletzander wrote:
> This way more users can run our CI builds locally.
>
> Signed-off-by: Martin Kletzander
> ---
> Makefile.ci | 125 ++--
> 1 file changed, 93 insertions(+), 32 deletions(-)
>
>
On Wed, May 08, 2019 at 17:24:12 -0500, Eric Blake wrote:
> This brings about a couple of benefits:
> - use of VIR_AUTOUNREF() simplifies several callers
> - Fixes a todo about virDomainMomentObjList not being polymorphic enough
>
> Signed-off-by: Eric Blake
> ---
> src/conf/moment_conf.h
On Wed, May 08, 2019 at 17:24:11 -0500, Eric Blake wrote:
> In preparation for making virDomainSnapshotDef a descendant of
> virObject, it is time to fix all callers that allocate an object to
> use virDomainSnapshotDefNew() instead of VIR_ALLOC(). Fortunately,
> there aren't very many :)
>
>
On Wed, May 08, 2019 at 17:24:10 -0500, Eric Blake wrote:
> VIR_CLASS_NEW insists that descendents of virObject have 'parent' as
> the name of their inherited member at offset 0. While it would be
> possible to write a new class-creation macro that takes the actual
> field name 'current', and
On Tue, May 07, 2019 at 05:45:30PM +0200, Martin Kletzander wrote:
> The way it works now the Makefile needs to be both make valid and automake
> valid. That is fine for now, but if we want to use anything more advanced,
> like
> conditionals, we cannot have it like that any more.
>
> So
On Tue, May 07, 2019 at 12:15:32PM +0200, Andrea Bolognani wrote:
> Fedora 30 is out, which means that Fedora 28 is going to be
> EOL very soon. Let's get ahead of the game and drop support
> for it right now.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 2 +-
>
On Thu, May 02, 2019 at 06:28:13PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/host_vars/libvirt-fedora-28/docker.yml | 2 -
> .../host_vars/libvirt-fedora-28/install.yml | 2 -
> guests/host_vars/libvirt-fedora-28/main.yml | 24 --
>
On Thu, May 02, 2019 at 06:28:12PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/playbooks/build/jobs/defaults.yml| 2 --
> guests/playbooks/build/projects/libvirt-dbus.yml| 3 ---
> guests/playbooks/build/projects/libvirt-go-xml.yml | 1 -
>
On Thu, May 02, 2019 at 06:28:11PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/playbooks/build/jobs/defaults.yml| 2 ++
> guests/playbooks/build/projects/libvirt-dbus.yml| 3 +++
> guests/playbooks/build/projects/libvirt-go-xml.yml | 1 +
>
On Thu, May 02, 2019 at 06:28:10PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/host_vars/libvirt-fedora-30/docker.yml | 2 +
> .../host_vars/libvirt-fedora-30/install.yml | 2 +
> guests/host_vars/libvirt-fedora-30/main.yml | 24 ++
>
On Wed, May 08, 2019 at 17:24:09 -0500, Eric Blake wrote:
> VIR_CLASS_NEW insists that descendents of virObject have 'parent' as
> the name of their inherited member at offset 0. While it would be
> possible to write a new class-creation macro that takes the actual
> field name, and rewrite
On Tue, May 07, 2019 at 03:17:40PM +0200, Andrea Bolognani wrote:
> Instead of hardcoding the name of the package manager in
> commands, use the value obtained from the inventory.
>
> In some cases this is necessary, eg. when RPM-based
> distributions are involved; for most other cases we could
>
On Tue, May 07, 2019 at 03:17:41PM +0200, Andrea Bolognani wrote:
> We're already doing this for FreeBSD, so do it for CentOS
> and Fedora as well.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/playbooks/update/tasks/base.yml | 11 +--
> 1 file changed, 1 insertion(+), 10
On Tue, May 07, 2019 at 03:17:42PM +0200, Andrea Bolognani wrote:
> Now that we are using package_manager everywhere instead of
> hardcoding the names, it's finally possible to make the
> alignment of the resulting Dockerfiles perfect.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool
Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did
not consider SLE 12 which still has 2.0.1 that does not ship
a pkg-config file.
Similar to how we check for readline, prefer pkg-config if available
and fall back to the old detection code if not found.
NB: this is not a clean
On Tue, May 07, 2019 at 03:17:39PM +0200, Andrea Bolognani wrote:
> Platforms that share the same package format might still want
> to use different package managers, a good example being CentOS
> with yum and Fedora with dnf.
>
> Signed-off-by: Andrea Bolognani
> ---
>
On Thu, May 09, 2019 at 12:53:07 +0200, Martin Kletzander wrote:
> On Thu, May 09, 2019 at 12:43:33PM +0200, Peter Krempa wrote:
> > Document that checking if a integer is (non-)zero should (not must)
> > avoid the shortened form that C allows as it may confuse readers into
> > overlooking the
On Thu, May 09, 2019 at 12:43:33PM +0200, Peter Krempa wrote:
Document that checking if a integer is (non-)zero should (not must)
avoid the shortened form that C allows as it may confuse readers into
overlooking the other possible values which might be interresting to
handle.
While pointers
Peter Krempa (3):
docs: hacking: Document few practices for creating error messages
docs: hacking: Add good practices for shortening conditional
expressions
docs: hacking: Discourage use of the ternary operator and ban it's
abuse
docs/hacking.html.in | 61
Forbid breaking lines inside the two branches of the ternary operator
and nesting them. Using it in these instances does not help readability.
Signed-off-by: Peter Krempa
---
docs/hacking.html.in | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/hacking.html.in
State that error messages should not be broken into multiple lines for
programmer friendliness and should not be concatenated on the fly for
translator friendliness and few other details.
Signed-off-by: Peter Krempa
---
docs/hacking.html.in | 28
1 file changed, 28
Document that checking if a integer is (non-)zero should (not must)
avoid the shortened form that C allows as it may confuse readers into
overlooking the other possible values which might be interresting to
handle.
While pointers have distinct values from the point of view of the code
we only
On Tue, May 07, 2019 at 11:54:20AM +0200, Andrea Bolognani wrote:
> On Tue, 2019-04-16 at 11:19 +0100, Daniel P. Berrangé wrote:
> > +.job_template: _definition
> > + script:
> > +- mkdir vpath
> > +- cd vpath
>
> We use build/ for CentOS CI and Travis CI builds, so let's stick
> with
On Tue, May 7, 2019 at 11:03 PM Daniel Henrique Barboza
wrote:
>
>
>
> On 4/25/19 9:50 AM, Christian Ehrhardt wrote:
> > Hi,
> > this series tries to address a drop of commandline options by qemu in
> > regard to
> > osxsave [1] and ospke [2].
> > This was already discussed in [3] late last year
On Thu, May 09, 2019 at 10:30:25AM +0200, Andrea Bolognani wrote:
> On Wed, 2019-05-08 at 17:29 +0100, Daniel P. Berrangé wrote:
> > On Wed, May 08, 2019 at 06:21:21PM +0200, Olaf Hering wrote:
> > > On Wed, Apr 03, Ján Tomko wrote:
> > >
> > > > Since all our supported platforms include at least
On Thu, May 09, 2019 at 10:40:51AM +0200, Ján Tomko wrote:
> On Thu, May 09, 2019 at 10:30:25AM +0200, Andrea Bolognani wrote:
> > On Wed, 2019-05-08 at 17:29 +0100, Daniel P. Berrangé wrote:
> > > On Wed, May 08, 2019 at 06:21:21PM +0200, Olaf Hering wrote:
> > > > On Wed, Apr 03, Ján Tomko
On Thu, May 09, 2019 at 10:30:25AM +0200, Andrea Bolognani wrote:
On Wed, 2019-05-08 at 17:29 +0100, Daniel P. Berrangé wrote:
On Wed, May 08, 2019 at 06:21:21PM +0200, Olaf Hering wrote:
> On Wed, Apr 03, Ján Tomko wrote:
>
> > Since all our supported platforms include at least yajl 2.0.4,
> >
On Wed, 2019-05-08 at 17:29 +0100, Daniel P. Berrangé wrote:
> On Wed, May 08, 2019 at 06:21:21PM +0200, Olaf Hering wrote:
> > On Wed, Apr 03, Ján Tomko wrote:
> >
> > > Since all our supported platforms include at least yajl 2.0.4,
> > > use pkg-config to detect the library and set the minimum
On Wed, May 08, 2019 at 11:27:47PM +0800, Boris Fiuczynski wrote:
> On 5/8/19 11:22 PM, Alex Williamson wrote:
> >>> I thought there was a request to make this more specific to migration
> >>> by renaming it to something like migration_version. Also, as an
> >>>
> >> so this attribute may not
On 5/8/19 11:22 PM, Alex Williamson wrote:
I thought there was a request to make this more specific to migration
by renaming it to something like migration_version. Also, as an
so this attribute may not only include a mdev device's parent device info and
mdev type, but also include numeric
67 matches
Mail list logo
