Re: [libvirt] surprising setting in domain.xml

2019-05-16 Thread Eric Blake
On 5/16/19 10:20 AM, Thomas Stein wrote: > Hello all. > > My currently used versions: libvirt-5.2.0 and qemu-4.0.0. > > Here is my problem. I'm struggeling since a few weeks with a strange > behaviour by either qemu or libvirt. After a reboot of > the hardware node the $domain.xml contains

[libvirt] [PATCH 1/6] qemu: Introduce virQEMUCapsProbeQMPMachineProps()

2019-05-16 Thread Andrea Bolognani
Up until now we've probed machine type properties, along with properties for other types, in virQEMUCapsProbeQMPDevices(), but soon we're going to need some logic that is specific to machine types and as such wouldn't quite fit into that function. Signed-off-by: Andrea Bolognani ---

[libvirt] [PATCH 4/6] qemu: Probe canonicalized machine type

2019-05-16 Thread Andrea Bolognani
Now that we have the list of machine types available when probing machine type properties, we can list properties for the canonicalized version of the "pseries" machine type instead of having to go through "spapr-machine", which we know to be the parent type for all "pseries-*-machine" types. By

[libvirt] [PATCH 3/6] qemu: Move call to virQEMUCapsProbeQMPMachineProps()

2019-05-16 Thread Andrea Bolognani
We're going to need information about available machine types when probing machine type properties soon, and that means we have to change the order we call QMP commands. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 4 +- .../caps_2.12.0.aarch64.replies

[libvirt] [PATCH 5/6] tests: Refresh capabilities for QEMU on ppc64

2019-05-16 Thread Andrea Bolognani
Now that we're probing machine type properties using the latest machine type rather than the "spapr-machine" parent, we can finally discover properties that are not available on all machine types. This commit refreshes replies for QEMU 4.0.0 as well as 3.1.0 to show not only that we're actually

[libvirt] [PATCH 0/6] qemu: Rework the way we probe machine type properties

2019-05-16 Thread Andrea Bolognani
This is a prerequisite for vSMMUv3 support, which I'm currently working on, but I'm posting it separately because it still makes perfect sense as a standalone series and I think it's a nice cleanup in its own right. Unfortunately there's quite a bit of test suite churn associated with these

[libvirt] [PATCH 2/6] qemu: Add -machine suffix automatically

2019-05-16 Thread Andrea Bolognani
The QOM type for machine types is the machine type name followed by the -machine suffix. Since this is always the case, we can make virQEMUCapsMachineProps more readable and avoid repetition by not including the suffix there and adding it automatically while processing the data. Signed-off-by:

[libvirt] [PATCH 6/6] qemu: Only probe available machine types

2019-05-16 Thread Andrea Bolognani
Since we know the full list of machine types supported by the QEMU binary when probing machine type properties, we can save some work (and eventually test suite churn, as more architecture-specific machine types need to be probed) by only probing machines that we know exist. Signed-off-by: Andrea

[libvirt] surprising setting in domain.xml

2019-05-16 Thread Thomas Stein
Hello all. My currently used versions: libvirt-5.2.0 and qemu-4.0.0. Here is my problem. I'm struggeling since a few weeks with a strange behaviour by either qemu or libvirt. After a reboot of the hardware node the $domain.xml contains suddenly a backingStore setting which was not there

Re: [libvirt] [PATCH 0/2] build: bump minimum udev version to 219

2019-05-16 Thread Pavel Hrdina
On Thu, May 16, 2019 at 03:41:15PM +0200, Ján Tomko wrote: > Inspired-by: Pavel Hrdina > > Ján Tomko (2): > build: bump minimum udev version to 219 > build: drop check for udev_monitor_set_receive_buffer_size Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature --

[libvirt] [PATCH 2/2] build: drop check for udev_monitor_set_receive_buffer_size

2019-05-16 Thread Ján Tomko
It has been exported by systemd commit commit a571c23e954cb88cdd5faa28593b19bd7c340130 libudev: export udev_monitor_set_receive_buffer_size() released in v183. Signed-off-by: Ján Tomko --- m4/virt-udev.m4| 10 -- src/node_device/node_device_udev.c | 2 -- 2

[libvirt] [PATCH 0/2] build: bump minimum udev version to 219

2019-05-16 Thread Ján Tomko
Inspired-by: Pavel Hrdina Ján Tomko (2): build: bump minimum udev version to 219 build: drop check for udev_monitor_set_receive_buffer_size m4/virt-udev.m4| 14 ++ src/node_device/node_device_udev.c | 2 -- 2 files changed, 2 insertions(+), 14 deletions(-)

[libvirt] [PATCH 1/2] build: bump minimum udev version to 219

2019-05-16 Thread Ján Tomko
This is the version of systemd RHEL/CentOS 7 uses: https://repology.org/project/systemd/versions Oldest tracked openSUSE distros have 228, Ubuntu 16.04 has 229 and Gentoo's alternative eudev has bumped the version to 219 back in 2015. Signed-off-by: Ján Tomko --- m4/virt-udev.m4 | 4 ++-- 1

Re: [libvirt] [PATCH] src: don't statically link code that's already in libvirt.so

2019-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2019 at 02:56:21PM +0200, Ján Tomko wrote: > On Thu, May 16, 2019 at 12:09:57PM +0100, Daniel P. Berrangé wrote: > > virtlockd and virtlogd statically link to libvirt-net-rpc-server.la > > libvirt-net-rpc.la and libvirt_util.la. libvirt-iohelper statically > > libvirt_iohelper >

Re: [libvirt] [PATCH] src: don't statically link code that's already in libvirt.so

2019-05-16 Thread Ján Tomko
On Thu, May 16, 2019 at 12:09:57PM +0100, Daniel P. Berrangé wrote: virtlockd and virtlogd statically link to libvirt-net-rpc-server.la libvirt-net-rpc.la and libvirt_util.la. libvirt-iohelper statically libvirt_iohelper links to libvirt_util.la. All this code is all already built into the

[libvirt] [PATCH] src: don't statically link code that's already in libvirt.so

2019-05-16 Thread Daniel P . Berrangé
virtlockd and virtlogd statically link to libvirt-net-rpc-server.la libvirt-net-rpc.la and libvirt_util.la. libvirt-iohelper statically links to libvirt_util.la. All this code is all already built into the main libvirt.so, so we should dynamically link all these pieces. This reduces the size of

Re: [libvirt] [PATCH] virt-aa-helper: clean old reference to libvirt-sandbox

2019-05-16 Thread Christian Ehrhardt
On Thu, May 16, 2019 at 9:42 AM Daniel P. Berrangé wrote: > > On Thu, May 16, 2019 at 09:38:55AM +0200, Christian Ehrhardt wrote: > > It came up that libvirt-sandbox is a failed (and removed) experiment. > > Let us clean up and remove it from the virt-aa-helper source as well. > > > >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-16 Thread Ilias Stamatis
On Thu, May 16, 2019 at 9:44 AM Michal Privoznik wrote: > > On 5/15/19 11:49 AM, Ilias Stamatis wrote: > > On Wed, May 15, 2019 at 10:14 AM Michal Privoznik > > wrote: > >> > >> On 5/14/19 5:24 PM, Ilias Stamatis wrote: > >>> On Tue, May 14, 2019 at 5:04 PM Michal Privoznik > >>> wrote: >

Re: [libvirt] [PATCH v2] test_driver: implement virDomainGetDiskErrors

2019-05-16 Thread Michal Privoznik
On 5/15/19 11:49 AM, Ilias Stamatis wrote: On Wed, May 15, 2019 at 10:14 AM Michal Privoznik wrote: On 5/14/19 5:24 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 5:04 PM Michal Privoznik wrote: On 5/14/19 12:50 PM, Ilias Stamatis wrote: On Tue, May 14, 2019 at 12:40 PM John Ferlan

[libvirt] [PATCH] virt-aa-helper: clean old reference to libvirt-sandbox

2019-05-16 Thread Christian Ehrhardt
It came up that libvirt-sandbox is a failed (and removed) experiment. Let us clean up and remove it from the virt-aa-helper source as well. Signed-off-by: Christian Ehrhardt --- src/security/virt-aa-helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] virt-aa-helper: clean old reference to libvirt-sandbox

2019-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2019 at 09:38:55AM +0200, Christian Ehrhardt wrote: > It came up that libvirt-sandbox is a failed (and removed) experiment. > Let us clean up and remove it from the virt-aa-helper source as well. > > Signed-off-by: Christian Ehrhardt > --- > src/security/virt-aa-helper.c | 3 +--

Re: [libvirt] [PATCH] virt-aa-helper: allow sysfs path used for vhost-scsi

2019-05-16 Thread Christian Ehrhardt
On Wed, May 15, 2019 at 4:14 PM Daniel P. Berrangé wrote: > > On Wed, May 15, 2019 at 04:11:34PM +0200, Christian Ehrhardt wrote: > > When a vhost scsi device is hotplugged virt-aa-helper is called to > > add the respective path. > > For example the config: > > > > > > > > Will call it