Re: [libvirt] [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

2019-05-27 Thread Eduardo Habkost
On Fri, May 17, 2019 at 09:45:17AM +0200, Igor Mammedov wrote: > '-numa mem' option has a number of issues and mgmt often defaults > to it. Unfortunately it's no possible to replace it with an alternative > '-numa memdev' without breaking migration compatibility. What's possible > though is to

Re: [libvirt] [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

2019-05-27 Thread Markus Armbruster
Igor Mammedov writes: > '-numa mem' option has a number of issues and mgmt often defaults > to it. Unfortunately it's no possible to replace it with an alternative > '-numa memdev' without breaking migration compatibility. To be precise: -numa node,mem=... and -numa node,memdev=... Correct? >

Re: [libvirt] [Qemu-devel] [PATCH v3 3/6] qmp: qmp_qom_list_properties(): ignore empty string options

2019-05-27 Thread Markus Armbruster
Igor Mammedov writes: > Current QAPI semantics return empty "" string in case string property > value hasn't been set (i.e. NULL). Do not show initial value in this > case in "qom-list-properties" command output to reduce clutter. > > Signed-off-by: Igor Mammedov > --- > qmp.c | 12

Re: [libvirt] [Qemu-devel] [PATCH v3 2/6] qmp: make "qom-list-properties" show initial property values

2019-05-27 Thread Markus Armbruster
Igor Mammedov writes: > Add in the command output object's property values right after creation > (i.e. state of the object returned by object_new() or equivalent). > > Follow up patch will add machine property 'numa-mem-supported', which > would allow mgmt to introspect which machine types

Re: [libvirt] [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-05-27 Thread Markus Armbruster
Igor Mammedov writes: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet (ex: property being inspected during preconfig time). Reproduced: $ qemu-system-x86_64 -nodefaults -S -display none -preconfig -qmp stdio {"QMP":

Re: [libvirt] [PATCH 5/9] conf: refactor 'virDomainResctrlVcpuMatch'

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: Let 'virDomainResctrlVcpuMatch' return a pointer of @virDomainResctrlDefPtr in its third parameter. Signed-off-by: Wang Huaqiang --- src/conf/domain_conf.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-)

Re: [libvirt] [PATCH 4/9] conf: Replace 'virResctrlAllocIsEmpty' with @n==0 for indicating no resctrl allocation in configuration file

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: @n denotes the number of element under element in function 'virDomainCachetuneDefParse' or the number of element under element in function virDomainMemorytuneDefParse'. Originally it is using 'virResctrlAllocIsEmpty' function to judge if no resctrl

Re: [libvirt] [PATCH 8/9] util: Extend virresctl API to retrieve multiple monitor statistics

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: Export virResctrlMonitorGetStats and make virResctrlMonitorGetCacheOccupancy obsoleted. Signed-off-by: Wang Huaqiang --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 33 + src/util/virresctrl.c| 46

Re: [libvirt] [PATCH 6/9] util: Refactor 'virResctrlMonitorFreeStats'

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: Refactor 'virResctrlMonitorFreeStats' to let it available to free the 'virResctrlMonitorStatsPtr' variable. Signed-off-by: Wang Huaqiang --- src/qemu/qemu_driver.c | 1 + src/util/virresctrl.c | 4 +--- 2 files changed, 2 insertions(+), 3

Re: [libvirt] [PATCH 0/9] util/resctrl cleanups and refactors

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: Plan to support Resctrl Control Monitors, which is a feature introduced by kernel 'resctrl' sub-model. Submit some cleanup and refactoring patches for upcoming memory bandwidth resource monitoring (MBM) monitors. Related MBM RFC is

Re: [libvirt] [PATCH 7/9] util: Refactor 'virResctrlMonitorStats'

2019-05-27 Thread Michal Privoznik
On 5/23/19 11:34 AM, Wang Huaqiang wrote: Refactor 'virResctrlMonitorStats' to track multiple statistical records. Signed-off-by: Wang Huaqiang --- src/qemu/qemu_driver.c | 2 +- src/util/virresctrl.c | 17 ++--- src/util/virresctrl.h | 12 ++-- 3 files changed, 25

Re: [libvirt] [PATCH] test_driver: implement virDomainMemoryPeek

2019-05-27 Thread Ján Tomko
On Fri, May 24, 2019 at 02:50:27PM +0200, Ilias Stamatis wrote: On Fri, May 24, 2019 at 2:39 PM Ján Tomko wrote: On Thu, May 23, 2019 at 01:37:01PM +0200, Ilias Stamatis wrote: >Begins by writing a @start byte in the first position of @buffer and >then for every next byte it stores the value

[libvirt] [PATCH] snapshot: Store both config and live XML in the snapshot domain

2019-05-27 Thread Maxiwell S. Garcia
The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in the snapshot XML as the entry. In case of offline

[libvirt] [jenkins-ci PATCH] lcitool: Don't warn when using package manager directly

2019-05-27 Thread Andrea Bolognani
We only do this when performing operations that the corresponding Ansible module doesn't support, so we know what we're doing and don't want warnings to show up. Note that while only the dnf and yum modules complain at the moment, we might as well use warn=no everywhere so that we're already

Re: [libvirt] [PATCH 0/2] qemu: Fix for emulatorsched

2019-05-27 Thread Michal Privoznik
On 5/22/19 12:27 PM, Martin Kletzander wrote: Partially-related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1712781 Martin Kletzander (2): qemu: Set emulator thread scheduler only after QEMU starts docs: Add emulatorsched fix info to news.xml docs/news.xml | 12

Re: [libvirt] [glib PATCH v2 2/2] gtk-doc.make: Remove the file

2019-05-27 Thread Andrea Bolognani
On Mon, 2019-05-27 at 13:41 +0200, Fabiano Fidêncio wrote: > Now that we're using gtkdocisze as part of autogen.sh, there's no reason s/gtkdocisze/gtkdocize/ > to keep our own gtk-doc.make file. > > Signed-off-by: Fabiano Fidêncio > --- > .gitignore | 1 + > gtk-doc.make | 256

Re: [libvirt] [glib PATCH v2 1/2] autogen.sh: Simplify autogen.sh

2019-05-27 Thread Andrea Bolognani
On Mon, 2019-05-27 at 13:41 +0200, Fabiano Fidêncio wrote: > Let's use an autogen.sh based on libosinfo's one, which is cleaner and > matches the current GNOME guidelines. > > Signed-off-by: Fabiano Fidêncio > --- > .gitignore | 3 +++ > autogen.sh | 58

Re: [libvirt] [PATCH] qemu: Get default hugepage size only if needed

2019-05-27 Thread Erik Skultety
On Mon, May 27, 2019 at 11:18:51AM +0200, Michal Privoznik wrote: > Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69 > > Hugepages don't work in session mode but when building memory > part of command line we query for the default size anyway. This > breaks creating domains under session daemon.

Re: [libvirt] [PATCH] spec: Improve handling for default network

2019-05-27 Thread Michal Privoznik
On 5/27/19 1:34 PM, Andrea Bolognani wrote: This is exactly how we already treat nwfilters, which require the same kind of care (aka nasty hacks) as the default network, because in both cases the UUID is generated and written to disk the first time libvirtd is started after installing the

Re: [libvirt] [glib PATCH v2 2/2] gtk-doc.make: Remove the file

2019-05-27 Thread Michal Privoznik
On 5/27/19 1:41 PM, Fabiano Fidêncio wrote: Now that we're using gtkdocisze as part of autogen.sh, there's no reason to keep our own gtk-doc.make file. Signed-off-by: Fabiano Fidêncio --- .gitignore | 1 + gtk-doc.make | 256 --- 2 files

Re: [libvirt] [glib PATCH v2 0/2] Simplify autogen.sh & get rid of our own gtk-doc.make

2019-05-27 Thread Michal Privoznik
On 5/27/19 1:41 PM, Fabiano Fidêncio wrote: Let's use a similiar autogen.sh as the one used by libosinfo and, with the change, let's also drop our own crafted gtk-doc.make (as we'll be using gtkdocize to generate the file). Changes since v1: - Do not remove the "--system" shortcut v1:

[libvirt] [glib PATCH v2 1/2] autogen.sh: Simplify autogen.sh

2019-05-27 Thread Fabiano Fidêncio
Let's use an autogen.sh based on libosinfo's one, which is cleaner and matches the current GNOME guidelines. Signed-off-by: Fabiano Fidêncio --- .gitignore | 3 +++ autogen.sh | 58 +++--- 2 files changed, 28 insertions(+), 33 deletions(-) diff

[libvirt] [glib PATCH v2 2/2] gtk-doc.make: Remove the file

2019-05-27 Thread Fabiano Fidêncio
Now that we're using gtkdocisze as part of autogen.sh, there's no reason to keep our own gtk-doc.make file. Signed-off-by: Fabiano Fidêncio --- .gitignore | 1 + gtk-doc.make | 256 --- 2 files changed, 1 insertion(+), 256 deletions(-) delete

[libvirt] [glib PATCH v2 0/2] Simplify autogen.sh & get rid of our own gtk-doc.make

2019-05-27 Thread Fabiano Fidêncio
Let's use a similiar autogen.sh as the one used by libosinfo and, with the change, let's also drop our own crafted gtk-doc.make (as we'll be using gtkdocize to generate the file). Changes since v1: - Do not remove the "--system" shortcut v1:

[libvirt] [PATCH] spec: Improve handling for default network

2019-05-27 Thread Andrea Bolognani
This is exactly how we already treat nwfilters, which require the same kind of care (aka nasty hacks) as the default network, because in both cases the UUID is generated and written to disk the first time libvirtd is started after installing the corresponding subpackage. After this patch, RPM

Re: [libvirt] [PATCH] spec: Fix permissions of nwfilter XMLs

2019-05-27 Thread Andrea Bolognani
On Thu, 2019-05-23 at 16:35 +0200, Jiri Denemark wrote: > On Thu, May 23, 2019 at 16:12:27 +0200, Andrea Bolognani wrote: > > On Thu, 2019-05-23 at 14:56 +0200, Jiri Denemark wrote: > > [...] > > > %post daemon-config-nwfilter > > > cp %{_datadir}/libvirt/nwfilter/*.xml

[libvirt] [PATCH] qemu: Get default hugepage size only if needed

2019-05-27 Thread Michal Privoznik
Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69 Hugepages don't work in session mode but when building memory part of command line we query for the default size anyway. This breaks creating domains under session daemon. Query the page size only if it's clear we need hugepages. Signed-off-by:

Re: [libvirt] [PATCH 0/5] Support embedding the QEMU driver in client apps directly

2019-05-27 Thread Michal Privoznik
On 5/17/19 2:24 PM, Daniel P. Berrangé wrote: This patch series proposes a new way to build a "libvirt QEMU shim" which supports more use cases than the previous approach from last year, as well as being vastly simpler to implement. Specifically - We can use this to embed the QEMU driver in