[libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-29 Thread Jim Fehlig
openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared -fPIC -DPIC ../src/libvirt_qemu_probes.o \ -Wl,--whole-archive ../src/.libs/libvirt_driver_qemu_impl.a \

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-29 Thread Alex Williamson
On Tue, 28 May 2019 22:57:15 +0200 Boris Fiuczynski wrote: > On 5/14/19 5:31 PM, Alex Williamson wrote: > > On Wed, 8 May 2019 17:27:47 +0200 > > Boris Fiuczynski wrote: > > > >> On 5/8/19 11:22 PM, Alex Williamson wrote: > > I thought there was a request to make this more specific to

[libvirt] [PATCH 3/4] test_driver: implement virDomainSaveImageDefineXML

2019-05-29 Thread Ilias Stamatis
Updates the existing image stored in @path, in case @dxml contains valid XML supported by the fake host. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c

[libvirt] [PATCH 4/4] test_driver: implement virDomainSaveImageGetXMLDesc

2019-05-29 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 24 1 file changed, 24 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b0195ac63d..719e956d99 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2255,6 +2255,29

[libvirt] [PATCH 1/4] test_driver: extract image saving code into a separate function

2019-05-29 Thread Ilias Stamatis
Extracting the code logic for writing a test image to disk from testDomainSaveFlags into a separate function, allows us to reuse this code in other functions such as testDomainSaveImageDefineXML. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 114

[libvirt] [PATCH 2/4] test_driver: extract image loading code into a separate function

2019-05-29 Thread Ilias Stamatis
Extracting the code logic for opening and parsing a test image from testDomainRestoreFlags into a separate function, allows us to reuse this code in other functions such as testDomainSaveImageGetXMLDesc. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 115

[libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-05-29 Thread Ilias Stamatis
While implementing virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML for the test driver, I realized that there exists already code for saving and loading test images which can be reused. However, it needed to be extracted from testDomainSaveFlags and testDomainRestoreFlags into

[libvirt] [PATCH] qemu: fix pr-helper0 remain

2019-05-29 Thread Jie Wang
if libvirt receive DISCONNECTED event and set prDaemonRunning to false, and qemuDomainRemoveDiskDevice is performing in the meantime. qemuDomainRemoveDiskDevice will return directly by prDaemonRunning check, so the pr-helper0 object will remain. I think it is no need to check prDaemonRunning in

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-29 Thread Boris Fiuczynski
On 5/14/19 5:31 PM, Alex Williamson wrote: On Wed, 8 May 2019 17:27:47 +0200 Boris Fiuczynski wrote: On 5/8/19 11:22 PM, Alex Williamson wrote: I thought there was a request to make this more specific to migration by renaming it to something like migration_version. Also, as an so

Re: [libvirt] [PATCH v3 2/2] drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU

2019-05-29 Thread Yan Zhao
On Wed, May 29, 2019 at 11:07:50AM +0800, Zhenyu Wang wrote: > On 2019.05.26 23:44:37 -0400, Yan Zhao wrote: > > This feature implements the migration_version attribute for Intel's vGPU > > mdev devices. > > > > migration_version attribute is rw. > > It's used to check migration compatibility for

Re: [libvirt] Question about save and restore OVS per-port data in live migration

2019-05-29 Thread Michal Privoznik
On 5/29/19 6:23 AM, wangxin (U) wrote: Hi When we try to migrate a guest with 12 NICs, we find libvirt will try to get per-port data in finish phase, it makes the guest paused for several hundred milliseconds. qemuMigrationCookieAddNetwork -> virNetDevOpenvswitchGetMigrateData for