Re: [libvirt] [PATCH] test_driver: implement virDomainGetHostname

2019-05-31 Thread Ilias Stamatis
On Fri, May 31, 2019 at 4:31 PM Ilias Stamatis wrote: > > Always return "domain_name" + "host". > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c >

[libvirt] [PATCH 3/4] util: Introduce virNumaNodesetToCPUset()

2019-05-31 Thread Andrea Bolognani
This helper converts a set of NUMA node to the set of CPUs they contain. Signed-off-by: Andrea Bolognani --- src/libvirt_private.syms | 1 + src/util/virnuma.c | 55 src/util/virnuma.h | 2 ++ 3 files changed, 58 insertions(+) diff --git

[libvirt] [PATCH 2/4] fixup? util: Optimize virBitmapUnion()

2019-05-31 Thread Andrea Bolognani
The original implementation is extremely straightforward but not too efficient, because it uses the public API instead of poking the innards directly. This second implementation does the latter, and as a consequence can afford to make @b const, which is nice even though most existing virBitmap

[libvirt] [PATCH 1/4] util: Introduce virBitmapUnion()

2019-05-31 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 26 ++ src/util/virbitmap.h | 4 tests/virbitmaptest.c| 37 + 4 files changed, 68 insertions(+) diff --git

[libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-05-31 Thread Andrea Bolognani
Commit f136b83139c6 made some changes in the way we set CPU affinity for QEMU processes, and while doing so unfortunately also introduced a logic bug in that it tried to use a NUMA node map where a CPU map was expected. Because of that, guests using would suddenly fail to start: # virsh start

[libvirt] [PATCH 0/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-05-31 Thread Andrea Bolognani
See detailed explanation in the commit message for patch 1/4 and the corresponding bug report. Andrea Bolognani (4): util: Introduce virBitmapUnion() fixup? util: Optimize virBitmapUnion() util: Introduce virNumaNodesetToCPUset() qemu: Fix qemuProcessInitCpuAffinity()

[libvirt] [PATCH] test_driver: implement virDomainGetHostname

2019-05-31 Thread Ilias Stamatis
Always return "domain_name" + "host". Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f58a1da95..aad7bb6036 100644 --- a/src/test/test_driver.c +++

Re: [libvirt] [PATCH v2] docs: Drop the external AMD SEV links

2019-05-31 Thread Michal Privoznik
On 5/31/19 8:05 AM, Erik Skultety wrote: One of the current SEV document links went dead as AMD moved the resource to another place (document store), so there's probably very little point in maintaining 3rd party links if the resources are being moved. Signed-off-by: Erik Skultety ---

Re: [libvirt] [PATCH] maint: Add support for .ctags.d

2019-05-31 Thread Michal Privoznik
On 5/30/19 8:51 PM, Jiri Denemark wrote: Depending on the way ctags was compiled, it may look for .ctags.d/*.ctags files rather than .ctags for reading configuration. Signed-off-by: Jiri Denemark --- .ctags.d/libvirt.ctags | 1 + 1 file changed, 1 insertion(+) create mode 12

Re: [libvirt] Question about save and restore OVS per-port data in live migration

2019-05-31 Thread wangxin (U)
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Friday, May 31, 2019 3:25 PM > To: wangxin (U) ; libvir-list@redhat.com > Cc: Lichunhe (Cloud Networking) > Subject: Re: Question about save and restore OVS per-port data in live > migration > > On

[libvirt] [PATCH 2/5] conf: Report TSC frequency in host CPU capabilities

2019-05-31 Thread Jiri Denemark
This patch adds a new element into the host CPU capabilities XML. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 48 + src/conf/cpu_conf.h | 2 ++ 2 files changed, 50 insertions(+) diff --git a/src/conf/cpu_conf.c

[libvirt] [PATCH 3/5] cpu_x86: Fix placement of *CheckFeature functions

2019-05-31 Thread Jiri Denemark
Commit 0a97486e09 moved them outside #ifdef, but after virCPUx86GetHost, which will start calling them in the following patch. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 72 +++ 1 file changed, 35 insertions(+), 37 deletions(-) diff --git

[libvirt] [PATCH 4/5] cpu_x86: Probe TSC frequency and scaling support

2019-05-31 Thread Jiri Denemark
When the host CPU supports invariant TSC the host CPU definition created by virCPUx86GetHost will contain (unless probing fails for some reason) addition TSC related data. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 9 + 1 file changed, 9 insertions(+) diff --git

[libvirt] [PATCH 5/5] qemu: Check TSC frequency before starting QEMU

2019-05-31 Thread Jiri Denemark
When migrating a domain with invtsc CPU feature enabled, the TSC frequency of the destination host must match the frequency used when the domain was started on the source host or the destination host has to support TSC scaling. If the frequencies do not match and the destination host does not

[libvirt] [PATCH 1/5] util: Add virHostCPUGetTscInfo

2019-05-31 Thread Jiri Denemark
On a KVM x86_64 host which supports invariant TSC this function can be used to detect the TSC frequency and the availability of TSC scaling. The magic MSR numbers required to check if VMX scaling is supported on the host are documented in Volume 3 of the Intel® 64 and IA-32 Architectures Software

[libvirt] [PATCH 0/5] Check TSC frequency before starting QEMU

2019-05-31 Thread Jiri Denemark
When migrating a domain with invtsc CPU feature enabled, the TSC frequency of the destination host must match the frequency used when the domain was started on the source host or the destination host has to support TSC scaling. If the frequencies do not match and the destination host does not

[libvirt] [PATCH v2] qemu: fix pr-helper0 remain

2019-05-31 Thread Jie Wang
If libvirt receive DISCONNECTED event and set prDaemonRunning to false, and qemuDomainRemoveDiskDevice is performing in the meantime. qemuDomainRemoveDiskDevice will return directly by prDaemonRunning check, so the pr-helper0 object will remain. In that case we should try harder and also kill the

Re: [libvirt] [PATCH 0/2] news: Update for 5.4.0 release

2019-05-31 Thread Michal Privoznik
On 5/30/19 4:33 PM, Andrea Bolognani wrote: Hopefully I've done a decent enough job at summarizing, especially with the security stuff: if not, please let me know! Andrea Bolognani (2): news: Reformat overgrown line news: Update for 5.4.0 release docs/news.xml | 61

Re: [libvirt] [PATCH] qemu: fix pr-helper0 remain

2019-05-31 Thread Michal Privoznik
On 5/31/19 10:06 AM, wangjie (P) wrote: Hi, Michal:     Sorry, I don't think out which case make us to do that, what are the risks? can you give me an example? Well, qemuProcessKillManagedPRDaemon() not only kills pr-helper process but it also cleans up after it. If we receive DISCONNECTED

[libvirt] Availability of 5.4.0 Release Candidate 2

2019-05-31 Thread Daniel Veillard
This is tagged in git, I have put the signed tarball and source RPM at the usual place: https://libvirt.org/sources/ this is virtually identical to RC1 except for the portability fix from Jim. I hope this means it's stable, or everybody is taking days off :-) likely to push the final

Re: [libvirt] [PATCH] qemu: fix pr-helper0 remain

2019-05-31 Thread wangjie (P)
Hi, Michal:     Sorry, I don't think out which case make us to do that, what are the risks? can you give me an example? On 2019/5/31 15:21, Michal Privoznik wrote: On 5/31/19 9:19 AM, wangjie (P) wrote: Hi, Michal: Do you mean we should also remove "if (!priv->prDaemonRunning)" in

Re: [libvirt] Question about save and restore OVS per-port data in live migration

2019-05-31 Thread Michal Privoznik
On 5/30/19 3:50 AM, wangxin (U) wrote: -Original Message- From: Michal Privoznik [mailto:mpriv...@redhat.com] Sent: Wednesday, May 29, 2019 3:44 PM To: wangxin (U) ; libvir-list@redhat.com Cc: Lichunhe (Cloud Networking) Subject: Re: Question about save and restore OVS per-port data in

Re: [libvirt] [PATCH] qemu: fix pr-helper0 remain

2019-05-31 Thread Michal Privoznik
On 5/31/19 9:19 AM, wangjie (P) wrote: Hi, Michal:     Do you mean we should also remove "if (!priv->prDaemonRunning)" in qemuProcessKillManagedPRDaemon ? I don't understand why do that, can you tell me more details? Yes. I mean exactly that. Michal -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu: fix pr-helper0 remain

2019-05-31 Thread wangjie (P)
Hi, Michal:     Do you mean we should also remove "if (!priv->prDaemonRunning)" in qemuProcessKillManagedPRDaemon ? I don't understand why do that, can you tell me more details? On 2019/5/30 18:22, Michal Privoznik wrote: On 5/29/19 11:44 AM, Jie Wang wrote: if libvirt receive DISCONNECTED

[libvirt] [PATCH v2] docs: Drop the external AMD SEV links

2019-05-31 Thread Erik Skultety
One of the current SEV document links went dead as AMD moved the resource to another place (document store), so there's probably very little point in maintaining 3rd party links if the resources are being moved. Signed-off-by: Erik Skultety --- docs/formatdomaincaps.html.in | 16