Re: [libvirt] [PATCH] test_driver: implement virNetworkGetDHCPLeases

On 6/8/19 12:00 PM, Ilias Stamatis wrote: > Return infinite time DHCP leases for fixed IPV4 addresses. > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 118 + > 1 file changed, 118 insertions(+) > > diff --git a/src/test/test_driver.c

[libvirt] [PATCH] build: Require cppi for syntax-check

Since its introduction in v0.8.0~314 we allowed for cppi to be not present for 'syntax-check' because the package did exist in Fedora Core 12. Well, we don't care anymore ¯\_(ツ)_/¯ All recent distros have it. Moreover, it's fairly easy to miss 'cppi not installed' message in sea of syntax-check

Re: [libvirt] [PATCH] virfile: adds quobyte as a shared fs

On 5/28/19 2:55 PM, Silvan Kaiser wrote: > Adds detection of a Quobyte shared file system for > live migration. > > Signed-off-by: Silvan Kaiser > --- > src/util/virfile.c| 13 - > src/util/virfile.h| 1 + > tests/virfiledata/mounts3.txt | 1 + >

[libvirt] [PATCH 3/3] docs: storage: document the 'lvm2' disk format oddness

Signed-off-by: Ján Tomko --- docs/storage.html.in | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 4681a02023..7a9a980e7c 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -359,7 +359,16 @@ The

[libvirt] [PATCH 1/3] docs: storage: fix spacing when enumerating volume formats

There was a space missing after 'qcow'. Delete 'qcow' and 'cow' as examples to make the document more relevant for the current decade. Signed-off-by: Ján Tomko --- docs/storage.html.in | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/storage.html.in

[libvirt] [PATCH 0/3] docs: storage: document 'lvm2' disk fun

Ján Tomko (3): docs: storage: fix spacing when enumerating volume formats docs: storage: type out two docs: storage: document the 'lvm2' disk format oddness docs/storage.html.in | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.20.1 -- libvir-list

[libvirt] [PATCH 2/3] docs: storage: type out two

Signed-off-by: Ján Tomko --- docs/storage.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 9291c69f32..4681a02023 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -308,7 +308,7 @@ by adding

[libvirt] [PATCH 03/10] qemu: domain: remove monJSON field

If we have a monitor, it is a JSON monitor. Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 3 --- src/qemu/qemu_domain.h | 1 - src/qemu/qemu_process.c | 1 - tests/qemuhotplugtest.c | 2 -- 4 files changed, 7 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH 10/10] qemu: monitor: s/ret/rc/ in UpdateVideoSize functions

Use 'rc' to temporarily store the subfunction return values, instead of ret. Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index

[libvirt] [PATCH 04/10] qemu: stop formatting json='1' in status XML

For quite some time now it is impossible to connect to a domain using a HMP monitor, so there is no point in formatting it in the status XML. Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c| 1 - tests/qemustatusxml2xmldata/blockjob-mirror-in.xml|

[libvirt] [PATCH 08/10] qemu: monitor: remove the json field

Now that it is no longer used, remove it. Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index ab2b54e002..f19bbea8b9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c

[libvirt] [PATCH 07/10] qemu: monitor: remove mon->json checks

Remove all the mon->json checks in qemuMonitor functions. Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 84 - 1 file changed, 25 insertions(+), 59 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index

[libvirt] [PATCH 02/10] qemu: assume monJSON is always true

Now that we no longer support the HMP monitor, remove some dead code. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 8 +++- src/qemu/qemu_domain.c| 10 -- src/qemu/qemu_driver.c| 3 +-- src/qemu/qemu_migration.c | 21 +++--

[libvirt] [PATCH 05/10] qemu: remove json argument from qemuMonitorOpen

Always assume JSON monitor was requested, since all the callers pass true anyway. Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 13 - src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_process.c | 3 +-- tests/qemumonitortestutils.c | 1 - 4 files changed, 5

[libvirt] [PATCH 09/10] qemu: monitor: use VIR_AUTOFREE in qemuMonitor*VideoSize

Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f19bbea8b9..1b2773c60a 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1205,7

[libvirt] [PATCH 06/10] qemu: monitor: assume JSON in QEMU_CHECK_MONITOR macro

In preparation to removing the json field from qemuMonitor, stop checking for it in QEMU_CHECK_MONITOR. Signed-off-by: Ján Tomko --- src/qemu/qemu_monitor.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index

[libvirt] [PATCH 00/10] qemu: remove json fields from domain and monitor objects

Applies on top of Peter's removal of commandline parsing https://www.redhat.com/archives/libvir-list/2019-June/msg00405.html After removal of qemuProcessAttach there is no codepath that could possibly set monJSON to false (not that libvirt would be able to much with such domain), so we can finish

[libvirt] [PATCH 01/10] qemu: also delete qemuProcessAttach

Now that the virDomainQemuAttach API returns an error, we can remove the unused qemuProcessAttach function as well, deleting the only user that possibly could have requested to open a non-JSON monitor. Signed-off-by: Ján Tomko --- src/qemu/qemu_process.c | 243

[libvirt] [PATCH 11/12] tests: qemuMonitorTestAddUnexpectedErrorResponse: VIR_AUTOFREE

Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 6be4de8059..c053712573 100644 --- a/tests/qemumonitortestutils.c +++

[libvirt] [PATCH 12/12] tests: qemuMonitorTestAddInvalidCommandResponse: VIR_AUTOFREE

Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index c053712573..c14ffb23b9 100644 --- a/tests/qemumonitortestutils.c +++

[libvirt] [PATCH 10/12] tests: refactor qemuMonitorTestProcessCommandDefaultValidate

Use VIR_AUTO* for cleanup and virBufferCurrentContent instead of virBufferContentAndReset. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/tests/qemumonitortestutils.c

[libvirt] [PATCH 04/12] tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition

This function is skipped for non-JSON monitor (which never happens now) and for agent connections (which we currently do not test). Only check for qapischema to simplify the condition. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH 01/12] tests: assume JSON monitor in qemuMonitorTestNewSimple

The only user of the qemuMonitorTestNewSimple macro is using JSON. Always pass 'true' to qemuMonitorTestNew and remove the 'json' argument. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 2 +- tests/qemumonitortestutils.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

[libvirt] [PATCH 09/12] tests: refactor qemuMonitorTestProcessCommandDefault

Use VIR_AUTOPTR and get rid of the 'ret' variable. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index

[libvirt] [PATCH 07/12] tests: remove text monitor testing infrastructure

We removed testing for text monitor some time ago, remove the remains from the test infrastructure. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 125 --- 1 file changed, 44 insertions(+), 81 deletions(-) diff --git a/tests/qemumonitortestutils.c

[libvirt] [PATCH 08/12] tests: qemuMonitorReportError: use VIR_AUTOFREE

Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index f1104e0ff9..313ecb01fd 100644 --- a/tests/qemumonitortestutils.c +++

[libvirt] [PATCH 05/12] tests: assume JSON in qemuMonitorTestIO

Only strip the carriage return for agent monitor, now that we no longer support text monitor. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index

[libvirt] [PATCH 06/12] tests: qemuMonitorReportError: use tmp variable properly

There is no obvious benefit in putting the escaped message back into msg while tmp holds the original message. Remove the assignment and use 'tmp' directly'. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH 02/12] tests: always assume JSON in qemuMonitorTestNew

Now that all the callers call qemuMonitorTestNew with json=true, remove the argument and always assume JSON. Signed-off-by: Ján Tomko --- tests/qemuhotplugtest.c | 2 +- tests/qemumonitortestutils.c | 15 ++- tests/qemumonitortestutils.h | 7 +++ 3 files changed, 10

[libvirt] [PATCH 00/12] tests: remove text monitor testing infrastructure

Ján Tomko (12): tests: assume JSON monitor in qemuMonitorTestNewSimple tests: always assume JSON in qemuMonitorTestNew tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition tests: assume JSON in

[libvirt] [PATCH 03/12] tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE

Use VIR_AUTOFREE. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 86883e682b..bb30bed51e 100644 --- a/tests/qemumonitortestutils.c