On 6/17/19 6:40 PM, Andrea Bolognani wrote:
On Mon, 2019-06-17 at 18:21 +0200, Michal Privoznik wrote:
It's fairly easy (especially for new contributors) to not spot
the 'cppi not installed' line in the syntax-check output. Turn it
into a banner that is more visible
Good so far.
and at the s
On Mon, Jun 17, 2019 at 11:12 AM Michal Privoznik wrote:
>
> On 5/22/19 10:10 PM, Ilias Stamatis wrote:
> > Ignore @source in the case of the test driver and return fixed private
> > IPv4 addresses for all the interfaces defined in the domain.
> >
> > Signed-off-by: Ilias Stamatis
> > ---
> >
> >
On Sat, Jun 15, 2019 at 3:25 PM Michal Prívozník wrote:
>
> On 6/8/19 12:00 PM, Ilias Stamatis wrote:
> > Return infinite time DHCP leases for fixed IPV4 addresses.
> >
> > Signed-off-by: Ilias Stamatis
> > ---
> > src/test/test_driver.c | 118 +
> > 1 fil
On Mon, Jun 17, 2019 at 9:52 AM Erik Skultety wrote:
>
> On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote:
> > On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety wrote:
> > >
> > > On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote:
> > > > On Thu, Jun 13, 2019 at 10:20 AM E
I'm happy to announce the release of virt-manager 2.2.0!
virt-manager is a desktop application for managing KVM, Xen, and LXC
virtualization via libvirt.
The release can be downloaded from:
http://virt-manager.org/download/
This release includes:
- libvirt XML viewing and editing UI for new an
On Mon, 17 Jun 2019 16:10:30 +0100
Daniel P. Berrangé wrote:
> On Mon, Jun 17, 2019 at 08:54:38AM -0600, Alex Williamson wrote:
> > On Mon, 17 Jun 2019 15:00:00 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Thu, May 23, 2019 at 05:20:01PM -0600, Alex Williamson wrote:
> > > > Hi,
> > > >
On Mon, Jun 17, 2019 at 06:40:14PM +0200, Andrea Bolognani wrote:
> On Mon, 2019-06-17 at 18:21 +0200, Michal Privoznik wrote:
> > It's fairly easy (especially for new contributors) to not spot
> > the 'cppi not installed' line in the syntax-check output. Turn it
> > into a banner that is more visi
On Mon, 2019-06-17 at 17:50 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> docs/formatdomain.html.in | 4 ++--
> docs/formatnetworkport.html.in | 12 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat /
On Mon, 2019-06-17 at 18:21 +0200, Michal Privoznik wrote:
> It's fairly easy (especially for new contributors) to not spot
> the 'cppi not installed' line in the syntax-check output. Turn it
> into a banner that is more visible
Good so far.
> and at the same time add it as
> a build dependency.
It's fairly easy (especially for new contributors) to not spot
the 'cppi not installed' line in the syntax-check output. Turn it
into a banner that is more visible and at the same time add it as
a build dependency. Unfortunately, RHEL doesn't ship cppi so we
can add the dependency only for Fedora.
On 6/17/19 3:27 PM, Andrea Bolognani wrote:
On Mon, 2019-06-17 at 14:13 +0200, Michal Privoznik wrote:
[...]
@@ -695,6 +695,11 @@ sc_require_whitespace_in_translation:
{ echo '$(ME): missing whitespace at line split' 1>&2; \
exit 1; } || :
+cppi_banner = \
+ " ***
On Fri, 14 Jun 2019 10:04:18 -0600
Alex Williamson wrote:
> On Fri, 14 Jun 2019 17:06:15 +0200
> Christophe de Dinechin wrote:
>
> > > On 14 Jun 2019, at 16:23, Alex Williamson
> > > wrote:
> > >
> > > On Fri, 14 Jun 2019 11:54:42 +0200
> > > Christophe de Dinechin wrote:
> > > Where is th
Signed-off-by: Ján Tomko
---
docs/formatdomain.html.in | 4 ++--
docs/formatnetworkport.html.in | 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 73a9cb6205..cf585d8e99 100644
--- a/docs/formatdomain
There is a missing empty line between two functions since its
introduction in v1.2.0-rc1~150.
Signed-off-by: Michal Privoznik
---
Pushed under trivial rule.
tests/virpcimock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 7f9cdaa9b8..beb5e149
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> The only user is now in qemu_monitor_json.c to re-parse the command line
> format into keyvalue pairs for use in QMP command construction.
>
> Move and rename the functions.
>
> Signed-off-by: Peter Krempa
> ---
> po/POTFILES
On Mon, Jun 17, 2019 at 08:54:38AM -0600, Alex Williamson wrote:
> On Mon, 17 Jun 2019 15:00:00 +0100
> Daniel P. Berrangé wrote:
>
> > On Thu, May 23, 2019 at 05:20:01PM -0600, Alex Williamson wrote:
> > > Hi,
> > >
> > > Currently mediated device management, much like SR-IOV VF management,
> >
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> qemu_domain.c is now the only place that uses it, so we can move it from
> qemu_parse_command.h
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_domain.c| 3 ++-
> src/qemu/qemu_parse_command.h | 2 --
> 2 files changed, 2 ins
On Mon, Jun 17, 2019 at 02:55:30PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index f95dfdf3b4..ff4f190c23 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -54,6 +54,18 @
On Mon, Jun 17, 2019 at 02:55:34PM +0200, Peter Krempa wrote:
The only user is now in qemu_monitor_json.c to re-parse the command line
format into keyvalue pairs for use in QMP command construction.
Move and rename the functions.
For now.
Signed-off-by: Peter Krempa
---
po/POTFILES
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> It's now unused and utterly obsolete.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_parse_command.c | 2622 +
> src/qemu/qemu_parse_command.h | 14 -
> 2 files changed, 1 insertion(+), 2635 deletio
On Mon, Jun 17, 2019 at 02:55:33PM +0200, Peter Krempa wrote:
qemu_domain.c is now the only place that uses it, so we can move it from
qemu_parse_command.h
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 3 ++-
src/qemu/qemu_parse_command.h | 2 --
2 files changed, 2 insertions(+)
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> Now that we no longer use that functionality we can also drop the tests.
>
> Signed-off-by: Peter Krempa
> ---
> tests/Makefile.am | 11 +-
> tests/qemuargv2xmldata/boot-cdrom.args| 22 --
> tests/qemu
On Mon, Jun 17, 2019 at 02:55:32PM +0200, Peter Krempa wrote:
It's now unused and utterly obsolete.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_parse_command.c | 2622 +
src/qemu/qemu_parse_command.h | 14 -
2 files changed, 1 insertion(+), 2635 deletions(-)
On Mon, Jun 17, 2019 at 02:55:31PM +0200, Peter Krempa wrote:
Now that we no longer use that functionality we can also drop the tests.
Signed-off-by: Peter Krempa
---
tests/Makefile.am | 11 +-
tests/qemuargv2xmldata/boot-cdrom.args| 22 --
tests/qemuargv2xml
On Mon, Jun 17, 2019 at 02:55:29PM +0200, Peter Krempa wrote:
This code is really neglected and does not at all work reliably. It
can't even be used for converting our own commandline back.
Since this was mostly useful for aiding migration from manually run qemu
to libvirt and will not work for
On Mon, Jun 17, 2019 at 02:55:28PM +0200, Peter Krempa wrote:
Now that we no longer support attaching to a live non-libvirt qemu we
s/live non-libvirt qemu/live QEMU process not managed by libvirt/
can drop the backend functions as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_parse_c
On Mon, 2019-06-17 at 17:01 +0200, Andrea Bolognani wrote:
> On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> [...]
> > +
> > + qemu: Remove support for virDomainQemuAttach and
> > virConnectDomainXMLFromNative APIs
> > +
> > +
> > + The qemu imple
On Mon, Jun 17, 2019 at 02:55:27PM +0200, Peter Krempa wrote:
Attaching to modern qemu will not work with all this code and attempting
to ressurect it would be mostly pointless.
Signed-off-by: Peter Krempa
---
src/check-aclrules.pl | 1 +
src/qemu/qemu_driver.c | 92 ---
On Mon, Jun 17, 2019 at 02:55:26PM +0200, Peter Krempa wrote:
Allow expressing that a hypervisor implementation was deleted by adding
a end-version when the implementation was removed to our hypervisor
support matrix.
This patch hacks the perl scrip that generates the support matrix to
script
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
[...]
> +
> + qemu: Remove support for virDomainQemuAttach and
> virConnectDomainXMLFromNative APIs
> +
> +
> + The qemu implementations for the APIs mentioned above were removed
> + and the A
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> This code is really neglected and does not at all work reliably. It
> can't even be used for converting our own commandline back.
>
> Since this was mostly useful for aiding migration from manually run qemu
> to libvirt and will not work for
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> Now that we no longer support attaching to a live non-libvirt qemu we
> can drop the backend functions as well.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_parse_command.c | 92 ---
> src/qemu/qemu
On Mon, 17 Jun 2019 15:00:00 +0100
Daniel P. Berrangé wrote:
> On Thu, May 23, 2019 at 05:20:01PM -0600, Alex Williamson wrote:
> > Hi,
> >
> > Currently mediated device management, much like SR-IOV VF management,
> > is largely left as an exercise for the user. This is an attempt to
> > provid
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
> Attaching to modern qemu will not work with all this code and attempting
> to ressurect it would be mostly pointless.
>
> Signed-off-by: Peter Krempa
> ---
> src/check-aclrules.pl | 1 +
> src/qemu/qemu_driver.c | 92
On Mon, 2019-06-17 at 14:55 +0200, Peter Krempa wrote:
[...]
> foreach my $drv (keys %{$groups{"virHypervisorDriver"}->{drivers}}) {
> -my $openVersStr =
> $groups{"virHypervisorDriver"}->{drivers}->{$drv}->{"connectOpen"};
> +my $openVersStr =
> $groups{"virHypervisorDriver"}->{drivers}
On Fri, Jun 07, 2019 at 07:44:21AM -0400, Laine Stump wrote:
> On 5/23/19 11:32 AM, Daniel P. Berrangé wrote:
> > This initial implementation just wires up the APIs and does tracking of
> > the port XML definitions. It is not yet integrated into the resource
> > allocation logic.
> >
> > Signed-of
On Mon, Jun 17, 2019 at 03:32:17PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 06, 2019 at 09:51:52PM -0400, Laine Stump wrote:
> > On 5/23/19 11:32 AM, Daniel P. Berrangé wrote:
> > > The virNetworkObjPtr state will need to maintain a record of all
> > > virNetworkPortDefPtr objects associated
On Thu, Jun 06, 2019 at 09:51:52PM -0400, Laine Stump wrote:
> On 5/23/19 11:32 AM, Daniel P. Berrangé wrote:
> > The virNetworkObjPtr state will need to maintain a record of all
> > virNetworkPortDefPtr objects associated with the network. Record these
> > in a hash and add APIs for manipulating t
On Fri, May 24, 2019 at 03:28:31PM -0400, Laine Stump wrote:
> On 5/23/19 11:32 AM, Daniel P. Berrangé wrote:
> > Introduce a virNetworkPortDefPtr struct to represent the data associated
> > with a virtual network port. Add APIs for parsing/formatting XML docs
> > with the data.
> >
> > Signed-off
On Thu, May 23, 2019 at 05:20:01PM -0600, Alex Williamson wrote:
> Hi,
>
> Currently mediated device management, much like SR-IOV VF management,
> is largely left as an exercise for the user. This is an attempt to
> provide something and see where it goes. I doubt we'll solve
> everyone's needs
On Mon, Jun 03, 2019 at 06:07:02PM +0200, Michal Privoznik wrote:
> On 4/25/19 10:19 AM, Michal Privoznik wrote:
> >
> > This is meant for next release to have the most time possible for
> > testing. Some of the patches were ACKed in v3 already but since they
> > don't make sense on their own I hav
On Thu, Apr 25, 2019 at 10:20:01AM +0200, Michal Privoznik wrote:
> This reverts commit fc3990c7e64be1da1631952d3ec384ebef50e125.
>
> Now that all the reported bugs are fixed let's turn the feature
> back on.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> docs/news.xm
On Thu, Apr 25, 2019 at 10:20:00AM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/qemu/qemu_blockjob.c | 6 ++
> src/qemu/qemu_driver.c | 17 ++---
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Dani
On Thu, Apr 25, 2019 at 10:19:58AM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/security/security_selinux.c | 57 +
> 1 file changed, 57 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
On Thu, Apr 25, 2019 at 10:19:57AM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/security/security_dac.c | 62 +
> 1 file changed, 62 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
On Thu, Apr 25, 2019 at 10:19:59AM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/qemu/qemu_security.c | 19 +++
> src/qemu/qemu_security.h | 5 +
> 2 files changed, 24 insertions(+)
Reviewed-by: Daniel P. Berrangé
On Thu, Apr 25, 2019 at 10:19:56AM +0200, Michal Privoznik wrote:
> A simple helper function that would be used from DAC and SELinux
> drivers.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/security/security_util.c | 63
> src/
On Thu, Apr 25, 2019 at 10:19:55AM +0200, Michal Privoznik wrote:
> The purpose of this API is to allow caller move XATTRs (or remove
> them) from one file to another. This will be needed when moving
> top level of disk chain (either by introducing new HEAD or
> removing it).
>
> Signed-off-by: Mi
On Thu, Apr 25, 2019 at 10:19:54AM +0200, Michal Privoznik wrote:
> This effectively reverts d7420430ce6 and adds new code.
>
> Here is the problem: Imagine a file X that is to be shared
> between two domains as a disk. Let the first domain (vm1) have
> seclabel remembering turned on and the other
On Mon, 2019-06-17 at 14:13 +0200, Michal Privoznik wrote:
[...]
> @@ -695,6 +695,11 @@ sc_require_whitespace_in_translation:
> { echo '$(ME): missing whitespace at line split' 1>&2; \
> exit 1; } || :
>
> +cppi_banner = \
> + " **
On Thu, Apr 25, 2019 at 10:19:53AM +0200, Michal Privoznik wrote:
> Some paths will not be restored. Because we can't possibly know
> if they are still in use or not. Reflect this in the test so that
> we can test more domains. Also see next commit for more detailed
> explanation.
>
> Signed-off-b
On Thu, Apr 25, 2019 at 10:19:51AM +0200, Michal Privoznik wrote:
> One caller in particular (virSecurityDACSetImageLabelInternal)
> will want to have the feature turned on only in some cases.
> Introduce @remember member to _virSecurityDACChownItem to track
> whether caller wants to do owner remem
On Thu, Apr 25, 2019 at 10:19:52AM +0200, Michal Privoznik wrote:
> Just like previous commit allowed to enable or disable owner
> remembering for each individual path, do the same for SELinux
> driver. This is going to be needed in the next commit.
>
> Signed-off-by: Michal Privoznik
> Reviewed-
On Thu, Apr 25, 2019 at 10:19:50AM +0200, Michal Privoznik wrote:
> Both DAC and SELinux drivers support transactions. Each item on
> the transaction list consists of various variables and @restore
> is one of them. Document it so that as the list of variables grow
> it's easier to spot which varia
On Thu, Apr 25, 2019 at 10:19:48AM +0200, Michal Privoznik wrote:
> It's better to have the function report errors, because none of
> the callers does.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/util/virfile.c | 18 ++
> 1 file changed, 14 inser
On Thu, Apr 25, 2019 at 10:19:49AM +0200, Michal Privoznik wrote:
> The way that virSecurityDACRecallLabel is currently written is
> that if XATTRs are not supported for given path to the caller
> this is not different than if the path is still in use. The value
> of 1 is returned which makes secdr
On Thu, Apr 25, 2019 at 10:19:47AM +0200, Michal Privoznik wrote:
> It's better to have the function report errors, because none of
> the callers does.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/util/virfile.c | 18 ++
> 1 file changed, 14 inser
On Thu, Apr 25, 2019 at 10:19:44AM +0200, Michal Privoznik wrote:
> Firstly, there's no reason to enumerate all XATTRs since they
> differ only in the prefix and we can construct them in a loop.
>
> Secondly, and more importantly, the script was still looking for
> just one prefix "trusted.libvirt
On Thu, Apr 25, 2019 at 10:19:45AM +0200, Michal Privoznik wrote:
> Just like it's DAC counterpart is doing,
> virSecuritySELinuxRestoreAllLabel() could print @migrated in the
> debug message.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Cole Robinson
> ---
> src/security/security_selinux
On Thu, Apr 25, 2019 at 10:19:46AM +0200, Michal Privoznik wrote:
> The way that security drivers use XATTR is kind of verbose. If
> error reporting was left for caller then the caller would end up
> even more verbose.
>
> There are two places where we do not want to report error if
> virFileGetXA
On Thu, Apr 25, 2019 at 10:19:42AM +0200, Michal Privoznik wrote:
> This simplifies the code a bit and removes the need for cleanup
> label in one case. In the other case the label is kept because
> it's going to be used later.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/qemusecuritytest.c
On Thu, 30 May 2019 10:33:16 +0200
Igor Mammedov wrote:
> Changes since v3:
> - simplify series by dropping idea of showing property values in
> "qom-list-properties"
> and use MachineInfo in QAPI schema instead
>
> Changes since v2:
> - taking in account previous review, implement a wa
qemu_domain.c is now the only place that uses it, so we can move it from
qemu_parse_command.h
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 3 ++-
src/qemu/qemu_parse_command.h | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/q
Attaching to modern qemu will not work with all this code and attempting
to ressurect it would be mostly pointless.
Signed-off-by: Peter Krempa
---
src/check-aclrules.pl | 1 +
src/qemu/qemu_driver.c | 92 --
2 files changed, 9 insertions(+), 84 deletion
This code is really neglected and does not at all work reliably. It
can't even be used for converting our own commandline back.
Since this was mostly useful for aiding migration from manually run qemu
to libvirt and will not work for this puspose in many cases it's not
worth having.
Signed-off-by
On Thu, Apr 25, 2019 at 10:19:43AM +0200, Michal Privoznik wrote:
> Having to enumerate all capabilities that we want domain to have
> is too verbose and prevents us from adding more tests. Have the
> domain always have the latest x86_64 capabilities. This means
> that we have to drop two arm tests
Signed-off-by: Peter Krempa
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index f95dfdf3b4..ff4f190c23 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -54,6 +54,18 @@
+
+
+
+ qemu: R
Allow expressing that a hypervisor implementation was deleted by adding
a end-version when the implementation was removed to our hypervisor
support matrix.
This patch hacks the perl scrip that generates the support matrix to
support comments like:
.domainQemuAttach = qemuDomainQemuAttach, /* 0.8.
On Thu, Apr 25, 2019 at 10:19:41AM +0200, Michal Privoznik wrote:
> The @securityManager variable in testDomain() is unused. Drop it.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/qemusecuritytest.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
-
All the code is mostly outdated and does not really help in most cases.
Since this was already proposed and I did not see anything against here
are the patches.
As a follow up I'll refactor and move the rest of qemu_parse_command.c
once this is out of the way.
you can fetch this by
git fetch h
On Thu, Apr 25, 2019 at 10:19:40AM +0200, Michal Privoznik wrote:
> Problem with current approach is that if
> qemuSecuritySetAllLabel() fails, then the @chown_paths and
> @xattr_paths hash tables are not freed and preserve values
> already stored there into the next test case.
>
> Signed-off-by:
On Thu, Apr 25, 2019 at 10:19:39AM +0200, Michal Privoznik wrote:
> I don't really know what happened when I was writing the original
> code, but even if error was to be set the corresponding boolean
> was set to false meaning no error.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/qemusecur
Now that we no longer use that functionality we can also drop the tests.
Signed-off-by: Peter Krempa
---
tests/Makefile.am | 11 +-
tests/qemuargv2xmldata/boot-cdrom.args| 22 --
tests/qemuargv2xmldata/boot-cdrom.xml | 35 --
tests/qemuargv2xmldata/
The only user is now in qemu_monitor_json.c to re-parse the command line
format into keyvalue pairs for use in QMP command construction.
Move and rename the functions.
Signed-off-by: Peter Krempa
---
po/POTFILES | 1 -
src/qemu/Makefile.inc.am | 2 -
src/qemu/qemu_mon
Now that we no longer support attaching to a live non-libvirt qemu we
can drop the backend functions as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_parse_command.c | 92 ---
src/qemu/qemu_parse_command.h | 7 ---
2 files changed, 99 deletions(-)
diff --g
It's now unused and utterly obsolete.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_parse_command.c | 2622 +
src/qemu/qemu_parse_command.h | 14 -
2 files changed, 1 insertion(+), 2635 deletions(-)
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_par
On Thu, Apr 25, 2019 at 10:19:38AM +0200, Michal Privoznik wrote:
> One of the functions of this mock is that it spoofs chown() and
> stat() calls. But it is doing so in a clever way: it stores the
> new owner on chown() and reports it on subsequent stat(). This is
> done by using a 32bit unsigned
On Thu, Apr 25, 2019 at 10:19:37AM +0200, Michal Privoznik wrote:
> This test is beautiful. It checks if we haven't messed up
> refcounting on security labels (well, XATTRs where the original
> owner is stored). It does this by setting up tracking of XATTR
> setting/removing into a hash table, then
It's fairly easy (especially for new contributors) to not spot
the 'cppi not installed' line in the syntax-check output. Turn it
into a banner that is more visible and at the same time add it as
a build dependency. Unfortunately, RHEL doesn't ship cppi so we
can add the dependency only for Fedora.
On Mon, Jun 17, 2019 at 11:50:01AM +0200, Andrea Bolognani wrote:
> On Mon, 2019-06-17 at 11:37 +0200, Martin Kletzander wrote:
> > On Mon, Jun 17, 2019 at 10:46:33AM +0200, Michal Privoznik wrote:
> > > On 6/17/19 9:15 AM, Andrea Bolognani wrote:
> > > > According to [1], only Fedora and FreeBSD h
On Mon, Jun 17, 2019 at 11:50:01AM +0200, Andrea Bolognani wrote:
> On Mon, 2019-06-17 at 11:37 +0200, Martin Kletzander wrote:
> > On Mon, Jun 17, 2019 at 10:46:33AM +0200, Michal Privoznik wrote:
> > > On 6/17/19 9:15 AM, Andrea Bolognani wrote:
> > > > According to [1], only Fedora and FreeBSD h
On Mon, 2019-06-17 at 11:37 +0200, Martin Kletzander wrote:
> On Mon, Jun 17, 2019 at 10:46:33AM +0200, Michal Privoznik wrote:
> > On 6/17/19 9:15 AM, Andrea Bolognani wrote:
> > > According to [1], only Fedora and FreeBSD have cppi packaged, so
> > > merging this patch will make 'make syntax-chec
On Mon, Jun 17, 2019 at 10:46:33AM +0200, Michal Privoznik wrote:
On 6/17/19 9:15 AM, Andrea Bolognani wrote:
On Mon, 2019-06-17 at 01:19 +0200, Ján Tomko wrote:
On Sat, Jun 15, 2019 at 03:17:22PM +0200, Michal Privoznik wrote:
Since its introduction in v0.8.0~314 we allowed for cppi to be
not
On 6/14/19 1:23 PM, Andrea Bolognani wrote:
An alternative take on David Gibson's patch
https://www.redhat.com/archives/libvir-list/2019-June/msg00061.html
from earlier this month.
Andrea Bolognani (7):
docs: Fix validation of spapr-vio addresses
qemu: Rework qemuDomainDeviceDefValida
On 5/22/19 10:10 PM, Ilias Stamatis wrote:
Ignore @source in the case of the test driver and return fixed private
IPv4 addresses for all the interfaces defined in the domain.
Signed-off-by: Ilias Stamatis
---
The default config of the test driver has no guest interfaces defined,
so this must b
On 6/15/19 2:54 PM, Ján Tomko wrote:
Ján Tomko (3):
docs: storage: fix spacing when enumerating volume formats
docs: storage: type out two
docs: storage: document the 'lvm2' disk format oddness
docs/storage.html.in | 26 +-
1 file changed, 17 insertions(+), 9
On 6/17/19 9:15 AM, Andrea Bolognani wrote:
On Mon, 2019-06-17 at 01:19 +0200, Ján Tomko wrote:
On Sat, Jun 15, 2019 at 03:17:22PM +0200, Michal Privoznik wrote:
Since its introduction in v0.8.0~314 we allowed for cppi to be
not present for 'syntax-check' because the package did exist in
Fedora
On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote:
> On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety wrote:
> >
> > On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote:
> > > On Thu, Jun 13, 2019 at 10:20 AM Erik Skultety
> > > wrote:
> > > >
> > > > On Tue, Jun 04, 2019 a
On Fri, Jun 14, 2019 at 15:51:31 +0200, Ján Tomko wrote:
> On Fri, Jun 14, 2019 at 03:30:25PM +0200, Peter Krempa wrote:
> > This code is really neglected and does not at all work reliably. It
> > can't even be used for converting our own commandline back.
> >
> > Since this was mostly useful for
On Mon, 2019-06-17 at 01:19 +0200, Ján Tomko wrote:
> On Sat, Jun 15, 2019 at 03:17:22PM +0200, Michal Privoznik wrote:
> > Since its introduction in v0.8.0~314 we allowed for cppi to be
> > not present for 'syntax-check' because the package did exist in
> > Fedora Core 12. Well, we don't care anym
On Sat, Jun 15, 2019 at 13:53:58 +0200, Ján Tomko wrote:
> Ján Tomko (12):
> tests: assume JSON monitor in qemuMonitorTestNewSimple
> tests: always assume JSON in qemuMonitorTestNew
> tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE
> tests: qemuMonitorTestProcessCommandDefaultValid
On Sat, Jun 15, 2019 at 13:54:07 +0200, Ján Tomko wrote:
> Use VIR_AUTOPTR and get rid of the 'ret' variable.
>
> Signed-off-by: Ján Tomko
> ---
> tests/qemumonitortestutils.c | 31 +++
> 1 file changed, 11 insertions(+), 20 deletions(-)
>
> diff --git a/tests/qemumo
92 matches
Mail list logo
