[libvirt] [PATCH 08/13] backup: Implement virsh support for checkpoints

Introduce a bunch of new virsh commands for managing checkpoints in isolation. More commands are needed for performing incremental backups, but these commands were easy to implement by modeling heavily after virsh-snapshot.c (no need for checkpoint-revert, and checkpoint-list was a lot easier

[libvirt] [PATCH 10/13] backup: test: Implement metadata tracking for checkpoint APIs

A lot of this work heavily copies from the existing snapshot APIs. The test driver doesn't really have to do anything more than just expose an interface into libvirt metadata, making it possible to test saving and restoring XML, and tracking relations between multiple checkpoints. Signed-off-by:

[libvirt] [PATCH 11/13] backup: qemu: Implement metadata tracking for checkpoint APIs

A lot of this work heavily copies from the existing snapshot APIs. The interaction with qemu during create/delete still needs to be implemented, but this takes care of all the libvirt metadata (saving and restoring XML, and tracking the relations between multiple checkpoints). Signed-off-by:

[libvirt] [PATCH 12/13] backup: Wire up qemu checkpoint commands over QMP

Time to actually issue the QMP transactions that create and delete persistent checkpoints. For create, we only need one transaction: inside, we visit all disks affected by the checkpoint, and create a new enabled bitmap, as well as disabling the bitmap of the parent checkpoint (if any). For

[libvirt] [PATCH 03/13] backup: Document nuances between different state capture APIs

Now that various new API have been added, it is worth a landing page that gives an overview of capturing various pieces of guest state, and which APIs are best suited to which tasks. Signed-off-by: Eric Blake Reviewed-by: John Ferlan Reviewed-by: Daniel P. Berrangé --- docs/docs.html.in

[libvirt] [PATCH 13/13] backup: qemu: Implement VIR_DOMAIN_CHECKPOINT_XML_SIZE flag

Once a checkpoint has been created, it is desirable to estimate the size of the disk delta that is represented between the checkpoint and the current operation. To do this, we have to scrape information out of QMP query-block on a request from the user. --- src/qemu/qemu_monitor.h | 4 ++

[libvirt] [PATCH 02/13] backup: Introduce virDomainCheckpoint APIs

Introduce a bunch of new public APIs related to backup checkpoints. Checkpoints are modeled heavily after virDomainSnapshotPtr (both represent a point in time of the guest), although a snapshot exists with the intent of rolling back to that state, while a checkpoint exists to make it possible to

[libvirt] [PATCH 06/13] backup: Add new domain:checkpoint access control

Creating a checkpoint does not modify guest-visible state, but does modify host resources. Rather than reuse existing domain:write, domain:block_write, or domain:snapshot access controls, it seems better to introduce a new access control specific to tasks related to checkpoints and incremental

[libvirt] [PATCH 05/13] backup: Allow for lists of checkpoint objects

Create a new file for managing a list of checkpoint objects, borrowing heavily from existing virDomainSnapshotObjList paradigms. Note that while checkpoints definitely have a use case for multiple children to a single parent (create a base snapshot, create a child snapshot, revert to the base,

[libvirt] [PATCH 09/13] snapshot: Refactor test to utilize virDomainMoment more

Similar to commit a487890d for qemu, a little bit of refactoring in the snapshot delete code will make it easier to reuse functionality for checkpoints. Signed-off-by: Eric Blake --- src/test/test_driver.c | 34 +- 1 file changed, 17 insertions(+), 17

[libvirt] [PATCH 01/13] backup: Document new XML for checkpoints

Prepare for new checkpoint APIs by describing the XML that will represent a checkpoint. The checkpoint XML is modeled heavily after virDomainSnapshotPtr. (See the docs for more details). Add testsuite coverage for some minimal uses of the XML (bare minimum, the sample from html, and a full

[libvirt] [PATCH v8.5 00/13] Checkpoint APIs (incremental backup saga)

This is a subset of v8 of incremental backup, focusing more on just the checkpoint manipulation code (as this had fewer review comments that still needed addressing). I think there is enough here that even if this lands in 5.5 while the backup APIs slide into 5.6 that we'd still have a reasonably

[libvirt] [PATCH 07/13] backup: Implement checkpoint APIs for remote driver

The remote code generator had to be taught about the new virDomainCheckpointPtr type, at which point the remote driver code for backups can be generated. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrangé --- src/remote/remote_daemon_dispatch.c | 20 src/remote/remote_driver.c

[libvirt] [PATCH 04/13] backup: Parse and output checkpoint XML

Add a new file checkpoint_conf.c that performs the translation to and from new XML describing a checkpoint. The code shares a common base class with snapshots, since a checkpoint similarly represents the domain state at a moment in time. Add some basic testing of round trip XML handling through

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

On Tue, 18 Jun 2019 14:48:11 +0200 Sylvain Bauza wrote: > On Tue, Jun 18, 2019 at 1:01 PM Cornelia Huck wrote: > > > On Mon, 17 Jun 2019 11:05:17 -0600 > > Alex Williamson wrote: > > > > > On Mon, 17 Jun 2019 16:10:30 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Mon, Jun 17,

Re: [libvirt] [PATCH v2 2/4] conf: fix leak of directory handle when loading network ports

On 6/18/19 1:39 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/conf/virnetworkobj.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c > index 47c142998e..ed1f02f4c5 100644 > ---

Re: [libvirt] [PATCH v2 0/4] Misc fixes to network port code

On 6/18/19 1:39 PM, Daniel P. Berrangé wrote: > Fixes for bugs spotted by coverity > > Daniel P. Berrangé (4): > conf: fix leak when parsing network port XML > conf: fix leak of directory handle when loading network ports > conf: fix NULL deref when exporting ports > conf: add error

[libvirt] [PATCH v2 2/4] conf: fix leak of directory handle when loading network ports

Signed-off-by: Daniel P. Berrangé --- src/conf/virnetworkobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 47c142998e..ed1f02f4c5 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -1750,6 +1750,7 @@

[libvirt] [go-xml PATCH] Add support for network filter binding XML schema

Signed-off-by: Daniel P. Berrangé --- nwfilter_binding.go | 73 + xml_test.go | 3 ++ 2 files changed, 76 insertions(+) create mode 100644 nwfilter_binding.go diff --git a/nwfilter_binding.go b/nwfilter_binding.go new file mode 100644 index

[libvirt] RFC: revival of hotplug/unplug for PCI Multifunction devices in QEMU guests

Hi, This is labeled as RFC but it's more like a FYI to let people know and comment beforehand. Shiva sent a 28 patch series last year that implements hotplug/unplug support for PCI multifunction devices [1]. The design motivation of his work was based in a RFC sent to this mailing list back in

[libvirt] [PATCH v2 0/4] Misc fixes to network port code

Fixes for bugs spotted by coverity Daniel P. Berrangé (4): conf: fix leak when parsing network port XML conf: fix leak of directory handle when loading network ports conf: fix NULL deref when exporting ports conf: add error checking of UUID generation src/conf/domain_conf.c | 12

[libvirt] [PATCH v2 3/4] conf: fix NULL deref when exporting ports

Signed-off-by: Daniel P. Berrangé --- src/conf/virnetworkobj.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index ed1f02f4c5..fd4bf779b9 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@

[libvirt] [PATCH v2 4/4] conf: add error checking of UUID generation

Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ee651e7742..c69d382d70 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30415,7

[libvirt] [PATCH v2 1/4] conf: fix leak when parsing network port XML

Use auto free to avoid leaking the "trustGuestRxFilters" strings Signed-off-by: Daniel P. Berrangé --- src/conf/virnetworkportdef.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/conf/virnetworkportdef.c b/src/conf/virnetworkportdef.c index

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

On Tue, Jun 18, 2019 at 06:33:01PM +0200, Christophe de Dinechin wrote: > > > > On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > > > > Signed-off-by: Daniel P. Berrangé > > --- > > network.go | 80 ++ > > network_port.go | 233

[libvirt] [go-xml PATCH] Add support for network port XML schema

Signed-off-by: Daniel P. Berrangé --- domain.go | 1 + network.go | 1 + network_port.go | 200 xml_test.go | 3 + 4 files changed, 205 insertions(+) create mode 100644 network_port.go diff --git a/domain.go b/domain.go

Re: [libvirt] [PATCH v6 18/23] conf: support recording ports against virNetworkObjPtr

[...] > + > + > +int > +virNetworkObjDeleteAllPorts(virNetworkObjPtr net, > +const char *stateDir) > +{ > +char *dir; > +DIR *dh; > +struct dirent *de; > +int rc; > +int ret = -1; > + > +if (!(dir = virNetworkObjGetPortStatusDir(net,

Re: [libvirt] [PATCH v6 04/23] conf: add APIs to convert virDomainNetDef to virNetworkPortDef

[...] > +virNetworkPortDefPtr > +virDomainNetDefToNetworkPort(virDomainDefPtr dom, > + virDomainNetDefPtr iface) > +{ > +virNetworkPortDefPtr port; > + > +if (iface->type != VIR_DOMAIN_NET_TYPE_NETWORK) { > +virReportError(VIR_ERR_INTERNAL_ERROR, > +

[libvirt] [PATCH 37/46] util: scsi: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virscsi.h | 11 --- src/util/virscsihost.h | 7 ++- src/util/virscsivhost.h | 13 + 3 files changed, 11 insertions(+), 20 deletions(-) diff --git a/src/util/virscsi.h b/src/util/virscsi.h index 907948455e..6cc68835b7

[libvirt] [PATCH 31/46] util: object: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virobject.h | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/util/virobject.h b/src/util/virobject.h index d13fc4b1ac..fe5dbe7326 100644 --- a/src/util/virobject.h +++ b/src/util/virobject.h @@ -19,11 +19,10

[libvirt] [PATCH 46/46] syntax check: update header guard check

Internal headers should use #pragma once instead of the standard #ifndef guard. Public headers still require the existing header guard. Signed-off-by: Jonathon Jongsma --- build-aux/header-ifdef.pl | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff

Re: [libvirt] [PATCH v6 02/23] conf: introduce virNetworkPortDefPtr struct and XML support

[...] > +static virNetworkPortDefPtr > +virNetworkPortDefParseXML(xmlXPathContextPtr ctxt) > +{ > +virNetworkPortDefPtr def; > +char *uuid = NULL; > +xmlNodePtr virtPortNode; > +xmlNodePtr vlanNode; > +xmlNodePtr bandwidthNode; > +xmlNodePtr addressNode; > +char

[libvirt] [PATCH 43/46] xen: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/xenapi/xenapi_driver.h | 5 + src/xenapi/xenapi_driver_private.h | 17 +++-- src/xenapi/xenapi_utils.h | 15 ++- src/xenconfig/xen_common.h | 17 +++-- src/xenconfig/xen_sxpr.h |

[libvirt] [PATCH 44/46] tests: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- tests/qemumonitortestutils.h | 19 +++--- tests/qemusecuritytest.h | 7 +- tests/testutils.h| 45 ++-- tests/testutilshostcpus.h| 11 ++- tests/testutilslxc.h | 11 ++- tests/testutilsqemu.h| 21 +++---

[libvirt] [PATCH 34/46] util: sysinfo: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virsysinfo.h | 13 + src/util/virsysinfopriv.h | 5 + 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/util/virsysinfo.h b/src/util/virsysinfo.h index c0015834bc..f30809294b 100644 --- a/src/util/virsysinfo.h

[libvirt] [PATCH 39/46] src/vbox: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/vbox/vbox_MSCOMGlue.h | 11 +-- src/vbox/vbox_common.h| 161 +- src/vbox/vbox_driver.h| 19 ++-- src/vbox/vbox_get_driver.h| 7 +- src/vbox/vbox_glue.h | 15 ++--

[libvirt] [PATCH 23/46] util: log: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virlog.h | 55 ++- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/src/util/virlog.h b/src/util/virlog.h index 775a726b06..a30b760fb4 100644 --- a/src/util/virlog.h +++ b/src/util/virlog.h @@

[libvirt] [PATCH 29/46] util: hash: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virhash.h | 8 ++-- src/util/virhashcode.h | 7 ++- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/util/virhash.h b/src/util/virhash.h index d2156a5ce0..ed3774e693 100644 --- a/src/util/virhash.h +++

[libvirt] [PATCH 13/46] src/test: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/test/test_driver.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/test/test_driver.h b/src/test/test_driver.h index ff7803da7f..8c8a462db7 100644 --- a/src/test/test_driver.h +++ b/src/test/test_driver.h @@ -19,11 +19,8 @@

[libvirt] [PATCH 12/46] src/storage: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/storage/storage_backend.h | 13 - src/storage/storage_backend_disk.h | 5 +--- src/storage/storage_backend_fs.h| 5 +--- src/storage/storage_backend_gluster.h | 5 +--- src/storage/storage_backend_iscsi.h

[libvirt] [PATCH 18/46] util: netdev: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virnetdev.h | 33 +++- src/util/virnetdevbandwidth.h| 8 +++- src/util/virnetdevbridge.h | 8 +++- src/util/virnetdevip.h | 9 +++-- src/util/virnetdevmacvlan.h | 22

[libvirt] [PATCH 14/46] util: thread: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virthread.h | 19 --- src/util/virthreadjob.h | 6 +- src/util/virthreadpool.h | 9 +++-- 3 files changed, 12 insertions(+), 22 deletions(-) diff --git a/src/util/virthread.h b/src/util/virthread.h index

[libvirt] [PATCH 09/46] src/rpc: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/rpc/virkeepalive.h| 9 +++- src/rpc/virnetclient.h| 41 --- src/rpc/virnetclientprogram.h | 15 + src/rpc/virnetclientstream.h | 9 +++- src/rpc/virnetdaemon.h| 21

[libvirt] [PATCH 20/46] util: file: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virfile.h | 61 ++ 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/src/util/virfile.h b/src/util/virfile.h index 641960e2ca..094c92e2b9 100644 --- a/src/util/virfile.h +++

[libvirt] [PATCH 07/46] src/qemu: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.h| 8 ++- src/qemu/qemu_alias.h| 13 ++--- src/qemu/qemu_block.h| 17 +++--- src/qemu/qemu_blockjob.h | 9 ++-- src/qemu/qemu_capabilities.h | 23

[libvirt] [PATCH 00/46] Finish moving header guards to #pragma once

My previous series ported a bunch of internal headers to use #pragma once as the header guard (per https://wiki.libvirt.org/page/BiteSizedTasks#Switch_headers_to_use_.23pragma_once). This series ports the rest of the internal headers. The public headers are unchanged, and the syntax check

[libvirt] [PATCH 01/46] src/locking: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/locking/domain_lock.h | 11 --- src/locking/lock_daemon.h | 9 +++-- src/locking/lock_daemon_config.h | 7 ++- src/locking/lock_daemon_dispatch.h | 7 ++- src/locking/lock_driver.h | 18 +++---

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > network.go | 80 ++ > network_port.go | 233 > network_port_compat.h | 67 > network_port_wrapper.go |

Re: [libvirt] ANNOUNCE: virt-manager 2.2.0 released

On 6/17/19 1:49 PM, Cole Robinson wrote: > I'm happy to announce the release of virt-manager 2.2.0! > > virt-manager is a desktop application for managing KVM, Xen, and LXC > virtualization via libvirt. > > The release can be downloaded from: > > http://virt-manager.org/download/ > A note to

[libvirt] [PATCH 42/46] src/vz: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/vz/vz_driver.h | 5 + src/vz/vz_sdk.h| 9 +++-- src/vz/vz_utils.h | 37 + 3 files changed, 21 insertions(+), 30 deletions(-) diff --git a/src/vz/vz_driver.h b/src/vz/vz_driver.h index

[libvirt] [PATCH 41/46] src/vmx: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/vmx/vmx.h | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/vmx/vmx.h b/src/vmx/vmx.h index 8c068b4cb2..18478ac0ae 100644 --- a/src/vmx/vmx.h +++ b/src/vmx/vmx.h @@ -19,14 +19,13 @@ * */ -#ifndef

[libvirt] [PATCH 25/46] util: error: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virerror.h | 41 +++-- src/util/virerrorpriv.h | 5 + 2 files changed, 20 insertions(+), 26 deletions(-) diff --git a/src/util/virerror.h b/src/util/virerror.h index 8f51510dc2..4cfb0c18dd 100644 ---

[libvirt] [PATCH 40/46] src/vmware: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/vmware/vmware_conf.h | 19 --- src/vmware/vmware_driver.h | 5 + 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/src/vmware/vmware_conf.h b/src/vmware/vmware_conf.h index 93b424ef2f..deeed22300 100644 ---

[libvirt] [PATCH 36/46] util: xml: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virxml.h | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/src/util/virxml.h b/src/util/virxml.h index 38031b62c5..6208977dd1 100644 --- a/src/util/virxml.h +++ b/src/util/virxml.h @@ -18,18 +18,17

[libvirt] [PATCH 35/46] util: netlink: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virnetlink.h | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1bc075a86f..6419a775e1 100644 --- a/src/util/virnetlink.h +++

[libvirt] [PATCH 26/46] util: virprobe.h: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virprobe.h | 63 + 1 file changed, 30 insertions(+), 33 deletions(-) diff --git a/src/util/virprobe.h b/src/util/virprobe.h index 5635e58252..80a5f48ec8 100644 --- a/src/util/virprobe.h +++

[libvirt] [PATCH 38/46] util: misc: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virarptable.h | 7 ++ src/util/viraudit.h | 15 +--- src/util/virauth.h | 8 +++--- src/util/virauthconfig.h | 9 +++ src/util/virautoclean.h | 17 ++--- src/util/virbitmap.h | 11

[libvirt] [PATCH 30/46] util: mac: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virmacaddr.h | 17 +++-- src/util/virmacmap.h | 5 + 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/util/virmacaddr.h b/src/util/virmacaddr.h index 55f9d61abe..55cfd12164 100644 --- a/src/util/virmacaddr.h +++

[libvirt] [PATCH 28/46] util: command: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/vircommand.h | 11 --- src/util/vircommandpriv.h | 7 ++- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/util/vircommand.h b/src/util/vircommand.h index c03da43f25..c9a8d3c41c 100644 --- a/src/util/vircommand.h

[libvirt] [PATCH 32/46] util: string: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virstring.h | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/util/virstring.h b/src/util/virstring.h index b2cd8ea53c..5e64ad1bb9 100644 --- a/src/util/virstring.h +++

[libvirt] [PATCH 33/46] util: socketaddr: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virsocketaddr.h | 45 +++- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/src/util/virsocketaddr.h b/src/util/virsocketaddr.h index 5230cddf64..b2ecb3c748 100644 --- a/src/util/virsocketaddr.h +++

[libvirt] [PATCH 45/46] tools: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- tools/nss/libvirt_nss.h | 27 - tools/virsh-completer.h | 6 +- tools/virsh-console.h| 11 ++-- tools/virsh-domain-monitor.h | 7 +-- tools/virsh-domain.h | 7 +-- tools/virsh-host.h

[libvirt] [PATCH 24/46] util: cgroup: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/vircgroup.h| 10 -- src/util/vircgroupbackend.h | 15 ++- src/util/vircgroupv1.h | 5 + src/util/vircgroupv2.h | 5 + 4 files changed, 12 insertions(+), 23 deletions(-) diff --git a/src/util/vircgroup.h

[libvirt] [PATCH 27/46] util: dbus: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virdbus.h | 22 ++ src/util/virdbuspriv.h | 11 --- 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/src/util/virdbus.h b/src/util/virdbus.h index c1e5de31ab..083c074d59 100644 --- a/src/util/virdbus.h

[libvirt] [PATCH 17/46] util: storage: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virstorageencryption.h | 17 +++-- src/util/virstoragefile.h| 31 ++- src/util/virstoragefilebackend.h | 9 +++-- 3 files changed, 24 insertions(+), 33 deletions(-) diff --git

[libvirt] [PATCH 15/46] util: alloc: use #pragma once

Signed-off-by: Jonathon Jongsma --- src/util/viralloc.h | 101 +--- 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index 92c71d9a1a..2b82096fde 100644 --- a/src/util/viralloc.h +++

[libvirt] [PATCH 22/46] util: host: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virhostcpu.h | 17 +++-- src/util/virhostcpupriv.h | 11 --- src/util/virhostdev.h | 19 --- src/util/virhostmem.h | 7 ++- 4 files changed, 21 insertions(+), 33 deletions(-) diff --git

[libvirt] [PATCH 19/46] util: arch.h: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virarch.h | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/src/util/virarch.h b/src/util/virarch.h index 638ca9f484..233b83f31b 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@

[libvirt] [PATCH 06/46] src/phyp: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/phyp/phyp_driver.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/phyp/phyp_driver.h b/src/phyp/phyp_driver.h index 52a5d2bd17..d7076e3697 100644 --- a/src/phyp/phyp_driver.h +++ b/src/phyp/phyp_driver.h @@ -19,9 +19,6 @@ *

[libvirt] [PATCH 21/46] util: firewall: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/util/virfirewall.h | 11 --- src/util/virfirewalld.h | 7 ++- src/util/virfirewalldpriv.h | 7 ++- src/util/virfirewallpriv.h | 7 ++- 4 files changed, 10 insertions(+), 22 deletions(-) diff --git a/src/util/virfirewall.h

[libvirt] [PATCH 05/46] src/openvz: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/openvz/openvz_conf.h | 21 + src/openvz/openvz_driver.h | 11 --- src/openvz/openvz_util.h | 5 + 3 files changed, 14 insertions(+), 23 deletions(-) diff --git a/src/openvz/openvz_conf.h b/src/openvz/openvz_conf.h

[libvirt] [PATCH 11/46] src/security: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/security/security_apparmor.h | 13 + src/security/security_dac.h | 7 ++- src/security/security_driver.h | 11 --- src/security/security_manager.h | 13 + src/security/security_nop.h | 7 ++-

[libvirt] [PATCH 04/46] src/nwfilter: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/nwfilter/nwfilter_dhcpsnoop.h | 6 ++ src/nwfilter/nwfilter_driver.h| 9 +++-- src/nwfilter/nwfilter_ebiptables_driver.h | 13 + src/nwfilter/nwfilter_gentech_driver.h| 11 ---

[libvirt] [PATCH 08/46] src/remote: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/remote/remote_daemon.h | 35 +--- src/remote/remote_daemon_config.h | 7 ++ src/remote/remote_daemon_dispatch.h | 11 - src/remote/remote_daemon_stream.h | 7 ++ src/remote/remote_driver.h |

[libvirt] [PATCH 10/46] src/secret: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/secret/secret_driver.h | 5 + src/secret/secret_util.h | 8 +++- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/secret/secret_driver.h b/src/secret/secret_driver.h index b7e46ee045..3dcf420792 100644 ---

[libvirt] [PATCH 16/46] util: atomic: use #pragma once

Signed-off-by: Jonathon Jongsma --- src/util/viratomic.h | 91 +--- 1 file changed, 44 insertions(+), 47 deletions(-) diff --git a/src/util/viratomic.h b/src/util/viratomic.h index 0b2b3df081..35800dafcd 100644 --- a/src/util/viratomic.h +++

[libvirt] [PATCH 03/46] src/network: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/network/bridge_driver.h | 15 ++- src/network/bridge_driver_platform.h | 15 ++- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h index

[libvirt] [PATCH 02/46] src/lxc: use #pragma once in headers

Signed-off-by: Jonathon Jongsma --- src/lxc/lxc_cgroup.h| 13 +--- src/lxc/lxc_conf.h | 47 +++-- src/lxc/lxc_container.h | 37 +++- src/lxc/lxc_domain.h| 13 +--- src/lxc/lxc_driver.h| 5 +

[libvirt] [PATCH] qemu: distinguish pr disk before qemuHotplugRemoveManagedPR

when a disk without PR perform attach or detach operation, need not call qemuHotplugRemoveManagedPR, otherwise, it will print err log about PR, let us fix it. Signed-off-by: Jie Wang --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[libvirt] [go PATCH] Add support for virNetworkPort object and APIs

Signed-off-by: Daniel P. Berrangé --- network.go | 80 ++ network_port.go | 233 network_port_compat.h | 67 network_port_wrapper.go | 197 + network_port_wrapper.h | 79

Re: [libvirt] [PATCH] test_driver: implement virDomainGetMemoryParameters

On Thu, Jun 13, 2019 at 04:06:59PM +0200, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8ef843b203..9e8236a5b6

Re: [libvirt] [PATCH] storage: escape ipv6 for ceph mon hosts to librados

Oops, I forgot about this patch. On Sun, Apr 28, 2019 at 01:25:05PM +0800, Yi Li wrote: From 4af765cb6ee87eb7a131901057a8b6d0e859ac63 Mon Sep 17 00:00:00 2001 From: Yi Li Date: Sun, 28 Apr 2019 10:29:53 +0800 Subject: [PATCH v2] storage: escape ipv6 for ceph mon hosts to librados Hosts for

Re: [libvirt] [PATCH v3 15/15] vircgroupmock: mock virCgroupV2DevicesAvailable

On Thu, Apr 25, 2019 at 09:44:32AM +0200, Pavel Hrdina wrote: We need to mock virCgroupV2DevicesAvailable() in order to remove any dependency on kernel as BPF devices might not be available. Signed-off-by: Pavel Hrdina --- src/util/vircgroupv2devices.h | 5 -

Re: [libvirt] [PATCH v3 14/15] vircgroup: workaround devices in hybrid mode

On Thu, Apr 25, 2019 at 09:44:31AM +0200, Pavel Hrdina wrote: So the issue here is that you can end up with configuration where you have cgroup v1 and v2 enabled at the same time and the devices controllers is enabled for cgroup v1. In cgroup v2 there is no devices controller, the device access

Re: [libvirt] [PATCH RFC 1/1] allow to specify additional config data

On Thu, 6 Jun 2019 10:15:52 -0600 Alex Williamson wrote: > On Thu, 6 Jun 2019 09:32:24 -0600 > Alex Williamson wrote: > > > On Thu, 6 Jun 2019 16:44:17 +0200 > > Cornelia Huck wrote: > > > > > Add a rough implementation for vfio-ap. > > > > > > Signed-off-by: Cornelia Huck > > > --- > >

Re: [libvirt] [PATCH v3 13/15] vircgroup: introduce virCgroupV2DenyAllDevices

On Thu, Apr 25, 2019 at 09:44:30AM +0200, Pavel Hrdina wrote: If we want to deny all devices we just need to replace any existing program with new program with empty map. Signed-off-by: Pavel Hrdina --- src/util/vircgroupv2.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by:

Re: [libvirt] [PATCH v3 12/15] vircgroup: introduce virCgroupV2AllowAllDevices

On Thu, Apr 25, 2019 at 09:44:29AM +0200, Pavel Hrdina wrote: If we want to allow all devices with all permissions we need to replace any existing program that has any rule configured, otherwise we just need to add new rule which will for example allow read access to all devices. Signed-off-by:

Re: [libvirt] [PATCH v2 1/2] docs: Move "Community" links from footer to homepage

On Tue, Jun 18, 2019 at 04:45:25PM +0200, Andrea Bolognani wrote: > On Tue, 2019-06-18 at 15:18 +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 18, 2019 at 03:33:33PM +0200, Andrea Bolognani wrote: > > > This replaces the existing Planet Virt Tools blog roll. > > > > > > Signed-off-by: Andrea

Re: [libvirt] [PATCH v2 1/2] docs: Move "Community" links from footer to homepage

On Tue, 2019-06-18 at 16:47 +0200, Peter Krempa wrote: > On Tue, Jun 18, 2019 at 15:18:53 +0100, Daniel Berrange wrote: > > I'm a nack on this change as it is significantly worse than > > what we have today. > > How about at least hosting the JS stuff from somewhere else on > libvirt.org than the

Re: [libvirt] [PATCH v3 11/15] vircgroup: introduce virCgroupV2DenyDevice

On Thu, Apr 25, 2019 at 09:44:28AM +0200, Pavel Hrdina wrote: In order to deny device we need to check if there is any entry in BPF map and we need to load the current value from map if there is already entry for that device. If both values are same we can remove that entry but if they are

Re: [libvirt] [PATCH v3 10/15] vircgroup: introduce virCgroupV2AllowDevice

On Thu, Apr 25, 2019 at 09:44:27AM +0200, Pavel Hrdina wrote: In order to allow device we need to create key and value which will be used to update BPF map. virBPFUpdateElem() can override existing entries in BPF map so we need to check if that entry exists in order to track number of entries

Re: [libvirt] [PATCH v3 09/15] vircgroup: introduce virCgroupV2DevicesGetKey

On Thu, Apr 25, 2019 at 09:44:26AM +0200, Pavel Hrdina wrote: Device rules are stored in BPF map that is a hash type, this function will create a key based on major and minor id of device. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/vircgroupv2devices.c | 8

Re: [libvirt] [PATCH v3 08/15] vircgroup: introduce virCgroupV2DeviceGetPerms

On Thu, Apr 25, 2019 at 09:44:25AM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/vircgroupv2devices.c | 34 ++ src/util/vircgroupv2devices.h | 6 ++ 3 files changed, 41 insertions(+) diff --git

Re: [libvirt] [PATCH v3 07/15] vircgroup: introduce virCgroupV2DevicesRemoveProg

On Thu, Apr 25, 2019 at 09:44:24AM +0200, Pavel Hrdina wrote: We need to close our FD that we have for BPF program and map in order to let kernel remove all resources once the cgroup is removed as well. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/vircgroupv2.c

Re: [libvirt] [PATCH v3 06/15] vircgroup: introduce virCgroupV2DevicesPrepareProg

On Thu, Apr 25, 2019 at 09:44:23AM +0200, Pavel Hrdina wrote: This function will be called for every virCgroup(Allow|Deny)* API in order to prepare BPF program for guest. Since libvirtd can be restarted at any point we will first try to detect existing progam, if there is none we will create a

Re: [libvirt] [PATCH v3 05/15] vircgroup: introduce virCgroupV2DevicesCreateProg

On Thu, Apr 25, 2019 at 09:44:22AM +0200, Pavel Hrdina wrote: This function creates new BPF program with new empty BPF map with the default size and attaches it to the guest cgroup. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/vircgroupv2devices.c | 53

Re: [libvirt] [PATCH 0/2] error: Allow better reporting of errors in some nested cases

On Tue, Jun 11, 2019 at 14:01:25 +0200, Peter Krempa wrote: > Peter Krempa (2): > util: error: Add API for prefixing last set error with a string > qemu: process: Report better error when virtlogd connection fails ping? signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH v3 04/15] vircgroup: introduce virCgroupV2DevicesDetectProg

On Thu, Apr 25, 2019 at 09:44:21AM +0200, Pavel Hrdina wrote: This function will be called if libvirtd was restarted while some domains were running. It will try to detect existing programs attached to the guest cgroup. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH v2 1/2] docs: Move "Community" links from footer to homepage

On Tue, Jun 18, 2019 at 15:18:53 +0100, Daniel Berrange wrote: > On Tue, Jun 18, 2019 at 03:33:33PM +0200, Andrea Bolognani wrote: > > This replaces the existing Planet Virt Tools blog roll. > > > > Signed-off-by: Andrea Bolognani > > --- > > docs/index.html.in | 19 +-- > >

Re: [libvirt] [PATCH v2 1/2] docs: Move "Community" links from footer to homepage

On Tue, 2019-06-18 at 15:18 +0100, Daniel P. Berrangé wrote: > On Tue, Jun 18, 2019 at 03:33:33PM +0200, Andrea Bolognani wrote: > > This replaces the existing Planet Virt Tools blog roll. > > > > Signed-off-by: Andrea Bolognani > > --- > > docs/index.html.in | 19 +-- > >

  1   2   >