Document that CPU model runnability guarantees won't apply to
unversioned CPU models anymore.
Signed-off-by: Eduardo Habkost
---
Cc: libvir-list@redhat.com
---
qemu-deprecated.texi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/qemu-deprecated.texi
Hello!
Two weeks passed and still this fix not applied. Is no one interested
fixing it?
Wrong mailing list? Anything?
Please, answer.
On 10.06.2019 13:45, Sergei Turchanov wrote:
This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
fdlist[i] erroneously was replaced
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index d3bc6e7bce..868dadd682 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3433,7 +3433,7 @@
Ilias Stamatis (2):
test_driver: use addr_offset for non-network infs too
test_driver: use virDomainNetDefPtr instead of virDomainNetDef *
src/test/test_driver.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
--
2.22.0
--
libvir-list mailing list
libvir-list@redhat.com
The addr_offset can be used even for the hard-coded addresses in an
attempt to always return unique ips.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index
On Mon, Jun 24, 2019 at 9:10 PM Ilias Stamatis
wrote:
>
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 141 +
> 1 file changed, 141 insertions(+)
>
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 141 +
1 file changed, 141 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4b1f2724a0..180940f859 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
The function modifies the context but did not care to restore it back.
If a was used on a disk, the would not be
parsed.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 1 +
tests/qemustatusxml2xmldata/modern-out.xml | 12 +++-
2 files changed, 12
Upcomming patch will add an example which changes output-only.
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/modern-out.xml | 471 -
1 file changed, 470 insertions(+), 1 deletion(-)
mode change 12 => 100644 tests/qemustatusxml2xmldata/modern-out.xml
diff
Adding a seclabel breaks the output by improperly handling the XPath
context and thus not being able to parse the .
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/modern-in.xml | 3 +++
tests/qemustatusxml2xmldata/modern-out.xml | 15 ---
2 files changed, 7
The parser for the seclabel would mess up context leaving disk source
private data unparsed.
Peter Krempa (3):
tests: qemustatusxml2xml: Split out the output file for 'modern' test
tests: qemustatusxml2xml: Add a seclabel for a disk with privateData
conf: domain: Restore XPath context after
On Fri, 2019-06-21 at 12:58 -0300, Daniel Henrique Barboza wrote:
> Trivial change. Adding the name of the device that has an
> unknown PCI header type in that function helps when debugging
> PCI code.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
> src/util/virpci.c | 3 ++-
> 1 file
The 'blockdev-create' starts a job which creates a storage volume using
the given protocol or formats an existing (added) volume with one of the
supported storage formats.
This patch adds the monitor interaction bits.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 30
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
src/qemu/qemu_monitor_json.c | 22 ++
src/qemu/qemu_monitor_json.h |
This new event is a superset of the BLOCK_JOB* events and also covers
jobs which don't bind to a VM disk.
In this patch the monitor part is implemented.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 +
src/qemu/qemu_monitor.h | 9 +
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 23 +
src/qemu/qemu_monitor.h | 49 +++
src/qemu/qemu_monitor_json.c | 79 +
src/qemu/qemu_monitor_json.h | 6 ++
This belongs to the new job management API which can manage also
non-block based jobs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
src/qemu/qemu_monitor_json.c | 22 ++
src/qemu/qemu_monitor_json.h |
This belongs to the new job management API for generic jobs.
The dismiss command is meant to remove a concluded job after we were
able to get the final status.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 4
Allow using the delayed dismiss of the job so that we can reap the state
even if libvirtd was not running when qemu emitted the job completion
event.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c| 2 +-
src/qemu/qemu_monitor.c | 9 +
src/qemu/qemu_monitor.h |
Allow using the node name to specify the base and top of the 'commit'
operation, allow specifying explicit job name and add support for
delayed dismiss of the job so that we can reap the state even if
libvirtd was not running when qemu emitted the job completion event.
Signed-off-by: Peter Krempa
This contains set of monitor adjustments needed for supporting the block
job APIs with -blockdev.
Note that the last patch does not contain tests as there is a extensive
testsuite added with the actual formatter of the JSON properties which
are used with that API which will be posted later.
I
Allow using the node name to specify the base of the 'stream' operation,
allow specifying explicit job name and add support for delayed dismiss
of the job so that we can reap the state even if libvirtd was not
running when qemu emitted the job completion event.
Signed-off-by: Peter Krempa
---
Use the new helpers for removing the backing chain in case when
-blockdev is used. For -drive this function has a local implementation.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
As this conversion removes the last use of qemuHotplugDiskSource*
functions we can remove all of them now.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 188 ++--
1 file changed, 7 insertions(+), 181 deletions(-)
diff --git
When changing media using blockdev-add we need to remove the leftovers
if we didn't succeed plugging in the full chain or closing the tray.
Otherwise the data structures will be freed and thus the backing chain
members will never be unplugged.
Signed-off-by: Peter Krempa
---
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1ae8a00352..7a7497686a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@
These are meant to replace the ad-hoc helpers qemuHotplugDiskSourceAtttach...
and the open-coded version in qemu_command.c for use in command line
generation.
The functions for preparing for attach of chains unfortunately need to
be in qemu_command.c as they use function defined by that file and
We use only one copy-on-read filter per disk, so we should handle it
separately from the chain.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 46 ++---
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c
Move around few of the helpers which deal with disk addition and
removal and fix a potential bug in the blockdev media change routine.
The refactors will allow simplify a corner case of using blockdev such
as if the disk frontend is unplugged the backends can be unplugged only
after blockjobs
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index acfec8a1bb..1ae8a00352 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2560,8
Replace the open-coded local implementation with
qemuBuildStorageSourceChainAttachPrepare(Drive|Blockdev).
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 34 +++---
1 file changed, 7 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_command.c
Replace the use of qemuHotplugDiskSourceAttach* helpers with
qemuBuildStorageSourceChainAttachPrepare(Blockdev|Drive).
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c
Move it to qemu_block.c and call it qemuBlockStorageSourceDetachPrepare.
It will be reused in other parts as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 57 +
src/qemu/qemu_block.h | 4 +++
src/qemu/qemu_hotplug.c | 63
Igor Mammedov writes:
> On Mon, 24 Jun 2019 10:17:33 +0200
> Markus Armbruster wrote:
>
>> Igor Mammedov writes:
>>
>> > Fallback might affect guest or worse whole host performance
>> > or functionality if backing file were used to share guest RAM
>> > with another process.
>> >
>> > Patch
On Mon, 24 Jun 2019 10:36:55 +0100
Daniel P. Berrangé wrote:
> On Mon, Jun 24, 2019 at 10:17:33AM +0200, Markus Armbruster wrote:
> > Igor Mammedov writes:
> >
> > > Fallback might affect guest or worse whole host performance
> > > or functionality if backing file were used to share guest
On Mon, 24 Jun 2019 10:17:33 +0200
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > Fallback might affect guest or worse whole host performance
> > or functionality if backing file were used to share guest RAM
> > with another process.
> >
> > Patch deprecates fallback so that we could
On Mon, Jun 24, 2019 at 10:17:33AM +0200, Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > Fallback might affect guest or worse whole host performance
> > or functionality if backing file were used to share guest RAM
> > with another process.
> >
> > Patch deprecates fallback so that we
On Fri, Jun 21, 2019 at 02:18:23PM -0500, Eric Blake wrote:
> In libvirt_private.syms, we have a policy of keeping blocks of symbols
> sorted by name - in fact, we enforce it during 'make check' with our
> check-symsorting rule calling out to a perl script. But
> libvirt_public.syms has been more
Igor Mammedov writes:
> Fallback might affect guest or worse whole host performance
> or functionality if backing file were used to share guest RAM
> with another process.
>
> Patch deprecates fallback so that we could remove it in future
> and ensure that QEMU will provide expected behavior and
39 matches
Mail list logo
