Igor Mammedov writes:
> Fallback might affect guest or worse whole host performance
> or functionality if backing file were used to share guest RAM
> with another process.
>
> Patch deprecates fallback so that we could remove it in future
> and ensure that QEMU will provide expected behavior and
Hello!
On 25.06.2019 18:41, Ján Tomko wrote:
Thanks for catching this!
However to be able to catch this, per our rules:
https://libvirt.org/governance.html#contributors
we need you to provide a sign-off to certify you complied with the
Developer Certificate of Origin:
This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
fdlist[i] erroneously was replaced by fdlist[1] which caused
lxcOpenNamespace to return a list with identical elements.
Signed-off-by: Sergei Turchanov
---
libvirt-lxc-override.c | 2 +-
1 file changed, 1
Hi,
Based on the discussions we've had, I've rewritten the bulk of
mdevctl. I think it largely does everything we want now, modulo
devices that will need some sort of 1:N values per key for
configuration in the config file versus the 1:1 key:value setup we
currently have (so don't consider the
Always return / and /boot as the mount points imitating a default
Fedora installation. Use the first disk found, otherwise if no disk
device of type VIR_DOMAIN_DISK_DEVICE_DISK is present, return 0 mount
points.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 66
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4b1f2724a0..1b1ff3003e 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -438,6 +438,11 @@ static const char
Ilias Stamatis (2):
test_driver: add a disk device in the default config
test_driver: implement virDomainGetFSInfo
src/test/test_driver.c | 71 ++
1 file changed, 71 insertions(+)
--
2.22.0
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Jun 14, 2019 at 10:04:36AM +0200, Andrea Bolognani wrote:
Right now *-headless and *-graphics tests are using different
quoting styles, which results in the diff between them being
basically useless, whereas we would like it to be possible to
compare these files directly and easily spot
On Tue, Jun 25, 2019 at 01:18:01PM -0500, Eric Blake wrote:
> On 6/25/19 11:16 AM, Igor Mammedov wrote:
> > Fallback might affect guest or worse whole host performance
> > or functionality if backing file were used to share guest RAM
> > with another process.
> >
> > Patch deprecates fallback so
On Fri, Jun 14, 2019 at 10:04:39AM +0200, Andrea Bolognani wrote:
We didn't do this earlier because the DO_TEST_CAPS_ARCH_LATEST()
macro was limited to qemuxml2argv until recently.
Signed-off-by: Andrea Bolognani
---
.../aarch64-virt-graphics.aarch64-latest.xml | 115 +
On Fri, Jun 14, 2019 at 10:04:37AM +0200, Andrea Bolognani wrote:
Use the latest virt-manager to regenerate the files.
The command line is once again along the lines of
$ virt-install \
--name guest --os-variant fedora29 \
--vcpus 4 --memory 4096 --disk size=5 \
--graphics (none|vnc)
On Fri, Jun 14, 2019 at 10:04:38AM +0200, Andrea Bolognani wrote:
Support for this has only relatively recently been added to
virt-manager.
Signed-off-by: Andrea Bolognani
---
.../riscv64-virt-graphics.riscv64-latest.args | 59 +++
.../riscv64-virt-graphics.xml |
On 6/25/19 11:16 AM, Igor Mammedov wrote:
> Fallback might affect guest or worse whole host performance
> or functionality if backing file were used to share guest RAM
> with another process.
>
> Patch deprecates fallback so that we could remove it in future
> and ensure that QEMU will provide
On Mon, Jun 24, 2019 at 05:38:55PM +0200, Peter Krempa wrote:
When changing media using blockdev-add we need to remove the leftovers
if we didn't succeed plugging in the full chain or closing the tray.
Otherwise the data structures will be freed and thus the backing chain
members will never be
[although I'm really not happy with the overprefixing]
On Mon, Jun 24, 2019 at 05:38:54PM +0200, Peter Krempa wrote:
As this conversion removes the last use of qemuHotplugDiskSource*
functions we can remove all of them now.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 188
On Mon, Jun 24, 2019 at 05:38:54PM +0200, Peter Krempa wrote:
As this conversion removes the last use of qemuHotplugDiskSource*
functions we can remove all of them now.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 188 ++--
1 file changed, 7
On Mon, Jun 24, 2019 at 05:38:53PM +0200, Peter Krempa wrote:
Use the new helpers for removing the backing chain in case when
-blockdev is used. For -drive this function has a local implementation.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 19 +--
1 file changed,
On Mon, Jun 24, 2019 at 05:38:49PM +0200, Peter Krempa wrote:
Replace the open-coded local implementation with
qemuBuildStorageSourceChainAttachPrepare(Drive|Blockdev).
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 34 +++---
1 file changed, 7
On Mon, Jun 24, 2019 at 05:38:52PM +0200, Peter Krempa wrote:
Replace the use of qemuHotplugDiskSourceAttach* helpers with
qemuBuildStorageSourceChainAttachPrepare(Blockdev|Drive).
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 19 +++
1 file changed, 11
On Mon, Jun 24, 2019 at 05:38:51PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing
On Mon, Jun 24, 2019 at 05:38:50PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
On Mon, Jun 24, 2019 at 05:38:48PM +0200, Peter Krempa wrote:
These are meant to replace the ad-hoc helpers qemuHotplugDiskSourceAtttach...
s/ttt/tt/
and the open-coded version in qemu_command.c for use in command line
generation.
The functions for preparing for attach of chains
On Tue, Jun 25, 2019 at 12:16:29PM -0400, Igor Mammedov wrote:
> Fallback might affect guest or worse whole host performance
> or functionality if backing file were used to share guest RAM
> with another process.
>
> Patch deprecates fallback so that we could remove it in future
> and ensure that
Fallback might affect guest or worse whole host performance
or functionality if backing file were used to share guest RAM
with another process.
Patch deprecates fallback so that we could remove it in future
and ensure that QEMU will provide expected behavior and fail if
it can't use user provided
Hello everyone,
We've been using libvirt version 0.10.2 for a long time (on CentOS 6 OS)
and now we have started creating new KVM cluster all based on CentOS 7
OS and libvirt version 4.5.0 (that came with CentOS repo).
TLDR Version:
- When we try to migrate using "virsh migrate test --live
On Tue, Jun 25, 2019 at 13:44:36 +0200, Ján Tomko wrote:
> Commit a7fb2258 added sanitization of storage pool target paths,
> however source dir paths were left unsanitized.
>
> A netfs pool with:
>
>
>
>
> will not be correctly detected as mounted by
>
s/dude/duce/ in the subject
On Fri, Jun 21, 2019 at 08:33:51AM +0200, Peter Krempa wrote:
Peter Krempa (3):
error: Add VIR_ERR_DEPRECATED error code
qemu: Use VIR_ERR_DEPRECATED in QemuAttach and DomainXMLFromNative
stubs
news: Mention VIR_ERR_DEPRECATED in improvements
docs/news.xml
On Fri, Jun 21, 2019 at 08:33:51 +0200, Peter Krempa wrote:
> Peter Krempa (3):
> error: Add VIR_ERR_DEPRECATED error code
> qemu: Use VIR_ERR_DEPRECATED in QemuAttach and DomainXMLFromNative
> stubs
> news: Mention VIR_ERR_DEPRECATED in improvements
>
> docs/news.xml |
Our code would skip adding the default type in this cases, but since we
know that the only reasonable option here is 'fat' we can add it while
starting the VM.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 12 +---
virStorageSourceGetActualType would return VIR_STORAGE_TYPE_NONE in case
when a virStorageSource of (top level) type VIR_STORAGE_TYPE_VOLUME was
not prepared to use by the vm by calling
virDomainDiskTranslateSourcePool.
Fix this issue by returning VIR_STORAGE_TYPE_VOLUME in case when the
volume
qemuBuildDriveSourceStr omits the disk format string when we are
emulating a 'fat' filesystem froma directory. The logic should decide
based on the 'actualType' as a disk type=pool may be converted to a
directory.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1
The storage volume may in fact convert into a directory when starting
the VM so that it may be actually possible to use it.
This is a regression caused by c9b27af32d5 as moving the check to
validation time without adjustment causes problems as the volumes are
not translated yet.
Signed-off-by:
Peter Krempa (4):
util: storage: Fix virStorageSourceGetActualType if volume was not
translated
qemu: command: Use 'actualType' when deciding whether to use disk
format
qemu: domain: Allow 'VIR_STORAGE_TYPE_VOLUME' disks with 'fat' format
qemu: Supply correct default type for 'dir'
On Mon, Jun 24, 2019 at 05:38:47PM +0200, Peter Krempa wrote:
We use only one copy-on-read filter per disk, so we should handle it
separately from the chain.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 46 ++---
1 file changed, 25 insertions(+),
On Mon, Jun 24, 2019 at 05:38:46PM +0200, Peter Krempa wrote:
Move it to qemu_block.c and call it qemuBlockStorageSourceDetachPrepare.
It will be reused in other parts as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 57 +
On Tue, Jun 25, 2019 at 15:31:40 +0200, Peter Krempa wrote:
> Peter Krempa (3):
> util: storage: Fix virStorageSourceGetActualType if volume was not
> translated
> qemu: domain: Allow 'VIR_STORAGE_TYPE_VOLUME' disks with 'fat' format
> qemu: Supply correct default type for 'dir' based
>
Our code would skip adding the default type in this cases, but since we
know that the only reasonable option here is 'fat' we can add it while
starting the VM.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 12 +---
The storage volume may in fact convert into a directory when starting
the VM so that it may be actually possible to use it.
This is a regression caused by c9b27af32d5 as moving the check to
validation time without adjustment causes problems as the volumes are
not translated yet.
Signed-off-by:
virStorageSourceGetActualType would return VIR_STORAGE_TYPE_NONE in case
when a virStorageSource of (top level) type VIR_STORAGE_TYPE_VOLUME was
not prepared to use by the vm by calling
virDomainDiskTranslateSourcePool.
Fix this issue by returning VIR_STORAGE_TYPE_VOLUME in case when the
volume
Peter Krempa (3):
util: storage: Fix virStorageSourceGetActualType if volume was not
translated
qemu: domain: Allow 'VIR_STORAGE_TYPE_VOLUME' disks with 'fat' format
qemu: Supply correct default type for 'dir' based
VIR_STORAGE_TYPE_VOLUME
src/qemu/qemu_domain.c
Ideally if we want to push the next release on Monday, we should enter freeze
tomorrow, then push Rc2 on Friday and then if everything goes well we can
push 5.5.0 final next Monday.
Hopefully that plan works for everyone,
Daniel
--
Daniel Veillard | Red Hat Developers Tools
Ping
On 2019/6/18 21:28, Jie Wang wrote:
when a disk without PR perform attach or detach operation,
need not call qemuHotplugRemoveManagedPR, otherwise, it will
print err log about PR, let us fix it.
Signed-off-by: Jie Wang
---
src/qemu/qemu_hotplug.c | 7 +--
1 file changed, 5
Shouldn't the $SUBJECT be "add missing comma" not "omit comma",
since you are adding a missing comma here.
On Tue, Jun 25, 2019 at 07:41:25PM +0800, Yi Li wrote:
> Silly mistakes omit the comma for multiple ipaddr
> Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0
>
> Signed-off-by: Yi Li
> ---
s/omit/fix omitted/
On Tue, Jun 25, 2019 at 07:41:25PM +0800, Yi Li wrote:
Silly mistakes omit the comma for multiple ipaddr
Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0
Signed-off-by: Yi Li
---
src/storage/storage_backend_rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Commit a7fb2258 added sanitization of storage pool target paths,
however source dir paths were left unsanitized.
A netfs pool with:
will not be correctly detected as mounted by
virStorageBackendFileSystemIsMounted, because it shows up in the
mount list without the trailing slash.
Silly mistakes omit the comma for multiple ipaddr
Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0
Signed-off-by: Yi Li
---
src/storage/storage_backend_rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_backend_rbd.c
There are some paths (e.g. /dev/vfio/vfio or /dev/mapper/control)
which are defined in qemu_domain.c and then in qemu_cgroup.c
again. This is suboptimal. Lets move paths into qemu_domain.h and
drop duplicate definitions.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_cgroup.c | 13
On Mon, 24 Jun 2019 16:01:49 +0200
Markus Armbruster wrote:
> Igor Mammedov writes:
>
> > On Mon, 24 Jun 2019 10:17:33 +0200
> > Markus Armbruster wrote:
> >
> >> Igor Mammedov writes:
> >>
> >> > Fallback might affect guest or worse whole host performance
> >> > or functionality if
This affects only cgroups v2 where enabled controllers are not based on
available mount points but on the list provided in cgroup.controllers
file. However, moving it will fill in placement as well, so it needs
to be freed together with mount point if we don't need that controller.
Before this
Pavel Hrdina (7):
util: vircgroup: pass parent cgroup into virCgroupDetectControllersCB
util: vircgroup: improve controller detection
util: vircgroupv2: use any controller to create thread directory
util: vircgroupv2: enable CPU controller only if it's available
util: vircgroupv2:
When detecting available controllers on host we can be limited by list
of controllers from qemu.conf file.
Signed-off-by: Pavel Hrdina
---
Notes:
Introduced in v3
src/util/vircgroupv2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/vircgroupv2.c
The assumption that CPU controller would be always enabled is wrong, we
should use any available controller to create a new sub-cgroup.
Signed-off-by: Pavel Hrdina
Reviewed-by: Ján Tomko
---
src/util/vircgroupv2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In order to skip controllers that we are not able to activate we need
to return different return value so the caller can decide what to do.
Signed-off-by: Pavel Hrdina
---
Notes:
Introduced in v2
src/util/vircgroupv2.c | 19 +--
1 file changed, 17 insertions(+), 2
It might happen that we are not able to enable CPU controller so we
can enable it for thread sub-cgroups only if it's available in parent
cgroup.
Signed-off-by: Pavel Hrdina
Reviewed-by: Ján Tomko
---
src/util/vircgroupv2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Currently CPU controller cannot be enabled if there is any real-time
task running and is assigned to non-root cgroup which is the case on
several distributions with graphical environment.
Instead of erroring out treat it as the controller is not available.
Signed-off-by: Pavel Hrdina
---
In cgroups v2 we don't have to detect available controllers every single
time if we are creating a new cgroup based on parent cgroup.
Signed-off-by: Pavel Hrdina
Reviewed-by: Ján Tomko
---
src/util/vircgroup.c| 2 +-
src/util/vircgroupbackend.h | 3 ++-
src/util/vircgroupv1.c |
On Fri, 2019-06-14 at 10:04 +0200, Andrea Bolognani wrote:
> *** BLURBY MCBLURBFACE ***
>
> Andrea Bolognani (4):
> tests: Normalize quotes for *-graphics
> tests: Update *-headless and *-graphics
> tests: Add riscv64-virt-graphics
> tests: Enable *-headless and *-graphics in qemuxml2xml
On Fri, Jun 21, 2019 at 03:32:40PM +0200, Pavel Hrdina wrote:
> Pavel Hrdina (6):
> util: vircgroup: pass parent cgroup into virCgroupDetectControllersCB
> util: vircgroup: improve controller detection
> util: vircgroupv2: use any controller to create thread directory
> util: vircgroupv2:
On Tue, Jun 25, 2019 at 10:50:56AM +0200, Peter Krempa wrote:
On Tue, Jun 25, 2019 at 10:46:28 +0200, Ján Tomko wrote:
On Mon, Jun 24, 2019 at 06:27:12PM +0200, Peter Krempa wrote:
> Adding a seclabel breaks the output by improperly handling the XPath
> context and thus not being able to parse
On Tue, Jun 25, 2019 at 10:46:28 +0200, Ján Tomko wrote:
> On Mon, Jun 24, 2019 at 06:27:12PM +0200, Peter Krempa wrote:
> > Adding a seclabel breaks the output by improperly handling the XPath
> > context and thus not being able to parse the .
> >
>
> However nice it is to see the effects of
On Mon, Jun 24, 2019 at 06:27:13PM +0200, Peter Krempa wrote:
The function modifies the context but did not care to restore it back.
If a was used on a disk, the would not be
parsed.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 1 +
On Mon, Jun 24, 2019 at 06:27:12PM +0200, Peter Krempa wrote:
Adding a seclabel breaks the output by improperly handling the XPath
context and thus not being able to parse the .
However nice it is to see the effects of the fix during review, I think
we should not be adding broken test data
On Mon, Jun 24, 2019 at 06:27:11PM +0200, Peter Krempa wrote:
Upcomming patch will add an example which changes output-only.
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/modern-out.xml | 471 -
1 file changed, 470 insertions(+), 1 deletion(-)
mode change
On Tue, Jun 25, 2019 at 10:29:52AM +1000, Sergei Turchanov wrote:
Hello!
Hi!
Two weeks passed and still this fix not applied.
Oops.
Is no one interested
fixing it?
Wrong mailing list? Anything?
Please, answer.
On 10.06.2019 13:45, Sergei Turchanov wrote:
This fixes regression caused
64 matches
Mail list logo
