>> --->> Patch v1:>>
>> https://www.redhat.com/archives/libvir-list/2019-June/msg01248.html>> >>
>> Changes in v2:>> - Adding a "stype" field for the --diskspec string which
>> will indicate a "file" or "block" storage type.>> I'm a little late for
>> bike-shedding, but could we have supported
On Tue, 9 Jul 2019 14:26:08 +0200
Pavel Hrdina wrote:
> [...]
>
> In addition if you would like to have only one VM as root:root you
> should keep the default config as nobody:kvm and use the root:root for
> that specific VM.
>
> Pavel
Let me answer this part in another post.
Generally I agree
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Describe the encryption element in the TPM's domain XML.
>
> Signed-off-by: Stefan Berger
> ---
> docs/formatdomain.html.in | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdo
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the Secret XML documentation with vtpm usage type.
>
> Signed-off-by: Stefan Berger
> ---
> docs/formatsecret.html.in | 61 +--
> 1 file changed, 59 insertions(+), 2 deletions(-)
>
> diff --git a/d
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Allow vTPM state encryption when swtpm_setup and swtpm support
> passing a passphrase using a file descriptor.
>
> This patch enables the encryption of the vTPM state only. It does
> not encrypt the state during migration, so the destination
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Run 'swtpm socket --print-capabilities' and
> 'swtpm_setup --print-capabilities' to get the JSON object of the
> features the programs are supporting and parse them into a bitmap.
>
> Signed-off-by: Stefan Berger
> ---
> src/conf/Makefile.i
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c and introduce
> a few functions to query the executables needed for virCommands.
>
> Signed-off-by: Stefan Berger
Couldn't there be a TOCTOU issue?
Anyway, for the move:
Reviewed-b
Hi
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Check whether previously found executables were updated and if
> so look for them again. This helps to use updated features of
> swtpm and its tools upon updating them.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Move virtpm.c from utils dir to its own tpm dir. This change
> is mostly driven by the later introduction of virtpm_conf.c where
> the define function like XYZTypeFromString() that we cannot
> include from utils dir.
>
> Signed-off-by: Stefan
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Refactor virTPMEmulatorInit to use a loop with parameters. This allows
> for easier extension later on.
>
> Signed-off-by: Stefan Berger
for the refactoring,
Reviewed-by: Marc-André Lureau
> ---
> src/tpm/virtpm.c | 80 +
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> The QEMU command line does not change when TPM state is encrypted
> compared to when it is plain.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> .../tpm-emulator-tpm2-enc.x86_64-latest.args | 35 +++
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the TPM XML schema with support for an encryption node.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> docs/schemas/domaincommon.rng | 30 ++
> 1 file changed, 30 insertions(+)
On Tue, Jul 9, 2019 at 9:25 PM Stefan Berger wrote:
>
> Add a test case for the TPM XML encryption parser and formatter.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> .../tpm-emulator-tpm2-enc.xml | 34 +
> .../tpm-emulator-tpm2-enc.x
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Add VIR_STORAGE_ENCRYPTION_FORMAT_VTPM with string 'vtpm' for
> support of encrypting vTPM storage.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_block.c | 1 +
> src/util/virstorageencr
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Add an already existing test case tpm-emulator-tpm2 to qemuxml2xmltest.c
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> tests/qemuxml2xmltest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the TPM device XML parser and XML generator with emulator
> state encryption support.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> src/conf/domain_conf.c | 40 +++-
>
Hi
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Add support for usage type vTPM to secret.
>
> Signed-off-by: Stefan Berger
> ---
> include/libvirt/libvirt-secret.h | 1 +
> src/conf/secret_conf.c | 13 +
> src/util/virsecret.c | 2 +-
> 3 files ch
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the schema for the Secret to support the vTPM usage type
> and add a test case for parsing the Secret with usage type vTPM.
>
> Signed-off-by: Stefan Berger
> ---
> docs/schemas/secret.rng | 10 ++
> tests/secret
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 097720bb0a..b491247e49 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3561,6 +
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 8c25c679a5..097720bb0a 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@
---
src/test/test_driver.c | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 49d7030d21..af3503c523 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -384,6 +384,35 @@ test
On success update the domain-private data. Consider / and /boot to be
the only mountpoints avaiable in order to be consistent with the other
FS-related calls.
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 58 ++
1 file changed, 58 insertions(+
Ilias Stamatis (4):
test_driver: introduce domain-private data
test_driver: implement virDomainFSFreeze
test_driver: implement virDomainFSThaw
test_driver: implement virDomainFSTrim
src/test/test_driver.c | 191 -
1 file changed, 190 insertions(+),
The QEMU command line does not change when TPM state is encrypted
compared to when it is plain.
Signed-off-by: Stefan Berger
---
.../tpm-emulator-tpm2-enc.x86_64-latest.args | 35 +++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 36 insertions(+)
create
On 7/8/19 8:12 AM, Daniel P. Berrangé wrote:
I should have read more libvirt mail yesterday before responding to the other
thread. Sorry for missing this message.
> The virtlogd config is set to rollover logs every 2 MB.
>
> Normally a logrotate config file is also installed to handle cases wh
This patch now passes the passphrase as a migration key to swtpm.
This now encrypts the state of the TPM while a VM is migrated between
hosts or when suspended into a file. Since the migration key secret
is the same as the state encryption secret, this now requires that
the migration destination ho
Move virtpm.c from utils dir to its own tpm dir. This change
is mostly driven by the later introduction of virtpm_conf.c where
the define function like XYZTypeFromString() that we cannot
include from utils dir.
Signed-off-by: Stefan Berger
---
po/POTFILES | 2 +-
src/Makefile.a
Extend the Secret XML documentation with vtpm usage type.
Signed-off-by: Stefan Berger
---
docs/formatsecret.html.in | 61 +--
1 file changed, 59 insertions(+), 2 deletions(-)
diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
index defbe71731
Check whether previously found executables were updated and if
so look for them again. This helps to use updated features of
swtpm and its tools upon updating them.
Signed-off-by: Stefan Berger
---
src/qemu/qemu_tpm.c | 1 +
src/tpm/virtpm.c| 34 ++
2 files c
Extend the schema for the Secret to support the vTPM usage type
and add a test case for parsing the Secret with usage type vTPM.
Signed-off-by: Stefan Berger
---
docs/schemas/secret.rng | 10 ++
tests/secretxml2xmlin/usage-vtpm.xml | 7 +++
tests/secretxml2xmltest.c
Add an already existing test case tpm-emulator-tpm2 to qemuxml2xmltest.c
Signed-off-by: Stefan Berger
---
tests/qemuxml2xmltest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index a64b17ac28..a29958ae29 100644
--- a/tests/qemuxml2xmltest.
Run 'swtpm socket --print-capabilities' and
'swtpm_setup --print-capabilities' to get the JSON object of the
features the programs are supporting and parse them into a bitmap.
Signed-off-by: Stefan Berger
---
src/conf/Makefile.inc.am | 6 ++
src/conf/virtpm_conf.c | 36
src/con
Add a test case for the TPM XML encryption parser and formatter.
Signed-off-by: Stefan Berger
---
.../tpm-emulator-tpm2-enc.xml | 34 +
.../tpm-emulator-tpm2-enc.xml | 38 +++
tests/qemuxml2xmltest.c | 1 +
3
Describe the encryption element in the TPM's domain XML.
Signed-off-by: Stefan Berger
---
docs/formatdomain.html.in | 16
1 file changed, 16 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index a7a6ec32a5..b53ea7d6f4 100644
--- a/docs/formatdom
Add support for usage type vTPM to secret.
Signed-off-by: Stefan Berger
---
include/libvirt/libvirt-secret.h | 1 +
src/conf/secret_conf.c | 13 +
src/util/virsecret.c | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/libvirt/libvi
Extend the TPM XML schema with support for an encryption node.
Signed-off-by: Stefan Berger
---
docs/schemas/domaincommon.rng | 30 ++
1 file changed, 30 insertions(+)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 31db599ab9..4a4f4f
Allow vTPM state encryption when swtpm_setup and swtpm support
passing a passphrase using a file descriptor.
This patch enables the encryption of the vTPM state only. It does
not encrypt the state during migration, so the destination secret
does not need to have the same password at this point.
S
Refactor virTPMEmulatorInit to use a loop with parameters. This allows
for easier extension later on.
Signed-off-by: Stefan Berger
---
src/tpm/virtpm.c | 80 ++--
1 file changed, 37 insertions(+), 43 deletions(-)
diff --git a/src/tpm/virtpm.c b/src/tp
This series of patches addresses the RFE in BZ 172830:
https://bugzilla.redhat.com/show_bug.cgi?id=1728030
This series of patches adds support for vTPM state encryption by passing
the read-end of a pipe's file descriptor to 'swtpm_setup' and 'swtpm'
where they can read a passphrase from and derive
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/openvz/openvz_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/openvz/openvz_driver.c b/src/openv
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/libxl/libxl_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libx
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/vmware/vmware_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/vmware/vmware_driver.c b/src/vmwar
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/lxc/lxc_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
Since v1:
- use syntax-check rather than dynamic runtime check for API mismatch
- fix more stragglers with mismatched API, found by the syntax-check
- fix a bug in bhyve no-op flag handling
- expand no-op flag handling to other affected drivers
Eric Blake (9):
vbox: Add various vir*Flags API
x
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/bhyve/bhyve_driver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bh
Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op,
and in line with the recent doc tweak in commit c049f022.
Signed-off-by: Eric Blake
---
src/xenapi/xenapi_driver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xena
Even though we don't accept any flags, it is unfriendly to callers
that use the modern API to have to fall back to the flag-free API.
Signed-off-by: Eric Blake
---
src/xenapi/xenapi_driver.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/src/xenapi/xe
As shown in recent patches, several drivers provided only an older
counterpart of an API, making it harder to uniformly use the newer
preferred API form. We can prevent future instances of this by
enhancing 'make syntax-check' to flag any time a modern API is
forgotten when an older API is present.
Even though we don't accept any flags, it is unfriendly to callers
that use the modern API to have to fall back to the flag-free API.
Signed-off-by: Eric Blake
---
src/vbox/vbox_common.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/vbox/vbox_c
Move qemuTPMEmulatorInit to virTPMEmulatorInit in virtpm.c and introduce
a few functions to query the executables needed for virCommands.
Signed-off-by: Stefan Berger
---
src/libvirt_private.syms | 4 ++
src/qemu/qemu_tpm.c | 83
src/tpm/virtpm.c
Add VIR_STORAGE_ENCRYPTION_FORMAT_VTPM with string 'vtpm' for
support of encrypting vTPM storage.
Signed-off-by: Stefan Berger
---
src/qemu/qemu_block.c | 1 +
src/util/virstorageencryption.c | 2 +-
src/util/virstorageencryption.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
Extend the TPM device XML parser and XML generator with emulator
state encryption support.
Signed-off-by: Stefan Berger
---
src/conf/domain_conf.c | 40 +++-
src/conf/domain_conf.h | 1 +
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/src/conf
Since swtpm does not support getting started once it was created
with encrypted enabled, we don't allow encryption to be removed.
Similarly, we do not allow encrypted to be added once swtpm has
run.
Signed-off-by: Stefan Berger
---
src/conf/domain_conf.c| 56 +
On 7/8/19 10:37 PM, Eric Blake wrote:
> We can ignore flags rather than rejecting them as unknown since a
> correct implementation of those flags is a no-op given that bhyve
> lacks managed save or snapshots.
>
> Signed-off-by: Eric Blake
> ---
> src/bhyve/bhyve_driver.c | 5 -
> 1 file chan
Way back in the past, the "no_tty=1" option was added for the remote
driver to disable local password prompting by disabling use of the local
tty:
commit b32f42984994a397441a1c48f1a002e906624c51
Author: Daniel P. Berrange
Date: Fri Sep 21 20:17:09 2007 +
Added a no_tty param to r
On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> Sometimes the original URL might even stop working, as is the
> case for Ubuntu 16.04 this very moment. We want the lastest
> point release anyway.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/host_vars/libvirt-debian-10/in
Even though we technically don't need them because we don't
have Ubuntu guests on CentOS CI, leaving the mapping incomplete
when it's easy to cover everything feels wrong.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/
Debian 10 doesn't include OpenJDK 8, which would be a problem
if not for the fact that thankfully the Jenkins agent, which
is the only thing we need Java for, seems to work perfectly
fine with OpenJDK 11 too.
Given this fact, we can move to OpenJDK 11 pretty much across
the board and stick to Open
See commit 2/2 for more information.
Andrea Bolognani (2):
guests: Add mapping for OpenJDK on Ubuntu
guests: Use OpenJDK 11 where possible
guests/vars/mappings.yml | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
h
On Mon, Jul 08, 2019 at 11:55:51 -0500, Eric Blake wrote:
> Time to actually issue the QMP transactions that start and
> stop backup commands (for now, just pull mode, not push).
> Starting a job has to kick off several pre-req steps, then
> a transaction, and additionally spawn an NBD server for p
Sometimes the original URL might even stop working, as is the
case for Ubuntu 16.04 this very moment. We want the lastest
point release anyway.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-debian-10/install.yml | 2 +-
guests/host_vars/libvirt-debian-9/install.yml | 2 +-
guests
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 49d7030d21..891a398a92 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -2602,6 +2602,3
Commit 611b85c2aa70 added this for all operating systems,
but at the time we had (mistakenly) dropped support for
Ubuntu 16.04, so we need to catch up after the recent
revert brought it back.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
guests/host_vars/libvirt-ubuntu-16/main.yml | 1
On Mon, Jul 08, 2019 at 11:55:50 -0500, Eric Blake wrote:
> Still needs to actually kick off the right QMP commands, but at
> least allows validation of backup XML, including the fact that
> a backup job can survive a libvirtd restart. Atomically creating
> a checkpoint alongside the backup still n
On Mon, Jul 08, 2019 at 11:55:48 -0500, Eric Blake wrote:
> Accept XML describing a generic block job, and output it again as
> needed. This may still need a few tweaks to match the documented XML
> and RNG schema.
>
> Signed-off-by: Eric Blake
> ---
[...]
> diff --git a/src/conf/backup_conf.h
On Tue, Jul 09, 2019 at 05:34:14PM +0200, Andrea Bolognani wrote:
> See commit 1/2 for the explanation.
>
> Andrea Bolognani (2):
> guests: Re-introduce Ubuntu 16.04
> Start building on Ubuntu 16.04 once again
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com
On 7/8/19 10:36 PM, Eric Blake wrote:
> Even though we don't accept any flags, it is unfriendly to callers
> that use the modern API to have to fall back to the flag-free API.
>
> Signed-off-by: Eric Blake
> ---
> src/bhyve/bhyve_driver.c | 38 --
> 1 file cha
On Mon, Jul 08, 2019 at 11:55:46 -0500, Eric Blake wrote:
> Introduce a few new public APIs related to incremental backups. This
> builds on the previous notion of a checkpoint (without an existing
> checkpoint, the new API is a full backup, differing from
> virDomainBlockCopy in the point of time
This reverts commit 008ed7e28f6e.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/build/jobs/defaults.yml| 1 +
guests/playbooks/build/projects/libvirt-dbus.yml| 5 -
guests/playbooks/build/projects/libvirt-go-xml.yml | 1 +
guests/playbooks/build/projects/libvirt-go.ym
See commit 1/2 for the explanation.
Andrea Bolognani (2):
guests: Re-introduce Ubuntu 16.04
Start building on Ubuntu 16.04 once again
guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 ++
.../host_vars/libvirt-ubuntu-16/install.yml | 2 ++
guests/host_vars/libvirt-ubuntu-16/main.yml |
According to our platform support policy[1], we support an
Ubuntu LTS release for two years after the *following* LTS
has been released, which means that Ubuntu 16.04 is going to
be an official target for almost one more year.
This reverts commit c6c648534dd1.
[1] https://libvirt.org/platforms.ht
On Tue, Jul 09, 2019 at 05:10:59PM +0200, Martin Kletzander wrote:
> On Tue, Jul 09, 2019 at 12:33:54PM +0100, Daniel P. Berrangé wrote:
> > Support for the modern CPU_ALLOC macros was added 10 years ago in
> >
> > commit a73cd93b2428adbbc62bb919b6cf5ffd27728040
> > Author: Daniel P. Berrange
>
On Tue, Jul 09, 2019 at 12:33:54PM +0100, Daniel P. Berrangé wrote:
Support for the modern CPU_ALLOC macros was added 10 years ago in
commit a73cd93b2428adbbc62bb919b6cf5ffd27728040
Author: Daniel P. Berrange
Date: Mon Nov 16 16:08:29 2009 +
Alternate CPU affinity impl to cope with
The cleanup label in virNetworkObjAddPort() function serves no
purpose. Drop it and thus simplify the function a bit.
Signed-off-by: Michal Privoznik
---
src/conf/virnetworkobj.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/conf/virnetworkobj.c b/src/con
Almost trivial, not pushed though.
Michal Prívozník (3):
virnetworkobj: Free retval of virNetworkObjGetPortStatusDir()
virnetworkobj: Drop needless cleanup label in virNetworkObjAddPort
virnetworkobj: Drop needless cleanup label in virNetworkObjDeletePort
src/conf/virnetworkobj.c | 37
The virNetworkObjGetPortStatusDir() function allocates a memory
to construct a path. None of the callers free it leading to a
memleak.
Signed-off-by: Michal Privoznik
---
src/conf/virnetworkobj.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/virnetworkobj.c b
The cleanup label in virNetworkObjDeletePort() function serves no
purpose. Drop it and thus simplify the function a bit.
Signed-off-by: Michal Privoznik
---
src/conf/virnetworkobj.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/conf/virnetworkobj.c b/
On Mon, Jul 08, 2019 at 11:55:45 -0500, Eric Blake wrote:
> Prepare for new backup APIs by describing the XML that will represent
> a backup. The XML resembles snapshots and checkpoints in being able
> to select actions for a set of disks, but has other differences. It
> can support both push mod
On Tue, Jul 09, 2019 at 03:28:20PM +0200, Michal Privoznik wrote:
The @oldDef variable in libxlAddDom0() is not used really. Drop
it.
Signed-off-by: Michal Privoznik
---
src/libxl/libxl_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Not really needed since its introduction
Signed-off-by: Eric Blake
---
Pushing under trivial rule.
src/driver.h | 4 ++--
docs/news-2014.html.in | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 3fcea0d629..898fb96df4 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -78,9
On Tue, Jul 09, 2019 at 02:45:54PM +0200, Andrea Bolognani wrote:
> On Tue, 2019-07-09 at 10:21 +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 08, 2019 at 06:03:10PM +0200, Andrea Bolognani wrote:
> > > When only geteuid() is mocked, the test crashes on Debian 10.
> > >
> > > Fatal: failed to
On 7/9/19 4:36 AM, Daniel P. Berrangé wrote:
> On Tue, Jul 09, 2019 at 11:02:03AM +0200, Peter Krempa wrote:
>> On Mon, Jul 08, 2019 at 22:37:02 -0500, Eric Blake wrote:
>>> As shown in recent patches, several drivers provided only an older
>>> counterpart of an API, making it harder to uniformly u
The @oldDef variable in libxlAddDom0() is not used really. Drop
it.
Signed-off-by: Michal Privoznik
---
src/libxl/libxl_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 7c236383e4..731700ded6 100644
--- a/sr
On 7/8/19 4:46 AM, Liu Dayu wrote:
> virsh snapshot-create-as supports 'file' storage type in --diskspec by
> default.
> But it doesn't support 'block' storage type in the
> virshParseSnapshotDiskspec().
> So if a snapshot on a block device (e.g. LV) was created, the type of
> current running sto
On Tue, 2019-07-09 at 10:21 +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 08, 2019 at 06:03:10PM +0200, Andrea Bolognani wrote:
> > When only geteuid() is mocked, the test crashes on Debian 10.
> >
> > Fatal: failed to reset uid: No such file or directory
> >
> > Program received signal SIGA
On Tue, 9 Jul 2019 14:26:08 +0200
Pavel Hrdina wrote:
> On Tue, Jul 09, 2019 at 02:03:15PM +0200, Stephan von Krawczynski wrote:
> > On Tue, 9 Jul 2019 09:40:23 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Mon, Jul 08, 2019 at 09:47:24PM +0200, Stephan von Krawczynski
> > > wrote:
> > >
On Tue, Jul 09, 2019 at 02:03:15PM +0200, Stephan von Krawczynski wrote:
> On Tue, 9 Jul 2019 09:40:23 +0100
> Daniel P. Berrangé wrote:
>
> > On Mon, Jul 08, 2019 at 09:47:24PM +0200, Stephan von Krawczynski wrote:
> > > Hello list,
> > >
> > > I came across a fundamental flaw in the libvirt us
On Tue, 9 Jul 2019 09:40:23 +0100
Daniel P. Berrangé wrote:
> On Mon, Jul 08, 2019 at 09:47:24PM +0200, Stephan von Krawczynski wrote:
> > Hello list,
> >
> > I came across a fundamental flaw in the libvirt user configuration lately
> > and try to find a solution now. Here is the problem:
> > I
Support for the modern CPU_ALLOC macros was added 10 years ago in
commit a73cd93b2428adbbc62bb919b6cf5ffd27728040
Author: Daniel P. Berrange
Date: Mon Nov 16 16:08:29 2009 +
Alternate CPU affinity impl to cope with NR_CPUS > 1024
This is long enough that we can assume it always
On Tue, Jul 09, 2019 at 12:55:18PM +0200, Jan Zerebecki wrote:
>
> On 09/07/2019 10.35, Daniel P. Berrangé wrote:
> > If virtlogd is active, we do *not* want logrotate doing anything at all.
>
> Are you saying that to fix the bug at hand, I should be required to
> first implement 2 features in vi
On 09/07/2019 10.35, Daniel P. Berrangé wrote:
> If virtlogd is active, we do *not* want logrotate doing anything at all.
Are you saying that to fix the bug at hand, I should be required to
first implement 2 features in virtlogd and replace the current logrotate
config (none of which caused the b
On Mon, Jul 08, 2019 at 22:12:38 -0500, Eric Blake wrote:
> On 7/8/19 2:56 AM, Peter Krempa wrote:
> > On Fri, Jul 05, 2019 at 23:37:31 -0500, Eric Blake wrote:
> >> We've been doing a terrible job of performing XML validation in our
> >> various API that parse XML with a corresponding schema (we s
On Tue, 2019-07-09 at 10:07 +0100, Daniel P. Berrangé wrote:
> BTW, lcitool fails when you don't have any $HOME/.ssh/id_rsa.pub
> file, which is always for me, as my guests run on a remote server
> and my key is on my laptop.
>
> It ought to get the key by using "ssh-add -L" to get it from the age
Ping
On Thu, Jun 27, 2019 at 10:54:29AM +0100, Daniel P. Berrangé wrote:
> The libvirtd daemon has some support for systemd socket activation
> from:
>
> commit 27a7081c2968ca0d7fbd590629b5a5303851f4a3
> Author: Martin Kletzander
> Date: Tue Jul 15 15:28:53 2014 +0200
>
> daemon: su
On Tue, Jul 09, 2019 at 07:42:06AM +, Sahid Orentino Ferdjaoui wrote:
> Signed-off-by: Sahid Orentino Ferdjaoui
> ---
> README.md | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/phot
On Tue, Jul 09, 2019 at 07:42:07AM +, Sahid Orentino Ferdjaoui wrote:
> We passed the 0.2.9 since that one has been sent to crates.io but the
> code was never merged. To avoid that in future, new version will be
> sent to crates.io only when accepted by upstream.
>
> Signed-off-by: Sahid Orent
On Tue, Jul 09, 2019 at 07:42:05AM +, Sahid Orentino Ferdjaoui wrote:
> Also configure default mech used by sasl to 'digest-md5' since
> 'scram-sha-1' requires an encryption layer.
>
> Signed-off-by: Sahid Orentino Ferdjaoui
> ---
> .travis.yml | 3 ++-
> tests/libvirtd.sasl | 2 ++
>
On Tue, Jul 09, 2019 at 07:42:04AM +, Sahid Orentino Ferdjaoui wrote:
> Signed-off-by: Sahid Orentino Ferdjaoui
> ---
> .travis.yml | 7 +++
> README.md | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange
On Tue, Jul 09, 2019 at 07:42:03AM +, Sahid Orentino Ferdjaoui wrote:
> Signed-off-by: Sahid Orentino Ferdjaoui
> ---
> tests/domain.rs | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o
On Tue, Jul 09, 2019 at 07:42:02AM +, Sahid Orentino Ferdjaoui wrote:
> Due to an issue fixed in libvirt master we should not consider running
> integration tests in parallel.
>
> https://www.redhat.com/archives/libvir-list/2019-July/msg00287.html
>
> Signed-off-by: Sahid Orentino Ferdjaoui
1 - 100 of 125 matches
Mail list logo
