On 7/17/19 7:20 PM, Daniel Henrique Barboza wrote:
After this commit, QEMU domains with PCI hostdevs running with
managed=true started to fail to launch with the following error:
error : virProcessRunInFork:1170 : internal error: child reported (status=125):
unable to open /dev/vfio/1: Device o
This commit is similar with 596aa144. It fixes an uninitialized
variable to avoid garbage value. This case, it uses time 't' 0 if
an error occurs with virTimeMillisNowRaw.
Signed-off-by: Julio Faracco
---
src/util/virtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/
On 7/8/19 7:06 AM, Peter Krempa wrote:
> On Sat, Jul 06, 2019 at 22:56:04 -0500, Eric Blake wrote:
>> Add a new file checkpoint_conf.c that performs the translation to and
>> from new XML describing a checkpoint. The code shares a common base
>> class with snapshots, since a checkpoint similarly re
On 7/17/19 12:49 PM, Laine Stump wrote:
> On 7/14/19 8:03 PM, Cole Robinson wrote:
>> There's several unresolved RFEs for the bridge
>> driver that are essentially requests to add XML wrappers
>> for underlying dnsmasq options.
>>
>> This series adds a dnsmasq xmlns namespace for
>> XML that allo
On 7/17/19 1:39 PM, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Let's add a possibility to query dirty-bitmaps not only on root nodes.
> It is useful when dealing both with snapshots and incremental backups.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Added deprecation i
On 7/17/19 4:05 PM, Eric Blake wrote:
> On 7/17/19 2:21 PM, John Snow wrote:
>>>
>>> Is this worth squeezing into 4.1, to start the deprecation clock one
>>> cycle earlier (on the grounds that the missing information for anonymous
>>> nodes is a bug)? Or am I pushing the boundaries too far, whe
On 7/17/19 2:21 PM, John Snow wrote:
>>
>> Is this worth squeezing into 4.1, to start the deprecation clock one
>> cycle earlier (on the grounds that the missing information for anonymous
>> nodes is a bug)? Or am I pushing the boundaries too far, where keeping
>> this as 4.2 material remains the
On 7/17/19 3:13 PM, Eric Blake wrote:
> On 7/17/19 12:39 PM, John Snow wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> Let's add a possibility to query dirty-bitmaps not only on root nodes.
>> It is useful when dealing both with snapshots and incremental backups.
>>
>> Signed-off-by: Vladimi
On 7/17/19 12:39 PM, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Let's add a possibility to query dirty-bitmaps not only on root nodes.
> It is useful when dealing both with snapshots and incremental backups.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Added deprecation inf
On 7/17/19 1:39 PM, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Let's add a possibility to query dirty-bitmaps not only on root nodes.
> It is useful when dealing both with snapshots and incremental backups.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Added deprecation i
On Wed, Jul 17, 2019 at 03:49:28PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 38 ++
> 1 file changed, 38 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jul 17, 2019 at 03:49:29PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 30 ++
> 1 file changed, 30 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://
On Wed, Jul 17, 2019 at 03:49:27PM +0200, Andrea Bolognani wrote:
> The implementation is a bit awkward and surprising because the
>
> GET /api/v1/repository/{repository}/tag/{tag}/images
>
> API does not report the information we're looking form in an
> easy to consume form. It also suffers fr
From: Vladimir Sementsov-Ogievskiy
Let's add a possibility to query dirty-bitmaps not only on root nodes.
It is useful when dealing both with snapshots and incremental backups.
Signed-off-by: Vladimir Sementsov-Ogievskiy
[Added deprecation information. --js]
Signed-off-by: John Snow
---
block
On Wed, Jul 17, 2019 at 03:49:26PM +0200, Andrea Bolognani wrote:
> The implementation is limited in that it will not work
> properly if a repository contains more than 100 tags, but
> that's not really a big concern for us as each repository is
> only going to contain a single tag (latest).
>
> S
On Wed, Jul 17, 2019 at 03:49:25PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 39 +++
> 1 file changed, 39 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jul 17, 2019 at 03:49:24PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 27 +++
> 1 file changed, 27 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www
On Wed, Jul 17, 2019 at 03:49:23PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 40
> 1 file changed, 40 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jul 17, 2019 at 03:49:22PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 40
> 1 file changed, 40 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jul 17, 2019 at 03:49:21PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 27 +++
> 1 file changed, 27 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www
On Wed, Jul 17, 2019 at 03:49:19PM +0200, Andrea Bolognani wrote:
> We don't want sensitive information such as the API token to
> be stored into the script, both because it could lead to them
> being leaked by mistake and because it makes it needlessly
> complicated for users to take advantage of
On Wed, Jul 17, 2019 at 03:49:20PM +0200, Andrea Bolognani wrote:
> We're going to need it for some specific Quay APIs later on.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: htt
After this commit, QEMU domains with PCI hostdevs running with
managed=true started to fail to launch with the following error:
error : virProcessRunInFork:1170 : internal error: child reported (status=125):
unable to open /dev/vfio/1: Device or resource busy
One way to avoid this issue is to di
On Wed, Jul 17, 2019 at 03:49:18PM +0200, Andrea Bolognani wrote:
> Instead of storing the client configuration in global
> variables, create a single configuration object to store all
> of them and pass around for functions to use.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin |
On Wed, Jul 17, 2019 at 03:49:17PM +0200, Andrea Bolognani wrote:
> They're not currently used, and don't look like they're
> actually necessary to use the Quay API.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berr
On Wed, Jul 17, 2019 at 03:49:16PM +0200, Andrea Bolognani wrote:
> While a command line parameter for enabling debug mode has
> been defined, it's not currently used in any form or shape.
>
> Make it so enabling debug mode actually does something
> useful, that is, prints the most important parts
On Wed, Jul 17, 2019 at 03:49:15PM +0200, Andrea Bolognani wrote:
> Instead of building all arguments for a request at the same
> time as the request itself is prepared, build them beforehand
> and then pass them to the corresponding function.
>
> This makes the code more readable, especially when
On Wed, Jul 17, 2019 at 03:49:14PM +0200, Andrea Bolognani wrote:
> We're going to introduce several other list-* commands later,
> and we want their output to be more or less consistent, so
> start by tweaking the existing command.
>
> More specifically, we want the output of each list-* command
On Wed, Jul 17, 2019 at 03:49:13PM +0200, Andrea Bolognani wrote:
> We're going to introduce several other show-* commands later,
> and we want their output to be more or less consistent, so
> start by tweaking the existing command.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin |
On Wed, Jul 17, 2019 at 03:49:12PM +0200, Andrea Bolognani wrote:
> If we've been asked not to produce any output, we can bail
> early: doing so means we don't need to increase indentation
> for subsequent code, and in some cases we can even avoid
> fetching the JSON data from the response object.
On Wed, Jul 17, 2019 at 04:37:07PM +0200, Ján Tomko wrote:
> Wrap each release headline in an element with the id set
> to the release value and page.xsl will take care of the rest.
>
> Reported-by: Kashyap Chamarthy
> Signed-off-by: Ján Tomko
Thanks for the quick patch!
Just tested this loca
On 7/14/19 8:03 PM, Cole Robinson wrote:
There's several unresolved RFEs for the bridge
driver that are essentially requests to add XML wrappers
for underlying dnsmasq options.
This series adds a dnsmasq xmlns namespace for
XML that allows passing option strings directly to the
generated dnsma
On Wed, Jul 17, 2019 at 15:41:48 +0200, Ján Tomko wrote:
> Libvirt 1.1.1 was released 6 years ago. This was the version that
> ended up in RHEL 7.0. It is unlikely that the reader will need to
> consider libvirt versions beyond that. Remove the since markers
> for older versions to de-clutter the d
On Wed, Jul 17, 2019 at 15:41:47 +0200, Ján Tomko wrote:
> Libvirt 1.1.1 was released 6 years ago. This was the version that
> ended up in RHEL 7.0. It is unlikely that the reader will need to
> consider libvirt versions beyond that. Remove the since markers
> for older versions to de-clutter the d
On Wed, Jul 17, 2019 at 04:22:15PM +0200, Peter Krempa wrote:
This is based on quite a lot of patches that were ACK'd but I didn't
push them yet, so feel free to fetch this at:
git fetch https://gitlab.com/pipo.sk/libvirt.git legacy-job-refactor
Peter Krempa (2):
qemu: blockjob: Save config on
On Wed, Jul 17, 2019 at 04:22:20PM +0200, Peter Krempa wrote:
The legacy job handler does not look at the old job state so we can
update it earlier.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
On Wed, Jul 17, 2019 at 04:30:50PM +0200, Peter Krempa wrote:
Now that the blockjob handling code deals with the status XML we don't
need to save it explicitly when starting blockjobs.
Signed-off-by: Peter Krempa
---
Note that this depends now on:
https://www.redhat.com/archives/libvir-list/2
On Wed, Jul 17, 2019 at 15:41:41 +0200, Ján Tomko wrote:
> Got a bit lost while navigating around the element
> documentation.
>
> Ján Tomko (7):
> docs: link to networkportformat.html in format.html
> docs: drvqemu: fix a typo
> docs: drvqemu: remove relative time reference
> docs: forma
On Wed, Jul 17, 2019 at 17:06:22 +0200, Ján Tomko wrote:
> On Wed, Jul 17, 2019 at 05:02:02PM +0200, Peter Krempa wrote:
> > On Wed, Jul 17, 2019 at 16:37:06 +0200, Ján Tomko wrote:
> > > Set a default namespace in the stylesheet instead.
> > >
> > > Signed-off-by: Ján Tomko
> > > ---
> > > docs
On Wed, Jul 17, 2019 at 17:05:08 +0200, Michal Privoznik wrote:
> On 7/16/19 3:00 PM, Peter Krempa wrote:
> > On Thu, Jul 11, 2019 at 17:53:58 +0200, Michal Privoznik wrote:
> > > To simplify implementation, some restrictions are added. For
> > > instance, an NVMe disk can't go to any bus but virti
On Wed, 2019-07-17 at 16:37 +0200, Ján Tomko wrote:
> Wrap each release headline in an element with the id set
> to the release value and page.xsl will take care of the rest.
>
> Reported-by: Kashyap Chamarthy
> Signed-off-by: Ján Tomko
> ---
> docs/news-html.xsl | 17 +++--
> 1 fi
On Wed, Jul 17, 2019 at 05:02:02PM +0200, Peter Krempa wrote:
On Wed, Jul 17, 2019 at 16:37:06 +0200, Ján Tomko wrote:
Set a default namespace in the stylesheet instead.
Signed-off-by: Ján Tomko
---
docs/Makefile.am | 8 +---
docs/news-html.xsl | 4 +++-
2 files changed, 4 insertions(+)
On 7/16/19 3:00 PM, Peter Krempa wrote:
On Thu, Jul 11, 2019 at 17:53:58 +0200, Michal Privoznik wrote:
To simplify implementation, some restrictions are added. For
instance, an NVMe disk can't go to any bus but virtio and has to
be type of 'disk' and can't have startupPolicy set.
Signed-off-by
On Wed, Jul 17, 2019 at 16:37:06 +0200, Ján Tomko wrote:
> Set a default namespace in the stylesheet instead.
>
> Signed-off-by: Ján Tomko
> ---
> docs/Makefile.am | 8 +---
> docs/news-html.xsl | 4 +++-
> 2 files changed, 4 insertions(+), 8 deletions(-)
Fails in vpath build:
/usr/bin/x
On Wed, 2019-07-17 at 16:37 +0200, Ján Tomko wrote:
[...]
>
> - xmlns:xsl="http://www.w3.org/1999/XSL/Transform";>
> + +xmlns="http://www.w3.org/1999/xhtml";
> +xmlns:xsl="http://www.w3.org/1999/XSL/Transform";>
I suggest formatting this as
http://www.w3.org/1999/xhtml";
Ján Tomko (2):
docs: news: remove sed sorcery
docs: news: add per-release links
docs/Makefile.am | 8 +---
docs/news-html.xsl | 21 ++---
2 files changed, 15 insertions(+), 14 deletions(-)
--
2.20.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redha
Set a default namespace in the stylesheet instead.
Signed-off-by: Ján Tomko
---
docs/Makefile.am | 8 +---
docs/news-html.xsl | 4 +++-
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index 1cfa38dc80..bc2fd6ea42 100644
--- a/docs/Makefile
Wrap each release headline in an element with the id set
to the release value and page.xsl will take care of the rest.
Reported-by: Kashyap Chamarthy
Signed-off-by: Ján Tomko
---
docs/news-html.xsl | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/docs/news
Now that the blockjob handling code deals with the status XML we don't
need to save it explicitly when starting blockjobs.
Signed-off-by: Peter Krempa
---
Note that this depends now on:
https://www.redhat.com/archives/libvir-list/2019-July/msg01088.html
Or fetch the whole updated series (due t
There's no need to do it if the job is not completed. The new helper
allows to do this with much less hassle in the correct place.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qem
This is based on quite a lot of patches that were ACK'd but I didn't
push them yet, so feel free to fetch this at:
git fetch https://gitlab.com/pipo.sk/libvirt.git legacy-job-refactor
Peter Krempa (2):
qemu: blockjob: Save config only in
qemuBlockJobEventProcessLegacyCompleted
qemu: bloc
The legacy job handler does not look at the old job state so we can
update it earlier.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 097d87f663..08d131
This command is hooked into the virsh hypervisor-cpu-compare command.
As such, the CPU model XML provided to the command will be compared
to the hypervisor CPU contained in the QEMU capabilities file for the
appropriate QEMU binary (for s390x, this CPU definition can be observed
via virsh domcapabi
Interfaces with QEMU to baseline CPU models. The command takes two
CPU models, A and B, that are given a model name and an optional list
of CPU features. Through the query-cpu-model-baseline command issued
via QMP, a result is produced that contains a new baselined CPU model
that is guaranteed to r
This capability enables CPU model comparison between two CPU
definitions via QMP.
Signed-off-by: Collin Walling
Reviewed-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/ca
Changelog:
v3
- rebased on master
v2
- numerous cleanups
- removed "policy fix function" and now properly check
for policy == -1 in the CPUDef -> JSON parser
- resolved some memory leaks
- added string arg to qemuMonitorJSON
Implement an XML to virCPUDefPtr helper that handles
the ctxt prerequisite for virCPUDefParseXML.
This does not alter any functionality.
Signed-off-by: Collin Walling
Reviewed-by: Bjoern Walk
Reviewed-by: Daniel Henrique Barboza
---
src/conf/cpu_conf.c | 30 ++
Interfaces with QEMU to compare CPU models. The command takes two
CPU models, A and B, that are given a model name and an optional list
of CPU features. Through the query-cpu-model-comparison command issued
via QMP, a result is produced that contains the comparison evaluation
string (identical, sup
Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be
later used for the comparison and baseline functions.
This does not alter any functionality.
Signed-off-by: Collin Walling
Reviewed-by: Bjoern Walk
Reviewed-by: Daniel Henrique Barboza
---
src/qemu/qemu_monitor_json.c | 173 +
This command is hooked into the virsh hypervisor-cpu-baseline command.
As such, the CPU models provided in the XML sent to the command will be
baselined with the CPU contained in the QEMU capabilities file for the
appropriate QEMU binary (for s390x, this CPU definition can be observed
via virsh dom
This capability enables CPU model baselining between two CPU
definitions via QMP.
Signed-off-by: Collin Walling
Reviewed-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/c
On Wed, Jul 17, 2019 at 03:49:11PM +0200, Andrea Bolognani wrote:
> It was clearly copied from create-repo and not cleaned up
> sufficiently afterwards.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P.
If we've been asked not to produce any output, we can bail
early: doing so means we don't need to increase indentation
for subsequent code, and in some cases we can even avoid
fetching the JSON data from the response object.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 19 +
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 40
1 file changed, 40 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index cd989b3..465cd8d 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -221,6 +221,30 @@ def run_show_trig
The implementation is limited in that it will not work
properly if a repository contains more than 100 tags, but
that's not really a big concern for us as each repository is
only going to contain a single tag (latest).
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 31 +++
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 30 ++
1 file changed, 30 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index a35996e..36ce183 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -259,6 +259,25 @@ def run_create_tag(config,
They're not currently used, and don't look like they're
actually necessary to use the Quay API.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 2 --
1 file changed, 2 deletions(-)
diff --git a/guests/quayadmin b/guests/quayadmin
index 04a8b66..218a945 100755
--- a/guests/quayadmin
+++ b
While a command line parameter for enabling debug mode has
been defined, it's not currently used in any form or shape.
Make it so enabling debug mode actually does something
useful, that is, prints the most important parts of the
conversation happening between the client and the server.
Signed-of
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 38 ++
1 file changed, 38 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index f99ac03..a35996e 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -237,6 +237,28 @@ def run_show_tag(co
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 40
1 file changed, 40 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index 99c7a27..cd989b3 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -196,6 +196,31 @@ def run_list_trig
Instead of building all arguments for a request at the same
time as the request itself is prepared, build them beforehand
and then pass them to the corresponding function.
This makes the code more readable, especially when complex
params or long endpoints are involved.
Signed-off-by: Andrea Bolog
We're going to introduce several other show-* commands later,
and we want their output to be more or less consistent, so
start by tweaking the existing command.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/guests/qua
The implementation is a bit awkward and surprising because the
GET /api/v1/repository/{repository}/tag/{tag}/images
API does not report the information we're looking form in an
easy to consume form. It also suffers from the same limitations
as the list-tags command.
Signed-off-by: Andrea Bolog
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 27 +++
1 file changed, 27 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index 465cd8d..c2ea2b7 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -180,6 +180,22 @@ def run_delete_repo(config, ar
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 39 +++
1 file changed, 39 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index c2ea2b7..f71ad2d 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -196,6 +196,30 @@ def run_list_build
Instead of storing the client configuration in global
variables, create a single configuration object to store all
of them and pass around for functions to use.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 45 +
1 file changed, 25 insertions(
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 27 +++
1 file changed, 27 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index bbb35a2..99c7a27 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -180,6 +180,22 @@ def run_delete_repo(config, ar
We're going to need it for some specific Quay APIs later on.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 4
1 file changed, 4 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index 5db7895..bbb35a2 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -87,6 +87,1
We don't want sensitive information such as the API token to
be stored into the script, both because it could lead to them
being leaked by mistake and because it makes it needlessly
complicated for users to take advantage of the tool.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 25 +++
It was clearly copied from create-repo and not cleaned up
sufficiently afterwards.
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/guests/quayadmin b/guests/quayadmin
index 31ea929..5dc5eff 100755
--- a/guests/quayadmin
+
This code was written by Daniel P. Berrangé, and contains
the scaffolding necessary to call Quay APIs as well as the
implementation of a few commands.
Signed-off-by: Daniel P. Berrangé
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 198 +++
1
We're going to introduce several other list-* commands later,
and we want their output to be more or less consistent, so
start by tweaking the existing command.
More specifically, we want the output of each list-* command
to be such that you can take one of the lines, append it to
the arguments yo
Changes from [v1]:
* add Dan's R-b to the patch importing the initial implementation;
* don't break quiet mode for show-repo, and make sure it works for
all other show-* commands as well;
* fix typos.
[v1] https://www.redhat.com/archives/libvir-list/2019-July/msg01018.html
Andrea Bol
Signed-off-by: Ján Tomko
---
docs/drvqemu.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in
index 12b2c2bd2f..f0115bff7e 100644
--- a/docs/drvqemu.html.in
+++ b/docs/drvqemu.html.in
@@ -38,7 +38,7 @@
KVM hyperv
Libvirt 1.1.1 was released 6 years ago. This was the version that
ended up in RHEL 7.0. It is unlikely that the reader will need to
consider libvirt versions beyond that. Remove the since markers
for older versions to de-clutter the documentation a bit.
Signed-off-by: Ján Tomko
---
docs/drvnoded
It has not aged well.
Signed-off-by: Ján Tomko
---
docs/drvqemu.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in
index f0115bff7e..294117ee1f 100644
--- a/docs/drvqemu.html.in
+++ b/docs/drvqemu.html.in
@@ -376,7 +376,7 @@ ch
Signed-off-by: Ján Tomko
---
docs/format.html.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/format.html.in b/docs/format.html.in
index 640a9957ee..b488f7b38f 100644
--- a/docs/format.html.in
+++ b/docs/format.html.in
@@ -17,6 +17,7 @@
Domains
Networks
Network fi
Libvirt 1.1.1 was released 6 years ago. This was the version that
ended up in RHEL 7.0. It is unlikely that the reader will need to
consider libvirt versions beyond that. Remove the since markers
for older versions to de-clutter the documentation a bit.
Signed-off-by: Ján Tomko
---
docs/formatdo
Signed-off-by: Ján Tomko
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 671d822a71..22d1b85aca 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1959,7 +1959,7 @
As of commit 7373c4e48 the QEMU driver also supports TSC.
Signed-off-by: Ján Tomko
---
docs/formatdomain.html.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 22d1b85aca..1d57729394 100644
--- a/docs/formatdomai
Got a bit lost while navigating around the element
documentation.
Ján Tomko (7):
docs: link to networkportformat.html in format.html
docs: drvqemu: fix a typo
docs: drvqemu: remove relative time reference
docs: formatdomain: remove stray nbsp
docs: formatdomain: tsc is supported by QEMU
On 7/16/19 2:38 PM, Peter Krempa wrote:
On Thu, Jul 11, 2019 at 18:16:58 +0200, Peter Krempa wrote:
On Thu, Jul 11, 2019 at 18:12:16 +0200, Michal Privoznik wrote:
On 7/11/19 6:05 PM, Peter Krempa wrote:
On Thu, Jul 11, 2019 at 17:53:58 +0200, Michal Privoznik wrote:
To simplify implementatio
On Wed, 2019-07-17 at 13:03 +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 17, 2019 at 01:53:59PM +0200, Andrea Bolognani wrote:
> > We don't want sensitive information such as the API token to
> > be stored into the script, both because it could lead to them
> > being leaked by mistake and because
On Wed, 2019-07-17 at 13:00 +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 17, 2019 at 01:53:52PM +0200, Andrea Bolognani wrote:
> > Since the user is explicity asking for information to be
> > displayed, we should present it to them whether or not quiet
> > mode is enabled.
>
> The reason why I h
On Wed, 2019-07-17 at 14:11 +0200, Ján Tomko wrote:
> On Wed, Jul 17, 2019 at 01:53:51PM +0200, Andrea Bolognani wrote:
> > It was clearly copied from create-repo and not cleaned up
> > sufficiently afterwards.
>
> This is fixing lines introduced in the previous patch, why not just
> squash it?
B
s/amd/adm/
Jano
On Wed, Jul 17, 2019 at 01:53:58PM +0200, Andrea Bolognani wrote:
Instead of storing the client configuration in global
variables, create a single configuration object to store all
of them and pass around for functions to use.
Signed-off-by: Andrea Bolognani
---
guests/quayadm
On Wed, Jul 17, 2019 at 01:53:50PM +0200, Andrea Bolognani wrote:
This code was written by Daniel P. Berrangé, and contains
the scaffolding necessary to call Quay APIs as well as the
implementation of a few commands.
Per our Governance document:
https://libvirt.org/governance.html#contributors
On Wed, Jul 17, 2019 at 01:53:51PM +0200, Andrea Bolognani wrote:
It was clearly copied from create-repo and not cleaned up
sufficiently afterwards.
This is fixing lines introduced in the previous patch, why not just
squash it?
Jano
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 3
On Wed, Jul 17, 2019 at 01:53:50PM +0200, Andrea Bolognani wrote:
> This code was written by Daniel P. Berrangé, and contains
> the scaffolding necessary to call Quay APIs as well as the
> implementation of a few commands.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/quayadmin | 198 ++
On Wed, Jul 17, 2019 at 01:53:59PM +0200, Andrea Bolognani wrote:
> We don't want sensitive information such as the API token to
> be stored into the script, both because it could lead to them
> being leaked by mistake and because it makes it needlessly
> complicated for users to take advantage of
1 - 100 of 127 matches
Mail list logo
