Re: [libvirt] [PATCH 35/41] remote: change hand written methods to not directly access connection

On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/remote/remote_daemon_dispatch.c > @@ -4210,14 +4128,13 @@ > remoteDispatchConnectDomainEventRegister(virNetServerPtr server > ATTRIBUTE_UNUSED > daemonClientEventCallbackPtr ref; > struct daemonClientPrivate

Re: [libvirt] [PATCH 34/41] remote: change generated methods to not directly access connection

On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > +++ b/src/remote/remote_daemon_dispatch.c > @@ -2013,6 +2134,7 @@ remoteDispatchConnectClose(virNetServerPtr server > ATTRIBUTE_UNUSED, > } > > > + > static int > remoteDispatchDomainGetSchedulerType(virNetServerPtr server

Re: [libvirt] [PATCH 33/41] remote: get rid of bogus ATTRIBUTE_UNUSED annotation client param

On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > The client parameter is always used to get access to the private data > struct. > > Signed-off-by: Daniel P. Berrangé > --- > src/remote/remote_daemon_dispatch.c | 98 ++--- > 1 file changed, 49

Re: [libvirt] [PATCH 32/41] admin: add ability to connect to the per-driver daemon sockets

On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/libvirt-admin.c > @@ -101,6 +97,7 @@ virAdmInitialize(void) > return 0; > } > > + > static char * > getSocketPath(virURIPtr uri) > { Unrelated whitespace change. [...] > @@ -127,27 +124,28 @@

Re: [libvirt] [PATCH 20/41] secret: introduce virtsecretd daemon

On Sun, 2019-07-28 at 17:22 +0200, Andrea Bolognani wrote: > Anyway, with the caveat that the comments made for previous patches > are addressed here as well if they apply, > > Reviewed-by: Andrea Bolognani Patches 21-31 are basically the same as this one, so they also get a R-b with the same

Re: [libvirt] [PATCH 20/41] secret: introduce virtsecretd daemon

On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/secret/virtsecretd.service.in [...] > +[Install] > +WantedBy=multi-user.target > +Also=virtsecretd.socket > +Also=virtsecretd-ro.socket > +Also=virtsecretd-admin.socket Interestingly, we *do* include the admin socket

Re: [libvirt] [PATCH 19/41] remote: introduce virtproxyd daemon to handle IP connectivity

On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: [...] > - We can make virtproxyd and the virtXXXd per-driver daemons all >have "Conflicts: libvirtd.service" in their systemd unit files. >This will guarantee that libvirtd is never started at the same >time, as this would

[libvirt] [PATCH] conf: Remove unnecessary declaration in virDomainCheckpointDefParse

The @creation variable wasn't used - caused a Travis build failure. Signed-off-by: John Ferlan --- Pushing under the trivial and build break rules. src/conf/checkpoint_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c index

[libvirt] [PATCH v2 1/2] tests: virsh-optparse: remove no longer valid cpu-stats test cases

These test cases are no longer valid since this series provides an implementation of the virDomainGetCPUStats API for the test driver. Signed-off-by: Ilias Stamatis --- tests/virsh-optparse | 20 1 file changed, 20 deletions(-) diff --git a/tests/virsh-optparse

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 132 + 1 file changed, 132 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ab0f8b06d6..56f08fc3d2 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainGetCPUStats

Changes since v1: * Removed failing test cases * Total CPUTIME now is the sum of the individual CPUs Ilias Stamatis (2): tests: virsh-optparse: remove no longer valid cpu-stats test cases test_driver: implement virDomainGetCPUStats src/test/test_driver.c | 132