Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index aae9875194..0e0acf2baf 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
On 8/1/19 11:24 AM, Daniel Henrique Barboza wrote:
[...]
So yeah. I am not sure what's different from the environments I use
versus
the one you're using (and probably the env of every other committer here,
otherwise this test failure would be pointed out earlier). I'll need
to think
more
On 7/29/19 5:17 AM, Michal Privoznik wrote:
On 7/26/19 8:38 PM, Stefan Berger wrote:
I noticed that if a domain fails to restore, the ref count in the xattr
'trusted.libvirt.security.ref_selinux' keeps on increasing indefinitely
and the VM will never restore even if the root cause for the
On 8/1/19 9:24 AM, Daniel Henrique Barboza wrote:
>>>
>>> So I think the difference is that your dev box is not echoing the
>>> commands, and the real problem is that the test is dependent on the
>>> current environment (is there some configuration file that determines
>>> whether virsh in batch
The public API entry points will call virDispatchError which
will print to stderr by default. We then jump to a cleanup
path which calls virDispatchError again.
We tried to stop the entry points printing to stderr, but
incorrectly called virSetErrorFunc. It needs a real function
that is a no-op,
Use the plain libc APIs to avoid a dependancy on the main libvirt
code from the nss module.
Signed-off-by: Daniel P. Berrangé
---
cfg.mk | 2 +-
tools/nss/libvirt_nss.c | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index
Now that the code does not refer to any libvirt headers,
except internal.h macros, it does not need to link to
any libvirt code, nor gnulib either. The only thing it
needs is yajl.
Signed-off-by: Daniel P. Berrangé
---
config-post.h | 30 ---
src/Makefile.am| 73
The .leases file is currently loaded using the virLease class,
which in turn uses the virJSON parsing code. This pulls in a
heap of libvirt code (logging, hash tables, etc) which we do
not wish to depend on.
This uses the yajl parser code directly, so the only dep is
yajl and plain libc
Use the plain libc APIs to avoid a dependancy on the main libvirt
code from the nss module.
Signed-off-by: Daniel P. Berrangé
---
tools/nss/libvirt_nss.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c
index
Use the plain libc APIs to avoid a dependancy on the main libvirt
code from the nss module.
Signed-off-by: Daniel P. Berrangé
---
tools/nss/libvirt_nss.c| 16 +++-
tools/nss/libvirt_nss.h| 5 +++--
tools/nss/libvirt_nss_leases.c | 6 --
3 files changed, 18
Build a list of mac addresses immediately, so that later code
searching for leases can be simplified and avoid needing to
use the virMacMap object.
Signed-off-by: Daniel P. Berrangé
---
cfg.mk | 4 +--
tools/nss/libvirt_nss.c | 73 -
2
Use the plain libc socket APIs to avoid a dependancy on the main
libvirt code from the nss module.
Signed-off-by: Daniel P. Berrangé
---
tools/nss/libvirt_nss.c| 36 --
tools/nss/libvirt_nss_leases.c | 56 +-
2 files changed, 69
Now that none of the libvirt.so code will ever run in a setuid
context, we can remove the virIsSUID() method. The global
initializer function can just inline the check itself. The new
inlined check is slightly stronger as it also looks for a
setgid situation.
Signed-off-by: Daniel P. Berrangé
The .macs file is currently loaded using the virMacMap class,
which in turn uses the virJSON parsing code. This pulls in a
heap of libvirt code (logging, hash tables, objects, etc) which
we do not wish to depend on.
This uses the yajl parser code directly, so the only dep is
yajl and plain libc
Now that 100% of libvirt code is forbidden in a SUID environment,
we no longer need to worry about whether env variables are
trustworthy or not. The virt-login-shell setuid program, which
does not link to any libvirt code, will purge all environment
variables, except $TERM, before invoking the
The virt-login-shell binary is a setuid program that takes
no arguments. When invoked it looks at the invoking uid,
resolves it to a username, and finds an LXC guest with the
same name. It then starts the guest and runs the shell in
side the namespaces of the container.
Given this set of tasks
Use the plain libc APIs to avoid a dependancy on the main libvirt
code from the nss module.
Signed-off-by: Daniel P. Berrangé
---
cfg.mk | 2 +-
tools/nss/libvirt_nss.c | 13 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index
Now that 100% of libvirt code is forbidden in a SUID environment,
we no longer need to worry about whether env variables are
trustworthy or not. The virt-login-shell setuid program, which
does not link to any libvirt code, will purge all environment
variables, except $TERM, before invoking the
As previously discussed, it is desirable to move libvirt to a model
where we abort-on-OOM, possibly making use of glib2.
This would be good for libvirt in general, but it is bad for a
couple of libvirt addons.
The virt-login-shell setuid program would be ok with abort-on-OOM,
but absolutely can
If the 'allowed_users' config setting in virt-login-shell.conf
does not exist, we dereference a NULL pointer resulting in a
crash. We should check for this case and thus ensure the user
is denied access gracefully.
Signed-off-by: Daniel P. Berrangé
---
tools/virt-login-shell.c | 2 +-
1 file
We'll shortly be renaming the binary to virt-login-shell-helper
and introducing a new tool as virt-login-shell. Renaming the
source file first gives a much more usefull diff for the next
commit.
Signed-off-by: Daniel P. Berrangé
---
tools/Makefile.am | 2 +-
The virt-login-shell setuid program is now a tiny piece of code
that only uses standard libc functions, and santizes the execution
environment before invoking the real virt-login-shell-helper.
The latter is thus able to use the normal libvirt.so build,
allowing us to delete the special cut down
On 8/1/19 9:49 AM, Daniel Henrique Barboza wrote:
On 8/1/19 8:43 AM, Eric Blake wrote:
On 8/1/19 6:30 AM, Eric Blake wrote:
On 7/31/19 4:58 PM, Daniel Henrique Barboza wrote:
There is a chance that the current sed filtering used in
these new tests might fail in some machines due to the
The 'guestinfo' command uses the new virDomainGetGuestInfo() API to
query information about the specified domain and print it out for the
user. The output is modeled roughly on the 'domstats' command.
Signed-off-by: Jonathon Jongsma
---
tools/virsh-domain.c | 53
Iimplements the new guest information API by querying requested
information via the guest agent.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_driver.c | 77 ++
1 file changed, 77 insertions(+)
diff --git a/src/qemu/qemu_driver.c
This function queries timezone information within the guest and adds
the information to an array of typed parameters with field names
intended to be returned to virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 46 ++
This series adds several bits of guest information provided by a new API
function virDomainGetGuestInfo(). There is an implementation for qemu using the
guest agent. In particular, it adds information about logged-in users, guest
OS, and timezone.
I had previously submitted a patch series with a
This function fetches the list of logged-in users from the qemu agent
and adds them to a list of typed parameters so that they can be used
internally in libvirt.
Also add some basic tests for the function.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 92 +++
This API is intended to aggregate several guest agent information
queries and is ispired by stats API virDomainListGetStats(). It is
anticipated that this information will be provided by a guest agent
running within the domain.
Signed-off-by: Jonathon Jongsma
---
This function queries the guest operating system information and adds
the returned information to an array of typed parameters with field
names intended to be returned in virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 52 ++
Add daemon and client code to serialize/deserialize
virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/remote/remote_daemon_dispatch.c | 41 ++
src/remote/remote_driver.c | 53 +
src/remote/remote_protocol.x| 21
Hi Daniel,
> >
> > Hi all,
> >
> > Virtio-pmem support has been added to kernel[1] and qemu[2]
> > upstream. User document[3] has more details on how to use this
> > new device.
> >
> > We now need support in libvirt. Required support would be a subset
> > of features already implemented
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 72 ++
1 file changed, 72 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index cffd60c75c..228e24b0ae 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index de449d89fb..cffd60c75c 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -4487,6 +4487,17 @@
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 1d371a5832..de449d89fb 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -4487,6 +4487,13 @@
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 178 +
1 file changed, 178 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 784622985c..1d371a5832 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index c8aad6a0bb..784622985c 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -4302,6 +4302,15 @@
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 290 +
1 file changed, 290 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index aae9875194..c8aad6a0bb 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Ilias Stamatis (6):
test_driver: implement virDomainAttachDeviceFlags
test_driver: implement virDomainAttachDevice
test_driver: implement virDomainDetachDeviceFlags
test_driver: implement virDomainDetachDevice
test_driver: implement virDomainDetachDeviceAlias
test_driver: implement
On Thu, Aug 01, 2019 at 01:44:06AM -0400, Pankaj Gupta wrote:
>
> Hi all,
>
> Virtio-pmem support has been added to kernel[1] and qemu[2]
> upstream. User document[3] has more details on how to use this
> new device.
>
> We now need support in libvirt. Required support would be a subset
> of
On 8/1/19 8:43 AM, Eric Blake wrote:
On 8/1/19 6:30 AM, Eric Blake wrote:
On 7/31/19 4:58 PM, Daniel Henrique Barboza wrote:
There is a chance that the current sed filtering used in
these new tests might fail in some machines due to the
repetition of the 'virsh #' prompt at the same line,
Hi all,
Virtio-pmem support has been added to kernel[1] and qemu[2]
upstream. User document[3] has more details on how to use this
new device.
We now need support in libvirt. Required support would be a subset
of features already implemented for emulated nvdimm. We will use
new
On 8/1/19 6:30 AM, Eric Blake wrote:
> On 7/31/19 4:58 PM, Daniel Henrique Barboza wrote:
>> There is a chance that the current sed filtering used in
>> these new tests might fail in some machines due to the
>> repetition of the 'virsh #' prompt at the same line,
>> together with valid output that
On 7/31/19 4:58 PM, Daniel Henrique Barboza wrote:
> There is a chance that the current sed filtering used in
> these new tests might fail in some machines due to the
> repetition of the 'virsh #' prompt at the same line,
> together with valid output that shouldn't be filtered.
Ah, so it is a
On Wed, Jul 31, 2019 at 06:18:00PM +, Jim Fehlig wrote:
> The xencommons service provides all the essential services such as
> xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so
> libvirtd should be started after xencommons.
>
> The xendomains service uses Xen's xl tool to
Hi
On Wed, Jun 5, 2019 at 2:32 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series of patches adds support for running virtio GPUs in
> seperate processes, thanks to vhost-user backend.
>
> The QEMU support landed for 4.1. There are several benefits of running
> the GPU/virgl in an
On Wed, 2019-07-31 at 17:58 +, Jim Fehlig wrote:
> +
> +
> + qemu: Add support for overriding max threads per process limit
> +
> +
> + systemd-based systems impose a limit on the number of threads a
> + process can spawn, which in some
47 matches
Mail list logo
