[libvirt] [PATCH v3 1/5] cpu_x86: add Edx to KVM_FEATURE_DEF()

2019-08-05 Thread Vitaly Kuznetsov
Some Hyper-V features (like the upcoming Direct Synthetic timers) are announced by feature bits in Edx but KVM_FEATURE_DEF() supports only Eax. Signed-off-by: Vitaly Kuznetsov --- src/cpu/cpu_x86.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[libvirt] [PATCH v3 0/5] Add support for Direct Mode for Hyper-V Synthetic timers

2019-08-05 Thread Vitaly Kuznetsov
Changes since v2: - Post 5.6.0 rebase, patches 1-3 are dropped as they were already merged. Original description: QEMU-4.1 will bring us Direct Mode for Hyper-V Synthetic timers support, we need to support it in libvirt too. As this is not a new enlightenment but rather an enhancement of an exist

[libvirt] [PATCH v3 4/5] qemu: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-05 Thread Vitaly Kuznetsov
QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as normal interrupts (and not VMBus messages). This is used by Hyper-V on KVM. Signed-off-by: Vitaly Kuznetsov --- src/qemu/qemu_

[libvirt] [PATCH v3 2/5] conf: change the way how Hyper-V features are printed out

2019-08-05 Thread Vitaly Kuznetsov
Current code doesn't allow us to add sub-features as we always print the closing '/>'. As a preparatory change to implementing 'direct' sub-feature for 'stimer' feature switch to printing closing tag individually. No functional change. Signed-off-by: Vitaly Kuznetsov --- src/conf/domain_conf.c

[libvirt] [PATCH v3 3/5] conf: add support for Direct Mode for Hyper-V Synthetic timers

2019-08-05 Thread Vitaly Kuznetsov
Support 'Direct Mode' for Hyper-V Synthetic Timers in domain config. Make it 'stimer' enlightenment option as it is not a separate thing. Signed-off-by: Vitaly Kuznetsov --- docs/formatdomain.html.in | 10 +++--- docs/schemas/domaincommon.rng | 16 - src/conf/domain_conf.c| 6

[libvirt] [PATCH v3 5/5] news: mention Direct Mode for Hyper-V Synthetic timers support

2019-08-05 Thread Vitaly Kuznetsov
The QEMU driver now supports Direct Mode for Hyper-V Synthetic timers for Hyper-V guests. Signed-off-by: Vitaly Kuznetsov --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a4d727b9c5..d63fca3b48 100644 --- a/docs/news.xml +++ b/doc

Re: [libvirt] [PATCH] daemon: improve Xen support in systemd service

2019-08-05 Thread Jim Fehlig
On 8/1/19 3:36 AM, Daniel P. Berrangé wrote: > On Wed, Jul 31, 2019 at 06:18:00PM +, Jim Fehlig wrote: >> The xencommons service provides all the essential services such as >> xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so >> libvirtd should be started after xencommons. >> >

Re: [libvirt] [PATCH] tools: console: Use proper constructor

2019-08-05 Thread Michal Prívozník
On 8/5/19 6:03 PM, Roman Bolshakov wrote: > "virsh console" on macOS cannot attach to a domain and it doesn't matter if > it's local or remote domain: > $ ~ virsh console vm > Connected to domain vm > Escape character is ^] > error: internal error: unable to wait on console condition > > T

[libvirt] [PATCH] news.xml: Restore blank news example

2019-08-05 Thread Michal Privoznik
In v5.6.0-rc1~347 I've mistakenly messed up news.xml as the change I wanted to promote was added into a comment (I blame git rebase for that). Anyway, restore the original state of the comment so it can be copied again. Signed-off-by: Michal Privoznik --- Pushed under trivial rule. docs/news.x

[libvirt] Release of libvirt-5.6.0

2019-08-05 Thread Daniel Veillard
It's out ! Tagged in git and with signed tarball and source rpm at the usual place: https://libvirt.org/sources/ I also released the 5.6.0 python bindings for the release that can be found at: https://libvirt.org/sources/python/ This release includes a number of new features, notably

[libvirt] [PATCH] maint: Post-release version bump to 5.7.0

2019-08-05 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- Pushed under trivial rule. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d18d427695..109827b89c 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@

[libvirt] [PATCH 3/5] qemu_firmware: Extend qemuFirmwareGetSupported to return FW paths

2019-08-05 Thread Michal Privoznik
The qemuFirmwareGetSupported() function is called from qemu driver to generate domain capabilities XML based on FW descriptor files. However, the function currently reports only some features from domcapabilities XML and not actual FW image paths. The paths reported in the domcapabilities XML still

[libvirt] [PATCH 4/5] qemufirmwaretest: Test FW path getting through qemuFirmwareGetSupported()

2019-08-05 Thread Michal Privoznik
There is one hack hidden here, but since this is in a test, it's okay. In order to get a list of expected firmwares in virFirmwarePtr form I'm using virFirmwareParseList(). But usually, in real life scenario, this function is used only to parse a list of UEFI images which have NVRAM split out. In o

[libvirt] [PATCH 1/5] virfirmware: Expose and define autoptr for virFirmwareFree

2019-08-05 Thread Michal Privoznik
This function frees a _virFirmware struct. So far, it doesn't need to be called from outside of the module, but this will change shortly. In the light of recent VIR_DEFINE_AUTOPTR_FUNC() additions, do the same to virFirmwareFree(). Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1

[libvirt] [PATCH 2/5] qemu_firmware: Document qemuFirmwareGetSupported

2019-08-05 Thread Michal Privoznik
This function is going to get some new arguments. Document the current ones for clarity. Signed-off-by: Michal Privoznik --- src/qemu/qemu_firmware.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index bf29b10b9a..8fb

[libvirt] [PATCH 0/5] qemu: Use FW descriptors to report FW image paths

2019-08-05 Thread Michal Privoznik
It feels a bit odd to report a built in list of FW images when we have FW descriptor files. Especially, when some weird architectures are concerned. For instance, OVMF_CODE.fd is reported even for non-x86_64/non-i386 arches, like ppc. But if FW descriptor files are taken into the picture then no OV

[libvirt] [PATCH 5/5] qemu: Use FW descriptors to report FW image paths

2019-08-05 Thread Michal Privoznik
Now that we have qemuFirmwareGetSupported() so that it also returns a list of FW image paths, we can use it to report them in domain capabilities instead of the old time default list. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1733940 Signed-off-by: Michal Privoznik --- src/qemu/qemu

[libvirt] [PATCH] tools: console: Use proper constructor

2019-08-05 Thread Roman Bolshakov
"virsh console" on macOS cannot attach to a domain and it doesn't matter if it's local or remote domain: $ ~ virsh console vm Connected to domain vm Escape character is ^] error: internal error: unable to wait on console condition The error comes from pthread_cond_wait that fails with EINV

Re: [libvirt] [PATCH] qemu: support bootindex on vfio-ccw mdev device

2019-08-05 Thread Boris Fiuczynski
On 8/2/19 3:30 PM, Peter Krempa wrote: On Fri, Aug 02, 2019 at 15:15:59 +0200, Boris Fiuczynski wrote: Add support to specify a boot order on vfio-ccw passthrough devices. Signed-off-by: Boris Fiuczynski Acked-by: Jason J. Herne Reviewed-by: Marc Hartmayer --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH 4/4] tests: Add separate tests for 'xres' and 'yres'

2019-08-05 Thread Ján Tomko
On Sun, Aug 04, 2019 at 10:21:21PM -0300, jcfara...@gmail.com wrote: From: Julio Faracco New tests to verify resolution properties of a simple qxl video. Signed-off-by: Julio Faracco --- .../video-qxl-resolution.args | 32 +++ xml->argv test should be introduced a

Re: [libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 12:30:48PM +0200, Ján Tomko wrote: > On Mon, Aug 05, 2019 at 08:43:14AM +0200, Erik Skultety wrote: > > On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfara...@gmail.com wrote: > > > From: Julio Faracco > > > > > > Now, QEMU command line can define 'xres' and 'yres' if XML cont

Re: [libvirt] [PATCH 2/4] conf: Adding XML support for 'xres' and 'yres'

2019-08-05 Thread Ján Tomko
On Mon, Aug 05, 2019 at 12:39:58PM +0200, Ján Tomko wrote: On Sun, Aug 04, 2019 at 10:21:19PM -0300, jcfara...@gmail.com wrote: From: Julio Faracco XML need to support both properties together. This commit adds XML support for QXL model if they are set. Domain configuration is able to The co

Re: [libvirt] [PATCH 0/4] Adding resolution properties for QXL device

2019-08-05 Thread Gerd Hoffmann
On Mon, Aug 05, 2019 at 11:17:35AM +0200, Erik Skultety wrote: > On Mon, Aug 05, 2019 at 09:12:26AM +0200, Gerd Hoffmann wrote: > > On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfara...@gmail.com wrote: > > > From: Julio Faracco > > > > > > This serie adds 'xres' and 'yres' properties into XML defin

Re: [libvirt] [PATCH 2/4] conf: Adding XML support for 'xres' and 'yres'

2019-08-05 Thread Ján Tomko
On Sun, Aug 04, 2019 at 10:21:19PM -0300, jcfara...@gmail.com wrote: From: Julio Faracco XML need to support both properties together. This commit adds XML support for QXL model if they are set. Domain configuration is able to The commit message should show an example of the XML that is being

Re: [libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

2019-08-05 Thread Ján Tomko
On Mon, Aug 05, 2019 at 08:43:14AM +0200, Erik Skultety wrote: On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfara...@gmail.com wrote: From: Julio Faracco Now, QEMU command line can define 'xres' and 'yres' if XML contains both properties from qxl model. Signed-off-by: Julio Faracco --- src/qe

Re: [libvirt] [PATCH 0/4] Adding resolution properties for QXL device

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 09:12:26AM +0200, Gerd Hoffmann wrote: > On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfara...@gmail.com wrote: > > From: Julio Faracco > > > > This serie adds 'xres' and 'yres' properties into XML definition for QXL > > video device to specify a default resolution. This seri

Re: [libvirt] [PATCH 0/2] test_driver: implement the remaining virDomainCreate APIs

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 11:02:21AM +0200, Ilias Stamatis wrote: > Ilias Stamatis (2): > test_driver: implement virDomainCreateWithFiles > test_driver: implement virDomainCreateXMLWithFile > > src/test/test_driver.c | 23 +++ > 1 file changed, 23 insertions(+) Reviewed-by:

Re: [libvirt] [PATCH] libxl: Implement domain metadata getter/setter

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 10:53:33AM +0200, Michal Privoznik wrote: > Fortunately, the code that handles metadata getting or setting is > driver agnostic, so all that is needed from individual hypervisor > drivers is to call the right functions. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?

[libvirt] [PATCH 1/2] test_driver: implement virDomainCreateWithFiles

2019-08-05 Thread Ilias Stamatis
This should just forward the call to testDomainCreateWithFlags since we can't do anything with the provided file descriptors in the test driver. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/test/test_driver.c b/src/

[libvirt] [PATCH 2/2] test_driver: implement virDomainCreateXMLWithFile

2019-08-05 Thread Ilias Stamatis
This should just forward the call to testDomainCreateXML since we can't do anything with the provided file descriptors in the test driver. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test/

[libvirt] [PATCH 0/2] test_driver: implement the remaining virDomainCreate APIs

2019-08-05 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainCreateWithFiles test_driver: implement virDomainCreateXMLWithFile src/test/test_driver.c | 23 +++ 1 file changed, 23 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

[libvirt] [PATCH] libxl: Implement domain metadata getter/setter

2019-08-05 Thread Michal Privoznik
Fortunately, the code that handles metadata getting or setting is driver agnostic, so all that is needed from individual hypervisor drivers is to call the right functions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1732306 Signed-off-by: Michal Privoznik --- src/libxl/libxl_driver.c

Re: [libvirt] [PATCH 0/4] Adding resolution properties for QXL device

2019-08-05 Thread Gerd Hoffmann
On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfara...@gmail.com wrote: > From: Julio Faracco > > This serie adds 'xres' and 'yres' properties into XML definition for QXL > video device to specify a default resolution. This serie covers a simple > test case too. Why limit this to qxl? virtio and s