Signed-off-by: Ilias Stamatis
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 102 +
1 file changed, 102 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 2b5376ec28..14b7d683e1 100755
--- a/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 259 +
1 file changed, 259 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 14b7d683e1..009bc18a73 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Ilias Stamatis (2):
test_driver: implement testDomainGetBlockIoTune
test_driver: implement virDomainSetBlockIoTune
src/test/test_driver.c | 361 +
1 file changed, 361 insertions(+)
--
2.22.0
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, Aug 08, 2019 at 03:00:27PM -0300, Daniel Henrique Barboza wrote:
> (CCing Nikolay Shirokovskiy, author of 29f2b5248c )
>
> On 8/7/19 8:34 AM, Roman Bolshakov wrote:
> > An attempt to poweroff a VM from inside triggers the error for existing
> > session of virsh console and it returns
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 8bd5a5296b..211c0d737a 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -7624,6
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 40
1 file changed, 40 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 211c0d737a..a127dc69c1 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@
The managedSave APIs according to the documentation are supposed to
operate on a disk file. However, this might not be appropriate in the
case of the test driver since:
* It's better if the test driver keeps all its state in memory only and
doesn't affect the host in any way.
* The test driver,
Ilias Stamatis (3):
test_driver: use domain-private data to store managed image
test_driver: implement virDomainManagedSaveGetXMLDesc
test_driver: implement virDomainManagedSaveDefineXML
src/test/test_driver.c | 93 +-
1 file changed, 92
The nwfilter XML configs are not merely examples, they are data that is
actively shipped and used in production by users.
Signed-off-by: Daniel P. Berrangé
---
examples/Makefile.am | 10 --
src/nwfilter/Makefile.inc.am | 8
From: Wim ten Have
Update the KVM feature tests for QEMU's kvm-hint-dedicated
performance hint.
Signed-off-by: Wim ten Have
Signed-off-by: Menno Lageman
---
tests/qemuxml2argvdata/kvm-features-off.xml | 1 +
tests/qemuxml2argvdata/kvm-features.args | 4 ++--
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
This patch adds a new KVM feature 'hint-dedicated' to set this performance
hint for KVM guests.
Wim ten Have (2):
qemu: support for kvm-hint-dedicated
From: Wim ten Have
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
This patch adds a new KVM feature 'hint-dedicated' to set this performance
hint for KVM guests. The feature is off by default.
To enable
In particular, switch to using canonical 'hv-feature' syntax instead of
'hv_feature' aliases.
Suggested-by: Ján Tomko ~
Signed-off-by: Vitaly Kuznetsov
---
tests/qemuxml2argvdata/hyperv-off.args| 27 ---
.../hyperv-off.x86_64-latest.args | 32 +
QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers
(hv-stimer-direct CPU flag): Windows guests can request that timer
expiration notifications are delivered as normal interrupts (and not
VMBus messages). This is used by Hyper-V on KVM.
Signed-off-by: Vitaly Kuznetsov
---
Changes since v3 [Ján Tomko]:
- Drop already merged patches.
- add "tests: qemuxml2argv: switch to DO_TEST_CAPS_LATEST for Hyper-V
tests" patch (hope I got the idea correctly).
- add hyperv-stimer-direct test to qemuxml2xml/qemuxml2argv tests.
- use VIR_CPU_x86_HV_STIMER_DIRECT instead of
Support 'Direct Mode' for Hyper-V Synthetic Timers in domain config.
Make it 'stimer' enlightenment option as it is not a separate thing.
Reviewed-by: Ján Tomko
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 10 +++---
docs/schemas/domaincommon.rng | 16 -
The QEMU driver now supports Direct Mode for Hyper-V Synthetic timers
for Hyper-V guests.
Reviewed-by: Ján Tomko
Signed-off-by: Vitaly Kuznetsov
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index a4d727b9c5..d63fca3b48 100644
---
On 8/9/19 9:02 AM, Jiri Denemark wrote:
> On Wed, Jul 31, 2019 at 14:52:17 -0500, Eric Blake wrote:
>> On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
>>> Max,
>>>
>>> Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
>>> failing, but they are also failing on master, thus I say
On Fri, 2019-08-09 at 10:35 +0200, Andrea Bolognani wrote:
>
> Andrea Bolognani (4):
> refresh: Get rid of self.project_name
> refresh: Improve project handling
> refresh: Look for project with startswith()
> refresh: Update comments
>
> refresh | 44
On Wed, Jul 31, 2019 at 14:52:17 -0500, Eric Blake wrote:
> On 7/31/19 2:45 PM, Daniel Henrique Barboza wrote:
> > Max,
> >
> > Code looks ok. Two tests (virsh-checkpoint and virsh-snapshot) are
> > failing, but they are also failing on master, thus I say this patch get a
> > pass because it
On Tue, Jul 23, 2019 at 16:47:05 -0300, Maxiwell S. Garcia wrote:
> The snapshot-create operation of running guests saves the live
> XML and uses it to replace the active and inactive domain in
> case of revert. So, the config XML is ignored by the snapshot
> process. This commit changes it and
On 8/8/19 4:26 PM, Maxiwell S. Garcia wrote:
QEMU shows a warning message if partial NUMA mapping is set. This patch
adds a warning message in libvirt when editing the XML. It must be an
error in future, when QEMU remove this ability.
Signed-off-by: Maxiwell S. Garcia
---
Ján Tomko writes:
> Either leave this as-is and add the new feature in a separate test,
> or you can branch the test based on QEMU versions like we do for other
> features:
>
> DO_TEST_CAPS_VER("pv-spinlock-disabled", "2.7.0");
> DO_TEST_CAPS_VER("pv-spinlock-disabled", "4.0.0");
>
On 8/9/19 8:29 AM, Han Han wrote:
Signed-off-by: Han Han
---
src/libvirt-admin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Ah, good catch. There are some other APIs that don't log all the
arguments. I'm adding them into this patch, changing the commit message
a big, ACKing
On Fri, Aug 02, 2019 at 11:51:05AM +0200, Ilias Stamatis wrote:
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 58 ++
> 1 file changed, 58 insertions(+)
>
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index
On Fri, Aug 09, 2019 at 04:23:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Since its introduction in commit
> 8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
> "2.0" and not "2".
>
> Signed-off-by: Marc-André Lureau
> ---
The html docs agrees
On 8/9/19 2:23 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Since its introduction in commit
8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
"2.0" and not "2".
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2
From: Marc-André Lureau
Since its introduction in commit
8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
"2.0" and not "2".
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 8/8/19 4:26 PM, Jiri Denemark wrote:
Since qemuDomain{Device,}DefPostParse callbacks require qemuCaps, we
need to make sure they get the capabilities stored in the domain's
private data if the domain is running. Passing NULL may cause QEMU
capabilities probing to be triggered in case the
On 8/8/19 6:12 PM, Jiri Denemark wrote:
This reverts commit f38d553e2d6ec2f041cb7947b5eafcdd3b26ae65.
Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
is not a 1-1 replacement for the original configure option. Our old
--enable-test-coverage seems to be close to gnulib's
Hi
On Fri, Aug 9, 2019 at 2:15 PM Ján Tomko wrote:
>
> Redefining a domain via virDomainDefineXML should not give different results
> based on an already existing definition.
>
> Also, there's a crasher somewhere in the code:
> https://bugzilla.redhat.com/show_bug.cgi?id=1739338
>
> This reverts
On Fri, Aug 09, 2019 at 12:15:43 +0200, Ján Tomko wrote:
> Redefining a domain via virDomainDefineXML should not give different results
> based on an already existing definition.
>
> Also, there's a crasher somewhere in the code:
> https://bugzilla.redhat.com/show_bug.cgi?id=1739338
>
> This
On Fri, Aug 09, 2019 at 12:13:45PM +0200, Vitaly Kuznetsov wrote:
Ján Tomko writes:
One more thing, qemuxml2argvtest is using DO_TEST:
DO_TEST("hyperv", NONE);
DO_TEST("hyperv-off", NONE);
DO_TEST("hyperv-panic", NONE);
which manually enumarate the used QEMU capabilities (although
On 8/9/19 11:04 AM, Daniel P. Berrangé wrote:
On Fri, Aug 09, 2019 at 10:49:11AM +0200, Michal Privoznik wrote:
If yajl_parse() fails, we try to print an error message. For
that, yajl_get_error() is used. However, its documentation say
that caller is also responsible for freeing the memory it
Redefining a domain via virDomainDefineXML should not give different results
based on an already existing definition.
Also, there's a crasher somewhere in the code:
https://bugzilla.redhat.com/show_bug.cgi?id=1739338
This reverts commit 94b3aa55f83ada33a9fdda66068d58ef1a56c0a5
---
Ján Tomko writes:
> One more thing, qemuxml2argvtest is using DO_TEST:
> DO_TEST("hyperv", NONE);
> DO_TEST("hyperv-off", NONE);
> DO_TEST("hyperv-panic", NONE);
> which manually enumarate the used QEMU capabilities (although there are
> none here)
>
> DO_TEST_CAPS_LATEST is the way
On Fri, Aug 09, 2019 at 10:49:11AM +0200, Michal Privoznik wrote:
> If yajl_parse() fails, we try to print an error message. For
> that, yajl_get_error() is used. However, its documentation say
> that caller is also responsible for freeing the memory it
> allocates by using yajl_free_error().
>
>
On Fri, Aug 09, 2019 at 10:49:10AM +0200, Michal Privoznik wrote:
> The NSS module has a compile time option which when enabled makes
> ERROR() and DEBUG() print messages onto stderr. But now that the
> module no longer links with libvirt, we need to include stdio.h
> and define NULLSTR().
>
>
On Fri, Aug 09, 2019 at 10:49:09AM +0200, Michal Privoznik wrote:
> Due to latest rewrite of NSS module, we are doing yajl parsing
> ourselves. This means, we had to introduce couple of callback
> that yajl calls. According to its documentation, a callback can
> cancel parsing if it returns a zero
On Fri, Aug 02, 2019 at 14:54:15 +0200, Paolo Bonzini wrote:
> host-passthrough documentation menions that the source and destination
> hosts are not identical in both hardware and configuration. Configuration
> actually includes microcode version and QEMU version, but this is not
> clear so make
On Wed, Aug 07, 2019 at 06:56:35PM +0200, Ilias Stamatis wrote:
> The managedSave APIs according to the documentation are supposed to
> operate on a disk file. However, this might not be appropriate in the
> case of the test driver since:
>
> * It's better if the test driver keeps all its state in
If yajl_parse() fails, we try to print an error message. For
that, yajl_get_error() is used. However, its documentation say
that caller is also responsible for freeing the memory it
allocates by using yajl_free_error().
Signed-off-by: Michal Privoznik
---
tools/nss/libvirt_nss_leases.c | 7
Due to latest rewrite of NSS module, we are doing yajl parsing
ourselves. This means, we had to introduce couple of callback
that yajl calls. According to its documentation, a callback can
cancel parsing if it returns a zero value. Well, we do just that
in the string callback
The NSS module has a compile time option which when enabled makes
ERROR() and DEBUG() print messages onto stderr. But now that the
module no longer links with libvirt, we need to include stdio.h
and define NULLSTR().
Signed-off-by: Michal Privoznik
---
tools/nss/libvirt_nss.h | 2 ++
1 file
Haven't spotted it during review of Dan's patches.
Long story short, if there's an unexpected key in JSON parsing stops.
But in general a key is hot harmful and shouldn't cause parser to stop.
See 1/3 for more explanation.
Michal Prívozník (3):
nss: Don't stop parsing on unexpected key
nss:
Andrea Bolognani (4):
refresh: Get rid of self.project_name
refresh: Improve project handling
refresh: Look for project with startswith()
refresh: Update comments
refresh | 44 +++-
1 file changed, 23 insertions(+), 21 deletions(-)
--
2.21.0
Instead of adding native projects first and then coming back
to add MinGW projects at a later time, add all projects in a
single step.
Signed-off-by: Andrea Bolognani
---
refresh | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/refresh b/refresh
index
This reverts some of the changes made by 7130ffe0a0e9, which
is okay because they were not entirely accurate: by the time
we start looking for CROSS, we have already removed the project
name from the stem, so the OS name is indeed the first thing
you'll find there.
Signed-off-by: Andrea Bolognani
Using rfind() makes sense when we're looking for CROSS, since
we don't know exactly where it will be, but when looking for
the project we know it will be at the very beginning of the
string so we should check accordingly.
Signed-off-by: Andrea Bolognani
---
refresh | 4 ++--
1 file changed, 2
We don't need to access it from anywhere else, so it can be
a local variable instead of an object property.
Signed-off-by: Andrea Bolognani
---
refresh | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/refresh b/refresh
index 8f99042..89c2818 100755
--- a/refresh
+++
On Thu, Aug 08, 2019 at 12:30:24PM +0200, Ilias Stamatis wrote:
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 40
> 1 file changed, 40 insertions(+)
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On 8/8/19 6:54 PM, Jonathon Jongsma wrote:
Series looks good to me, though you may want to wait for somebody with
more experience to properly ack it.
Reviewed-by: Jonathon Jongsma
That's okay. I've taken your R-b and pushed it. These are simple enough
so if there was any problem, it would
Signed-off-by: Han Han
---
src/libvirt-admin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index 4ae50b188f..cf40ea122e 100644
--- a/src/libvirt-admin.c
+++ b/src/libvirt-admin.c
@@ -1236,7 +1236,7 @@
53 matches
Mail list logo
