The comment I have here is that you're changing virConsoleShutdown
API for all callers, with this new boolean value 'needAbort', because of a
scenario (virStreamRecv being called before) that happens only on
virConsoleEventOnStream.
This is what I wondered in the review of the previous version
On Mon, Aug 12, 2019 at 14:15:22 -0400, Stefan Berger wrote:
> On 8/12/19 2:11 PM, Peter Krempa wrote:
> > On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote:
> > > On 8/9/19 6:15 AM, Ján Tomko wrote:
> > > > Redefining a domain via virDomainDefineXML should not give different
> > > >
On 8/12/19 2:11 PM, Peter Krempa wrote:
On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote:
On 8/9/19 6:15 AM, Ján Tomko wrote:
Redefining a domain via virDomainDefineXML should not give different results
based on an already existing definition.
I added this patch so that users
On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote:
> On 8/9/19 6:15 AM, Ján Tomko wrote:
> > Redefining a domain via virDomainDefineXML should not give different results
> > based on an already existing definition.
>
>
> I added this patch so that users don't try to change a VM from
On 8/9/19 6:15 AM, Ján Tomko wrote:
Redefining a domain via virDomainDefineXML should not give different results
based on an already existing definition.
I added this patch so that users don't try to change a VM from encrypted
to unencrypted on the level of the domain XML and assume it will
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 85 ++
1 file changed, 85 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 7eef54bb05..6274d5bf0f 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 74 ++
1 file changed, 74 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 60d611245d..7eef54bb05 100755
--- a/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index b4a883cb54..60d611245d 100755
--- a/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 85 ++
1 file changed, 85 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 7acde811ef..b4a883cb54 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 67 ++
src/test/test_driver.h | 11 +++
2 files changed, 78 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 5f5c512571..7acde811ef 100755
---
Changes since v1:
- Use vm-private data for storing iothread parameters and implement
virDomainSetIOThreadParams
Ilias Stamatis (5):
test_driver: implement virDomainAddIOThread
test_driver: implement virDomainDelIOThread
test_driver: implement virDomainPinIOThread
test_driver: implement
Since commit 'b66ca0220a' the 'tpm-emulator' tests in qemuxml2xmltest
started to fail unless 'make check' is either executed as root
or with an user with access to /etc/qemu/firmware file. This is the
error that happens in a regular 'make check' run with an unprivileged
user:
--
546) QEMU
On Mon, 2019-08-12 at 16:04 +0200, Michal Privoznik wrote:
> On 7/25/19 4:06 PM, Andrea Bolognani wrote:
> > This series is RFC because the corresponding QEMU patches[1] have
> > not been merged yet, and since QEMU is currently in the middle of
> > the 4.1.0 freeze we can't really expect to merge
Since libvirt-dockerfile's commit 7130ffe0a0e9, the containers
used for CI builds have been renamed from buildenv-* to
buildenv-libvirt-* in order to make it possible for projects
other than libvirt to be supported, so we need to update our
Makefile.ci scaffolding accordingly.
Signed-off-by:
On 7/25/19 4:06 PM, Andrea Bolognani wrote:
This series is RFC because the corresponding QEMU patches[1] have
not been merged yet, and since QEMU is currently in the middle of
the 4.1.0 freeze we can't really expect to merge them until 5.7.0
anyway.
With that in mind, a few patches are somewhat
Signed-off-by: Andrea Bolognani
---
guests/quayadmin | 38 ++
1 file changed, 38 insertions(+)
diff --git a/guests/quayadmin b/guests/quayadmin
index 02be0f4..8099d6a 100755
--- a/guests/quayadmin
+++ b/guests/quayadmin
@@ -318,6 +318,29 @@ def
Once [1] has been merged, we'll be able to conveniently cause
container images to be rebuilt without having to define custom
triggers.
[1] https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html
Andrea Bolognani (2):
quayadmin: Fix endpoints
quayadmin: Add create-build command
Some of the endpoints for the Quay API are documented[1] as
ending with a slash, and as it turns out the slash being there
is actually critical to proper operation: if you leave it out,
some APIs will behave on POST as if you had performed a GET,
which is extremely confusing and not at all what we
On Thu, Aug 08, 2019 at 06:00:39PM +0200, Peter Krempa wrote:
Rather than copying just the top level image, let's copy the full user
provided backing chain.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
On Thu, Aug 08, 2019 at 06:00:38PM +0200, Peter Krempa wrote:
The only code path which calls the parser with the
VIR_DOMAIN_DEF_PARSE_DISK_SOURCE is from qemuDomainBlockCopy. Since that
code path can properly handle backing chains for the disk and it's
desired to pass the parsed chains to the
On Thu, Aug 08, 2019 at 06:00:37PM +0200, Peter Krempa wrote:
In commit 3f93884a4d0 where the job handling of commit jobs with
blockdev was added I've forgot to add a 'break' in the switch fomatting
the status XML. Thankfully this would not be a problem as the cases
where this fell through
On Thu, Aug 08, 2019 at 06:00:36PM +0200, Peter Krempa wrote:
The utility of the function is extremely limited as for block copy
we need to register the mirror chain earlier than when it's set with the
disk. This means that it would be open-coded in that case.
Avoid any weird usage and just
On Thu, Aug 08, 2019 at 06:00:35PM +0200, Peter Krempa wrote:
Add virStorageFileSupportsCreate which allows silent check whether
virStorageFileCreate is implemented.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virstoragefile.c | 20
On Thu, Aug 08, 2019 at 06:00:34PM +0200, Peter Krempa wrote:
Modify the return value so that callers don't have to repeat logic.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
On Thu, Aug 08, 2019 at 06:00:33PM +0200, Peter Krempa wrote:
Commit 16ca234b56fac82 refactored how the 'shallow' and 'reuse' flags
are accessed but neglected to fix the clearing of 'shallow' in case when
the disk has no backing chain. This means that we'd request a shallow
copy even without
On Thu, Aug 08, 2019 at 06:00:32PM +0200, Peter Krempa wrote:
Allow reusing original backing chain when doing a shallow copy without
reuse of external image. The existing logic didn't allow it but it will
be possible. Also add a note to explain that logic.
Signed-off-by: Peter Krempa
---
On 8/12/19 2:30 PM, Menno Lageman wrote:
v2 of:
https://www.redhat.com/archives/libvir-list/2019-August/msg00363.html
diff to v1:
- reword description in documentation
- move check for valid domain config to qemuDomainDefValidate
Wim ten Have (2):
qemu: support for kvm-hint-dedicated
On Thu, Aug 08, 2019 at 06:00:31PM +0200, Peter Krempa wrote:
Rename qemuDomainObjPrivateXMLFormatBlockjobFormatChain to
qemuDomainObjPrivateXMLFormatBlockjobFormatSource and add a 'chain'
parameter which allows controlling whether the backing chain is
formatted.
Signed-off-by: Peter Krempa
From: Wim ten Have
Update the KVM feature tests for QEMU's kvm-hint-dedicated
performance hint.
Signed-off-by: Wim ten Have
Signed-off-by: Menno Lageman
---
tests/qemuxml2argvdata/kvm-features-off.xml | 1 +
tests/qemuxml2argvdata/kvm-features.args | 4 ++--
v2 of:
https://www.redhat.com/archives/libvir-list/2019-August/msg00363.html
diff to v1:
- reword description in documentation
- move check for valid domain config to qemuDomainDefValidate
Wim ten Have (2):
qemu: support for kvm-hint-dedicated performance hint
tests: add tests for
From: Wim ten Have
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
This patch adds a new KVM feature 'hint-dedicated' to set this performance
hint for KVM guests. The feature is off by default.
To enable
Signed-off-by: Andrea Bolognani
---
buildenv-libosinfo-centos-7.zip | Bin 0 -> 458 bytes
buildenv-libosinfo-debian-10-cross-aarch64.zip | Bin 0 -> 683 bytes
buildenv-libosinfo-debian-10-cross-armv6l.zip| Bin 0 -> 682 bytes
buildenv-libosinfo-debian-10-cross-armv7l.zip
See commit 1/3 for more information.
Andrea Bolognani (3):
refresh: Generate archived Dockerfiles
Remove plain Dockerfiles
Add archived Dockerfiles
.gitignore| 1 +
buildenv-libosinfo-centos-7.Dockerfile| 43 ---
We need this so that we can perform Quay builds without going
through a build trigger.
Once we start generating Dockerfiles this way, each refresh will
result in a bunch of binary files being modified, which is not
very nice to humans following along at home.
Thankfully, there is a way the issue
Hi Guys,
And I want to add the vhost-user-scsi-pci/vhost-user-blk-pci support
for libvirt.
The usage in qemu like this:
Vhost-SCSI
-chardev socket,id=char0,path=/var/tmp/vhost.0
-device vhost-user-scsi-pci,id=scsi0,chardev=char0
Vhost-BLK
-chardev socket,id=char1,path=/var/tmp/vhost.1
-device
If a libvirt error occurred during a test, then virTestRun()
reports it (regardless of test returning success or failure).
For instance, in this specific case, a hostdev is detached twice
and the second attempt is expected to fail. It does fail and
libvirt error is reported which is then printed
From: Michal Privoznik
There are few functions called from the test which return an
integer but their retval is compared as if it was a pointer.
Now, there is nothing wrong with that from machine POV, but
from readability perspective it's wrong.
Signed-off-by: Michal Privoznik
---
From: Michal Privoznik
There's no need to have VIR_DEBUG() really.
Signed-off-by: Michal Privoznik
---
tests/virhostdevtest.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c
index
If a test fails, it's stderr is caught in the logs. That's how
our CI works. But virReportError() is not.
Signed-off-by: Michal Privoznik
---
tests/virhostdevtest.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c
index
From: Michal Privoznik
The virTestRun() already reports the same.
Signed-off-by: Michal Privoznik
---
tests/virhostdevtest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c
index 713e0ff9a6..f6ea4c54fd 100644
--- a/tests/virhostdevtest.c
+++
Similarly to the previous commit, VIR_TEST_VERBOSE should put
'\n' at the end of each call so that the output is not broken.
Signed-off-by: Michal Privoznik
---
tests/cputest.c | 14 +++---
tests/qemublocktest.c| 10 ++---
tests/qemuhotplugtest.c | 10 ++---
From: Michal Privoznik
In this test there is this macro CHECK_LIST_COUNT() which checks
if a list of PCI devices contains expected count. If it doesn't
an error is reported and 'goto cleanup' is invoked. There's no
real reason for that as even since its introduction there is no
cleanup done and
Signed-off-by: Michal Privoznik
---
tests/virhashtest.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/virhashtest.c b/tests/virhashtest.c
index 95634eec80..2355e7bc63 100644
--- a/tests/virhashtest.c
+++ b/tests/virhashtest.c
@@ -47,9 +47,6 @@ testHashInit(int size)
}
There is an inconsistency with VIR_TEST_DEBUG() calls. One half
(roughly) of calls does have the newline character the other one
doesn't. Well, it doesn't have it because it assumed blindly that
new line will be printed, which is not the case.
Signed-off-by: Michal Privoznik
---
*** BLURB HERE ***
Michal Prívozník (9):
tests: Always put a '\n' after each debug print
tests: Always put '\n' at the end of VIR_TEST_VERBOSE
virhashtest: Drop useless new line
virhostdevtest: Check for integer retval in more verbose way
virhostdevtest: Drop most of 'cleanup' and 'out'
On 12-08-19 13:39, Michal Privoznik wrote:
On 8/12/19 1:18 PM, Menno Lageman wrote:
On 12-08-19 11:23, Michal Privoznik wrote:
On 8/9/19 5:19 PM, Menno Lageman wrote:
From: Wim ten Have
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add
On 8/12/19 1:18 PM, Menno Lageman wrote:
On 12-08-19 11:23, Michal Privoznik wrote:
On 8/9/19 5:19 PM, Menno Lageman wrote:
From: Wim ten Have
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
This patch
Regular VM shutdown triggers the error for existing session of virsh
console and it returns with non-zero exit code:
error: internal error: console stream EOF
The message and status code are misleading because there's no real
error. virStreamRecv returns 0 when the end of the stream is reached.
On 12-08-19 11:23, Michal Privoznik wrote:
On 8/9/19 5:19 PM, Menno Lageman wrote:
From: Wim ten Have
QEMU version 2.12.1 introduced a performance feature under commit
be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
This patch adds a new KVM feature 'hint-dedicated' to
On Thu, 2019-07-25 at 16:06 +0200, Andrea Bolognani wrote:
> This series is RFC because the corresponding QEMU patches[1] have
> not been merged yet, and since QEMU is currently in the middle of
> the 4.1.0 freeze we can't really expect to merge them until 5.7.0
> anyway.
>
> With that in mind, a
On Mon, Aug 12, 2019 at 11:33 AM Erik Skultety wrote:
>
> No need to CC me explicitly (especially for just a single patch of the
> series),
> all libvirt devs are subscribed to the list.
>
> Regards,
> Erik
I didn't do that intentionally. I think git send-email added you in
the CC list because
On 8/9/19 5:19 PM, Menno Lageman wrote:
> From: Wim ten Have
>
> QEMU version 2.12.1 introduced a performance feature under commit
> be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint")
>
> This patch adds a new KVM feature 'hint-dedicated' to set this performance
> hint for
On 8/9/19 5:19 PM, Menno Lageman wrote:
From: Wim ten Have
Update the KVM feature tests for QEMU's kvm-hint-dedicated
performance hint.
Signed-off-by: Wim ten Have
Signed-off-by: Menno Lageman
---
tests/qemuxml2argvdata/kvm-features-off.xml | 1 +
On Fri, Aug 09, 2019 at 09:53:00PM +0300, Ilias Stamatis wrote:
> Signed-off-by: Ilias Stamatis
> ---
> src/test/test_driver.c | 259 +
> 1 file changed, 259 insertions(+)
>
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index
No need to CC me explicitly (especially for just a single patch of the series),
all libvirt devs are subscribed to the list.
Regards,
Erik
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 8/11/19 10:59 PM, Laine Stump wrote:
Back in July 2010, commit 6ea90b84 (meant to resolve
https://bugzilla.redhat.com/571991 ) added code to set the MAC address
of any tap device to the associated guest interface's MAC, but with
the first byte replaced with 0xFE. This was done in order to
On Fri, Aug 09, 2019 at 04:46:43PM +0100, Daniel P. Berrangé wrote:
> The nwfilter XML configs are not merely examples, they are data that is
> actively shipped and used in production by users.
>
> Signed-off-by: Daniel P. Berrangé
> ---
You also want to squash the following:
diff --git
We don't include this information for any other library, and
having it there means there are two places we need to change
every time the required version is bumped.
configure will provide the user with a nice error message,
which includes the required version, if libxml2 found on the
system is
58 matches
Mail list logo
