Tested the patch series with a ppc64 guest, using upstream QEMU
in a Power8 host:
$ sudo ./run tools/virsh guestinfo qga-test
user.count : 1
user.0.name : danielhb
user.0.login-time : 1566588366375
os.id : ubuntu
os.name : Ubuntu
os.pretty-name :
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
The 'guestinfo' command uses the new virDomainGetGuestInfo() API to
query information about the specified domain and print it out for the
user. The output is modeled roughly on the 'domstats' command.
Signed-off-by: Jonathon Jongsma
---
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
Iimplements the new guest information API by querying requested
information via the guest agent.
Signed-off-by: Jonathon Jongsma
---
Reviewed-by: Daniel Henrique Barboza
Tested-by: Daniel Henrique Barboza
src/qemu/qemu_driver.c | 110
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
This function adds the complete filesystem information returned by the
qemu agent to an array of typed parameters with field names intended to
to be returned by virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
Tested-by: Daniel
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
Since version 3.0, qemu has returned disk usage statistics in
guest-get-fsinfo. And since 3.1, it has returned information about the
disk serial number and device node of disks that are targeted by the
filesystem.
Unfortunately, the public API
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
This function queries timezone information within the guest and adds
the information to an array of typed parameters with field names
intended to be returned to virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
I spotted two missing
Signed-off-by: Jim Fehlig
---
cfg.mk | 2 +-
configure.ac | 2 --
po/POTFILES | 6 ++---
src/Makefile.am | 1 -
src/libvirt_xenconfig.syms | 12 --
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
This function queries the guest operating system information and adds
the returned information to an array of typed parameters with field
names intended to be returned in virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
Reviewed-by:
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
This function fetches the list of logged-in users from the qemu agent
and adds them to a list of typed parameters so that they can be used
internally in libvirt.
Also add some basic tests for the function.
Signed-off-by: Jonathon Jongsma
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
Add daemon and client code to serialize/deserialize
virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
Reviewed-by: Daniel Henrique Barboza
Tested-by: Daniel Henrique Barboza
src/remote/remote_daemon_dispatch.c | 41
Flagged a couple of typos that can be fixed by the maintainer when
pushing upstream or by in a later version, if a new version is needed.
Aside for the typos, LGTM:
Reviewed-by: Daniel Henrique Barboza
Tested-by: Daniel Henrique Barboza
On 8/23/19 1:31 PM, Jonathon Jongsma wrote:
This
On Fri, Aug 23, 2019 at 03:33:36PM +0200, Michal Privoznik wrote:
> Currently, whenever there's a regular EOF on the console stream
> or an error the virStreamAbort() is called regardless. While this
> may not actually break anything, we should call virStreamFinish()
> to let the daemon know we've
On Fri, Aug 23, 2019 at 05:11:18PM +, Jim Fehlig wrote:
> On 8/8/19 9:10 AM, Daniel P. Berrangé wrote:
> > Arguably we could rename the libxl driver to "xen" since it is the
> > only xen driver we have these days, and that matches how we expose it
> > to users in the URI naming.
>
> While
On 8/8/19 9:10 AM, Daniel P. Berrangé wrote:
> Arguably we could rename the libxl driver to "xen" since it is the
> only xen driver we have these days, and that matches how we expose it
> to users in the URI naming.
While thinking about this today I realized it is actually quite a rat hole. I
On 8/23/19 11:00 AM, Jonathon Jongsma wrote:
On Thu, 2019-08-22 at 19:02 -0300, Daniel Henrique Barboza wrote:
[...]
Hmm, sorry for the sloppiness. I ran these tests multiple times, but
apparently after a final rebase, I introduced something that I failed
to catch before submitting. Thanks
On 8/23/19 12:21 PM, Cole Robinson wrote:
> From: Marc-André Lureau
>
> vhost-user-gpu helper may accept --render-node option to specify on
> which GPU should the renderning be done.
>
What does it do if the user doesn't pass one? Pick one itself, or just
not use one somehow?
If it picks one,
On 8/23/19 12:21 PM, Cole Robinson wrote:
> From: Marc-André Lureau
>
> Accept a new attribute to specify usage of helper process, ex:
>
>
>
>
>
For other devices, we have
Which is an attempt to make this more generic. IMO using vhostuser='yes'
and is the simplest match to
On 8/23/19 12:21 PM, Cole Robinson wrote:
> v1: https://www.redhat.com/archives/libvir-list/2019-June/msg00102.html
>
> This is v2 of Marc-André's series with minor changes. I'm not taking over
> this series, I just fixed these as part of the patch rebase so I can review
> it :)
>
> Changes
On 8/23/19 12:21 PM, Cole Robinson wrote:
> From: Marc-André Lureau
>
> The same config files disovery & priority rules are used for
> vhost-user backends.
>
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Cole Robinson
> ---
> src/qemu/Makefile.inc.am | 2 +
> src/qemu/qemu_configs.c
Since version 3.0, qemu has returned disk usage statistics in
guest-get-fsinfo. And since 3.1, it has returned information about the
disk serial number and device node of disks that are targeted by the
filesystem.
Unfortunately, the public API virDomainGetFSInfo() returns the
filesystem info
Iimplements the new guest information API by querying requested
information via the guest agent.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_driver.c | 110 +
1 file changed, 110 insertions(+)
diff --git a/src/qemu/qemu_driver.c
This API is intended to aggregate several guest agent information
queries and is ispired by stats API virDomainListGetStats(). It is
anticipated that this information will be provided by a guest agent
running within the domain.
Signed-off-by: Jonathon Jongsma
---
This function queries the guest operating system information and adds
the returned information to an array of typed parameters with field
names intended to be returned in virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 53 ++
The 'guestinfo' command uses the new virDomainGetGuestInfo() API to
query information about the specified domain and print it out for the
user. The output is modeled roughly on the 'domstats' command.
Signed-off-by: Jonathon Jongsma
---
tools/virsh-domain.c | 85
This function fetches the list of logged-in users from the qemu agent
and adds them to a list of typed parameters so that they can be used
internally in libvirt.
Also add some basic tests for the function.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 91 +++
Add daemon and client code to serialize/deserialize
virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/remote/remote_daemon_dispatch.c | 41 ++
src/remote/remote_driver.c | 53 +
src/remote/remote_protocol.x| 21
This function queries timezone information within the guest and adds
the information to an array of typed parameters with field names
intended to be returned to virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 46 ++
This function adds the complete filesystem information returned by the
qemu agent to an array of typed parameters with field names intended to
to be returned by virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 90 ++
src/qemu/qemu_agent.h |
changes in v3:
- fixed test failure
- fixed syntax issues that I had missed since I forgot to install cppi on my
new laptop
This series adds several bits of guest information provided by a new API
function virDomainGetGuestInfo(). There is an implementation for qemu using the
guest agent. In
From: Marc-André Lureau
Those new devices are merged for QEMU 4.1.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 2 ++
From: Marc-André Lureau
Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
qemuVhostUserFillDomainGPU() will find the first matching GPU helper
with the required capabilities and set the associated
vhost_user_binary.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
From: Marc-André Lureau
For each vhost-user GPUs,
- build a socket chardev, and pass the vhost-user socket to it
- build a vhost-user video device and associate it with the chardev
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c | 46
From: Marc-André Lureau
Check qemu capability, and accept 3d acceleration. 3d acceleration
support is checked when looking for a suitable vhost-user helper.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_process.c | 14 --
1 file changed, 12
From: Marc-André Lureau
Similar to the qemu_tpm.c, add a unit with a few functions to
start/stop and setup the cgroup of the external vhost-user-gpu
process. See function documentation.
Since the vhost-user connection fd isn't necessarily specific to QEMU,
it was easier to add it to
From: Marc-André Lureau
vhost-user device doesn't have a virgl option, it is passed to the
vhost-user-gpu helper process instead.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_cgroup.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index ecd96efb0a..eb6f993d8e 100644
---
From: Marc-André Lureau
To support virtio VGA with vhost-user, vhost-user-vga device is necessary.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_domain.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c
From: Marc-André Lureau
vhost-user-gpu helper may accept --render-node option to specify on
which GPU should the renderning be done.
(by comparison rendernode is the target/display rendering)
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
docs/formatdomain.html.in |
From: Marc-André Lureau
Each vhost-user-gpu needs its own helper gpu process.
Start/stop them, and apply the emulator cgroup controller.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_extdevice.c | 46 +++
1 file changed,
From: Marc-André Lureau
Learn to override the paths to the program to execute (vhost-user
helpers are executed to check for runtime capabilities).
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
tests/virfilewrapper.c | 22 ++
1 file changed, 22
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
.../vhost-user-gpu-secondary.args | 38
.../vhost-user-gpu-secondary.xml | 44 +++
tests/qemuxml2argvdata/vhost-user-vga.args| 35
From: Marc-André Lureau
Accept a new attribute to specify usage of helper process, ex:
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
docs/formatdomain.html.in | 6 ++
docs/schemas/domaincommon.rng | 11 ++-
src/conf/domain_conf.c| 14
From: Marc-André Lureau
Call qemuExtVhostUserGPUPrepareDomain() to fill the domain with the
location of the vhost-user binary to start.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_extdevice.c | 29 +
src/qemu/qemu_extdevice.h |
From: Marc-André Lureau
See function documentation. Used in a following patch.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/qemu_security.c | 47
src/qemu/qemu_security.h | 6 +
2 files changed, 53 insertions(+)
v1: https://www.redhat.com/archives/libvir-list/2019-June/msg00102.html
This is v2 of Marc-André's series with minor changes. I'm not taking over
this series, I just fixed these as part of the patch rebase so I can review
it :)
Changes since v1:
- rebase to master
- if test file build by
From: Marc-André Lureau
The same config files disovery & priority rules are used for
vhost-user backends.
Signed-off-by: Marc-André Lureau
Signed-off-by: Cole Robinson
---
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_configs.c | 183 +++
We need to give users the ability to customize the length of the
shutdown timeout, or even disable timeouts entirely. Thus we must move
the timeout arg into the sysconf file, instead of the service unit.
Signed-off-by: Daniel P. Berrangé
---
src/remote/libvirtd.service.in | 6 +-
When using systemd socket activation the --listen arg has no
effect. This is confusing to users upgrading from previous versions of
libvirt as their config is silently ignored. Turn use of --listen into a
fatal error when sockets are passed from systemd.
This helps the admin discover the change
Currently during RPM upgrade we restart libvirtd and unconditionally
enable use of systemd socket activation for the UNIX sockets.
If the user had previously given the --listen arg to libvirtd though,
this will no longer be honoured if socket activation is used.
We could start
This improves the upgrade path to systemd socket activation
- Disable socket activation in RPM %post if we see use of --listen
arg on existing install
- Report fatal error if --listen is used with socket activation,
since it is not honoured
Daniel P. Berrangé (4):
remote: use Wants
To facilitate upgrades from earlier versions of libvirt which did not
use socket activation for libvirtd, we want to allow the libvirtd socket
units to be disabled (masked). This can only be supported if we use the
warker Wants statement instead of Requires.
Signed-off-by: Daniel P. Berrangé
---
On Thu, 2019-08-22 at 19:02 -0300, Daniel Henrique Barboza wrote:
> This patch fails to compile in my env throwing this error:
>
>
> CC qemuagenttest.o
> qemuagenttest.c: In function
> 'testQemuAgentGetFSInfoCommon.constprop':
> qemuagenttest.c:242:5: error: 'ret_def' may be used
On Thu, Aug 22, 2019 at 07:50:14PM -0400, Cole Robinson wrote:
On 8/1/19 5:28 AM, Marc-André Lureau wrote:
Hi
On Wed, Jun 5, 2019 at 2:32 PM wrote:
From: Marc-André Lureau
Hi,
This series of patches adds support for running virtio GPUs in
seperate processes, thanks to vhost-user backend.
Currently, whenever there's a regular EOF on the console stream
or an error the virStreamAbort() is called regardless. While this
may not actually break anything, we should call virStreamFinish()
to let the daemon know we've successfully received all the data
and are shutting down the stream
On Fri, Aug 23, 2019 at 03:24:43PM +0200, Michal Privoznik wrote:
In my recent patches I've introduced
virStoragePoolObjIsStarting() which is then used to protect
storage pool definition when the pool object is locked and
unlocked during long running jobs. Well, my patches did not
anticipate
On 8/20/19 11:17 AM, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2):
rpm: depend on /usr/bin/nc instead of nc
rpm: move nc dep into the libvirt-daemon sub-RPM
libvirt.spec.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik
Michal
--
In my recent patches I've introduced
virStoragePoolObjIsStarting() which is then used to protect
storage pool definition when the pool object is locked and
unlocked during long running jobs. Well, my patches did not
anticipate that @obj can be NULL under 'cleanup' label in
storagePoolCreateXML()
On 8/21/19 3:33 PM, Roman Bolshakov wrote:
Regular VM shutdown triggers the error for existing session of virsh
console and it returns with non-zero exit code:
error: internal error: console stream EOF
The message and status code are misleading because there's no real
error. virStreamRecv
On 5/24/19 10:35 AM, Michal Privoznik wrote:
> In near future the storage pool object lock will be released
> during startPool and buildPool callback (in some backends). But
> this means that another thread may acquire the pool object lock
> and change its definition rendering the former thread
On 8/23/19 7:28 AM, Daniel P. Berrangé wrote:
On Thu, Aug 22, 2019 at 05:09:10PM -0300, Daniel Henrique Barboza wrote:
Hi Daniel,
On 6/19/19 4:31 AM, Daniel P. Berrangé wrote:
On Tue, Jun 18, 2019 at 03:04:40PM -0300, Daniel Henrique Barboza wrote:
[...]
Finally had the time to look into
On Thu, Aug 22, 2019 at 05:09:10PM -0300, Daniel Henrique Barboza wrote:
> Hi Daniel,
>
> On 6/19/19 4:31 AM, Daniel P. Berrangé wrote:
> > On Tue, Jun 18, 2019 at 03:04:40PM -0300, Daniel Henrique Barboza wrote:
> > > Hi,
> > >
> > > This is labeled as RFC but it's more like a FYI to let people
After my previous patches we have virPCIDeviceBindToStub() and
virPCIDeviceUnbindFromStub() which really do nothing but call
virPCIDeviceBindToStubWithOverride() and
virPCIDeviceUnbindFromStubWithOverride() respectively.
Drop "WithOverride" from the names and drop the thin wrappers.
ping
On Tue, Aug 20, 2019 at 10:17:15AM +0100, Daniel P. Berrangé wrote:
>
>
> Daniel P. Berrangé (2):
> rpm: depend on /usr/bin/nc instead of nc
> rpm: move nc dep into the libvirt-daemon sub-RPM
>
> libvirt.spec.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --
>
14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote:
> To get rid of implicit filters related workarounds in future let's
> deprecate them now.
Interesting, could we deprecate implicit filter without deprecation of
unnecessity of
parameter? As actually, it's good when this parameter is not
On 8/20/19 4:30 PM, Michal Privoznik wrote:
>
Thank you guys for review. I've pushed these.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
65 matches
Mail list logo
