Actually there is still some issue around this. When trying to start
another VM, so using even more pmem, there is a different issue now. Error
copied below.
[]# virsh start manual_clone
error: Failed to start domain manual_clone
error: internal error: qemu unexpectedly closed the monitor: ftrun
On Tue, Sep 03, 2019 at 03:06:24PM -0400, John Snow wrote:
>
>
> On 9/3/19 3:02 PM, Eric Blake wrote:
> > [adding libvirt list]
> >
> > On 9/3/19 1:50 PM, John Snow wrote:
> >>
> >>
> >> On 9/3/19 10:56 AM, Eric Blake wrote:
> >>> Mention the preferred URI form, especially since NBD is trying to
On 9/4/19 3:18 AM, Daniel P. Berrangé wrote:
> -Syntax for specifying a NBD device using TCP
> +Syntax for specifying a NBD device using TCP, in preferred URI form:
> +``nbd://[:]/[]''
> +
> ``nbd::[:exportname=]''
>
>
> In general libvirt should never use the psuedo-UR
On Mon, Sep 2, 2019 at 10:10 AM Seema Pandit wrote:
>
> After adding the memoryBacking tag in xml as below (in addition, to other xml
> changes to add nvdimm), virsh could allocate AD memory larger than the system
> RAM and VMs could start successfully.
>
>
>
>
>
>
>
>
>
>
>
> This
On August 21, 2019 11:19 pm, John Snow wrote:
>
>
> On 8/21/19 10:21 AM, Vladimir Sementsov-Ogievskiy wrote:
>> [CC Nikolay]
>>
>> 21.08.2019 1:25, John Snow wrote:
>>> Hi, downstream here at Red Hat I've been fielding some questions about
>>> the usability and feature readiness of Bitmaps (and
Use VIR_AUTOUNREF and get rid of the cleanup label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 42 --
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c7eb0b5e9a..8cb5e14ea4
Since libvirt stores the backing chain into the XML in a nested way it
is the prime possibility to hit libxml2's parsing limit of 256 layers.
Introduce code which will crawl the backing chain and verify that it's
not too deep. The maximum nesting is set to 200 layers so that there's
still some spa
Use VIR_AUTOFREE and remove the cleanup label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 1a557851bb..82625b2261 100644
--- a/src/qemu
More than 256 deep element tree break with our XML parser. Backing
chains are one of the simple ways to get there. Forbid them. Note that
the practical limit/sane approach is way less than 200.
Peter Krempa (2):
qemu: domain: Refactor cleanup in qemuDomainDetermineDiskChain
qemu: Prevent stora
When blockdev is used we always should use the blockdev mode for
non-shared storage migration.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index c13b21a0bb..
Use VIR_AUTOUNREF and remove the cleanup label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 82625b2261..c13b21a0bb 100644
--- a/sr
Once we enable blockdev there's no need to stick to drive mirror for
non-shared-storage migration.
This patchset applies on top of the external snapshot branch:
https://www.redhat.com/archives/libvir-list/2019-September/msg00082.html
Peter Krempa (4):
qemu: migration: Refactor cleanup in
qe
Remove the cleanup label as it's empty.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e387deb497..1a557851bb 100644
--- a/src/q
On Wed, Sep 4, 2019 at 12:56 AM Seema Pandit wrote:
>
> Actually there is still some issue around this. When trying to start another
> VM, so using even more pmem, there is a different issue now. Error copied
> below.
>
> []# virsh start manual_clone
>
> error: Failed to start domain manual_clon
On 9/4/19 10:34 AM, Peter Krempa wrote:
> Since libvirt stores the backing chain into the XML in a nested way it
> is the prime possibility to hit libxml2's parsing limit of 256 layers.
Nasty that libxml2 is forcing us into this arbitrary limit, but it is
some rather hairy setup to get there.
>
On 9/4/19 10:39 AM, Peter Krempa wrote:
> Use VIR_AUTOFREE and remove the cleanup label.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 17 ++---
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migrat
On 9/4/19 10:39 AM, Peter Krempa wrote:
> Once we enable blockdev there's no need to stick to drive mirror for
> non-shared-storage migration.
>
> This patchset applies on top of the external snapshot branch:
> https://www.redhat.com/archives/libvir-list/2019-September/msg00082.html
>
> Peter Kre
Since commit fd9ef3b31e, virDomainFindByUUIDRef() no longer exists and
all virDomainObjListFindBy*() functions now increment the reference
count.
Signed-off-by: Jonathon Jongsma
---
src/qemu/THREADS.txt | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/src/qem
The attribute is named 'secret', not 'uuid'
Signed-off-by: Cole Robinson
---
Pushed as trivial
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b7a342bb91..6c429cd593 100644
--- a/src/conf/domain_con
libvirt-override.c: In function ‘libvirt_virConnectBaselineHypervisorCPU’:
libvirt-override.c:9946:23: warning: comparison of integer expressions of
different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’
[-Wsign-compare]
libvirt-override.c:9961:19: warning: comparison of integer expre
20 matches
Mail list logo
