On 9/27/19 5:33 PM, Cole Robinson wrote:
On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique Barboza
---
I've made this test file to make sure I wasn't messing
up with the logic at patch 8. The idea of having this
test seems okay, but probably I could do it
On 9/27/19 7:03 AM, Pavel Hrdina wrote:
On Thu, Sep 26, 2019 at 05:18:41PM -0400, Cole Robinson wrote:
These helped with debugging
https://bugzilla.redhat.com/show_bug.cgi?id=1612383
Signed-off-by: Cole Robinson
---
src/util/vircgroup.c | 3 ++-
src/util/vircgroupv2.c | 9 +
2
On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique Barboza
---
I've made this test file to make sure I wasn't messing
up with the logic at patch 8. The idea of having this
test seems okay, but probably I could do it shorter/cleaner.
Feel free to discard it if
Convert the string duplication APIs to use the g_strdup family of APIs.
Annoyingly our virVasprintf/virAsprintf functions return the character
count, even though 90% of our usage doesn't need it. To retain compat
with these semantics we have a call to strlen which costs CPU time.
We previously
Convert the VIR_ALLOC family of APIs with use of the g_malloc family of
APIs. Use of VIR_ALLOC related functions should be incrementally phased
out over time, allowing return value checks to be dropped. Use of
VIR_FREE should be replaced with auto-cleanup whenever possible.
We previously used the
Replace use of the gnulib base64 module with glib's own base64 API family.
Signed-off-by: Daniel P. Berrangé
---
bootstrap.conf| 1 -
src/conf/virsecretobj.c | 38 +++
src/libvirt_private.syms | 1 -
src/libxl/libxl_conf.c
The VIR_TYPED_PARAM_* enum fields are defined in libvirt-common.h, not
in the remote protcol, so shouldn't be part of the protocol structs
output check. This avoids similar problems hitting when we add use of
glib, which has other such anonymous enums.
Signed-off-by: Daniel P. Berrangé
---
This is a followup to a previous patch series:
https://www.redhat.com/archives/libvir-list/2019-August/msg01374.html
The first abort-on-oom parts of that series merged already.
As well as fixing the issues mentioned last time, the glib parts now do
a little more:
- Demonstrate conversion of
Prepare for linking with glib by probing for it at configure
time. Per supported platforms target, the min glib versions on
relevant distros are:
RHEL-8: 2.56.1
RHEL-7: 2.50.3
Debian (Buster): 2.58.3
Debian (Stretch): 2.50.3
OpenBSD (Ports): 2.58.3
FreeBSD (Ports): 2.56.3
OpenSUSE
The GOptionContext API has the benefit over getopt_long that it will
automatically handle --help output formatting.
Signed-off-by: Daniel P. Berrangé
---
tools/virsh.c | 303 ++
1 file changed, 135 insertions(+), 168 deletions(-)
diff --git
Converting from virObject to GObject is reasonably straightforward,
as illustrated by this patch for virIdentity
In the header file
- Remove
typedef struct _virIdentity virIdentity
- Add
#define VIR_TYPE_IDENTITY virIdentity_get_type ()
G_DECLARE_FINAL_TYPE (virIdentity,
Add the main glib.h to internal.h so that all common code can use it.
Historically glib allowed applications to register an alternative
memory allocator, so mixing g_malloc/g_free with malloc/free was not
safe.
This was feature was dropped in 2.46.0 with:
commit
The GOptionContext API has the benefit over getopt_long that it will
automatically handle --help output formatting.
Signed-off-by: Daniel P. Berrangé
---
tools/virt-admin.c | 207 +
1 file changed, 98 insertions(+), 109 deletions(-)
diff --git
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_event.c| 25 ---
src/libxl/libxl_capabilities.c | 44 --
2 files changed, 31 insertions(+), 38 deletions(-)
diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index
It is documented that a command to run inside the container can be
passed with the -c arg.
virt-login-shell -c "ls -l /"
This fixes
commit 4feeb2d986b98013ebfb1d41ab6b9007b6cce6e2
Author: Daniel P. Berrangé
Date: Thu Aug 1 10:58:31 2019 +0100
tools: split virt-login-shell into
The video private data was not initializing the vhostuser FD
causing us to attempt to close FD 0 many times over.
Fixes
commit ca60ecfa8cc1bd85baf7137dd1864d5f00f019f0
Author: Marc-André Lureau
Date: Mon Sep 23 14:44:36 2019 +0400
qemu: add qemuDomainVideoPrivate
Signed-off-by:
It is documented that a command to run inside the container can be
passed with the -c arg.
virt-login-shell -c "ls -l /"
This fixes
commit 4feeb2d986b98013ebfb1d41ab6b9007b6cce6e2
Author: Daniel P. Berrangé
Date: Thu Aug 1 10:58:31 2019 +0100
tools: split virt-login-shell into
From: Malina Salina
While the default iptables setup used by Fedora/RHEL distros
only restricts traffic on the INPUT and/or FORWARD rules,
some users might have custom firewalls that restrict the
OUTPUT rules too.
These can prevent DHCP/DNS/TFTP responses from dnsmasq
from reaching the guest
On 9/27/19 12:11 PM, Pavel Mores wrote:
The way in which the qemu driver generates aliases for disks involves
ignoring the partition number part of a target dev name. This means that
all partitions of a block device and the device itself all end up with the
same alias. If multiple such disks
On Fri, 30 Aug 2019 at 21:33, Bruno Haible wrote:
>
> Hi Eric,
>
> > I wonder if gnulib could provide a workaround setgroups() that overcomes
> > this issue
>
> I don't see how a workaround could look like. The problem is not the value
> of NGROUPS_MAX in user-space, but the same value
The way in which the qemu driver generates aliases for disks involves
ignoring the partition number part of a target dev name. This means that
all partitions of a block device and the device itself all end up with the
same alias. If multiple such disks are specified in XML, the resulting
name
All the 6 virGetConnect* functions in driver.c shares the
same code base. This patch creates a new static function
virGetConnectGeneric() that contains the common code to
be used with all other virGetConnect*.
Signed-off-by: Daniel Henrique Barboza
---
CC'ing Cole Robinson since he reviewed
On Wed, Sep 25, 2019 at 02:54:39PM +0200, Peter Krempa wrote:
'vm' is passed in which contains the definition which contains the UUID
so we don't need another parameter for this.
Signed-off-by: Peter Krempa
---
src/conf/snapshot_conf.c | 5 ++---
src/conf/snapshot_conf.h | 3 +--
Use VIR_AUTORELEASE instead.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0988071708..ed59e64c10 100644
--- a/src/qemu/qemu_driver.c
+++
As an example of how to use VIR_AUTORELEASE let's convert this API's
'vm' object to use the new helper.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_driver.c
When a pointer is assigned to a variable marked by VIR_AUTOUNREF it will
be unref'd when the stack frame of the variable is destroyed and thus
users must assign it only when they wish to shed the reference. Add this
as a note to the VIR_AUTOUNREF macro.
Signed-off-by: Peter Krempa
---
Add helpers for using automatic stack'd variable cleaning for lockable
objects.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 2 ++
src/util/virobject.c | 29 +
src/util/virobject.h | 30 ++
3 files changed, 61
A spin-off from the refactors to checkpoints where Eric suggested that
we might want to replace virDomainObjEndAPI. See patch 2 for the
implementation and patch 3 for example use.
Peter Krempa (4):
util: object: Note that VIR_AUTOUNREF variables must have the
reference
util: object: Add
On Fri, Sep 27, 2019 at 07:48:55 -0500, Eric Blake wrote:
> On 9/27/19 1:33 AM, Peter Krempa wrote:
> > On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote:
> > > On 9/26/19 10:51 AM, Peter Krempa wrote:
> > > > Add a 'cleanup' label and use jumps as we do in other places.
> > > >
> > > >
This stop building the existing C based virt-host-validate
implementation and instead builds the Go implementation.
For the RPM spec this is written to rely on pre-packaged
RPMs for the 3rd party Go dependencies. These are all
already present in supported Fedora releases.
Signed-off-by: Daniel
On 9/27/19 1:33 AM, Peter Krempa wrote:
On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote:
On 9/26/19 10:51 AM, Peter Krempa wrote:
Add a 'cleanup' label and use jumps as we do in other places.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 17 ++---
1 file
This commit defines a set of YAML rules that result in the same set of
logical checks as the existing hardcoded virt-host-validate
implementation does.
Signed-off-by: Daniel P. Berrangé
---
tools/host-validate/rules/builtin.yaml| 20 +
tools/host-validate/rules/cpu.yaml|
This is a followup to a previous PoC patch I submitted a
month ago:
https://www.redhat.com/archives/libvir-list/2019-September/msg00036.html
The commit messages in the individual patches given quite a
bit of detail, so I'll keep this cover letter brief.
In my previous posting I was unhappy
The current virt-host-validate command has a bunch of checks defined in
the source code which are thus only extensible by the upstream project,
or downstream code modification.
The checks are implemented by a fairly simple set of rules, mostly
matching the contents of files, or output from
Add a check reporting if any CPU vulnerabilities have not been mitigated
by the kernel. It further reports whether it is safe to use Intel SMT
for KVM guests or not, as several of the vulnerabilities are dangerous
when combined with SMT and KVM, even if mitigations are in effect.
eg on a host
This decides on requiring Golang >= 1.11, since that introduces
the new standard concept of "Go modules":
https://blog.golang.org/using-go-modules
Previously such a concept was dealt with by any number of
external 3rd party. These didn't seemlessly integrate into
the go toolchain in the way
The C based virt-host-validate implementation is no longer required so
can be deleted entirely.
Signed-off-by: Daniel P. Berrangé
---
po/POTFILES | 5 -
tools/virt-host-validate-bhyve.c | 77 --
tools/virt-host-validate-bhyve.h | 24 --
On Fri, Sep 27, 2019 at 01:20:51PM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 27, 2019 at 02:15:45PM +0200, Erik Skultety wrote:
> > On Fri, Sep 27, 2019 at 01:09:31PM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote:
> > > > On Tue, Sep 24,
On Fri, Sep 27, 2019 at 13:57:26 +0200, Michal Privoznik wrote:
> As it turns out, on my 32bit ARM machine size_t is not the same
> size as ULL. However, @length argument for both functions is type
> of size_t but it's treated as ULL - for instance when passed to
> qemuMonitorJSONMakeCommand().
On Fri, Sep 27, 2019 at 02:15:45PM +0200, Erik Skultety wrote:
> On Fri, Sep 27, 2019 at 01:09:31PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote:
> > > On Tue, Sep 24, 2019 at 04:07:17PM +0100, Daniel P. Berrangé wrote:
> > > > We recently
On Fri, Sep 27, 2019 at 01:09:31PM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote:
> > On Tue, Sep 24, 2019 at 04:07:17PM +0100, Daniel P. Berrangé wrote:
> > > We recently forbid the use of --listen with socket activation:
> > >
> > > commit
On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote:
> On Tue, Sep 24, 2019 at 04:07:17PM +0100, Daniel P. Berrangé wrote:
> > We recently forbid the use of --listen with socket activation:
> >
> > commit 3a6a725b8f575890ee6c151ad1f46ea0ceea1f3b
> > Author: Daniel P. Berrangé
> >
As it turns out, on my 32bit ARM machine size_t is not the same
size as ULL. However, @length argument for both functions is type
of size_t but it's treated as ULL - for instance when passed to
qemuMonitorJSONMakeCommand(). The problem is that because of
"U:size" the virJSONValueObjectAddVArgs()
On Fri, Sep 27, 2019 at 10:09:05AM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 26, 2019 at 09:42:20PM -0300, Eduardo Habkost wrote:
> > (CCing libvir-list)
> >
> > On Thu, Sep 26, 2019 at 11:58:30PM +0200, Paolo Bonzini wrote:
> > > Is this really needed? QEMU's value of pconfig=on vs. off
On Fri, Sep 27, 2019 at 01:32:25PM +0200, Peter Krempa wrote:
> On Fri, Sep 27, 2019 at 12:24:05 +0100, Daniel Berrange wrote:
> > On Fri, Sep 27, 2019 at 11:42:28AM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Sep 27, 2019 at 10:33:45AM +0100, Daniel P. Berrangé wrote:
> > > > On Thu, Sep 26,
On Fri, Sep 27, 2019 at 12:24:05 +0100, Daniel Berrange wrote:
> On Fri, Sep 27, 2019 at 11:42:28AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 27, 2019 at 10:33:45AM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > > > On Tue, Sep 24, 2019
On Fri, Sep 27, 2019 at 11:42:28AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 27, 2019 at 10:33:45AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > > On Tue, Sep 24, 2019 at 03:58:46PM +0100, Daniel P. Berrangé wrote:
> > > > As part of an
Switch over to using meson for building the virsh / virt-admin
tools and supporting files.
Signed-off-by: Daniel P. Berrangé
---
libvirt.spec.in | 20 +
m4/virt-bash-completion.m4| 70
meson.build | 7 ++
meson_options.txt
This patch is the first baby step in an incremental conversion
to use meson. Initially all it does is take responsibilty for
creating the dist tarball.
No attempt is made to integrate into autotools at this stage.
Eventually meson will be the primary build system and autotools
will be invoked by
Switch over to using meson for building the two NSS modules
Signed-off-by: Daniel P. Berrangé
---
meson.build | 5 ++
tools/Makefile.am | 112 +-
tools/meson.build | 2 +
tools/nss/meson.build | 63
4 files
The example programs link against the main libvirt.so,
which is not yet built by meson. Thus we declare it
as an external dependancy initially.
Signed-off-by: Daniel P. Berrangé
---
examples/Makefile.am | 52 ---
examples/c/admin/meson.build | 51
This uses meson to install the example data files and example
program source.
Signed-off-by: Daniel P. Berrangé
---
Makefile.am | 2 +-
examples/Makefile.am | 83
examples/c/admin/meson.build | 8 +++
Switch over to using meson for building the virt-login-shell
tool
Signed-off-by: Daniel P. Berrangé
---
m4/virt-login-shell.m4 | 43 ---
meson.build| 2 ++
meson_options.txt | 1 +
tools/Makefile.am | 35 --
The meson recipes will need to link against libvirt.so,
libvirt-admin.so and libgnu.a. We declare these as
external pre-built dependencies for now.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 13 +
src/meson.build | 25 +
2 files changed, 38
Switch over to using meson for building the virt-host-validate
tool
Signed-off-by: Daniel P. Berrangé
---
configure.ac | 3 --
m4/virt-host-validate.m4 | 43 -
meson.build | 4 +++
meson_options.txt| 2 ++
src/meson.build
Historically we've allowed builds in the main src dir, but meson does
not support this. Explicitly force separate build dir in autotools to
align with meson. We must re-enable dependency tracking which the RPM
%configure macro turns off. Without this, the build dir doesn't get
the source directory
For the past week or to I've been tackling the problem of converting
from autotools to meson.
Many of the virt related projects have gone through this already, but
libvirt is a bit of a special case because it is so huge. In particular
I don't think it is acceptable to do a big bang where the
Placeholder options for enabling each driver, which will
be fleshed out in later commits.
Signed-off-by: Daniel P. Berrangé
---
meson_options.txt | 23 +++
src/bhyve/meson.build | 5 +
src/esx/meson.build | 2 ++
src/hyperv/meson.build | 2
Meson requires python 3 and python 2 is end of life at
the end of the year.
This is the bare minimum cleanup which simply drops any
"from __future__" usage and updates the shbang line.
Signed-off-by: Daniel P. Berrangé
---
configure.ac | 4 ++--
docs/apibuild.py
On Thu, Sep 26, 2019 at 05:18:41PM -0400, Cole Robinson wrote:
> These helped with debugging
> https://bugzilla.redhat.com/show_bug.cgi?id=1612383
>
> Signed-off-by: Cole Robinson
> ---
> src/util/vircgroup.c | 3 ++-
> src/util/vircgroupv2.c | 9 +
> 2 files changed, 11
On Fri, Sep 27, 2019 at 11:42:28AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 27, 2019 at 10:33:45AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > > On Tue, Sep 24, 2019 at 03:58:46PM +0100, Daniel P. Berrangé wrote:
> > > > As part of an
On Fri, Sep 27, 2019 at 10:33:45AM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > On Tue, Sep 24, 2019 at 03:58:46PM +0100, Daniel P. Berrangé wrote:
> > > As part of an goal to eliminate Perl from libvirt build tools,
> > > rewrite the
On Fri, 2019-09-27 at 10:33 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > * function calls sometimes leave an empty opening parenthesis
> > * always rewrapping function arguments might create unnecessary churn
> > * parameters wrapping might not
On Fri, Sep 27, 2019 at 10:33:45 +0100, Daniel Berrange wrote:
> On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> > On Tue, Sep 24, 2019 at 03:58:46PM +0100, Daniel P. Berrangé wrote:
> > > As part of an goal to eliminate Perl from libvirt build tools,
> > > rewrite the
On Thu, Sep 26, 2019 at 06:08:14PM +0200, Ján Tomko wrote:
> On Tue, Sep 24, 2019 at 03:58:46PM +0100, Daniel P. Berrangé wrote:
> > As part of an goal to eliminate Perl from libvirt build tools,
> > rewrite the check-spacing.pl tool in Python.
> >
> > This was a straight conversion, manually
On Thu, Sep 26, 2019 at 09:42:20PM -0300, Eduardo Habkost wrote:
> (CCing libvir-list)
>
> On Thu, Sep 26, 2019 at 11:58:30PM +0200, Paolo Bonzini wrote:
> > Is this really needed? QEMU's value of pconfig=on vs. off should be
> > provided by QMP CPU model queries, if a property is not available
On Thu, Sep 26, 2019 at 05:18:40PM -0400, Cole Robinson wrote:
> On Fedora 31, starting a 'mock' build alters /proc/$pid/cgroup,
> probably due to usage of systemd-nspawn.
>
> Before:
> $ cat /proc/self/cgroup
> 0::/user.slice/user-1000.slice/...
>
> After:
> $ cat /proc/self/cgroup
>
On Fri, Sep 27, 2019 at 09:22:13AM +0200, Erik Skultety wrote:
> On Thu, Sep 26, 2019 at 04:38:49PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote:
> > > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote:
> > > > On Thu, Sep 26, 2019
The interlocking with snapshots is executed prior to the ACL check so if
a VM has snapshots invoking the checkpoint API may leak it's existance.
Introduced with the qemuDomainCheckpointCreateXML API implementation in
commit 5f4e0796503.
Signed-off-by: Peter Krempa
---
Split out from the
On Thu, Sep 26, 2019 at 01:15:16PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 9/26/19 6:18 AM, Erik Skultety wrote:
> > On Wed, Sep 18, 2019 at 11:56:55AM -0300, Daniel Henrique Barboza wrote:
> > > virQEMUDriverConfigPtr can be auto-unref for the great majority
> > > of the uses made in
On Thu, Sep 26, 2019 at 04:38:49PM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote:
> > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote:
> > > > On Tue, Sep 24, 2019
On Fri, Sep 27, 2019 at 07:35:37AM +0200, Peter Krempa wrote:
> Now that qemu 4.1 was released we can update the capabilities to the
> final form.
>
> Signed-off-by: Peter Krempa
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote:
> On 9/26/19 10:51 AM, Peter Krempa wrote:
> > Add a 'cleanup' label and use jumps as we do in other places.
> >
> > Signed-off-by: Peter Krempa
> > ---
> > src/qemu/qemu_driver.c | 17 ++---
> > 1 file changed, 10
73 matches
Mail list logo
