Re: [libvirt] s390: change default cpu model to host-model?

2019-11-02 Thread Daniel P . Berrangé
On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: > On the KVM forum I have discussed the default cpu model mode on s390. > Right now if the xml does not specify anything, libvirt defaults to > not specifying anything on the qemu command line (no -cpu statement) > which is

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3

2019-11-02 Thread liushuyu
From: liushuyu --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else:

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3

2019-11-02 Thread liushuyu
From: liushuyu --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else:

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3

2019-11-02 Thread liushuyu
From: liushuyu --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else:

[libvirt] [PATCH v2] storage: Fix volStorageBackendRBDRefreshVolInfo

2019-11-02 Thread Yi Li
Fix the return value status comparison checking for call to volStorageBackendRBDRefreshVolInfo introduced by commit id f46d137e. we only should fail when the return is < 0. -ENOENT, -ETIMEDOUT will ignore according commit id f46d137e. Signed-off-by: Yi Li --- src/storage/storage_backend_rbd.c

[libvirt] [PATCH] storage: Fix volStorageBackendRBDRefreshVolInfo

2019-11-02 Thread Yi Li
Fix the return value status comparison checking for call to volStorageBackendRBDRefreshVolInfo introduced by commit id f46d137e. we only should fail when the return is < 0. -ENOENT, -ETIMEDOUT will ignore according commit id f46d137e. Signed-off-by: Yi Li --- src/storage/storage_backend_rbd.c

[libvirt] [PATCH v2] storage: improve the while loop virStorageBackendFileSystemIsMounted

2019-11-02 Thread Yi Li
Move virStorageBackendFileSystemGetPoolSource outside of the while loop Signed-off-by: Yi Li --- src/storage/storage_backend_fs.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index

[libvirt] [PATCH] storage: Don't get src in each loop since src is not changed

2019-11-02 Thread 李义
The src of pool is not changed in each loop, so don't VIR_FREE(src) and get when next iteration. Signed-off-by: Yi Li --- src/storage/storage_backend_fs.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend_fs.c

Re: [libvirt] [PATCH 0/1] dirty-bitmaps: remove deprecated autoload parameter

2019-11-02 Thread Max Reitz
On 25.09.19 01:01, John Snow wrote: > I'm going to be honest, here. There's actually no real reason to remove > this now, but we could, so I'm going to. > > Also, in terms of the API serving as documentation, it's nicer to not > pretend this is an option that does anything, so out it goes. > >

[libvirt] [PATCH] storage: improve the while loop virStorageBackendFileSystemIsMounted

2019-11-02 Thread Yi Li
Move virStorageBackendFileSystemGetPoolSource outside of the while loop Signed-off-by: Yi Li --- src/storage/storage_backend_fs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 02b8248..10d9457