Re: [libvirt] [PATCH v5] util: Set SIGPIPE to a no-op handler in virFork

2019-11-04 Thread wang.yechao255
ping. > Subject: [PATCH v5] util: Set SIGPIPE to a no-op handler in virFork > > Libvirtd has set SIGPIPE to ignored, and virFork resets all signal > handlers to the defaults. But child process may write logs to > stderr/stdout, that may generate SIGPIPE if journald has stopped. > > So set SIGPIPE

[libvirt] [PATCH v2 2/2] gitdm: Add missing entries

2019-11-04 Thread Andrea Bolognani
A few new companies and individuals contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani --- docs/gitdm/companies/others| 2 ++ docs/gitdm/groups/opensource | 1 + docs/gitdm/groups/unaffiliated | 2 ++ 3 files changed, 5

[libvirt] [PATCH v2 0/2] gitdm: Update configuration

2019-11-04 Thread Andrea Bolognani
Changes from [v1]: * added a few more addresses. [v1] https://www.redhat.com/archives/libvir-list/2019-October/msg01095.html Andrea Bolognani (2): gitdm: Fix sorting gitdm: Add missing entries docs/gitdm/companies/others| 4 +++- docs/gitdm/groups/opensource | 1 +

[libvirt] [PATCH v2 1/2] gitdm: Fix sorting

2019-11-04 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/gitdm/companies/others | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others index 99dc1ab31e..8900a7812e 100644 --- a/docs/gitdm/companies/others +++ b/docs/gitdm/companies/others @@

Re: [libvirt] [PATCH v2 2/2] news: Update for 5.9.0 release

2019-11-04 Thread Laine Stump
On 11/4/19 7:10 AM, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] news: Document more possible sections

2019-11-04 Thread Laine Stump
On 11/4/19 7:10 AM, Andrea Bolognani wrote: The "Security" section has been used in the past, so we're only documenting existing behavior; the "Packaging changes" will be used in the next commit, as well as in future releases when we make more changes that are relevant to packagers, such as the

[libvirt] [PATCH 1/2] doc: cgroups: Remove unwanted references to systemd

2019-11-04 Thread Miguel Ángel Arruga Vivas
The non-systemd configurations do not create system neither user control groups. The title of the diagram referenced systemd too. Signed-off-by: Miguel Ángel Arruga Vivas --- docs/cgroups.html.in | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH 2/2] vircgroup: Ensure /machine group is associated with its parent

2019-11-04 Thread Miguel Ángel Arruga Vivas
Call first virCgroupNew on the parent group virCgroupNewPartition if it is available on before the creation of the child group. This ensures that the creation of a first level group on the unified architecture, as the check at virCgroupV2ParseControllersFile as the parent file is there. Fixes:

[libvirt] [PATCH 0/2] [Bug 1760233] Better support for non-systemd distributions

2019-11-04 Thread Miguel Ángel Arruga Vivas
Hi everybody, The following patches try to enhance the support for non-systemd configurations. The first patch just removes the references to the cgroups created by systemd, only leaving the reference to /machine cgroup, created by libvirtd for hosted virtual machines. The second one ensures

Re: [libvirt] [PATCH] docs: Fix attribute names in filesystem/driver example

2019-11-04 Thread Jim Fehlig
On 11/4/19 4:20 AM, Erik Skultety wrote: > On Fri, Nov 01, 2019 at 05:52:20PM +, Jim Fehlig wrote: >> Signed-off-by: Jim Fehlig >> --- > Reviewed-by: Erik Skultety Thanks. I pushed this but missed adding your RB. I need to tweak my workflow to prevent that... Regards, Jim -- libvir-list

[libvirt] [PATCH v2 0/2] news: Update for 5.9.0 release

2019-11-04 Thread Andrea Bolognani
You know the drill. Andrea Bolognani (2): news: Document more possible sections news: Update for 5.9.0 release docs/news.xml | 103 +- 1 file changed, 101 insertions(+), 2 deletions(-) -- 2.21.0 -- libvir-list mailing list

[libvirt] [PATCH v2 2/2] news: Update for 5.9.0 release

2019-11-04 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/news.xml | 96 +++ 1 file changed, 96 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index e566ed9e57..11f52b81a0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -43,6 +43,36 @@ + +

[libvirt] [PATCH v2 1/2] news: Document more possible sections

2019-11-04 Thread Andrea Bolognani
The "Security" section has been used in the past, so we're only documenting existing behavior; the "Packaging changes" will be used in the next commit, as well as in future releases when we make more changes that are relevant to packagers, such as the switch to Meson. Signed-off-by: Andrea

[libvirt] [libvirt-dbus][PATCH v4 1/2] Introduce Domain Snapshot Interface

2019-11-04 Thread Simon Kobyda
Signed-off-by: Simon Kobyda --- data/meson.build| 1 + data/org.libvirt.DomainSnapshot.xml | 7 +++ src/connect.c | 6 +++ src/connect.h | 1 + src/domainsnapshot.c| 75 +

[libvirt] [libvirt-dbus][PATCH v4 2/2] Implement snapshots APIs

2019-11-04 Thread Simon Kobyda
Signed-off-by: Simon Kobyda --- data/org.libvirt.Domain.xml | 26 data/org.libvirt.DomainSnapshot.xml | 34 + src/domain.c| 154 src/domainsnapshot.c| 216 tests/libvirttest.py

[libvirt] [libvirt-dbus][PATCH v4 0/2] Implement snapshots

2019-11-04 Thread Simon Kobyda
Changes since v2: Implement and use virtDBusDomainSnapshotGetVirDomainSnapshot Add domain snapshot xml file to data/meson.build Fix flake8 style errors Simon Kobyda (2): Introduce Domain Snapshot Interface Implement snapshots APIs data/meson.build| 1 +

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-04 Thread Christian Borntraeger
On 04.11.19 11:49, David Hildenbrand wrote: > On 02.11.19 11:32, Daniel P. Berrangé wrote: >> On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: >>> On the KVM forum I have discussed the default cpu model mode on s390. >>> Right now if the xml does not specify anything,

Re: [libvirt] [PATCH] docs: Fix attribute names in filesystem/driver example

2019-11-04 Thread Erik Skultety
On Fri, Nov 01, 2019 at 05:52:20PM +, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-04 Thread David Hildenbrand
On 02.11.19 11:32, Daniel P. Berrangé wrote: On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: On the KVM forum I have discussed the default cpu model mode on s390. Right now if the xml does not specify anything, libvirt defaults to not specifying anything on the qemu

Re: [libvirt] [PATCH 0/8] Coverity related patches

2019-11-04 Thread Daniel P . Berrangé
On Sun, Nov 03, 2019 at 08:53:32AM -0500, John Ferlan wrote: > Some related to "new-ish" changes that have caused Coverity to > discover new issues and some from older changes from a pile of > 50 or so that are not essentially "false positives". > > John Ferlan (8): > vbox: Fix possible NULL

Re: [libvirt] [RFC PATCH 0/9] add virtiofs support (virtio-fs epopee)

2019-11-04 Thread Stefan Hajnoczi
On Fri, Nov 1, 2019 at 1:15 PM Ján Tomko wrote: Great, this looks like the right direction. > * leave queue-size and cache-size on their default values > or expose them in XML Please support the following parameters: * virtiofsd path - useful for testing custom virtiofsd binaries or

Re: [libvirt] [PATCH 8/9] wip: start virtiofsd

2019-11-04 Thread Stefan Hajnoczi
On Fri, Nov 1, 2019 at 1:18 PM Ján Tomko wrote: > +if (qemuSecuritySetDaemonSocketLabel(driver->securityManager, vm->def) < > 0) > +goto cleanup; > +fd = qemuOpenChrChardevUNIXSocket(chrdev); > +if (fd < 0) > +goto cleanup; > +if

Re: [libvirt] [PATCH 6/9] conf: qemu: add virtio-fs fsdriver type

2019-11-04 Thread Stefan Hajnoczi
On Fri, Nov 1, 2019 at 1:15 PM Ján Tomko wrote: > > Introduce a new 'virtio-fs' driver type for filesystem. > > > > > What happens with the target dir? virtio-fs has no way to pass the target dir into the guest. Out-of-band methods exist: qemu-guest-agent could be used to mount the