On 2019.11.05 14:10:42 -0700, Alex Williamson wrote:
> On Thu, 24 Oct 2019 13:08:23 +0800
> Zhenyu Wang wrote:
>
> > Hi,
> >
> > This is a refresh for previous send of this series. I got impression that
> > some SIOV drivers would still deploy their own create and config method so
> > stopped
On Thu, 24 Oct 2019 13:08:23 +0800
Zhenyu Wang wrote:
> Hi,
>
> This is a refresh for previous send of this series. I got impression that
> some SIOV drivers would still deploy their own create and config method so
> stopped effort on this. But seems this would still be useful for some other
>
Hi Dave,
Time flies, doesn't it? :-)
My reply is not related to this patch series, but rather your use
case...
On Thu, Oct 31, 2019 at 12:50:28 -0400, Dave Allan wrote:
> My usecase is that I'm flashing the USB device with a program running
> in the VM. I keep the VM running, and when I need
On Tue, 2019-08-27 at 21:46 -0400, Laine Stump wrote:
> with info about support for using precreated tap/macvtap devices in
> unprivileged libvirtd.
>
> Signed-off-by: Laine Stump
> ---
> docs/news.xml | 13 +
> 1 file changed, 13 insertions(+)
You mentioned this was never
We need to create a mapping between CPU model names and their
corresponding QOM types.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- ignore empty typename strings
Version 3:
- g_strdup
src/qemu/qemu_capabilities.c | 3 +
We will need to keep some QEMU-specific data for each CPU model
supported by a QEMU binary. Instead of complicating the generic
virDomainCapsCPUModelsPtr, we can just directly store
qemuMonitorCPUDefsPtr returned by the capabilities probing code.
Signed-off-by: Jiri Denemark
---
Notes:
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
- no change
...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 36 +++
.../x86_64-default-cpu-kvm-pc-4.2.xml | 24
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
- no change
...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 38
.../ppc64-default-cpu-kvm-pseries-2.7.xml | 22 +
Some callers of virQEMUCapsGetCPUDefinitions will need to filter the
returned list of CPU models. Let's add the filtering parameters directly
to virQEMUCapsGetCPUDefinitions to avoid copying the CPU models list
twice.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version
The function copies machine type data from one QEMU caps structure to
another.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git
While virDomainCapsCPUModel structure contains 'usable' field with
virDomainCapsCPUUsable type, the lower level structure specific to QEMU
driver used virTriStateBool for the same thing and we had to translate
between them.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
All the code for formatting machine type data was moved to a standalone
virQEMUCapsFormatMachines function.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 37 ++--
1 file changed, 23 insertions(+), 14
Almost all TCG query-machines replies match KVM. The only exceptions are
4.2.0 replies on s390x which differ in the reported default CPU type.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 3 +-
The function translates qemuMonitorCPUDefsPtr (used by QEMU caps probing
code) into virDomainCapsCPUModelsPtr used by domain capabilities.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- trivial rebase
Version 3:
- g_autoptr, g_steal_pointer
When starting a domain without a CPU model specified in the domain XML,
QEMU will choose a default one. Which is fine unless the domain gets
migrated to another host because libvirt doesn't perform any CPU ABI
checks and the virtual CPU provided by QEMU on the destination host can
differ from the
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- G_DEFINE_AUTOPTR_CLEANUP_FUNC
src/conf/cpu_conf.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h
index 30904fab95..892ed08653
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 64 +---
src/qemu/qemu_capabilities.h | 8 -
src/qemu/qemu_domain.c | 8 +++--
tests/domaincapstest.c | 10 --
4 files changed, 59
QEMU 4.2.0 will report default CPU types used by each machine type and
we will want to start using it.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change except for updated test results
Version 3:
- TCG and KVM are probed separately now
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- fix crash with CPUs without type
Version 3:
- no change
src/qemu/qemu_capabilities.c | 32
src/qemu/qemu_capabilities.h | 3 +++
2 files changed, 35 insertions(+)
It was very similar to virQEMUCapsGetAccel.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- g_autoptr
src/qemu/qemu_domain.c | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_domain.c
Let's store qemuMonitorCPUDefInfo directly in the array of CPUs in
qemuMonitorCPUDefs rather then using an array of pointers.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- trivial rebase
Version 3:
- minor change caused by g_new0 introduced in
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 150 ++-
src/qemu/qemu_capabilities.h | 3 -
2 files changed, 76 insertions(+), 77 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
Signed-off-by: Jiri Denemark
---
Notes:
Version 2:
- no change
Version 3:
- more glib functions
- the function now returns the pointer to the copy rather than int
as it can never fail
src/qemu/qemu_monitor.c | 23 +++
src/qemu/qemu_monitor.h |
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c6a2f65239..92041190eb 100644
---
The function would return a valid virDomainCapsCPUModelsPtr with empty
CPU models list if query-cpu-definitions exists in QEMU, but returns
GenericError meaning it's not in fact implemented. This behaviour is a
bit strange especially after such virDomainCapsCPUModels structure is
stored in
And make it use virQEMUCapsGetAccel once rather than repeating the same
code in all functions called from virQEMUCapsFormatAccel.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 29 +++--
1 file changed, 11
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 92041190eb..a0b5047276 100644
---
It is a tiny wrapper around virQEMUCapsProbeQMPCPUDefinitions which will
soon get private parameters and thus it cannot be exposed outside
qemu_capabilities.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new ptach
src/qemu/qemu_capabilities.c | 10 +-
Both virDomainCapsCPUModelsAdd and virDomainCapsCPUModelsAddSteal are so
simple we can just squash the code in a single function.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- g_steal_pointer
To avoid duplicating code which selects the right virQEMUCapsAccel data
to be filled during probing.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 51
1 file changed, 23 insertions(+), 28 deletions(-)
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
- no change
...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 38 +++
.../aarch64-default-cpu-kvm-virt-4.2.xml | 20 ++
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
- no change
...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 31 +++
.../s390-default-cpu-kvm-ccw-virtio-4.2.xml | 16 ++
Some specifics of machine types may depend on the accelerator and thus
the data should be moved to virQEMUCapsAccel. The TCG machine types are
just copied from the ones probed for KVM to simplify the changes to
qemucapabilitiestest data files.
Signed-off-by: Jiri Denemark
---
Notes:
Version
It is a container for a CPU models list (qemuMonitorCPUDefInfo) and a
number of elements in this list.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- v1 reviewed by Ján Tomko, but the patch had to be changed because
of the previous patch
All the code for loading machine type data was moved to a standalone
virQEMUCapsLoadMachines function.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 93 +---
1 file changed, 55 insertions(+), 38
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index b21aadf864..0a00f2c361 100644
---
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- no change
src/conf/domain_capabilities.c | 33 -
src/conf/domain_capabilities.h | 3 ---
src/libvirt_private.syms | 1 -
3 files
The new functions are designed to load and format capabilities which
depend on the accelerator (host CPU expansion and CPU models).
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 40 +-
.../caps_2.10.0.x86_64.xml
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 28 ++--
src/qemu/qemu_capabilities.h | 3 ---
2 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- no change
src/qemu/qemu_capabilities.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
And make it use virQEMUCapsGetAccel once rather than repeating the same
code in all functions called from virQEMUCapsLoadAccel.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 40 ++--
1 file changed, 15
To avoid mismatch between host and QEMU capabilities.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
tests/qemuxml2argvtest.c | 4
tests/testutilsqemu.c| 6 +++---
tests/testutilsqemu.h| 1 +
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git
The function can be used to get the pointer to all data which depend on
the accelerator.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 36
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git
In preparation for making machine types dependent on the accelerator,
the elements are formatted between and
.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 4 +-
.../caps_1.5.3.x86_64.xml | 30
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- no change
src/qemu/qemu_capabilities.c | 12
src/qemu/qemu_capabilities.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
All callers use nameLen == -1 anyway.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- no change
src/conf/domain_capabilities.c | 7 +++
src/conf/domain_capabilities.h | 1 -
src/qemu/qemu_capabilities.c | 2 +-
This is container for capabilities data that depend on the accelerator.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
src/qemu/qemu_capabilities.c | 66
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git
Rather than returning a direct pointer the list stored in qemuCaps the
function now creates a new copy of the CPU models list.
The main purpose of this seemingly useless change is to update callers
to free the result returned by virQEMUCapsGetCPUDefinitions because the
internals of this function
Most of the code moved to a new virQEMUCapsFetchCPUDefinitions function
and the existing virQEMUCapsFetchCPUModels just becomes a small wrapper
around virQEMUCapsFetchCPUDefinitions and virQEMUCapsCPUDefsToModels.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- g_autofree
src/qemu/qemu_capabilities.c | 58 +++-
1 file changed, 24 insertions(+), 34 deletions(-)
diff --git
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- g_autoptr
src/qemu/qemu_monitor_json.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
The functions return virDomainCapsCPUModelsPtr and thus they should be
called *CPUModels for consistency. Functions called *CPUDefinitions will
work on qemuMonitorCPUDefsPtr.
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
-
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- no change
Version 3:
- g_autofree
src/conf/domain_capabilities.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/conf/domain_capabilities.c
When starting a domain without a CPU model specified in the domain XML,
QEMU will choose a default one. Which is fine unless the domain gets
migrated to another host because libvirt doesn't perform any CPU ABI
checks and the virtual CPU provided by QEMU on the destination host can
differ from the
Generated with "spapr/kvm: Set default cpu model for all machine
classes" fix for QEMU applied.
Signed-off-by: Jiri Denemark
---
Notes:
Version 3:
- new patch
.../caps_4.2.0.ppc64.replies | 38 +--
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 +-
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version 2:
- new patch
Version 3:
- regenerated with the following QEMU patch applied
"s390x/kvm: Set default cpu model for all machine classes"
- includes domaincapsdata (previously in patch 2/31)
On Tue, 2019-11-05 at 10:03 +0100, Fabiano Fidêncio wrote:
> On Mon, Nov 4, 2019 at 6:04 PM Andrea Bolognani wrote:
> > Andrea Bolognani (2):
> > gitdm: Fix sorting
> > gitdm: Add missing entries
> >
> > docs/gitdm/companies/others| 4 +++-
> > docs/gitdm/groups/opensource | 1 +
> >
On Mon, Nov 4, 2019 at 6:04 PM Andrea Bolognani wrote:
>
> Changes from [v1]:
>
> * added a few more addresses.
>
>
> [v1] https://www.redhat.com/archives/libvir-list/2019-October/msg01095.html
>
> Andrea Bolognani (2):
> gitdm: Fix sorting
> gitdm: Add missing entries
>
>
59 matches
Mail list logo
